Merge pull request #3439 from ben-vargas/fix-grok-tool-params

fix(xai): default missing function tool parameters
This commit is contained in:
Luis Pater
2026-05-17 15:04:28 +08:00
committed by GitHub
2 changed files with 15 additions and 0 deletions
@@ -123,6 +123,9 @@ func TestXAIExecutorExecuteShapesResponsesRequest(t *testing.T) {
if toolType != "function" && toolType != "web_search" {
t.Fatalf("tools.%d.type = %q, want function or web_search; body=%s", i, toolType, string(gotBody))
}
if toolType == "function" && !tool.Get("parameters").Exists() {
t.Fatalf("tools.%d.parameters missing for xAI function tool; body=%s", i, string(gotBody))
}
if got := tool.Get("name").String(); got == "apply_patch" {
t.Fatalf("tools.%d.name = apply_patch, want removed; body=%s", i, string(gotBody))
}
@@ -261,6 +264,9 @@ func TestXAIExecutorExecuteStreamFiltersToolSearchTool(t *testing.T) {
if toolType != "function" && toolType != "web_search" {
t.Fatalf("tools.%d.type = %q, want function or web_search; body=%s", i, toolType, string(gotBody))
}
if toolType == "function" && !tool.Get("parameters").Exists() {
t.Fatalf("tools.%d.parameters missing for xAI function tool; body=%s", i, string(gotBody))
}
if got := tool.Get("name").String(); got == "apply_patch" {
t.Fatalf("tools.%d.name = apply_patch, want removed; body=%s", i, string(gotBody))
}