refactor: decompose monolithic services into modular architecture (#534)

* docs: add monolith refactor report with system breakdown

Comprehensive analysis of codebase identifying:
- 14 files over 500 lines requiring refactoring
- 3 critical monoliths (SessionStore, SearchManager, worker-service)
- 80% code duplication across agent files
- 5-phase refactoring roadmap with domain-based architecture

* fix: prevent memory_session_id from equaling content_session_id

The bug: memory_session_id was initialized to contentSessionId as a
"placeholder for FK purposes". This caused the SDK resume logic to
inject memory agent messages into the USER's Claude Code transcript,
corrupting their conversation history.

Root cause:
- SessionStore.createSDKSession initialized memory_session_id = contentSessionId
- SDKAgent checked memorySessionId !== contentSessionId but this check
  only worked if the session was fetched fresh from DB

The fix:
- SessionStore: Initialize memory_session_id as NULL, not contentSessionId
- SDKAgent: Simple truthy check !!session.memorySessionId (NULL = fresh start)
- Database migration: Ran UPDATE to set memory_session_id = NULL for 1807
  existing sessions that had the bug

Also adds [ALIGNMENT] logging across the session lifecycle to help debug
session continuity issues:
- Hook entry: contentSessionId + promptNumber
- DB lookup: contentSessionId → memorySessionId mapping proof
- Resume decision: shows which memorySessionId will be used for resume
- Capture: logs when memorySessionId is captured from first SDK response

UI: Added "Alignment" quick filter button in LogsModal to show only
alignment logs for debugging session continuity.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

* refactor: improve error handling in worker-service.ts

- Fix GENERIC_CATCH anti-patterns by logging full error objects instead of just messages
- Add [ANTI-PATTERN IGNORED] markers for legitimate cases (cleanup, hot paths)
- Simplify error handling comments to be more concise
- Improve httpShutdown() error discrimination for ECONNREFUSED
- Reduce LARGE_TRY_BLOCK issues in initialization code

Part of anti-pattern cleanup plan (132 total issues)

* refactor: improve error logging in SearchManager.ts

- Pass full error objects to logger instead of just error.message
- Fixes PARTIAL_ERROR_LOGGING anti-patterns (10 instances)
- Better debugging visibility when Chroma queries fail

Part of anti-pattern cleanup (133 remaining)

* refactor: improve error logging across SessionStore and mcp-server

- SessionStore.ts: Fix error logging in column rename utility
- mcp-server.ts: Log full error objects instead of just error.message
- Improve error handling in Worker API calls and tool execution

Part of anti-pattern cleanup (133 remaining)

* Refactor hooks to streamline error handling and loading states

- Simplified error handling in useContextPreview by removing try-catch and directly checking response status.
- Refactored usePagination to eliminate try-catch, improving readability and maintaining error handling through response checks.
- Cleaned up useSSE by removing unnecessary try-catch around JSON parsing, ensuring clarity in message handling.
- Enhanced useSettings by streamlining the saving process, removing try-catch, and directly checking the result for success.

* refactor: add error handling back to SearchManager Chroma calls

- Wrap queryChroma calls in try-catch to prevent generator crashes
- Log Chroma errors as warnings and fall back gracefully
- Fixes generator failures when Chroma has issues
- Part of anti-pattern cleanup recovery

* feat: Add generator failure investigation report and observation duplication regression report

- Created a comprehensive investigation report detailing the root cause of generator failures during anti-pattern cleanup, including the impact, investigation process, and implemented fixes.
- Documented the critical regression causing observation duplication due to race conditions in the SDK agent, outlining symptoms, root cause analysis, and proposed fixes.

* fix: address PR #528 review comments - atomic cleanup and detector improvements

This commit addresses critical review feedback from PR #528:

## 1. Atomic Message Cleanup (Fix Race Condition)

**Problem**: SessionRoutes.ts generator error handler had race condition
- Queried messages then marked failed in loop
- If crash during loop → partial marking → inconsistent state

**Solution**:
- Added `markSessionMessagesFailed()` to PendingMessageStore.ts
- Single atomic UPDATE statement replaces loop
- Follows existing pattern from `resetProcessingToPending()`

**Files**:
- src/services/sqlite/PendingMessageStore.ts (new method)
- src/services/worker/http/routes/SessionRoutes.ts (use new method)

## 2. Anti-Pattern Detector Improvements

**Problem**: Detector didn't recognize logger.failure() method
- Lines 212 & 335 already included "failure"
- Lines 112-113 (PARTIAL_ERROR_LOGGING detection) did not

**Solution**: Updated regex patterns to include "failure" for consistency

**Files**:
- scripts/anti-pattern-test/detect-error-handling-antipatterns.ts

## 3. Documentation

**PR Comment**: Added clarification on memory_session_id fix location
- Points to SessionStore.ts:1155
- Explains why NULL initialization prevents message injection bug

## Review Response

Addresses "Must Address Before Merge" items from review:
 Clarified memory_session_id bug fix location (via PR comment)
 Made generator error handler message cleanup atomic
 Deferred comprehensive test suite to follow-up PR (keeps PR focused)

## Testing

- Build passes with no errors
- Anti-pattern detector runs successfully
- Atomic cleanup follows proven pattern from existing methods

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>

* fix: FOREIGN KEY constraint and missing failed_at_epoch column

Two critical bugs fixed:

1. Missing failed_at_epoch column in pending_messages table
   - Added migration 20 to create the column
   - Fixes error when trying to mark messages as failed

2. FOREIGN KEY constraint failed when storing observations
   - All three agents (SDK, Gemini, OpenRouter) were passing
     session.contentSessionId instead of session.memorySessionId
   - storeObservationsAndMarkComplete expects memorySessionId
   - Added null check and clear error message

However, observations still not saving - see investigation report.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>

* Refactor hook input parsing to improve error handling

- Added a nested try-catch block in new-hook.ts, save-hook.ts, and summary-hook.ts to handle JSON parsing errors more gracefully.
- Replaced direct error throwing with logging of the error details using logger.error.
- Ensured that the process exits cleanly after handling input in all three hooks.

* docs: update monolith report post session-logging merge

- SessionStore grew to 2,011 lines (49 methods) - highest priority
- SearchManager reduced to 1,778 lines (improved)
- Agent files reduced by ~45 lines combined
- Added trend indicators and post-merge observations
- Core refactoring proposal remains valid

* refactor(sqlite): decompose SessionStore into modular architecture

Extract the 2011-line SessionStore.ts monolith into focused, single-responsibility
modules following grep-optimized progressive disclosure pattern:

New module structure:
- sessions/ - Session creation and retrieval (create.ts, get.ts, types.ts)
- observations/ - Observation storage and queries (store.ts, get.ts, recent.ts, files.ts, types.ts)
- summaries/ - Summary storage and queries (store.ts, get.ts, recent.ts, types.ts)
- prompts/ - User prompt management (store.ts, get.ts, types.ts)
- timeline/ - Cross-entity timeline queries (queries.ts)
- import/ - Bulk import operations (bulk.ts)
- migrations/ - Database migrations (runner.ts)

New coordinator files:
- Database.ts - ClaudeMemDatabase class with re-exports
- transactions.ts - Atomic cross-entity transactions
- Named re-export facades (Sessions.ts, Observations.ts, etc.)

Key design decisions:
- All functions take `db: Database` as first parameter (functional style)
- Named re-exports instead of index.ts for grep-friendliness
- SessionStore retained as backward-compatible wrapper
- Target file size: 50-150 lines (60% compliance)

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

* refactor(agents): extract shared logic into modular architecture

Consolidate duplicate code across SDKAgent, GeminiAgent, and OpenRouterAgent
into focused utility modules. Total reduction: 500 lines (29%).

New modules in src/services/worker/agents/:
- ResponseProcessor.ts: Atomic DB transactions, Chroma sync, SSE broadcast
- ObservationBroadcaster.ts: SSE event formatting and dispatch
- SessionCleanupHelper.ts: Session state cleanup and stuck message reset
- FallbackErrorHandler.ts: Provider error detection for fallback logic
- types.ts: Shared interfaces (WorkerRef, SSE payloads, StorageResult)

Bug fix: SDKAgent was incorrectly using obs.files instead of obs.files_read
and hardcoding files_modified to empty array.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

* refactor(search): extract search strategies into modular architecture

Decompose SearchManager into focused strategy pattern with:
- SearchOrchestrator: Coordinates strategy selection and fallback
- ChromaSearchStrategy: Vector semantic search via ChromaDB
- SQLiteSearchStrategy: Filter-only queries for date/project/type
- HybridSearchStrategy: Metadata filtering + semantic ranking
- ResultFormatter: Markdown table formatting for results
- TimelineBuilder: Chronological timeline construction
- Filter modules: DateFilter, ProjectFilter, TypeFilter

SearchManager now delegates to new infrastructure while maintaining
full backward compatibility with existing public API.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

* refactor(context): decompose context-generator into modular architecture

Extract 660-line monolith into focused components:
- ContextBuilder: Main orchestrator (~160 lines)
- ContextConfigLoader: Configuration loading
- TokenCalculator: Token budget calculations
- ObservationCompiler: Data retrieval and query building
- MarkdownFormatter/ColorFormatter: Output formatting
- Section renderers: Header, Timeline, Summary, Footer

Maintains full backward compatibility - context-generator.ts now
delegates to new ContextBuilder while preserving public API.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

* refactor(worker): decompose worker-service into modular infrastructure

Split 2000+ line monolith into focused modules:

Infrastructure:
- ProcessManager: PID files, signal handlers, child process cleanup
- HealthMonitor: Port checks, health polling, version matching
- GracefulShutdown: Coordinated cleanup on exit

Server:
- Server: Express app setup, core routes, route registration
- Middleware: Re-exports from existing middleware
- ErrorHandler: Centralized error handling with AppError class

Integrations:
- CursorHooksInstaller: Full Cursor IDE integration (registry, hooks, MCP)

WorkerService now acts as thin coordinator wiring all components together.
Maintains full backward compatibility with existing public API.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

* Refactor session queue processing and database interactions

- Implement claim-and-delete pattern in SessionQueueProcessor to simplify message handling and eliminate duplicate processing.
- Update PendingMessageStore to support atomic claim-and-delete operations, removing the need for intermediate processing states.
- Introduce storeObservations method in SessionStore for simplified observation and summary storage without message tracking.
- Remove deprecated methods and clean up session state management in worker agents.
- Adjust response processing to accommodate new storage patterns, ensuring atomic transactions for observations and summaries.
- Remove unnecessary reset logic for stuck messages due to the new queue handling approach.

* Add duplicate observation cleanup script

Script to clean up duplicate observations created by the batching bug
where observations were stored once per message ID instead of once per
observation. Includes safety checks to always keep at least one copy.

Usage:
  bun scripts/cleanup-duplicates.ts           # Dry run
  bun scripts/cleanup-duplicates.ts --execute # Delete duplicates
  bun scripts/cleanup-duplicates.ts --aggressive # Ignore time window

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

---------

Co-authored-by: Claude <noreply@anthropic.com>
This commit is contained in:
Alex Newman
2026-01-03 21:22:27 -05:00
committed by GitHub
parent 7748e62387
commit 2fc4153bef
87 changed files with 9933 additions and 3492 deletions
+51 -213
View File
@@ -15,13 +15,17 @@ import { homedir } from 'os';
import { DatabaseManager } from './DatabaseManager.js';
import { SessionManager } from './SessionManager.js';
import { logger } from '../../utils/logger.js';
import { parseObservations, parseSummary } from '../../sdk/parser.js';
import { buildInitPrompt, buildObservationPrompt, buildSummaryPrompt, buildContinuationPrompt } from '../../sdk/prompts.js';
import { SettingsDefaultsManager } from '../../shared/SettingsDefaultsManager.js';
import type { ActiveSession, ConversationMessage } from '../worker-types.js';
import { ModeManager } from '../domain/ModeManager.js';
import { updateCursorContextForProject } from '../worker-service.js';
import { getWorkerPort } from '../../shared/worker-utils.js';
import {
processAgentResponse,
shouldFallbackToClaude,
isAbortError,
type WorkerRef,
type FallbackAgent
} from './agents/index.js';
// Gemini API endpoint
const GEMINI_API_URL = 'https://generativelanguage.googleapis.com/v1beta/models';
@@ -96,11 +100,6 @@ interface GeminiContent {
parts: Array<{ text: string }>;
}
// Forward declaration for fallback agent type
type FallbackAgent = {
startSession(session: ActiveSession, worker?: any): Promise<void>;
};
export class GeminiAgent {
private dbManager: DatabaseManager;
private sessionManager: SessionManager;
@@ -119,28 +118,11 @@ export class GeminiAgent {
this.fallbackAgent = agent;
}
/**
* Check if an error should trigger fallback to Claude
*/
private shouldFallbackToClaude(error: any): boolean {
const message = error?.message || '';
// Fall back on rate limit (429), server errors (5xx), or network issues
return (
message.includes('429') ||
message.includes('500') ||
message.includes('502') ||
message.includes('503') ||
message.includes('ECONNREFUSED') ||
message.includes('ETIMEDOUT') ||
message.includes('fetch failed')
);
}
/**
* Start Gemini agent for a session
* Uses multi-turn conversation to maintain context across messages
*/
async startSession(session: ActiveSession, worker?: any): Promise<void> {
async startSession(session: ActiveSession, worker?: WorkerRef): Promise<void> {
try {
// Get Gemini configuration
const { apiKey, model, rateLimitingEnabled } = this.getGeminiConfig();
@@ -170,8 +152,17 @@ export class GeminiAgent {
session.cumulativeInputTokens += Math.floor(tokensUsed * 0.7); // Rough estimate
session.cumulativeOutputTokens += Math.floor(tokensUsed * 0.3);
// Process response (no original timestamp for init - not from queue)
await this.processGeminiResponse(session, initResponse.content, worker, tokensUsed, null);
// Process response using shared ResponseProcessor (no original timestamp for init - not from queue)
await processAgentResponse(
initResponse.content,
session,
this.dbManager,
this.sessionManager,
worker,
tokensUsed,
null,
'Gemini'
);
} else {
logger.warn('SDK', 'Empty Gemini init response - session may lack context', {
sessionId: session.sessionDbId,
@@ -205,18 +196,27 @@ export class GeminiAgent {
session.conversationHistory.push({ role: 'user', content: obsPrompt });
const obsResponse = await this.queryGeminiMultiTurn(session.conversationHistory, apiKey, model, rateLimitingEnabled);
let tokensUsed = 0;
if (obsResponse.content) {
// Add response to conversation history
session.conversationHistory.push({ role: 'assistant', content: obsResponse.content });
const tokensUsed = obsResponse.tokensUsed || 0;
tokensUsed = obsResponse.tokensUsed || 0;
session.cumulativeInputTokens += Math.floor(tokensUsed * 0.7);
session.cumulativeOutputTokens += Math.floor(tokensUsed * 0.3);
}
// Process response (even if empty) - empty responses will have no observations/summaries
// but messages still need to be marked complete atomically
await this.processGeminiResponse(session, obsResponse.content || '', worker, tokensUsed, originalTimestamp);
// Process response using shared ResponseProcessor
await processAgentResponse(
obsResponse.content || '',
session,
this.dbManager,
this.sessionManager,
worker,
tokensUsed,
originalTimestamp,
'Gemini'
);
} else if (message.type === 'summarize') {
// Build summary prompt
@@ -232,18 +232,27 @@ export class GeminiAgent {
session.conversationHistory.push({ role: 'user', content: summaryPrompt });
const summaryResponse = await this.queryGeminiMultiTurn(session.conversationHistory, apiKey, model, rateLimitingEnabled);
let tokensUsed = 0;
if (summaryResponse.content) {
// Add response to conversation history
session.conversationHistory.push({ role: 'assistant', content: summaryResponse.content });
const tokensUsed = summaryResponse.tokensUsed || 0;
tokensUsed = summaryResponse.tokensUsed || 0;
session.cumulativeInputTokens += Math.floor(tokensUsed * 0.7);
session.cumulativeOutputTokens += Math.floor(tokensUsed * 0.3);
}
// Process response (even if empty) - empty responses will have no observations/summaries
// but messages still need to be marked complete atomically
await this.processGeminiResponse(session, summaryResponse.content || '', worker, tokensUsed, originalTimestamp);
// Process response using shared ResponseProcessor
await processAgentResponse(
summaryResponse.content || '',
session,
this.dbManager,
this.sessionManager,
worker,
tokensUsed,
originalTimestamp,
'Gemini'
);
}
}
@@ -255,37 +264,26 @@ export class GeminiAgent {
historyLength: session.conversationHistory.length
});
} catch (error: any) {
if (error.name === 'AbortError') {
} catch (error: unknown) {
if (isAbortError(error)) {
logger.warn('SDK', 'Gemini agent aborted', { sessionId: session.sessionDbId });
throw error;
}
// Check if we should fall back to Claude
if (this.shouldFallbackToClaude(error) && this.fallbackAgent) {
if (shouldFallbackToClaude(error) && this.fallbackAgent) {
logger.warn('SDK', 'Gemini API failed, falling back to Claude SDK', {
sessionDbId: session.sessionDbId,
error: error.message,
error: error instanceof Error ? error.message : String(error),
historyLength: session.conversationHistory.length
});
// Reset any 'processing' messages back to 'pending' so Claude can retry them
// This handles the case where Gemini failed mid-processing a message
const pendingStore = this.sessionManager.getPendingMessageStore();
const resetCount = pendingStore.resetStuckMessages(0); // 0 = reset ALL processing messages
if (resetCount > 0) {
logger.info('SDK', 'Reset processing messages for fallback', {
sessionDbId: session.sessionDbId,
resetCount
});
}
// Fall back to Claude - it will use the same session with shared conversationHistory
// Note: Claude SDK will continue processing from current state
// Note: With claim-and-delete queue pattern, messages are already deleted on claim
return this.fallbackAgent.startSession(session, worker);
}
logger.failure('SDK', 'Gemini agent error', { sessionDbId: session.sessionDbId }, error);
logger.failure('SDK', 'Gemini agent error', { sessionDbId: session.sessionDbId }, error as Error);
throw error;
}
}
@@ -356,166 +354,6 @@ export class GeminiAgent {
return { content, tokensUsed };
}
/**
* Process Gemini response (same format as Claude)
* @param originalTimestamp - Original epoch when message was queued (for backlog processing accuracy)
*/
private async processGeminiResponse(
session: ActiveSession,
text: string,
worker: any | undefined,
discoveryTokens: number,
originalTimestamp: number | null
): Promise<void> {
// Parse observations and summary
const observations = parseObservations(text, session.contentSessionId);
const summary = parseSummary(text, session.sessionDbId);
// Convert nullable fields to empty strings for storeSummary (if summary exists)
const summaryForStore = summary ? {
request: summary.request || '',
investigated: summary.investigated || '',
learned: summary.learned || '',
completed: summary.completed || '',
next_steps: summary.next_steps || '',
notes: summary.notes
} : null;
// Get the pending message ID(s) for this response
const pendingMessageStore = this.sessionManager.getPendingMessageStore();
const sessionStore = this.dbManager.getSessionStore();
if (session.pendingProcessingIds.size > 0) {
// ATOMIC TRANSACTION: Store observations + summary + mark message(s) complete
for (const messageId of session.pendingProcessingIds) {
// CRITICAL: Must use memorySessionId (not contentSessionId) for FK constraint
if (!session.memorySessionId) {
throw new Error('Cannot store observations: memorySessionId not yet captured');
}
const result = sessionStore.storeObservationsAndMarkComplete(
session.memorySessionId,
session.project,
observations,
summaryForStore,
messageId,
pendingMessageStore,
session.lastPromptNumber,
discoveryTokens,
originalTimestamp ?? undefined
);
logger.info('SDK', 'Gemini observations and summary saved atomically', {
sessionId: session.sessionDbId,
messageId,
observationCount: result.observationIds.length,
hasSummary: !!result.summaryId,
atomicTransaction: true
});
// AFTER transaction commits - async operations (can fail safely)
for (let i = 0; i < observations.length; i++) {
const obsId = result.observationIds[i];
const obs = observations[i];
this.dbManager.getChromaSync().syncObservation(
obsId,
session.contentSessionId,
session.project,
obs,
session.lastPromptNumber,
result.createdAtEpoch,
discoveryTokens
).catch(err => {
logger.warn('SDK', 'Gemini chroma sync failed', { obsId }, err);
});
// Broadcast to SSE clients
if (worker && worker.sseBroadcaster) {
worker.sseBroadcaster.broadcast({
type: 'new_observation',
observation: {
id: obsId,
memory_session_id: session.memorySessionId,
session_id: session.contentSessionId,
type: obs.type,
title: obs.title,
subtitle: obs.subtitle,
text: null,
narrative: obs.narrative || null,
facts: JSON.stringify(obs.facts || []),
concepts: JSON.stringify(obs.concepts || []),
files_read: JSON.stringify(obs.files_read || []),
files_modified: JSON.stringify(obs.files_modified || []),
project: session.project,
prompt_number: session.lastPromptNumber,
created_at_epoch: result.createdAtEpoch
}
});
}
}
// Sync summary to Chroma (if present)
if (summaryForStore && result.summaryId) {
this.dbManager.getChromaSync().syncSummary(
result.summaryId,
session.contentSessionId,
session.project,
summaryForStore,
session.lastPromptNumber,
result.createdAtEpoch,
discoveryTokens
).catch(err => {
logger.warn('SDK', 'Gemini chroma sync failed', { summaryId: result.summaryId }, err);
});
// Broadcast to SSE clients
if (worker && worker.sseBroadcaster) {
worker.sseBroadcaster.broadcast({
type: 'new_summary',
summary: {
id: result.summaryId,
session_id: session.contentSessionId,
request: summary!.request,
investigated: summary!.investigated,
learned: summary!.learned,
completed: summary!.completed,
next_steps: summary!.next_steps,
notes: summary!.notes,
project: session.project,
prompt_number: session.lastPromptNumber,
created_at_epoch: result.createdAtEpoch
}
});
}
// Update Cursor context file for registered projects (fire-and-forget)
updateCursorContextForProject(session.project, getWorkerPort()).catch(error => {
logger.warn('CURSOR', 'Context update failed (non-critical)', { project: session.project }, error as Error);
});
}
}
// Clear the processed message IDs
session.pendingProcessingIds.clear();
session.earliestPendingTimestamp = null;
// Clean up old processed messages
const deletedCount = pendingMessageStore.cleanupProcessed(100);
if (deletedCount > 0) {
logger.debug('SDK', 'Cleaned up old processed messages', { deletedCount });
}
// Broadcast activity status after processing
if (worker && typeof worker.broadcastProcessingStatus === 'function') {
worker.broadcastProcessingStatus();
}
}
}
// REMOVED: markMessagesProcessed() - replaced by atomic transaction in processGeminiResponse()
// Messages are now marked complete atomically with observation storage to prevent duplicates
/**
* Get Gemini configuration from settings or environment
*/
+53 -215
View File
@@ -14,14 +14,18 @@
import { DatabaseManager } from './DatabaseManager.js';
import { SessionManager } from './SessionManager.js';
import { logger } from '../../utils/logger.js';
import { parseObservations, parseSummary } from '../../sdk/parser.js';
import { buildInitPrompt, buildObservationPrompt, buildSummaryPrompt, buildContinuationPrompt } from '../../sdk/prompts.js';
import { SettingsDefaultsManager } from '../../shared/SettingsDefaultsManager.js';
import { USER_SETTINGS_PATH } from '../../shared/paths.js';
import type { ActiveSession, ConversationMessage } from '../worker-types.js';
import { ModeManager } from '../domain/ModeManager.js';
import { updateCursorContextForProject } from '../worker-service.js';
import { getWorkerPort } from '../../shared/worker-utils.js';
import {
processAgentResponse,
shouldFallbackToClaude,
isAbortError,
type WorkerRef,
type FallbackAgent
} from './agents/index.js';
// OpenRouter API endpoint
const OPENROUTER_API_URL = 'https://openrouter.ai/api/v1/chat/completions';
@@ -29,7 +33,7 @@ const OPENROUTER_API_URL = 'https://openrouter.ai/api/v1/chat/completions';
// Context window management constants (defaults, overridable via settings)
const DEFAULT_MAX_CONTEXT_MESSAGES = 20; // Maximum messages to keep in conversation history
const DEFAULT_MAX_ESTIMATED_TOKENS = 100000; // ~100k tokens max context (safety limit)
const CHARS_PER_TOKEN_ESTIMATE = 4; // Conservative estimate: 1 token 4 chars
const CHARS_PER_TOKEN_ESTIMATE = 4; // Conservative estimate: 1 token = 4 chars
// OpenAI-compatible message format
interface OpenAIMessage {
@@ -56,11 +60,6 @@ interface OpenRouterResponse {
};
}
// Forward declaration for fallback agent type
type FallbackAgent = {
startSession(session: ActiveSession, worker?: any): Promise<void>;
};
export class OpenRouterAgent {
private dbManager: DatabaseManager;
private sessionManager: SessionManager;
@@ -79,28 +78,11 @@ export class OpenRouterAgent {
this.fallbackAgent = agent;
}
/**
* Check if an error should trigger fallback to Claude
*/
private shouldFallbackToClaude(error: any): boolean {
const message = error?.message || '';
// Fall back on rate limit (429), server errors (5xx), or network issues
return (
message.includes('429') ||
message.includes('500') ||
message.includes('502') ||
message.includes('503') ||
message.includes('ECONNREFUSED') ||
message.includes('ETIMEDOUT') ||
message.includes('fetch failed')
);
}
/**
* Start OpenRouter agent for a session
* Uses multi-turn conversation to maintain context across messages
*/
async startSession(session: ActiveSession, worker?: any): Promise<void> {
async startSession(session: ActiveSession, worker?: WorkerRef): Promise<void> {
try {
// Get OpenRouter configuration
const { apiKey, model, siteUrl, appName } = this.getOpenRouterConfig();
@@ -130,8 +112,17 @@ export class OpenRouterAgent {
session.cumulativeInputTokens += Math.floor(tokensUsed * 0.7); // Rough estimate
session.cumulativeOutputTokens += Math.floor(tokensUsed * 0.3);
// Process response (no original timestamp for init - not from queue)
await this.processOpenRouterResponse(session, initResponse.content, worker, tokensUsed, null);
// Process response using shared ResponseProcessor (no original timestamp for init - not from queue)
await processAgentResponse(
initResponse.content,
session,
this.dbManager,
this.sessionManager,
worker,
tokensUsed,
null,
'OpenRouter'
);
} else {
logger.warn('SDK', 'Empty OpenRouter init response - session may lack context', {
sessionId: session.sessionDbId,
@@ -164,18 +155,27 @@ export class OpenRouterAgent {
session.conversationHistory.push({ role: 'user', content: obsPrompt });
const obsResponse = await this.queryOpenRouterMultiTurn(session.conversationHistory, apiKey, model, siteUrl, appName);
let tokensUsed = 0;
if (obsResponse.content) {
// Add response to conversation history
session.conversationHistory.push({ role: 'assistant', content: obsResponse.content });
const tokensUsed = obsResponse.tokensUsed || 0;
tokensUsed = obsResponse.tokensUsed || 0;
session.cumulativeInputTokens += Math.floor(tokensUsed * 0.7);
session.cumulativeOutputTokens += Math.floor(tokensUsed * 0.3);
}
// Process response (even if empty) - empty responses will have no observations/summaries
// but messages still need to be marked complete atomically
await this.processOpenRouterResponse(session, obsResponse.content || '', worker, tokensUsed, originalTimestamp);
// Process response using shared ResponseProcessor
await processAgentResponse(
obsResponse.content || '',
session,
this.dbManager,
this.sessionManager,
worker,
tokensUsed,
originalTimestamp,
'OpenRouter'
);
} else if (message.type === 'summarize') {
// Build summary prompt
@@ -191,18 +191,27 @@ export class OpenRouterAgent {
session.conversationHistory.push({ role: 'user', content: summaryPrompt });
const summaryResponse = await this.queryOpenRouterMultiTurn(session.conversationHistory, apiKey, model, siteUrl, appName);
let tokensUsed = 0;
if (summaryResponse.content) {
// Add response to conversation history
session.conversationHistory.push({ role: 'assistant', content: summaryResponse.content });
const tokensUsed = summaryResponse.tokensUsed || 0;
tokensUsed = summaryResponse.tokensUsed || 0;
session.cumulativeInputTokens += Math.floor(tokensUsed * 0.7);
session.cumulativeOutputTokens += Math.floor(tokensUsed * 0.3);
}
// Process response (even if empty) - empty responses will have no observations/summaries
// but messages still need to be marked complete atomically
await this.processOpenRouterResponse(session, summaryResponse.content || '', worker, tokensUsed, originalTimestamp);
// Process response using shared ResponseProcessor
await processAgentResponse(
summaryResponse.content || '',
session,
this.dbManager,
this.sessionManager,
worker,
tokensUsed,
originalTimestamp,
'OpenRouter'
);
}
}
@@ -215,35 +224,26 @@ export class OpenRouterAgent {
model
});
} catch (error: any) {
if (error.name === 'AbortError') {
} catch (error: unknown) {
if (isAbortError(error)) {
logger.warn('SDK', 'OpenRouter agent aborted', { sessionId: session.sessionDbId });
throw error;
}
// Check if we should fall back to Claude
if (this.shouldFallbackToClaude(error) && this.fallbackAgent) {
if (shouldFallbackToClaude(error) && this.fallbackAgent) {
logger.warn('SDK', 'OpenRouter API failed, falling back to Claude SDK', {
sessionDbId: session.sessionDbId,
error: error.message,
error: error instanceof Error ? error.message : String(error),
historyLength: session.conversationHistory.length
});
// Reset any 'processing' messages back to 'pending' so Claude can retry them
const pendingStore = this.sessionManager.getPendingMessageStore();
const resetCount = pendingStore.resetStuckMessages(0); // 0 = reset ALL processing messages
if (resetCount > 0) {
logger.info('SDK', 'Reset processing messages for fallback', {
sessionDbId: session.sessionDbId,
resetCount
});
}
// Fall back to Claude - it will use the same session with shared conversationHistory
// Note: With claim-and-delete queue pattern, messages are already deleted on claim
return this.fallbackAgent.startSession(session, worker);
}
logger.failure('SDK', 'OpenRouter agent error', { sessionDbId: session.sessionDbId }, error);
logger.failure('SDK', 'OpenRouter agent error', { sessionDbId: session.sessionDbId }, error as Error);
throw error;
}
}
@@ -260,9 +260,7 @@ export class OpenRouterAgent {
* Keeps most recent messages within token budget
*/
private truncateHistory(history: ConversationMessage[]): ConversationMessage[] {
const settings = SettingsDefaultsManager.loadFromFile(
USER_SETTINGS_PATH
);
const settings = SettingsDefaultsManager.loadFromFile(USER_SETTINGS_PATH);
const MAX_CONTEXT_MESSAGES = parseInt(settings.CLAUDE_MEM_OPENROUTER_MAX_CONTEXT_MESSAGES) || DEFAULT_MAX_CONTEXT_MESSAGES;
const MAX_ESTIMATED_TOKENS = parseInt(settings.CLAUDE_MEM_OPENROUTER_MAX_TOKENS) || DEFAULT_MAX_ESTIMATED_TOKENS;
@@ -399,166 +397,6 @@ export class OpenRouterAgent {
return { content, tokensUsed };
}
/**
* Process OpenRouter response (same format as Claude/Gemini)
* @param originalTimestamp - Original epoch when message was queued (for backlog processing accuracy)
*/
private async processOpenRouterResponse(
session: ActiveSession,
text: string,
worker: any | undefined,
discoveryTokens: number,
originalTimestamp: number | null
): Promise<void> {
// Parse observations and summary
const observations = parseObservations(text, session.contentSessionId);
const summary = parseSummary(text, session.sessionDbId);
// Convert nullable fields to empty strings for storeSummary (if summary exists)
const summaryForStore = summary ? {
request: summary.request || '',
investigated: summary.investigated || '',
learned: summary.learned || '',
completed: summary.completed || '',
next_steps: summary.next_steps || '',
notes: summary.notes
} : null;
// Get the pending message ID(s) for this response
const pendingMessageStore = this.sessionManager.getPendingMessageStore();
const sessionStore = this.dbManager.getSessionStore();
if (session.pendingProcessingIds.size > 0) {
// ATOMIC TRANSACTION: Store observations + summary + mark message(s) complete
for (const messageId of session.pendingProcessingIds) {
// CRITICAL: Must use memorySessionId (not contentSessionId) for FK constraint
if (!session.memorySessionId) {
throw new Error('Cannot store observations: memorySessionId not yet captured');
}
const result = sessionStore.storeObservationsAndMarkComplete(
session.memorySessionId,
session.project,
observations,
summaryForStore,
messageId,
pendingMessageStore,
session.lastPromptNumber,
discoveryTokens,
originalTimestamp ?? undefined
);
logger.info('SDK', 'OpenRouter observations and summary saved atomically', {
sessionId: session.sessionDbId,
messageId,
observationCount: result.observationIds.length,
hasSummary: !!result.summaryId,
atomicTransaction: true
});
// AFTER transaction commits - async operations (can fail safely)
for (let i = 0; i < observations.length; i++) {
const obsId = result.observationIds[i];
const obs = observations[i];
this.dbManager.getChromaSync().syncObservation(
obsId,
session.contentSessionId,
session.project,
obs,
session.lastPromptNumber,
result.createdAtEpoch,
discoveryTokens
).catch(err => {
logger.warn('SDK', 'OpenRouter chroma sync failed', { obsId }, err);
});
// Broadcast to SSE clients
if (worker && worker.sseBroadcaster) {
worker.sseBroadcaster.broadcast({
type: 'new_observation',
observation: {
id: obsId,
memory_session_id: session.memorySessionId,
session_id: session.contentSessionId,
type: obs.type,
title: obs.title,
subtitle: obs.subtitle,
text: null,
narrative: obs.narrative || null,
facts: JSON.stringify(obs.facts || []),
concepts: JSON.stringify(obs.concepts || []),
files_read: JSON.stringify(obs.files_read || []),
files_modified: JSON.stringify(obs.files_modified || []),
project: session.project,
prompt_number: session.lastPromptNumber,
created_at_epoch: result.createdAtEpoch
}
});
}
}
// Sync summary to Chroma (if present)
if (summaryForStore && result.summaryId) {
this.dbManager.getChromaSync().syncSummary(
result.summaryId,
session.contentSessionId,
session.project,
summaryForStore,
session.lastPromptNumber,
result.createdAtEpoch,
discoveryTokens
).catch(err => {
logger.warn('SDK', 'OpenRouter chroma sync failed', { summaryId: result.summaryId }, err);
});
// Broadcast to SSE clients
if (worker && worker.sseBroadcaster) {
worker.sseBroadcaster.broadcast({
type: 'new_summary',
summary: {
id: result.summaryId,
session_id: session.contentSessionId,
request: summary!.request,
investigated: summary!.investigated,
learned: summary!.learned,
completed: summary!.completed,
next_steps: summary!.next_steps,
notes: summary!.notes,
project: session.project,
prompt_number: session.lastPromptNumber,
created_at_epoch: result.createdAtEpoch
}
});
}
// Update Cursor context file for registered projects (fire-and-forget)
updateCursorContextForProject(session.project, getWorkerPort()).catch(error => {
logger.warn('CURSOR', 'Context update failed (non-critical)', { project: session.project }, error as Error);
});
}
}
// Clear the processed message IDs
session.pendingProcessingIds.clear();
session.earliestPendingTimestamp = null;
// Clean up old processed messages
const deletedCount = pendingMessageStore.cleanupProcessed(100);
if (deletedCount > 0) {
logger.debug('SDK', 'Cleaned up old processed messages', { deletedCount });
}
// Broadcast activity status after processing
if (worker && typeof worker.broadcastProcessingStatus === 'function') {
worker.broadcastProcessingStatus();
}
}
}
// REMOVED: markMessagesProcessed() - replaced by atomic transaction in processOpenRouterResponse()
// Messages are now marked complete atomically with observation storage to prevent duplicates
/**
* Get OpenRouter configuration from settings or environment
*/
+155 -339
View File
@@ -14,14 +14,12 @@ import path from 'path';
import { DatabaseManager } from './DatabaseManager.js';
import { SessionManager } from './SessionManager.js';
import { logger } from '../../utils/logger.js';
import { parseObservations, parseSummary } from '../../sdk/parser.js';
import { buildInitPrompt, buildObservationPrompt, buildSummaryPrompt, buildContinuationPrompt } from '../../sdk/prompts.js';
import { SettingsDefaultsManager } from '../../shared/SettingsDefaultsManager.js';
import { USER_SETTINGS_PATH } from '../../shared/paths.js';
import type { ActiveSession, SDKUserMessage, PendingMessage } from '../worker-types.js';
import type { ActiveSession, SDKUserMessage } from '../worker-types.js';
import { ModeManager } from '../domain/ModeManager.js';
import { updateCursorContextForProject } from '../worker-service.js';
import { getWorkerPort } from '../../shared/worker-utils.js';
import { processAgentResponse, type WorkerRef } from './agents/index.js';
// Import Agent SDK (assumes it's installed)
// @ts-ignore - Agent SDK types may not be available
@@ -40,161 +38,163 @@ export class SDKAgent {
* Start SDK agent for a session (event-driven, no polling)
* @param worker WorkerService reference for spinner control (optional)
*/
async startSession(session: ActiveSession, worker?: any): Promise<void> {
async startSession(session: ActiveSession, worker?: WorkerRef): Promise<void> {
// Find Claude executable
const claudePath = this.findClaudeExecutable();
// Get model ID and disallowed tools
const modelId = this.getModelId();
// Memory agent is OBSERVER ONLY - no tools allowed
const disallowedTools = [
'Bash', // Prevent infinite loops
'Read', // No file reading
'Write', // No file writing
'Edit', // No file editing
'Grep', // No code searching
'Glob', // No file pattern matching
'WebFetch', // No web fetching
'WebSearch', // No web searching
'Task', // No spawning sub-agents
'NotebookEdit', // No notebook editing
'AskUserQuestion',// No asking questions
'TodoWrite' // No todo management
];
// Create message generator (event-driven)
const messageGenerator = this.createMessageGenerator(session);
// CRITICAL: Only resume if memorySessionId exists (was captured from a previous SDK response).
// memorySessionId starts as NULL and is captured on first SDK message.
// NEVER use contentSessionId for resume - that would inject messages into the user's transcript!
const hasRealMemorySessionId = !!session.memorySessionId;
// Find Claude executable
const claudePath = this.findClaudeExecutable();
// Get model ID and disallowed tools
const modelId = this.getModelId();
// Memory agent is OBSERVER ONLY - no tools allowed
const disallowedTools = [
'Bash', // Prevent infinite loops
'Read', // No file reading
'Write', // No file writing
'Edit', // No file editing
'Grep', // No code searching
'Glob', // No file pattern matching
'WebFetch', // No web fetching
'WebSearch', // No web searching
'Task', // No spawning sub-agents
'NotebookEdit', // No notebook editing
'AskUserQuestion',// No asking questions
'TodoWrite' // No todo management
];
// Create message generator (event-driven)
const messageGenerator = this.createMessageGenerator(session);
// CRITICAL: Only resume if memorySessionId exists (was captured from a previous SDK response).
// memorySessionId starts as NULL and is captured on first SDK message.
// NEVER use contentSessionId for resume - that would inject messages into the user's transcript!
const hasRealMemorySessionId = !!session.memorySessionId;
logger.info('SDK', 'Starting SDK query', {
sessionDbId: session.sessionDbId,
contentSessionId: session.contentSessionId,
memorySessionId: session.memorySessionId,
hasRealMemorySessionId,
resume_parameter: hasRealMemorySessionId ? session.memorySessionId : '(none - fresh start)',
lastPromptNumber: session.lastPromptNumber
});
// SESSION ALIGNMENT LOG: Resume decision proof - show if we're resuming with correct memorySessionId
if (session.lastPromptNumber > 1) {
logger.info('SDK', `[ALIGNMENT] Resume Decision | contentSessionId=${session.contentSessionId} | memorySessionId=${session.memorySessionId} | prompt#=${session.lastPromptNumber} | hasRealMemorySessionId=${hasRealMemorySessionId} | resumeWith=${hasRealMemorySessionId ? session.memorySessionId : 'NONE (fresh SDK session)'}`);
} else {
logger.info('SDK', `[ALIGNMENT] First Prompt | contentSessionId=${session.contentSessionId} | prompt#=${session.lastPromptNumber} | Will capture memorySessionId from first SDK response`);
}
// Run Agent SDK query loop
// Only resume if we have a captured memory session ID
const queryResult = query({
prompt: messageGenerator,
options: {
model: modelId,
// Resume with captured memorySessionId (null on first prompt, real ID on subsequent)
...(hasRealMemorySessionId && { resume: session.memorySessionId }),
disallowedTools,
abortController: session.abortController,
pathToClaudeCodeExecutable: claudePath
}
});
// Process SDK messages
for await (const message of queryResult) {
// Capture memory session ID from first SDK message (any type has session_id)
// This enables resume for subsequent generator starts within the same user session
if (!session.memorySessionId && message.session_id) {
session.memorySessionId = message.session_id;
// Persist to database for cross-restart recovery
this.dbManager.getSessionStore().updateMemorySessionId(
session.sessionDbId,
message.session_id
);
logger.info('SDK', 'Captured memory session ID', {
sessionDbId: session.sessionDbId,
memorySessionId: message.session_id
});
// SESSION ALIGNMENT LOG: Memory session ID captured - now contentSessionId→memorySessionId mapping is complete
logger.info('SDK', `[ALIGNMENT] Captured | contentSessionId=${session.contentSessionId} → memorySessionId=${message.session_id} | Future prompts will resume with this ID`);
}
// Handle assistant messages
if (message.type === 'assistant') {
const content = message.message.content;
const textContent = Array.isArray(content)
? content.filter((c: any) => c.type === 'text').map((c: any) => c.text).join('\n')
: typeof content === 'string' ? content : '';
const responseSize = textContent.length;
// Capture token state BEFORE updating (for delta calculation)
const tokensBeforeResponse = session.cumulativeInputTokens + session.cumulativeOutputTokens;
// Extract and track token usage
const usage = message.message.usage;
if (usage) {
session.cumulativeInputTokens += usage.input_tokens || 0;
session.cumulativeOutputTokens += usage.output_tokens || 0;
// Cache creation counts as discovery, cache read doesn't
if (usage.cache_creation_input_tokens) {
session.cumulativeInputTokens += usage.cache_creation_input_tokens;
}
logger.debug('SDK', 'Token usage captured', {
sessionId: session.sessionDbId,
inputTokens: usage.input_tokens,
outputTokens: usage.output_tokens,
cacheCreation: usage.cache_creation_input_tokens || 0,
cacheRead: usage.cache_read_input_tokens || 0,
cumulativeInput: session.cumulativeInputTokens,
cumulativeOutput: session.cumulativeOutputTokens
});
}
// Calculate discovery tokens (delta for this response only)
const discoveryTokens = (session.cumulativeInputTokens + session.cumulativeOutputTokens) - tokensBeforeResponse;
// Process response (empty or not) and mark messages as processed
// Capture earliest timestamp BEFORE processing (will be cleared after)
const originalTimestamp = session.earliestPendingTimestamp;
if (responseSize > 0) {
const truncatedResponse = responseSize > 100
? textContent.substring(0, 100) + '...'
: textContent;
logger.dataOut('SDK', `Response received (${responseSize} chars)`, {
sessionId: session.sessionDbId,
promptNumber: session.lastPromptNumber
}, truncatedResponse);
}
// Parse and process response (even if empty) with discovery token delta and original timestamp
// Empty responses will result in empty observations array and null summary
await this.processSDKResponse(session, textContent, worker, discoveryTokens, originalTimestamp);
}
// Log result messages
if (message.type === 'result' && message.subtype === 'success') {
// Usage telemetry is captured at SDK level
}
}
// Mark session complete
const sessionDuration = Date.now() - session.startTime;
logger.success('SDK', 'Agent completed', {
sessionId: session.sessionDbId,
duration: `${(sessionDuration / 1000).toFixed(1)}s`
});
logger.info('SDK', 'Starting SDK query', {
sessionDbId: session.sessionDbId,
contentSessionId: session.contentSessionId,
memorySessionId: session.memorySessionId,
hasRealMemorySessionId,
resume_parameter: hasRealMemorySessionId ? session.memorySessionId : '(none - fresh start)',
lastPromptNumber: session.lastPromptNumber
});
// SESSION ALIGNMENT LOG: Resume decision proof - show if we're resuming with correct memorySessionId
if (session.lastPromptNumber > 1) {
logger.info('SDK', `[ALIGNMENT] Resume Decision | contentSessionId=${session.contentSessionId} | memorySessionId=${session.memorySessionId} | prompt#=${session.lastPromptNumber} | hasRealMemorySessionId=${hasRealMemorySessionId} | resumeWith=${hasRealMemorySessionId ? session.memorySessionId : 'NONE (fresh SDK session)'}`);
} else {
logger.info('SDK', `[ALIGNMENT] First Prompt | contentSessionId=${session.contentSessionId} | prompt#=${session.lastPromptNumber} | Will capture memorySessionId from first SDK response`);
}
// Run Agent SDK query loop
// Only resume if we have a captured memory session ID
const queryResult = query({
prompt: messageGenerator,
options: {
model: modelId,
// Resume with captured memorySessionId (null on first prompt, real ID on subsequent)
...(hasRealMemorySessionId && { resume: session.memorySessionId }),
disallowedTools,
abortController: session.abortController,
pathToClaudeCodeExecutable: claudePath
}
});
// Process SDK messages
for await (const message of queryResult) {
// Capture memory session ID from first SDK message (any type has session_id)
// This enables resume for subsequent generator starts within the same user session
if (!session.memorySessionId && message.session_id) {
session.memorySessionId = message.session_id;
// Persist to database for cross-restart recovery
this.dbManager.getSessionStore().updateMemorySessionId(
session.sessionDbId,
message.session_id
);
logger.info('SDK', 'Captured memory session ID', {
sessionDbId: session.sessionDbId,
memorySessionId: message.session_id
});
// SESSION ALIGNMENT LOG: Memory session ID captured - now contentSessionId→memorySessionId mapping is complete
logger.info('SDK', `[ALIGNMENT] Captured | contentSessionId=${session.contentSessionId} → memorySessionId=${message.session_id} | Future prompts will resume with this ID`);
}
// Handle assistant messages
if (message.type === 'assistant') {
const content = message.message.content;
const textContent = Array.isArray(content)
? content.filter((c: any) => c.type === 'text').map((c: any) => c.text).join('\n')
: typeof content === 'string' ? content : '';
const responseSize = textContent.length;
// Capture token state BEFORE updating (for delta calculation)
const tokensBeforeResponse = session.cumulativeInputTokens + session.cumulativeOutputTokens;
// Extract and track token usage
const usage = message.message.usage;
if (usage) {
session.cumulativeInputTokens += usage.input_tokens || 0;
session.cumulativeOutputTokens += usage.output_tokens || 0;
// Cache creation counts as discovery, cache read doesn't
if (usage.cache_creation_input_tokens) {
session.cumulativeInputTokens += usage.cache_creation_input_tokens;
}
logger.debug('SDK', 'Token usage captured', {
sessionId: session.sessionDbId,
inputTokens: usage.input_tokens,
outputTokens: usage.output_tokens,
cacheCreation: usage.cache_creation_input_tokens || 0,
cacheRead: usage.cache_read_input_tokens || 0,
cumulativeInput: session.cumulativeInputTokens,
cumulativeOutput: session.cumulativeOutputTokens
});
}
// Calculate discovery tokens (delta for this response only)
const discoveryTokens = (session.cumulativeInputTokens + session.cumulativeOutputTokens) - tokensBeforeResponse;
// Process response (empty or not) and mark messages as processed
// Capture earliest timestamp BEFORE processing (will be cleared after)
const originalTimestamp = session.earliestPendingTimestamp;
if (responseSize > 0) {
const truncatedResponse = responseSize > 100
? textContent.substring(0, 100) + '...'
: textContent;
logger.dataOut('SDK', `Response received (${responseSize} chars)`, {
sessionId: session.sessionDbId,
promptNumber: session.lastPromptNumber
}, truncatedResponse);
}
// Parse and process response using shared ResponseProcessor
await processAgentResponse(
textContent,
session,
this.dbManager,
this.sessionManager,
worker,
discoveryTokens,
originalTimestamp,
'SDK'
);
}
// Log result messages
if (message.type === 'result' && message.subtype === 'success') {
// Usage telemetry is captured at SDK level
}
}
// Mark session complete
const sessionDuration = Date.now() - session.startTime;
logger.success('SDK', 'Agent completed', {
sessionId: session.sessionDbId,
duration: `${(sessionDuration / 1000).toFixed(1)}s`
});
}
/**
* Create event-driven message generator (yields messages from SessionManager)
*
@@ -315,190 +315,6 @@ export class SDKAgent {
}
}
/**
* Process SDK response text (parse XML, save to database, sync to Chroma)
* @param discoveryTokens - Token cost for discovering this response (delta, not cumulative)
* @param originalTimestamp - Original epoch when message was queued (for backlog processing accuracy)
*
* Also captures assistant responses to shared conversation history for provider interop.
* This allows Gemini to see full context if provider is switched mid-session.
*
* CRITICAL: Uses atomic transaction to prevent observation duplication on crash recovery.
*/
private async processSDKResponse(session: ActiveSession, text: string, worker: any | undefined, discoveryTokens: number, originalTimestamp: number | null): Promise<void> {
// Add assistant response to shared conversation history for provider interop
if (text) {
session.conversationHistory.push({ role: 'assistant', content: text });
}
// Parse observations and summary
const observations = parseObservations(text, session.contentSessionId);
const summary = parseSummary(text, session.sessionDbId);
// Get the pending message ID(s) for this response
// In normal operation, this should be ONE message (FIFO processing)
// But we handle multiple for safety (in case SDK batches messages)
const pendingMessageStore = this.sessionManager.getPendingMessageStore();
const sessionStore = this.dbManager.getSessionStore();
if (session.pendingProcessingIds.size > 0) {
// ATOMIC TRANSACTION: Store observations + summary + mark message(s) complete
// This prevents duplicates if the worker crashes after storing but before marking complete
for (const messageId of session.pendingProcessingIds) {
// CRITICAL: Must use memorySessionId (not contentSessionId) for FK constraint
if (!session.memorySessionId) {
throw new Error('Cannot store observations: memorySessionId not yet captured');
}
const result = sessionStore.storeObservationsAndMarkComplete(
session.memorySessionId,
session.project,
observations,
summary || null,
messageId,
pendingMessageStore,
session.lastPromptNumber,
discoveryTokens,
originalTimestamp ?? undefined
);
// Log what was saved
logger.info('SDK', 'Observations and summary saved atomically', {
sessionId: session.sessionDbId,
messageId,
observationCount: result.observationIds.length,
hasSummary: !!result.summaryId,
atomicTransaction: true
});
// AFTER transaction commits - async operations (can fail safely without data loss)
// Sync observations to Chroma
for (let i = 0; i < observations.length; i++) {
const obsId = result.observationIds[i];
const obs = observations[i];
const chromaStart = Date.now();
this.dbManager.getChromaSync().syncObservation(
obsId,
session.contentSessionId,
session.project,
obs,
session.lastPromptNumber,
result.createdAtEpoch,
discoveryTokens
).then(() => {
const chromaDuration = Date.now() - chromaStart;
logger.debug('CHROMA', 'Observation synced', {
obsId,
duration: `${chromaDuration}ms`,
type: obs.type,
title: obs.title || '(untitled)'
});
}).catch((error) => {
logger.warn('CHROMA', 'Observation sync failed, continuing without vector search', {
obsId,
type: obs.type,
title: obs.title || '(untitled)'
}, error);
});
// Broadcast to SSE clients (for web UI)
if (worker && worker.sseBroadcaster) {
worker.sseBroadcaster.broadcast({
type: 'new_observation',
observation: {
id: obsId,
memory_session_id: session.memorySessionId,
session_id: session.contentSessionId,
type: obs.type,
title: obs.title,
subtitle: obs.subtitle,
text: obs.text || null,
narrative: obs.narrative || null,
facts: JSON.stringify(obs.facts || []),
concepts: JSON.stringify(obs.concepts || []),
files_read: JSON.stringify(obs.files || []),
files_modified: JSON.stringify([]),
project: session.project,
prompt_number: session.lastPromptNumber,
created_at_epoch: result.createdAtEpoch
}
});
}
}
// Sync summary to Chroma (if present)
if (summary && result.summaryId) {
const chromaStart = Date.now();
this.dbManager.getChromaSync().syncSummary(
result.summaryId,
session.contentSessionId,
session.project,
summary,
session.lastPromptNumber,
result.createdAtEpoch,
discoveryTokens
).then(() => {
const chromaDuration = Date.now() - chromaStart;
logger.debug('CHROMA', 'Summary synced', {
summaryId: result.summaryId,
duration: `${chromaDuration}ms`,
request: summary.request || '(no request)'
});
}).catch((error) => {
logger.warn('CHROMA', 'Summary sync failed, continuing without vector search', {
summaryId: result.summaryId,
request: summary.request || '(no request)'
}, error);
});
// Broadcast to SSE clients (for web UI)
if (worker && worker.sseBroadcaster) {
worker.sseBroadcaster.broadcast({
type: 'new_summary',
summary: {
id: result.summaryId,
session_id: session.contentSessionId,
request: summary.request,
investigated: summary.investigated,
learned: summary.learned,
completed: summary.completed,
next_steps: summary.next_steps,
notes: summary.notes,
project: session.project,
prompt_number: session.lastPromptNumber,
created_at_epoch: result.createdAtEpoch
}
});
}
// Update Cursor context file for registered projects (fire-and-forget)
updateCursorContextForProject(session.project, getWorkerPort()).catch(error => {
logger.warn('CURSOR', 'Context update failed (non-critical)', { project: session.project }, error as Error);
});
}
}
// Clear the processed message IDs
session.pendingProcessingIds.clear();
session.earliestPendingTimestamp = null;
// Clean up old processed messages (keep last 100 for UI display)
const deletedCount = pendingMessageStore.cleanupProcessed(100);
if (deletedCount > 0) {
logger.debug('SDK', 'Cleaned up old processed messages', { deletedCount });
}
// Broadcast activity status after processing (queue may have changed)
if (worker && typeof worker.broadcastProcessingStatus === 'function') {
worker.broadcastProcessingStatus();
}
}
}
// REMOVED: markMessagesProcessed() - replaced by atomic transaction in processSDKResponse()
// Messages are now marked complete atomically with observation storage to prevent duplicates
// ============================================================================
// Configuration Helpers
// ============================================================================
@@ -508,7 +324,7 @@ export class SDKAgent {
*/
private findClaudeExecutable(): string {
const settings = SettingsDefaultsManager.loadFromFile(USER_SETTINGS_PATH);
// 1. Check configured path
if (settings.CLAUDE_CODE_PATH) {
// Lazy load fs to keep startup fast
@@ -522,10 +338,10 @@ export class SDKAgent {
// 2. Try auto-detection
try {
const claudePath = execSync(
process.platform === 'win32' ? 'where claude' : 'which claude',
process.platform === 'win32' ? 'where claude' : 'which claude',
{ encoding: 'utf8', windowsHide: true, stdio: ['ignore', 'pipe', 'ignore'] }
).trim().split('\n')[0].trim();
if (claudePath) return claudePath;
} catch (error) {
// [ANTI-PATTERN IGNORED]: Fallback behavior - which/where failed, continue to throw clear error
+7
View File
@@ -0,0 +1,7 @@
/**
* Search.ts - Named re-export facade for search module
*
* Provides a clean import path for the search module.
*/
export * from './search/index.js';
+155 -133
View File
@@ -1,9 +1,16 @@
/**
* SearchManager - Core search orchestration for claude-mem
* Extracted from mcp-server.ts to centralize business logic in Worker services
*
* This class contains all tool handler logic that was previously in the MCP server.
* The MCP server now acts as a thin HTTP wrapper that calls these methods via HTTP.
* This class is a thin wrapper that delegates to the modular search infrastructure.
* It maintains the same public interface for backward compatibility.
*
* The actual search logic is now in:
* - SearchOrchestrator: Strategy selection and coordination
* - ChromaSearchStrategy: Vector-based semantic search
* - SQLiteSearchStrategy: Filter-only queries
* - HybridSearchStrategy: Metadata filtering + semantic ranking
* - ResultFormatter: Output formatting
* - TimelineBuilder: Timeline construction
*/
import { basename } from 'path';
@@ -17,21 +24,36 @@ import { logger } from '../../utils/logger.js';
import { formatDate, formatTime, formatDateTime, extractFirstFile, groupByDate, estimateTokens } from '../../shared/timeline-formatting.js';
import { ModeManager } from '../domain/ModeManager.js';
const COLLECTION_NAME = 'cm__claude-mem';
const RECENCY_WINDOW_DAYS = 90;
const RECENCY_WINDOW_MS = RECENCY_WINDOW_DAYS * 24 * 60 * 60 * 1000;
import {
SearchOrchestrator,
TimelineBuilder,
TimelineData,
SEARCH_CONSTANTS
} from './search/index.js';
export class SearchManager {
private orchestrator: SearchOrchestrator;
private timelineBuilder: TimelineBuilder;
constructor(
private sessionSearch: SessionSearch,
private sessionStore: SessionStore,
private chromaSync: ChromaSync,
private formatter: FormattingService,
private timelineService: TimelineService
) {}
) {
// Initialize the new modular search infrastructure
this.orchestrator = new SearchOrchestrator(
sessionSearch,
sessionStore,
chromaSync
);
this.timelineBuilder = new TimelineBuilder();
}
/**
* Query Chroma vector database via ChromaSync
* @deprecated Use orchestrator.search() instead
*/
private async queryChroma(
query: string,
@@ -71,8 +93,8 @@ export class SearchManager {
// Flatten dateStart/dateEnd into dateRange object
if (normalized.dateStart || normalized.dateEnd) {
normalized.dateRange = {
start: normalized.dateStart,
end: normalized.dateEnd
start: normalized.dateStart,
end: normalized.dateEnd
};
delete normalized.dateStart;
delete normalized.dateEnd;
@@ -104,13 +126,13 @@ export class SearchManager {
logger.debug('SEARCH', 'Filter-only query (no query text), using direct SQLite filtering', { enablesDateFilters: true });
const obsOptions = { ...options, type: obs_type, concepts, files };
if (searchObservations) {
observations = this.sessionSearch.searchObservations(undefined, obsOptions);
observations = this.sessionSearch.searchObservations(undefined, obsOptions);
}
if (searchSessions) {
sessions = this.sessionSearch.searchSessions(undefined, options);
sessions = this.sessionSearch.searchSessions(undefined, options);
}
if (searchPrompts) {
prompts = this.sessionSearch.searchUserPrompts(undefined, options);
prompts = this.sessionSearch.searchUserPrompts(undefined, options);
}
}
// PATH 2: CHROMA SEMANTIC SEARCH (query text + Chroma available)
@@ -121,11 +143,11 @@ export class SearchManager {
// Build Chroma where filter for doc_type
let whereFilter: Record<string, any> | undefined;
if (type === 'observations') {
whereFilter = { doc_type: 'observation' };
whereFilter = { doc_type: 'observation' };
} else if (type === 'sessions') {
whereFilter = { doc_type: 'session_summary' };
whereFilter = { doc_type: 'session_summary' };
} else if (type === 'prompts') {
whereFilter = { doc_type: 'user_prompt' };
whereFilter = { doc_type: 'user_prompt' };
}
// Step 1: Chroma semantic search with optional type filter
@@ -134,51 +156,51 @@ export class SearchManager {
logger.debug('SEARCH', 'ChromaDB returned semantic matches', { matchCount: chromaResults.ids.length });
if (chromaResults.ids.length > 0) {
// Step 2: Filter by recency (90 days)
const ninetyDaysAgo = Date.now() - RECENCY_WINDOW_MS;
const recentMetadata = chromaResults.metadatas.map((meta, idx) => ({
id: chromaResults.ids[idx],
meta,
isRecent: meta && meta.created_at_epoch > ninetyDaysAgo
})).filter(item => item.isRecent);
// Step 2: Filter by recency (90 days)
const ninetyDaysAgo = Date.now() - SEARCH_CONSTANTS.RECENCY_WINDOW_MS;
const recentMetadata = chromaResults.metadatas.map((meta, idx) => ({
id: chromaResults.ids[idx],
meta,
isRecent: meta && meta.created_at_epoch > ninetyDaysAgo
})).filter(item => item.isRecent);
logger.debug('SEARCH', 'Results within 90-day window', { count: recentMetadata.length });
logger.debug('SEARCH', 'Results within 90-day window', { count: recentMetadata.length });
// Step 3: Categorize IDs by document type
const obsIds: number[] = [];
const sessionIds: number[] = [];
const promptIds: number[] = [];
// Step 3: Categorize IDs by document type
const obsIds: number[] = [];
const sessionIds: number[] = [];
const promptIds: number[] = [];
for (const item of recentMetadata) {
const docType = item.meta?.doc_type;
if (docType === 'observation' && searchObservations) {
obsIds.push(item.id);
} else if (docType === 'session_summary' && searchSessions) {
sessionIds.push(item.id);
} else if (docType === 'user_prompt' && searchPrompts) {
promptIds.push(item.id);
}
}
for (const item of recentMetadata) {
const docType = item.meta?.doc_type;
if (docType === 'observation' && searchObservations) {
obsIds.push(item.id);
} else if (docType === 'session_summary' && searchSessions) {
sessionIds.push(item.id);
} else if (docType === 'user_prompt' && searchPrompts) {
promptIds.push(item.id);
}
}
logger.debug('SEARCH', 'Categorized results by type', { observations: obsIds.length, sessions: sessionIds.length, prompts: prompts.length });
logger.debug('SEARCH', 'Categorized results by type', { observations: obsIds.length, sessions: sessionIds.length, prompts: prompts.length });
// Step 4: Hydrate from SQLite with additional filters
if (obsIds.length > 0) {
// Apply obs_type, concepts, files filters if provided
const obsOptions = { ...options, type: obs_type, concepts, files };
observations = this.sessionStore.getObservationsByIds(obsIds, obsOptions);
}
if (sessionIds.length > 0) {
sessions = this.sessionStore.getSessionSummariesByIds(sessionIds, { orderBy: 'date_desc', limit: options.limit, project: options.project });
}
if (promptIds.length > 0) {
prompts = this.sessionStore.getUserPromptsByIds(promptIds, { orderBy: 'date_desc', limit: options.limit, project: options.project });
}
// Step 4: Hydrate from SQLite with additional filters
if (obsIds.length > 0) {
// Apply obs_type, concepts, files filters if provided
const obsOptions = { ...options, type: obs_type, concepts, files };
observations = this.sessionStore.getObservationsByIds(obsIds, obsOptions);
}
if (sessionIds.length > 0) {
sessions = this.sessionStore.getSessionSummariesByIds(sessionIds, { orderBy: 'date_desc', limit: options.limit, project: options.project });
}
if (promptIds.length > 0) {
prompts = this.sessionStore.getUserPromptsByIds(promptIds, { orderBy: 'date_desc', limit: options.limit, project: options.project });
}
logger.debug('SEARCH', 'Hydrated results from SQLite', { observations: observations.length, sessions: sessions.length, prompts: prompts.length });
logger.debug('SEARCH', 'Hydrated results from SQLite', { observations: observations.length, sessions: sessions.length, prompts: prompts.length });
} else {
// Chroma returned 0 results - this is the correct answer, don't fall back to FTS5
logger.debug('SEARCH', 'ChromaDB found no matches (final result, no FTS5 fallback)', {});
// Chroma returned 0 results - this is the correct answer, don't fall back to FTS5
logger.debug('SEARCH', 'ChromaDB found no matches (final result, no FTS5 fallback)', {});
}
}
// ChromaDB not initialized - mark as failed to show proper error message
@@ -196,28 +218,28 @@ export class SearchManager {
// JSON format: return raw data for programmatic access (e.g., export scripts)
if (format === 'json') {
return {
observations,
sessions,
prompts,
totalResults,
query: query || ''
observations,
sessions,
prompts,
totalResults,
query: query || ''
};
}
if (totalResults === 0) {
if (chromaFailed) {
return {
content: [{
type: 'text' as const,
text: `⚠️ Vector search failed - semantic search unavailable.\n\nTo enable semantic search:\n1. Install uv: https://docs.astral.sh/uv/getting-started/installation/\n2. Restart the worker: npm run worker:restart\n\nNote: You can still use filter-only searches (date ranges, types, files) without a query term.`
}]
};
return {
content: [{
type: 'text' as const,
text: `Vector search failed - semantic search unavailable.\n\nTo enable semantic search:\n1. Install uv: https://docs.astral.sh/uv/getting-started/installation/\n2. Restart the worker: npm run worker:restart\n\nNote: You can still use filter-only searches (date ranges, types, files) without a query term.`
}]
};
}
return {
content: [{
type: 'text' as const,
text: `No results found matching "${query}"`
}]
content: [{
type: 'text' as const,
text: `No results found matching "${query}"`
}]
};
}
@@ -231,22 +253,22 @@ export class SearchManager {
const allResults: CombinedResult[] = [
...observations.map(obs => ({
type: 'observation' as const,
data: obs,
epoch: obs.created_at_epoch,
created_at: obs.created_at
type: 'observation' as const,
data: obs,
epoch: obs.created_at_epoch,
created_at: obs.created_at
})),
...sessions.map(sess => ({
type: 'session' as const,
data: sess,
epoch: sess.created_at_epoch,
created_at: sess.created_at
type: 'session' as const,
data: sess,
epoch: sess.created_at_epoch,
created_at: sess.created_at
})),
...prompts.map(prompt => ({
type: 'prompt' as const,
data: prompt,
epoch: prompt.created_at_epoch,
created_at: prompt.created_at
type: 'prompt' as const,
data: prompt,
epoch: prompt.created_at_epoch,
created_at: prompt.created_at
}))
];
@@ -276,46 +298,46 @@ export class SearchManager {
// Group by file within this day
const resultsByFile = new Map<string, CombinedResult[]>();
for (const result of dayResults) {
let file = 'General';
if (result.type === 'observation') {
file = extractFirstFile(result.data.files_modified, cwd);
}
if (!resultsByFile.has(file)) {
resultsByFile.set(file, []);
}
resultsByFile.get(file)!.push(result);
let file = 'General';
if (result.type === 'observation') {
file = extractFirstFile(result.data.files_modified, cwd);
}
if (!resultsByFile.has(file)) {
resultsByFile.set(file, []);
}
resultsByFile.get(file)!.push(result);
}
// Render each file section
for (const [file, fileResults] of resultsByFile) {
lines.push(`**${file}**`);
lines.push(this.formatter.formatSearchTableHeader());
lines.push(`**${file}**`);
lines.push(this.formatter.formatSearchTableHeader());
let lastTime = '';
for (const result of fileResults) {
if (result.type === 'observation') {
const formatted = this.formatter.formatObservationSearchRow(result.data as ObservationSearchResult, lastTime);
lines.push(formatted.row);
lastTime = formatted.time;
} else if (result.type === 'session') {
const formatted = this.formatter.formatSessionSearchRow(result.data as SessionSummarySearchResult, lastTime);
lines.push(formatted.row);
lastTime = formatted.time;
} else {
const formatted = this.formatter.formatUserPromptSearchRow(result.data as UserPromptSearchResult, lastTime);
lines.push(formatted.row);
lastTime = formatted.time;
}
}
let lastTime = '';
for (const result of fileResults) {
if (result.type === 'observation') {
const formatted = this.formatter.formatObservationSearchRow(result.data as ObservationSearchResult, lastTime);
lines.push(formatted.row);
lastTime = formatted.time;
} else if (result.type === 'session') {
const formatted = this.formatter.formatSessionSearchRow(result.data as SessionSummarySearchResult, lastTime);
lines.push(formatted.row);
lastTime = formatted.time;
} else {
const formatted = this.formatter.formatUserPromptSearchRow(result.data as UserPromptSearchResult, lastTime);
lines.push(formatted.row);
lastTime = formatted.time;
}
}
lines.push('');
lines.push('');
}
}
return {
content: [{
type: 'text' as const,
text: lines.join('\n')
type: 'text' as const,
text: lines.join('\n')
}]
};
}
@@ -364,7 +386,7 @@ export class SearchManager {
logger.debug('SEARCH', 'Chroma returned semantic matches for timeline', { matchCount: chromaResults?.ids?.length ?? 0 });
if (chromaResults?.ids && chromaResults.ids.length > 0) {
const ninetyDaysAgo = Date.now() - RECENCY_WINDOW_MS;
const ninetyDaysAgo = Date.now() - SEARCH_CONSTANTS.RECENCY_WINDOW_MS;
const recentIds = chromaResults.ids.filter((_id, idx) => {
const meta = chromaResults.metadatas[idx];
return meta && meta.created_at_epoch > ninetyDaysAgo;
@@ -488,7 +510,7 @@ export class SearchManager {
lines.push(`# Timeline around anchor: ${anchorId}`);
}
lines.push(`**Window:** ${depth_before} records before ${depth_after} records after | **Items:** ${filteredItems?.length ?? 0}`);
lines.push(`**Window:** ${depth_before} records before -> ${depth_after} records after | **Items:** ${filteredItems?.length ?? 0}`);
lines.push('');
@@ -534,9 +556,9 @@ export class SearchManager {
const sess = item.data as SessionSummarySearchResult;
const title = sess.request || 'Session summary';
const marker = isAnchor ? ' **ANCHOR**' : '';
const marker = isAnchor ? ' <- **ANCHOR**' : '';
lines.push(`**🎯 #S${sess.id}** ${title} (${formatDateTime(item.epoch)})${marker}`);
lines.push(`**\uD83C\uDFAF #S${sess.id}** ${title} (${formatDateTime(item.epoch)})${marker}`);
lines.push('');
} else if (item.type === 'prompt') {
if (tableOpen) {
@@ -549,7 +571,7 @@ export class SearchManager {
const prompt = item.data as UserPromptSearchResult;
const truncated = prompt.prompt_text.length > 100 ? prompt.prompt_text.substring(0, 100) + '...' : prompt.prompt_text;
lines.push(`**💬 User Prompt #${prompt.prompt_number}** (${formatDateTime(item.epoch)})`);
lines.push(`**\uD83D\uDCAC User Prompt #${prompt.prompt_number}** (${formatDateTime(item.epoch)})`);
lines.push(`> ${truncated}`);
lines.push('');
} else if (item.type === 'observation') {
@@ -577,10 +599,10 @@ export class SearchManager {
const tokens = estimateTokens(obs.narrative);
const showTime = time !== lastTime;
const timeDisplay = showTime ? time : '';
const timeDisplay = showTime ? time : '"';
lastTime = time;
const anchorMarker = isAnchor ? ' **ANCHOR**' : '';
const anchorMarker = isAnchor ? ' <- **ANCHOR**' : '';
lines.push(`| #${obs.id} | ${timeDisplay} | ${icon} | ${title}${anchorMarker} | ~${tokens} |`);
}
}
@@ -592,8 +614,8 @@ export class SearchManager {
return {
content: [{
type: 'text' as const,
text: lines.join('\n')
type: 'text' as const,
text: lines.join('\n')
}]
};
}
@@ -830,7 +852,7 @@ export class SearchManager {
if (chromaResults.ids.length > 0) {
// Step 2: Filter by recency (90 days)
const ninetyDaysAgo = Date.now() - RECENCY_WINDOW_MS;
const ninetyDaysAgo = Date.now() - SEARCH_CONSTANTS.RECENCY_WINDOW_MS;
const recentIds = chromaResults.ids.filter((_id, idx) => {
const meta = chromaResults.metadatas[idx];
return meta && meta.created_at_epoch > ninetyDaysAgo;
@@ -887,7 +909,7 @@ export class SearchManager {
if (chromaResults.ids.length > 0) {
// Step 2: Filter by recency (90 days)
const ninetyDaysAgo = Date.now() - RECENCY_WINDOW_MS;
const ninetyDaysAgo = Date.now() - SEARCH_CONSTANTS.RECENCY_WINDOW_MS;
const recentIds = chromaResults.ids.filter((_id, idx) => {
const meta = chromaResults.metadatas[idx];
return meta && meta.created_at_epoch > ninetyDaysAgo;
@@ -944,7 +966,7 @@ export class SearchManager {
if (chromaResults.ids.length > 0) {
// Step 2: Filter by recency (90 days)
const ninetyDaysAgo = Date.now() - RECENCY_WINDOW_MS;
const ninetyDaysAgo = Date.now() - SEARCH_CONSTANTS.RECENCY_WINDOW_MS;
const recentIds = chromaResults.ids.filter((_id, idx) => {
const meta = chromaResults.metadatas[idx];
return meta && meta.created_at_epoch > ninetyDaysAgo;
@@ -1425,7 +1447,7 @@ export class SearchManager {
// Header
lines.push(`# Timeline around anchor: ${anchorId}`);
lines.push(`**Window:** ${depth_before} records before ${depth_after} records after | **Items:** ${filteredItems?.length ?? 0}`);
lines.push(`**Window:** ${depth_before} records before -> ${depth_after} records after | **Items:** ${filteredItems?.length ?? 0}`);
lines.push('');
@@ -1473,9 +1495,9 @@ export class SearchManager {
// Render session
const sess = item.data as SessionSummarySearchResult;
const title = sess.request || 'Session summary';
const marker = isAnchor ? ' **ANCHOR**' : '';
const marker = isAnchor ? ' <- **ANCHOR**' : '';
lines.push(`**🎯 #S${sess.id}** ${title} (${formatDateTime(item.epoch)})${marker}`);
lines.push(`**\uD83C\uDFAF #S${sess.id}** ${title} (${formatDateTime(item.epoch)})${marker}`);
lines.push('');
} else if (item.type === 'prompt') {
// Close any open table
@@ -1490,7 +1512,7 @@ export class SearchManager {
const prompt = item.data as UserPromptSearchResult;
const truncated = prompt.prompt_text.length > 100 ? prompt.prompt_text.substring(0, 100) + '...' : prompt.prompt_text;
lines.push(`**💬 User Prompt #${prompt.prompt_number}** (${formatDateTime(item.epoch)})`);
lines.push(`**\uD83D\uDCAC User Prompt #${prompt.prompt_number}** (${formatDateTime(item.epoch)})`);
lines.push(`> ${truncated}`);
lines.push('');
} else if (item.type === 'observation') {
@@ -1523,10 +1545,10 @@ export class SearchManager {
const tokens = estimateTokens(obs.narrative);
const showTime = time !== lastTime;
const timeDisplay = showTime ? time : '';
const timeDisplay = showTime ? time : '"';
lastTime = time;
const anchorMarker = isAnchor ? ' **ANCHOR**' : '';
const anchorMarker = isAnchor ? ' <- **ANCHOR**' : '';
lines.push(`| #${obs.id} | ${timeDisplay} | ${icon} | ${title}${anchorMarker} | ~${tokens} |`);
}
}
@@ -1563,7 +1585,7 @@ export class SearchManager {
if (chromaResults.ids.length > 0) {
// Filter by recency (90 days)
const ninetyDaysAgo = Date.now() - RECENCY_WINDOW_MS;
const ninetyDaysAgo = Date.now() - SEARCH_CONSTANTS.RECENCY_WINDOW_MS;
const recentIds = chromaResults.ids.filter((_id, idx) => {
const meta = chromaResults.metadatas[idx];
return meta && meta.created_at_epoch > ninetyDaysAgo;
@@ -1659,7 +1681,7 @@ export class SearchManager {
// Header
lines.push(`# Timeline for query: "${query}"`);
lines.push(`**Anchor:** Observation #${topResult.id} - ${topResult.title || 'Untitled'}`);
lines.push(`**Window:** ${depth_before} records before ${depth_after} records after | **Items:** ${filteredItems?.length ?? 0}`);
lines.push(`**Window:** ${depth_before} records before -> ${depth_after} records after | **Items:** ${filteredItems?.length ?? 0}`);
lines.push('');
@@ -1705,7 +1727,7 @@ export class SearchManager {
const sess = item.data as SessionSummarySearchResult;
const title = sess.request || 'Session summary';
lines.push(`**🎯 #S${sess.id}** ${title} (${formatDateTime(item.epoch)})`);
lines.push(`**\uD83C\uDFAF #S${sess.id}** ${title} (${formatDateTime(item.epoch)})`);
lines.push('');
} else if (item.type === 'prompt') {
// Close any open table
@@ -1720,7 +1742,7 @@ export class SearchManager {
const prompt = item.data as UserPromptSearchResult;
const truncated = prompt.prompt_text.length > 100 ? prompt.prompt_text.substring(0, 100) + '...' : prompt.prompt_text;
lines.push(`**💬 User Prompt #${prompt.prompt_number}** (${formatDateTime(item.epoch)})`);
lines.push(`**\uD83D\uDCAC User Prompt #${prompt.prompt_number}** (${formatDateTime(item.epoch)})`);
lines.push(`> ${truncated}`);
lines.push('');
} else if (item.type === 'observation') {
@@ -1753,10 +1775,10 @@ export class SearchManager {
const tokens = estimateTokens(obs.narrative);
const showTime = time !== lastTime;
const timeDisplay = showTime ? time : '';
const timeDisplay = showTime ? time : '"';
lastTime = time;
const anchorMarker = isAnchor ? ' **ANCHOR**' : '';
const anchorMarker = isAnchor ? ' <- **ANCHOR**' : '';
lines.push(`| #${obs.id} | ${timeDisplay} | ${icon} | ${title}${anchorMarker} | ~${tokens} |`);
}
}
+2 -6
View File
@@ -137,7 +137,6 @@ export class SessionManager {
startTime: Date.now(),
cumulativeInputTokens: 0,
cumulativeOutputTokens: 0,
pendingProcessingIds: new Set(),
earliestPendingTimestamp: null,
conversationHistory: [], // Initialize empty - will be populated by agents
currentProvider: null // Will be set when generator starts
@@ -379,12 +378,9 @@ export class SessionManager {
}
const processor = new SessionQueueProcessor(this.getPendingStore(), emitter);
// Use the robust Pump iterator
for await (const message of processor.createIterator(sessionDbId, session.abortController.signal)) {
// Track this message ID for completion marking
session.pendingProcessingIds.add(message._persistentId);
// Use the robust iterator - messages are deleted on claim (no tracking needed)
for await (const message of processor.createIterator(sessionDbId, session.abortController.signal)) {
// Track earliest timestamp for accurate observation timestamps
// This ensures backlog messages get their original timestamps, not current time
if (session.earliestPendingTimestamp === null) {
@@ -0,0 +1,73 @@
/**
* FallbackErrorHandler: Error detection for provider fallback
*
* Responsibility:
* - Determine if an error should trigger fallback to Claude SDK
* - Provide consistent error classification across Gemini and OpenRouter
*/
import { FALLBACK_ERROR_PATTERNS } from './types.js';
/**
* Check if an error should trigger fallback to Claude SDK
*
* Errors that trigger fallback:
* - 429: Rate limit exceeded
* - 500/502/503: Server errors
* - ECONNREFUSED: Connection refused (server down)
* - ETIMEDOUT: Request timeout
* - fetch failed: Network failure
*
* @param error - Error object to check
* @returns true if the error should trigger fallback to Claude
*/
export function shouldFallbackToClaude(error: unknown): boolean {
const message = getErrorMessage(error);
return FALLBACK_ERROR_PATTERNS.some(pattern => message.includes(pattern));
}
/**
* Extract error message from various error types
*/
function getErrorMessage(error: unknown): string {
if (error === null || error === undefined) {
return '';
}
if (typeof error === 'string') {
return error;
}
if (error instanceof Error) {
return error.message;
}
if (typeof error === 'object' && 'message' in error) {
return String((error as { message: unknown }).message);
}
return String(error);
}
/**
* Check if error is an AbortError (user cancelled)
*
* @param error - Error object to check
* @returns true if this is an abort/cancellation error
*/
export function isAbortError(error: unknown): boolean {
if (error === null || error === undefined) {
return false;
}
if (error instanceof Error && error.name === 'AbortError') {
return true;
}
if (typeof error === 'object' && 'name' in error) {
return (error as { name: unknown }).name === 'AbortError';
}
return false;
}
@@ -0,0 +1,54 @@
/**
* ObservationBroadcaster: SSE broadcasting for observations and summaries
*
* Responsibility:
* - Broadcast new observations to SSE clients
* - Broadcast new summaries to SSE clients
* - Handle worker reference safely (null checks)
*
* BUGFIX: This module fixes the incorrect field names in SDKAgent:
* - SDKAgent used `obs.files` which doesn't exist - should be `obs.files_read`
* - SDKAgent used hardcoded `files_modified: JSON.stringify([])` - should use `obs.files_modified`
*/
import type { WorkerRef, ObservationSSEPayload, SummarySSEPayload } from './types.js';
/**
* Broadcast a new observation to SSE clients
*
* @param worker - Worker reference with SSE broadcaster (can be undefined)
* @param payload - Observation data to broadcast
*/
export function broadcastObservation(
worker: WorkerRef | undefined,
payload: ObservationSSEPayload
): void {
if (!worker?.sseBroadcaster) {
return;
}
worker.sseBroadcaster.broadcast({
type: 'new_observation',
observation: payload
});
}
/**
* Broadcast a new summary to SSE clients
*
* @param worker - Worker reference with SSE broadcaster (can be undefined)
* @param payload - Summary data to broadcast
*/
export function broadcastSummary(
worker: WorkerRef | undefined,
payload: SummarySSEPayload
): void {
if (!worker?.sseBroadcaster) {
return;
}
worker.sseBroadcaster.broadcast({
type: 'new_summary',
summary: payload
});
}
@@ -0,0 +1,270 @@
/**
* ResponseProcessor: Shared response processing for all agent implementations
*
* Responsibility:
* - Parse observations and summaries from agent responses
* - Execute atomic database transactions
* - Orchestrate Chroma sync (fire-and-forget)
* - Broadcast to SSE clients
* - Clean up processed messages
*
* This module extracts 150+ lines of duplicate code from SDKAgent, GeminiAgent, and OpenRouterAgent.
*/
import { logger } from '../../../utils/logger.js';
import { parseObservations, parseSummary, type ParsedObservation, type ParsedSummary } from '../../../sdk/parser.js';
import { updateCursorContextForProject } from '../../worker-service.js';
import { getWorkerPort } from '../../../shared/worker-utils.js';
import type { ActiveSession } from '../../worker-types.js';
import type { DatabaseManager } from '../DatabaseManager.js';
import type { SessionManager } from '../SessionManager.js';
import type { WorkerRef, StorageResult } from './types.js';
import { broadcastObservation, broadcastSummary } from './ObservationBroadcaster.js';
import { cleanupProcessedMessages } from './SessionCleanupHelper.js';
/**
* Process agent response text (parse XML, save to database, sync to Chroma, broadcast SSE)
*
* This is the unified response processor that handles:
* 1. Adding response to conversation history (for provider interop)
* 2. Parsing observations and summaries from XML
* 3. Atomic database transaction to store observations + summary
* 4. Async Chroma sync (fire-and-forget, failures are non-critical)
* 5. SSE broadcast to web UI clients
* 6. Session cleanup
*
* @param text - Response text from the agent
* @param session - Active session being processed
* @param dbManager - Database manager for storage operations
* @param sessionManager - Session manager for message tracking
* @param worker - Worker reference for SSE broadcasting (optional)
* @param discoveryTokens - Token cost delta for this response
* @param originalTimestamp - Original epoch when message was queued (for accurate timestamps)
* @param agentName - Name of the agent for logging (e.g., 'SDK', 'Gemini', 'OpenRouter')
*/
export async function processAgentResponse(
text: string,
session: ActiveSession,
dbManager: DatabaseManager,
sessionManager: SessionManager,
worker: WorkerRef | undefined,
discoveryTokens: number,
originalTimestamp: number | null,
agentName: string
): Promise<void> {
// Add assistant response to shared conversation history for provider interop
if (text) {
session.conversationHistory.push({ role: 'assistant', content: text });
}
// Parse observations and summary
const observations = parseObservations(text, session.contentSessionId);
const summary = parseSummary(text, session.sessionDbId);
// Convert nullable fields to empty strings for storeSummary (if summary exists)
const summaryForStore = normalizeSummaryForStorage(summary);
// Get session store for atomic transaction
const sessionStore = dbManager.getSessionStore();
// CRITICAL: Must use memorySessionId (not contentSessionId) for FK constraint
if (!session.memorySessionId) {
throw new Error('Cannot store observations: memorySessionId not yet captured');
}
// ATOMIC TRANSACTION: Store observations + summary ONCE
// Messages are already deleted from queue on claim, so no completion tracking needed
const result = sessionStore.storeObservations(
session.memorySessionId,
session.project,
observations,
summaryForStore,
session.lastPromptNumber,
discoveryTokens,
originalTimestamp ?? undefined
);
// Log what was saved
logger.info('SDK', `${agentName} observations and summary saved atomically`, {
sessionId: session.sessionDbId,
observationCount: result.observationIds.length,
hasSummary: !!result.summaryId,
atomicTransaction: true
});
// AFTER transaction commits - async operations (can fail safely without data loss)
await syncAndBroadcastObservations(
observations,
result,
session,
dbManager,
worker,
discoveryTokens,
agentName
);
// Sync and broadcast summary if present
await syncAndBroadcastSummary(
summary,
summaryForStore,
result,
session,
dbManager,
worker,
discoveryTokens,
agentName
);
// Clean up session state
cleanupProcessedMessages(session, worker);
}
/**
* Normalize summary for storage (convert null fields to empty strings)
*/
function normalizeSummaryForStorage(summary: ParsedSummary | null): {
request: string;
investigated: string;
learned: string;
completed: string;
next_steps: string;
notes: string | null;
} | null {
if (!summary) return null;
return {
request: summary.request || '',
investigated: summary.investigated || '',
learned: summary.learned || '',
completed: summary.completed || '',
next_steps: summary.next_steps || '',
notes: summary.notes
};
}
/**
* Sync observations to Chroma and broadcast to SSE clients
*/
async function syncAndBroadcastObservations(
observations: ParsedObservation[],
result: StorageResult,
session: ActiveSession,
dbManager: DatabaseManager,
worker: WorkerRef | undefined,
discoveryTokens: number,
agentName: string
): Promise<void> {
for (let i = 0; i < observations.length; i++) {
const obsId = result.observationIds[i];
const obs = observations[i];
const chromaStart = Date.now();
// Sync to Chroma (fire-and-forget)
dbManager.getChromaSync().syncObservation(
obsId,
session.contentSessionId,
session.project,
obs,
session.lastPromptNumber,
result.createdAtEpoch,
discoveryTokens
).then(() => {
const chromaDuration = Date.now() - chromaStart;
logger.debug('CHROMA', 'Observation synced', {
obsId,
duration: `${chromaDuration}ms`,
type: obs.type,
title: obs.title || '(untitled)'
});
}).catch((error) => {
logger.warn('CHROMA', `${agentName} chroma sync failed, continuing without vector search`, {
obsId,
type: obs.type,
title: obs.title || '(untitled)'
}, error);
});
// Broadcast to SSE clients (for web UI)
// BUGFIX: Use obs.files_read and obs.files_modified (not obs.files)
broadcastObservation(worker, {
id: obsId,
memory_session_id: session.memorySessionId,
session_id: session.contentSessionId,
type: obs.type,
title: obs.title,
subtitle: obs.subtitle,
text: null, // text field is not in ParsedObservation
narrative: obs.narrative || null,
facts: JSON.stringify(obs.facts || []),
concepts: JSON.stringify(obs.concepts || []),
files_read: JSON.stringify(obs.files_read || []),
files_modified: JSON.stringify(obs.files_modified || []),
project: session.project,
prompt_number: session.lastPromptNumber,
created_at_epoch: result.createdAtEpoch
});
}
}
/**
* Sync summary to Chroma and broadcast to SSE clients
*/
async function syncAndBroadcastSummary(
summary: ParsedSummary | null,
summaryForStore: { request: string; investigated: string; learned: string; completed: string; next_steps: string; notes: string | null } | null,
result: StorageResult,
session: ActiveSession,
dbManager: DatabaseManager,
worker: WorkerRef | undefined,
discoveryTokens: number,
agentName: string
): Promise<void> {
if (!summaryForStore || !result.summaryId) {
return;
}
const chromaStart = Date.now();
// Sync to Chroma (fire-and-forget)
dbManager.getChromaSync().syncSummary(
result.summaryId,
session.contentSessionId,
session.project,
summaryForStore,
session.lastPromptNumber,
result.createdAtEpoch,
discoveryTokens
).then(() => {
const chromaDuration = Date.now() - chromaStart;
logger.debug('CHROMA', 'Summary synced', {
summaryId: result.summaryId,
duration: `${chromaDuration}ms`,
request: summaryForStore.request || '(no request)'
});
}).catch((error) => {
logger.warn('CHROMA', `${agentName} chroma sync failed, continuing without vector search`, {
summaryId: result.summaryId,
request: summaryForStore.request || '(no request)'
}, error);
});
// Broadcast to SSE clients (for web UI)
broadcastSummary(worker, {
id: result.summaryId,
session_id: session.contentSessionId,
request: summary!.request,
investigated: summary!.investigated,
learned: summary!.learned,
completed: summary!.completed,
next_steps: summary!.next_steps,
notes: summary!.notes,
project: session.project,
prompt_number: session.lastPromptNumber,
created_at_epoch: result.createdAtEpoch
});
// Update Cursor context file for registered projects (fire-and-forget)
updateCursorContextForProject(session.project, getWorkerPort()).catch(error => {
logger.warn('CURSOR', 'Context update failed (non-critical)', { project: session.project }, error as Error);
});
}
@@ -0,0 +1,36 @@
/**
* SessionCleanupHelper: Session state cleanup after response processing
*
* Responsibility:
* - Reset earliest pending timestamp
* - Broadcast processing status updates
*
* NOTE: With claim-and-delete queue pattern, messages are deleted on claim,
* so there's no pendingProcessingIds tracking or processed message cleanup.
*/
import type { ActiveSession } from '../../worker-types.js';
import type { WorkerRef } from './types.js';
/**
* Clean up session state after response processing
*
* With claim-and-delete queue pattern, this function simply:
* 1. Resets the earliest pending timestamp
* 2. Broadcasts updated processing status to SSE clients
*
* @param session - Active session to clean up
* @param worker - Worker reference for status broadcasting (optional)
*/
export function cleanupProcessedMessages(
session: ActiveSession,
worker: WorkerRef | undefined
): void {
// Reset earliest pending timestamp for next batch
session.earliestPendingTimestamp = null;
// Broadcast activity status after processing (queue may have changed)
if (worker && typeof worker.broadcastProcessingStatus === 'function') {
worker.broadcastProcessingStatus();
}
}
+38
View File
@@ -0,0 +1,38 @@
/**
* Agent Consolidation Module
*
* This module provides shared utilities for SDK, Gemini, and OpenRouter agents.
* It extracts common patterns to reduce code duplication and ensure consistent behavior.
*
* Usage:
* ```typescript
* import { processAgentResponse, shouldFallbackToClaude } from './agents/index.js';
* ```
*/
// Types
export type {
WorkerRef,
ObservationSSEPayload,
SummarySSEPayload,
SSEEventPayload,
StorageResult,
ResponseProcessingContext,
ParsedResponse,
FallbackAgent,
BaseAgentConfig,
} from './types.js';
export { FALLBACK_ERROR_PATTERNS } from './types.js';
// Response Processing
export { processAgentResponse } from './ResponseProcessor.js';
// SSE Broadcasting
export { broadcastObservation, broadcastSummary } from './ObservationBroadcaster.js';
// Session Cleanup
export { cleanupProcessedMessages } from './SessionCleanupHelper.js';
// Error Handling
export { shouldFallbackToClaude, isAbortError } from './FallbackErrorHandler.js';
+133
View File
@@ -0,0 +1,133 @@
/**
* Shared agent types for SDK, Gemini, and OpenRouter agents
*
* Responsibility:
* - Define common interfaces used across all agent implementations
* - Provide type safety for response processing and broadcasting
*/
import type { ActiveSession } from '../../worker-types.js';
import type { ParsedObservation, ParsedSummary } from '../../../sdk/parser.js';
// ============================================================================
// Worker Reference Type
// ============================================================================
/**
* Worker reference for SSE broadcasting and status updates
* Both sseBroadcaster and broadcastProcessingStatus are optional
* to allow agents to run without a full worker context (e.g., testing)
*/
export interface WorkerRef {
sseBroadcaster?: {
broadcast(event: SSEEventPayload): void;
};
broadcastProcessingStatus?: () => void;
}
// ============================================================================
// SSE Event Payloads
// ============================================================================
export interface ObservationSSEPayload {
id: number;
memory_session_id: string | null;
session_id: string;
type: string;
title: string | null;
subtitle: string | null;
text: string | null;
narrative: string | null;
facts: string; // JSON stringified
concepts: string; // JSON stringified
files_read: string; // JSON stringified
files_modified: string; // JSON stringified
project: string;
prompt_number: number;
created_at_epoch: number;
}
export interface SummarySSEPayload {
id: number;
session_id: string;
request: string | null;
investigated: string | null;
learned: string | null;
completed: string | null;
next_steps: string | null;
notes: string | null;
project: string;
prompt_number: number;
created_at_epoch: number;
}
export type SSEEventPayload =
| { type: 'new_observation'; observation: ObservationSSEPayload }
| { type: 'new_summary'; summary: SummarySSEPayload };
// ============================================================================
// Response Processing Types
// ============================================================================
/**
* Result from atomic database transaction for observations/summary storage
*/
export interface StorageResult {
observationIds: number[];
summaryId: number | null;
createdAtEpoch: number;
}
/**
* Context needed for response processing
*/
export interface ResponseProcessingContext {
session: ActiveSession;
worker: WorkerRef | undefined;
discoveryTokens: number;
originalTimestamp: number | null;
}
/**
* Parsed response data ready for storage
*/
export interface ParsedResponse {
observations: ParsedObservation[];
summary: ParsedSummary | null;
}
// ============================================================================
// Fallback Agent Interface
// ============================================================================
/**
* Interface for fallback agent (used by Gemini/OpenRouter to fall back to Claude)
*/
export interface FallbackAgent {
startSession(session: ActiveSession, worker?: WorkerRef): Promise<void>;
}
// ============================================================================
// Agent Configuration Types
// ============================================================================
/**
* Base configuration shared across all agents
*/
export interface BaseAgentConfig {
dbManager: import('../DatabaseManager.js').DatabaseManager;
sessionManager: import('../SessionManager.js').SessionManager;
}
/**
* Error codes that should trigger fallback to Claude
*/
export const FALLBACK_ERROR_PATTERNS = [
'429', // Rate limit
'500', // Internal server error
'502', // Bad gateway
'503', // Service unavailable
'ECONNREFUSED', // Connection refused
'ETIMEDOUT', // Timeout
'fetch failed', // Network failure
] as const;
@@ -0,0 +1,302 @@
/**
* ResultFormatter - Formats search results for display
*
* Consolidates formatting logic from FormattingService and SearchManager.
* Provides consistent table and text formatting for all search result types.
*/
import {
ObservationSearchResult,
SessionSummarySearchResult,
UserPromptSearchResult,
CombinedResult,
SearchResults
} from './types.js';
import { ModeManager } from '../../domain/ModeManager.js';
import { formatTime, extractFirstFile, groupByDate, estimateTokens } from '../../../shared/timeline-formatting.js';
const CHARS_PER_TOKEN_ESTIMATE = 4;
export class ResultFormatter {
/**
* Format search results as markdown text
*/
formatSearchResults(
results: SearchResults,
query: string,
chromaFailed: boolean = false
): string {
const totalResults = results.observations.length +
results.sessions.length +
results.prompts.length;
if (totalResults === 0) {
if (chromaFailed) {
return this.formatChromaFailureMessage();
}
return `No results found matching "${query}"`;
}
// Combine all results with timestamps for unified sorting
const combined = this.combineResults(results);
// Sort by date
combined.sort((a, b) => b.epoch - a.epoch);
// Group by date, then by file within each day
const cwd = process.cwd();
const resultsByDate = groupByDate(combined, item => item.created_at);
// Build output with date/file grouping
const lines: string[] = [];
lines.push(`Found ${totalResults} result(s) matching "${query}" (${results.observations.length} obs, ${results.sessions.length} sessions, ${results.prompts.length} prompts)`);
lines.push('');
for (const [day, dayResults] of resultsByDate) {
lines.push(`### ${day}`);
lines.push('');
// Group by file within this day
const resultsByFile = new Map<string, CombinedResult[]>();
for (const result of dayResults) {
let file = 'General';
if (result.type === 'observation') {
file = extractFirstFile(
(result.data as ObservationSearchResult).files_modified,
cwd
);
}
if (!resultsByFile.has(file)) {
resultsByFile.set(file, []);
}
resultsByFile.get(file)!.push(result);
}
// Render each file section
for (const [file, fileResults] of resultsByFile) {
lines.push(`**${file}**`);
lines.push(this.formatSearchTableHeader());
let lastTime = '';
for (const result of fileResults) {
if (result.type === 'observation') {
const formatted = this.formatObservationSearchRow(
result.data as ObservationSearchResult,
lastTime
);
lines.push(formatted.row);
lastTime = formatted.time;
} else if (result.type === 'session') {
const formatted = this.formatSessionSearchRow(
result.data as SessionSummarySearchResult,
lastTime
);
lines.push(formatted.row);
lastTime = formatted.time;
} else {
const formatted = this.formatPromptSearchRow(
result.data as UserPromptSearchResult,
lastTime
);
lines.push(formatted.row);
lastTime = formatted.time;
}
}
lines.push('');
}
}
return lines.join('\n');
}
/**
* Combine results into unified format
*/
combineResults(results: SearchResults): CombinedResult[] {
return [
...results.observations.map(obs => ({
type: 'observation' as const,
data: obs,
epoch: obs.created_at_epoch,
created_at: obs.created_at
})),
...results.sessions.map(sess => ({
type: 'session' as const,
data: sess,
epoch: sess.created_at_epoch,
created_at: sess.created_at
})),
...results.prompts.map(prompt => ({
type: 'prompt' as const,
data: prompt,
epoch: prompt.created_at_epoch,
created_at: prompt.created_at
}))
];
}
/**
* Format search table header (no Work column)
*/
formatSearchTableHeader(): string {
return `| ID | Time | T | Title | Read |
|----|------|---|-------|------|`;
}
/**
* Format full table header (with Work column)
*/
formatTableHeader(): string {
return `| ID | Time | T | Title | Read | Work |
|-----|------|---|-------|------|------|`;
}
/**
* Format observation as table row for search results
*/
formatObservationSearchRow(
obs: ObservationSearchResult,
lastTime: string
): { row: string; time: string } {
const id = `#${obs.id}`;
const time = formatTime(obs.created_at_epoch);
const icon = ModeManager.getInstance().getTypeIcon(obs.type);
const title = obs.title || 'Untitled';
const readTokens = this.estimateReadTokens(obs);
const timeDisplay = time === lastTime ? '"' : time;
return {
row: `| ${id} | ${timeDisplay} | ${icon} | ${title} | ~${readTokens} |`,
time
};
}
/**
* Format session as table row for search results
*/
formatSessionSearchRow(
session: SessionSummarySearchResult,
lastTime: string
): { row: string; time: string } {
const id = `#S${session.id}`;
const time = formatTime(session.created_at_epoch);
const icon = '\uD83C\uDFAF'; // Target emoji
const title = session.request ||
`Session ${session.memory_session_id?.substring(0, 8) || 'unknown'}`;
const timeDisplay = time === lastTime ? '"' : time;
return {
row: `| ${id} | ${timeDisplay} | ${icon} | ${title} | - |`,
time
};
}
/**
* Format user prompt as table row for search results
*/
formatPromptSearchRow(
prompt: UserPromptSearchResult,
lastTime: string
): { row: string; time: string } {
const id = `#P${prompt.id}`;
const time = formatTime(prompt.created_at_epoch);
const icon = '\uD83D\uDCAC'; // Speech bubble emoji
const title = prompt.prompt_text.length > 60
? prompt.prompt_text.substring(0, 57) + '...'
: prompt.prompt_text;
const timeDisplay = time === lastTime ? '"' : time;
return {
row: `| ${id} | ${timeDisplay} | ${icon} | ${title} | - |`,
time
};
}
/**
* Format observation as index row (with Work column)
*/
formatObservationIndex(obs: ObservationSearchResult, _index: number): string {
const id = `#${obs.id}`;
const time = formatTime(obs.created_at_epoch);
const icon = ModeManager.getInstance().getTypeIcon(obs.type);
const title = obs.title || 'Untitled';
const readTokens = this.estimateReadTokens(obs);
const workEmoji = ModeManager.getInstance().getWorkEmoji(obs.type);
const workTokens = obs.discovery_tokens || 0;
const workDisplay = workTokens > 0 ? `${workEmoji} ${workTokens}` : '-';
return `| ${id} | ${time} | ${icon} | ${title} | ~${readTokens} | ${workDisplay} |`;
}
/**
* Format session as index row
*/
formatSessionIndex(session: SessionSummarySearchResult, _index: number): string {
const id = `#S${session.id}`;
const time = formatTime(session.created_at_epoch);
const icon = '\uD83C\uDFAF';
const title = session.request ||
`Session ${session.memory_session_id?.substring(0, 8) || 'unknown'}`;
return `| ${id} | ${time} | ${icon} | ${title} | - | - |`;
}
/**
* Format user prompt as index row
*/
formatPromptIndex(prompt: UserPromptSearchResult, _index: number): string {
const id = `#P${prompt.id}`;
const time = formatTime(prompt.created_at_epoch);
const icon = '\uD83D\uDCAC';
const title = prompt.prompt_text.length > 60
? prompt.prompt_text.substring(0, 57) + '...'
: prompt.prompt_text;
return `| ${id} | ${time} | ${icon} | ${title} | - | - |`;
}
/**
* Estimate read tokens for an observation
*/
private estimateReadTokens(obs: ObservationSearchResult): number {
const size = (obs.title?.length || 0) +
(obs.subtitle?.length || 0) +
(obs.narrative?.length || 0) +
(obs.facts?.length || 0);
return Math.ceil(size / CHARS_PER_TOKEN_ESTIMATE);
}
/**
* Format Chroma failure message
*/
private formatChromaFailureMessage(): string {
return `Vector search failed - semantic search unavailable.
To enable semantic search:
1. Install uv: https://docs.astral.sh/uv/getting-started/installation/
2. Restart the worker: npm run worker:restart
Note: You can still use filter-only searches (date ranges, types, files) without a query term.`;
}
/**
* Format search tips footer
*/
formatSearchTips(): string {
return `
---
Search Strategy:
1. Search with index to see titles, dates, IDs
2. Use timeline to get context around interesting results
3. Batch fetch full details: get_observations(ids=[...])
Tips:
- Filter by type: obs_type="bugfix,feature"
- Filter by date: dateStart="2025-01-01"
- Sort: orderBy="date_desc" or "date_asc"`;
}
}
@@ -0,0 +1,287 @@
/**
* SearchOrchestrator - Coordinates search strategies and handles fallback logic
*
* This is the main entry point for search operations. It:
* 1. Normalizes input parameters
* 2. Selects the appropriate strategy
* 3. Executes the search
* 4. Handles fallbacks on failure
* 5. Delegates to formatters for output
*/
import { SessionSearch } from '../../sqlite/SessionSearch.js';
import { SessionStore } from '../../sqlite/SessionStore.js';
import { ChromaSync } from '../../sync/ChromaSync.js';
import { ChromaSearchStrategy } from './strategies/ChromaSearchStrategy.js';
import { SQLiteSearchStrategy } from './strategies/SQLiteSearchStrategy.js';
import { HybridSearchStrategy } from './strategies/HybridSearchStrategy.js';
import { ResultFormatter } from './ResultFormatter.js';
import { TimelineBuilder, TimelineItem, TimelineData } from './TimelineBuilder.js';
import {
StrategySearchOptions,
StrategySearchResult,
SearchResults,
SEARCH_CONSTANTS,
ObservationSearchResult
} from './types.js';
import { logger } from '../../../utils/logger.js';
/**
* Normalized parameters from URL-friendly format
*/
interface NormalizedParams extends StrategySearchOptions {
concepts?: string[];
files?: string[];
obsType?: string[];
}
export class SearchOrchestrator {
private chromaStrategy: ChromaSearchStrategy | null = null;
private sqliteStrategy: SQLiteSearchStrategy;
private hybridStrategy: HybridSearchStrategy | null = null;
private resultFormatter: ResultFormatter;
private timelineBuilder: TimelineBuilder;
constructor(
private sessionSearch: SessionSearch,
private sessionStore: SessionStore,
private chromaSync: ChromaSync | null
) {
// Initialize strategies
this.sqliteStrategy = new SQLiteSearchStrategy(sessionSearch);
if (chromaSync) {
this.chromaStrategy = new ChromaSearchStrategy(chromaSync, sessionStore);
this.hybridStrategy = new HybridSearchStrategy(chromaSync, sessionStore, sessionSearch);
}
this.resultFormatter = new ResultFormatter();
this.timelineBuilder = new TimelineBuilder();
}
/**
* Main search entry point
*/
async search(args: any): Promise<StrategySearchResult> {
const options = this.normalizeParams(args);
// Decision tree for strategy selection
return await this.executeWithFallback(options);
}
/**
* Execute search with fallback logic
*/
private async executeWithFallback(
options: NormalizedParams
): Promise<StrategySearchResult> {
// PATH 1: FILTER-ONLY (no query text) - Use SQLite
if (!options.query) {
logger.debug('SEARCH', 'Orchestrator: Filter-only query, using SQLite', {});
return await this.sqliteStrategy.search(options);
}
// PATH 2: CHROMA SEMANTIC SEARCH (query text + Chroma available)
if (this.chromaStrategy) {
logger.debug('SEARCH', 'Orchestrator: Using Chroma semantic search', {});
const result = await this.chromaStrategy.search(options);
// If Chroma succeeded (even with 0 results), return
if (result.usedChroma) {
return result;
}
// Chroma failed - fall back to SQLite for filter-only
logger.debug('SEARCH', 'Orchestrator: Chroma failed, falling back to SQLite', {});
const fallbackResult = await this.sqliteStrategy.search({
...options,
query: undefined // Remove query for SQLite fallback
});
return {
...fallbackResult,
fellBack: true
};
}
// PATH 3: No Chroma available
logger.debug('SEARCH', 'Orchestrator: Chroma not available', {});
return {
results: { observations: [], sessions: [], prompts: [] },
usedChroma: false,
fellBack: false,
strategy: 'sqlite'
};
}
/**
* Find by concept with hybrid search
*/
async findByConcept(concept: string, args: any): Promise<StrategySearchResult> {
const options = this.normalizeParams(args);
if (this.hybridStrategy) {
return await this.hybridStrategy.findByConcept(concept, options);
}
// Fallback to SQLite
const results = this.sqliteStrategy.findByConcept(concept, options);
return {
results: { observations: results, sessions: [], prompts: [] },
usedChroma: false,
fellBack: false,
strategy: 'sqlite'
};
}
/**
* Find by type with hybrid search
*/
async findByType(type: string | string[], args: any): Promise<StrategySearchResult> {
const options = this.normalizeParams(args);
if (this.hybridStrategy) {
return await this.hybridStrategy.findByType(type, options);
}
// Fallback to SQLite
const results = this.sqliteStrategy.findByType(type, options);
return {
results: { observations: results, sessions: [], prompts: [] },
usedChroma: false,
fellBack: false,
strategy: 'sqlite'
};
}
/**
* Find by file with hybrid search
*/
async findByFile(filePath: string, args: any): Promise<{
observations: ObservationSearchResult[];
sessions: any[];
usedChroma: boolean;
}> {
const options = this.normalizeParams(args);
if (this.hybridStrategy) {
return await this.hybridStrategy.findByFile(filePath, options);
}
// Fallback to SQLite
const results = this.sqliteStrategy.findByFile(filePath, options);
return { ...results, usedChroma: false };
}
/**
* Get timeline around anchor
*/
getTimeline(
timelineData: TimelineData,
anchorId: number | string,
anchorEpoch: number,
depthBefore: number,
depthAfter: number
): TimelineItem[] {
const items = this.timelineBuilder.buildTimeline(timelineData);
return this.timelineBuilder.filterByDepth(items, anchorId, anchorEpoch, depthBefore, depthAfter);
}
/**
* Format timeline for display
*/
formatTimeline(
items: TimelineItem[],
anchorId: number | string | null,
options: {
query?: string;
depthBefore?: number;
depthAfter?: number;
} = {}
): string {
return this.timelineBuilder.formatTimeline(items, anchorId, options);
}
/**
* Format search results for display
*/
formatSearchResults(
results: SearchResults,
query: string,
chromaFailed: boolean = false
): string {
return this.resultFormatter.formatSearchResults(results, query, chromaFailed);
}
/**
* Get result formatter for direct access
*/
getFormatter(): ResultFormatter {
return this.resultFormatter;
}
/**
* Get timeline builder for direct access
*/
getTimelineBuilder(): TimelineBuilder {
return this.timelineBuilder;
}
/**
* Normalize query parameters from URL-friendly format
*/
private normalizeParams(args: any): NormalizedParams {
const normalized: any = { ...args };
// Parse comma-separated concepts into array
if (normalized.concepts && typeof normalized.concepts === 'string') {
normalized.concepts = normalized.concepts.split(',').map((s: string) => s.trim()).filter(Boolean);
}
// Parse comma-separated files into array
if (normalized.files && typeof normalized.files === 'string') {
normalized.files = normalized.files.split(',').map((s: string) => s.trim()).filter(Boolean);
}
// Parse comma-separated obs_type into array
if (normalized.obs_type && typeof normalized.obs_type === 'string') {
normalized.obsType = normalized.obs_type.split(',').map((s: string) => s.trim()).filter(Boolean);
delete normalized.obs_type;
}
// Parse comma-separated type (for filterSchema) into array
if (normalized.type && typeof normalized.type === 'string' && normalized.type.includes(',')) {
normalized.type = normalized.type.split(',').map((s: string) => s.trim()).filter(Boolean);
}
// Map 'type' param to 'searchType' for API consistency
if (normalized.type && !normalized.searchType) {
if (['observations', 'sessions', 'prompts'].includes(normalized.type)) {
normalized.searchType = normalized.type;
delete normalized.type;
}
}
// Flatten dateStart/dateEnd into dateRange object
if (normalized.dateStart || normalized.dateEnd) {
normalized.dateRange = {
start: normalized.dateStart,
end: normalized.dateEnd
};
delete normalized.dateStart;
delete normalized.dateEnd;
}
return normalized;
}
/**
* Check if Chroma is available
*/
isChromaAvailable(): boolean {
return !!this.chromaSync;
}
}
@@ -0,0 +1,302 @@
/**
* TimelineBuilder - Constructs timeline views for search results
*
* Builds chronological views around anchor points with depth control.
* Used by the timeline tool and get_context_timeline tool.
*/
import {
ObservationSearchResult,
SessionSummarySearchResult,
UserPromptSearchResult,
CombinedResult
} from './types.js';
import { ModeManager } from '../../domain/ModeManager.js';
import {
formatDate,
formatTime,
formatDateTime,
extractFirstFile,
estimateTokens
} from '../../../shared/timeline-formatting.js';
/**
* Timeline item for unified chronological display
*/
export interface TimelineItem {
type: 'observation' | 'session' | 'prompt';
data: ObservationSearchResult | SessionSummarySearchResult | UserPromptSearchResult;
epoch: number;
}
/**
* Raw timeline data from SessionStore
*/
export interface TimelineData {
observations: ObservationSearchResult[];
sessions: SessionSummarySearchResult[];
prompts: UserPromptSearchResult[];
}
export class TimelineBuilder {
/**
* Build timeline items from raw data
*/
buildTimeline(data: TimelineData): TimelineItem[] {
const items: TimelineItem[] = [
...data.observations.map(obs => ({
type: 'observation' as const,
data: obs,
epoch: obs.created_at_epoch
})),
...data.sessions.map(sess => ({
type: 'session' as const,
data: sess,
epoch: sess.created_at_epoch
})),
...data.prompts.map(prompt => ({
type: 'prompt' as const,
data: prompt,
epoch: prompt.created_at_epoch
}))
];
// Sort chronologically
items.sort((a, b) => a.epoch - b.epoch);
return items;
}
/**
* Filter timeline items to respect depth window around anchor
*/
filterByDepth(
items: TimelineItem[],
anchorId: number | string,
anchorEpoch: number,
depthBefore: number,
depthAfter: number
): TimelineItem[] {
if (items.length === 0) return items;
let anchorIndex = this.findAnchorIndex(items, anchorId, anchorEpoch);
if (anchorIndex === -1) return items;
const startIndex = Math.max(0, anchorIndex - depthBefore);
const endIndex = Math.min(items.length, anchorIndex + depthAfter + 1);
return items.slice(startIndex, endIndex);
}
/**
* Find anchor index in timeline items
*/
private findAnchorIndex(
items: TimelineItem[],
anchorId: number | string,
anchorEpoch: number
): number {
if (typeof anchorId === 'number') {
// Observation ID
return items.findIndex(
item => item.type === 'observation' &&
(item.data as ObservationSearchResult).id === anchorId
);
}
if (typeof anchorId === 'string' && anchorId.startsWith('S')) {
// Session ID
const sessionNum = parseInt(anchorId.slice(1), 10);
return items.findIndex(
item => item.type === 'session' &&
(item.data as SessionSummarySearchResult).id === sessionNum
);
}
// Timestamp anchor - find closest item
const index = items.findIndex(item => item.epoch >= anchorEpoch);
return index === -1 ? items.length - 1 : index;
}
/**
* Format timeline as markdown
*/
formatTimeline(
items: TimelineItem[],
anchorId: number | string | null,
options: {
query?: string;
depthBefore?: number;
depthAfter?: number;
cwd?: string;
} = {}
): string {
const { query, depthBefore, depthAfter, cwd = process.cwd() } = options;
if (items.length === 0) {
return query
? `Found observation matching "${query}", but no timeline context available.`
: 'No timeline items found';
}
const lines: string[] = [];
// Header
if (query && anchorId) {
const anchorObs = items.find(
item => item.type === 'observation' &&
(item.data as ObservationSearchResult).id === anchorId
);
const anchorTitle = anchorObs
? ((anchorObs.data as ObservationSearchResult).title || 'Untitled')
: 'Unknown';
lines.push(`# Timeline for query: "${query}"`);
lines.push(`**Anchor:** Observation #${anchorId} - ${anchorTitle}`);
} else if (anchorId) {
lines.push(`# Timeline around anchor: ${anchorId}`);
} else {
lines.push(`# Timeline`);
}
if (depthBefore !== undefined && depthAfter !== undefined) {
lines.push(`**Window:** ${depthBefore} records before -> ${depthAfter} records after | **Items:** ${items.length}`);
} else {
lines.push(`**Items:** ${items.length}`);
}
lines.push('');
// Group by day
const dayMap = this.groupByDay(items);
const sortedDays = this.sortDaysChronologically(dayMap);
// Render each day
for (const [day, dayItems] of sortedDays) {
lines.push(`### ${day}`);
lines.push('');
let currentFile: string | null = null;
let lastTime = '';
let tableOpen = false;
for (const item of dayItems) {
const isAnchor = this.isAnchorItem(item, anchorId);
if (item.type === 'session') {
// Close any open table
if (tableOpen) {
lines.push('');
tableOpen = false;
currentFile = null;
lastTime = '';
}
const sess = item.data as SessionSummarySearchResult;
const title = sess.request || 'Session summary';
const marker = isAnchor ? ' <- **ANCHOR**' : '';
lines.push(`**\uD83C\uDFAF #S${sess.id}** ${title} (${formatDateTime(item.epoch)})${marker}`);
lines.push('');
} else if (item.type === 'prompt') {
if (tableOpen) {
lines.push('');
tableOpen = false;
currentFile = null;
lastTime = '';
}
const prompt = item.data as UserPromptSearchResult;
const truncated = prompt.prompt_text.length > 100
? prompt.prompt_text.substring(0, 100) + '...'
: prompt.prompt_text;
lines.push(`**\uD83D\uDCAC User Prompt #${prompt.prompt_number}** (${formatDateTime(item.epoch)})`);
lines.push(`> ${truncated}`);
lines.push('');
} else if (item.type === 'observation') {
const obs = item.data as ObservationSearchResult;
const file = extractFirstFile(obs.files_modified, cwd);
if (file !== currentFile) {
if (tableOpen) {
lines.push('');
}
lines.push(`**${file}**`);
lines.push(`| ID | Time | T | Title | Tokens |`);
lines.push(`|----|------|---|-------|--------|`);
currentFile = file;
tableOpen = true;
lastTime = '';
}
const icon = ModeManager.getInstance().getTypeIcon(obs.type);
const time = formatTime(item.epoch);
const title = obs.title || 'Untitled';
const tokens = estimateTokens(obs.narrative);
const showTime = time !== lastTime;
const timeDisplay = showTime ? time : '"';
lastTime = time;
const anchorMarker = isAnchor ? ' <- **ANCHOR**' : '';
lines.push(`| #${obs.id} | ${timeDisplay} | ${icon} | ${title}${anchorMarker} | ~${tokens} |`);
}
}
if (tableOpen) {
lines.push('');
}
}
return lines.join('\n');
}
/**
* Group timeline items by day
*/
private groupByDay(items: TimelineItem[]): Map<string, TimelineItem[]> {
const dayMap = new Map<string, TimelineItem[]>();
for (const item of items) {
const day = formatDate(item.epoch);
if (!dayMap.has(day)) {
dayMap.set(day, []);
}
dayMap.get(day)!.push(item);
}
return dayMap;
}
/**
* Sort days chronologically
*/
private sortDaysChronologically(
dayMap: Map<string, TimelineItem[]>
): Array<[string, TimelineItem[]]> {
return Array.from(dayMap.entries()).sort((a, b) => {
const aDate = new Date(a[0]).getTime();
const bDate = new Date(b[0]).getTime();
return aDate - bDate;
});
}
/**
* Check if item is the anchor
*/
private isAnchorItem(item: TimelineItem, anchorId: number | string | null): boolean {
if (anchorId === null) return false;
if (typeof anchorId === 'number' && item.type === 'observation') {
return (item.data as ObservationSearchResult).id === anchorId;
}
if (typeof anchorId === 'string' && anchorId.startsWith('S') && item.type === 'session') {
return `S${(item.data as SessionSummarySearchResult).id}` === anchorId;
}
return false;
}
}
@@ -0,0 +1,101 @@
/**
* DateFilter - Date range filtering for search results
*
* Provides utilities for filtering search results by date range.
*/
import { DateRange, SearchResult, CombinedResult, SEARCH_CONSTANTS } from '../types.js';
/**
* Parse date range values to epoch milliseconds
*/
export function parseDateRange(dateRange?: DateRange): {
startEpoch?: number;
endEpoch?: number;
} {
if (!dateRange) {
return {};
}
const result: { startEpoch?: number; endEpoch?: number } = {};
if (dateRange.start) {
result.startEpoch = typeof dateRange.start === 'number'
? dateRange.start
: new Date(dateRange.start).getTime();
}
if (dateRange.end) {
result.endEpoch = typeof dateRange.end === 'number'
? dateRange.end
: new Date(dateRange.end).getTime();
}
return result;
}
/**
* Check if an epoch timestamp is within a date range
*/
export function isWithinDateRange(
epoch: number,
dateRange?: DateRange
): boolean {
if (!dateRange) {
return true;
}
const { startEpoch, endEpoch } = parseDateRange(dateRange);
if (startEpoch && epoch < startEpoch) {
return false;
}
if (endEpoch && epoch > endEpoch) {
return false;
}
return true;
}
/**
* Check if an epoch timestamp is within the recency window
*/
export function isRecent(epoch: number): boolean {
const cutoff = Date.now() - SEARCH_CONSTANTS.RECENCY_WINDOW_MS;
return epoch > cutoff;
}
/**
* Filter combined results by date range
*/
export function filterResultsByDate<T extends { epoch: number }>(
results: T[],
dateRange?: DateRange
): T[] {
if (!dateRange) {
return results;
}
return results.filter(result => isWithinDateRange(result.epoch, dateRange));
}
/**
* Get date boundaries for common ranges
*/
export function getDateBoundaries(range: 'today' | 'week' | 'month' | '90days'): DateRange {
const now = Date.now();
const startOfToday = new Date();
startOfToday.setHours(0, 0, 0, 0);
switch (range) {
case 'today':
return { start: startOfToday.getTime() };
case 'week':
return { start: now - 7 * 24 * 60 * 60 * 1000 };
case 'month':
return { start: now - 30 * 24 * 60 * 60 * 1000 };
case '90days':
return { start: now - SEARCH_CONSTANTS.RECENCY_WINDOW_MS };
}
}
@@ -0,0 +1,59 @@
/**
* ProjectFilter - Project scoping for search results
*
* Provides utilities for filtering search results by project.
*/
import { basename } from 'path';
/**
* Get the current project name from cwd
*/
export function getCurrentProject(): string {
return basename(process.cwd());
}
/**
* Normalize project name for filtering
*/
export function normalizeProject(project?: string): string | undefined {
if (!project) {
return undefined;
}
// Remove leading/trailing whitespace
const trimmed = project.trim();
if (!trimmed) {
return undefined;
}
return trimmed;
}
/**
* Check if a result matches the project filter
*/
export function matchesProject(
resultProject: string,
filterProject?: string
): boolean {
if (!filterProject) {
return true;
}
return resultProject === filterProject;
}
/**
* Filter results by project
*/
export function filterResultsByProject<T extends { project: string }>(
results: T[],
project?: string
): T[] {
if (!project) {
return results;
}
return results.filter(result => matchesProject(result.project, project));
}
@@ -0,0 +1,75 @@
/**
* TypeFilter - Observation type filtering for search results
*
* Provides utilities for filtering observations by type.
*/
type ObservationType = 'decision' | 'bugfix' | 'feature' | 'refactor' | 'discovery' | 'change';
/**
* Valid observation types
*/
export const OBSERVATION_TYPES: ObservationType[] = [
'decision',
'bugfix',
'feature',
'refactor',
'discovery',
'change'
];
/**
* Normalize type filter value(s)
*/
export function normalizeType(
type?: string | string[]
): ObservationType[] | undefined {
if (!type) {
return undefined;
}
const types = Array.isArray(type) ? type : [type];
const normalized = types
.map(t => t.trim().toLowerCase())
.filter(t => OBSERVATION_TYPES.includes(t as ObservationType)) as ObservationType[];
return normalized.length > 0 ? normalized : undefined;
}
/**
* Check if a result matches the type filter
*/
export function matchesType(
resultType: string,
filterTypes?: ObservationType[]
): boolean {
if (!filterTypes || filterTypes.length === 0) {
return true;
}
return filterTypes.includes(resultType as ObservationType);
}
/**
* Filter observations by type
*/
export function filterObservationsByType<T extends { type: string }>(
observations: T[],
types?: ObservationType[]
): T[] {
if (!types || types.length === 0) {
return observations;
}
return observations.filter(obs => matchesType(obs.type, types));
}
/**
* Parse comma-separated type string
*/
export function parseTypeString(typeString: string): ObservationType[] {
return typeString
.split(',')
.map(t => t.trim().toLowerCase())
.filter(t => OBSERVATION_TYPES.includes(t as ObservationType)) as ObservationType[];
}
+26
View File
@@ -0,0 +1,26 @@
/**
* Search Module - Named exports for search functionality
*
* This is the public API for the search module.
*/
// Main orchestrator
export { SearchOrchestrator } from './SearchOrchestrator.js';
// Formatters
export { ResultFormatter } from './ResultFormatter.js';
export { TimelineBuilder, TimelineItem, TimelineData } from './TimelineBuilder.js';
// Strategies
export { SearchStrategy, BaseSearchStrategy } from './strategies/SearchStrategy.js';
export { ChromaSearchStrategy } from './strategies/ChromaSearchStrategy.js';
export { SQLiteSearchStrategy } from './strategies/SQLiteSearchStrategy.js';
export { HybridSearchStrategy } from './strategies/HybridSearchStrategy.js';
// Filters
export * from './filters/DateFilter.js';
export * from './filters/ProjectFilter.js';
export * from './filters/TypeFilter.js';
// Types
export * from './types.js';
@@ -0,0 +1,213 @@
/**
* ChromaSearchStrategy - Vector-based semantic search via Chroma
*
* This strategy handles semantic search queries using ChromaDB:
* 1. Query Chroma for semantically similar documents
* 2. Filter by recency (90-day window)
* 3. Categorize by document type
* 4. Hydrate from SQLite
*
* Used when: Query text is provided and Chroma is available
*/
import { BaseSearchStrategy, SearchStrategy } from './SearchStrategy.js';
import {
StrategySearchOptions,
StrategySearchResult,
SEARCH_CONSTANTS,
ChromaMetadata,
ObservationSearchResult,
SessionSummarySearchResult,
UserPromptSearchResult
} from '../types.js';
import { ChromaSync } from '../../../sync/ChromaSync.js';
import { SessionStore } from '../../../sqlite/SessionStore.js';
import { logger } from '../../../../utils/logger.js';
export class ChromaSearchStrategy extends BaseSearchStrategy implements SearchStrategy {
readonly name = 'chroma';
constructor(
private chromaSync: ChromaSync,
private sessionStore: SessionStore
) {
super();
}
canHandle(options: StrategySearchOptions): boolean {
// Can handle when query text is provided and Chroma is available
return !!options.query && !!this.chromaSync;
}
async search(options: StrategySearchOptions): Promise<StrategySearchResult> {
const {
query,
searchType = 'all',
obsType,
concepts,
files,
limit = SEARCH_CONSTANTS.DEFAULT_LIMIT,
project,
orderBy = 'date_desc'
} = options;
if (!query) {
return this.emptyResult('chroma');
}
const searchObservations = searchType === 'all' || searchType === 'observations';
const searchSessions = searchType === 'all' || searchType === 'sessions';
const searchPrompts = searchType === 'all' || searchType === 'prompts';
let observations: ObservationSearchResult[] = [];
let sessions: SessionSummarySearchResult[] = [];
let prompts: UserPromptSearchResult[] = [];
try {
// Build Chroma where filter for doc_type
const whereFilter = this.buildWhereFilter(searchType);
// Step 1: Chroma semantic search
logger.debug('SEARCH', 'ChromaSearchStrategy: Querying Chroma', { query, searchType });
const chromaResults = await this.chromaSync.queryChroma(
query,
SEARCH_CONSTANTS.CHROMA_BATCH_SIZE,
whereFilter
);
logger.debug('SEARCH', 'ChromaSearchStrategy: Chroma returned matches', {
matchCount: chromaResults.ids.length
});
if (chromaResults.ids.length === 0) {
// No matches - this is the correct answer
return {
results: { observations: [], sessions: [], prompts: [] },
usedChroma: true,
fellBack: false,
strategy: 'chroma'
};
}
// Step 2: Filter by recency (90 days)
const recentItems = this.filterByRecency(chromaResults);
logger.debug('SEARCH', 'ChromaSearchStrategy: Filtered by recency', {
count: recentItems.length
});
// Step 3: Categorize by document type
const categorized = this.categorizeByDocType(recentItems, {
searchObservations,
searchSessions,
searchPrompts
});
// Step 4: Hydrate from SQLite with additional filters
if (categorized.obsIds.length > 0) {
const obsOptions = { type: obsType, concepts, files, orderBy, limit, project };
observations = this.sessionStore.getObservationsByIds(categorized.obsIds, obsOptions);
}
if (categorized.sessionIds.length > 0) {
sessions = this.sessionStore.getSessionSummariesByIds(categorized.sessionIds, {
orderBy,
limit,
project
});
}
if (categorized.promptIds.length > 0) {
prompts = this.sessionStore.getUserPromptsByIds(categorized.promptIds, {
orderBy,
limit,
project
});
}
logger.debug('SEARCH', 'ChromaSearchStrategy: Hydrated results', {
observations: observations.length,
sessions: sessions.length,
prompts: prompts.length
});
return {
results: { observations, sessions, prompts },
usedChroma: true,
fellBack: false,
strategy: 'chroma'
};
} catch (error) {
logger.warn('SEARCH', 'ChromaSearchStrategy: Search failed', {}, error as Error);
// Return empty result - caller may try fallback strategy
return {
results: { observations: [], sessions: [], prompts: [] },
usedChroma: false,
fellBack: false,
strategy: 'chroma'
};
}
}
/**
* Build Chroma where filter for document type
*/
private buildWhereFilter(searchType: string): Record<string, any> | undefined {
switch (searchType) {
case 'observations':
return { doc_type: 'observation' };
case 'sessions':
return { doc_type: 'session_summary' };
case 'prompts':
return { doc_type: 'user_prompt' };
default:
return undefined;
}
}
/**
* Filter results by recency (90-day window)
*/
private filterByRecency(chromaResults: {
ids: number[];
metadatas: ChromaMetadata[];
}): Array<{ id: number; meta: ChromaMetadata }> {
const cutoff = Date.now() - SEARCH_CONSTANTS.RECENCY_WINDOW_MS;
return chromaResults.metadatas
.map((meta, idx) => ({
id: chromaResults.ids[idx],
meta
}))
.filter(item => item.meta && item.meta.created_at_epoch > cutoff);
}
/**
* Categorize IDs by document type
*/
private categorizeByDocType(
items: Array<{ id: number; meta: ChromaMetadata }>,
options: {
searchObservations: boolean;
searchSessions: boolean;
searchPrompts: boolean;
}
): { obsIds: number[]; sessionIds: number[]; promptIds: number[] } {
const obsIds: number[] = [];
const sessionIds: number[] = [];
const promptIds: number[] = [];
for (const item of items) {
const docType = item.meta?.doc_type;
if (docType === 'observation' && options.searchObservations) {
obsIds.push(item.id);
} else if (docType === 'session_summary' && options.searchSessions) {
sessionIds.push(item.id);
} else if (docType === 'user_prompt' && options.searchPrompts) {
promptIds.push(item.id);
}
}
return { obsIds, sessionIds, promptIds };
}
}
@@ -0,0 +1,270 @@
/**
* HybridSearchStrategy - Combines metadata filtering with semantic ranking
*
* This strategy provides the best of both worlds:
* 1. SQLite metadata filter (get all IDs matching criteria)
* 2. Chroma semantic ranking (rank by relevance)
* 3. Intersection (keep only IDs from step 1, in rank order from step 2)
* 4. Hydrate from SQLite in semantic rank order
*
* Used for: findByConcept, findByFile, findByType with Chroma available
*/
import { BaseSearchStrategy, SearchStrategy } from './SearchStrategy.js';
import {
StrategySearchOptions,
StrategySearchResult,
SEARCH_CONSTANTS,
ObservationSearchResult,
SessionSummarySearchResult
} from '../types.js';
import { ChromaSync } from '../../../sync/ChromaSync.js';
import { SessionStore } from '../../../sqlite/SessionStore.js';
import { SessionSearch } from '../../../sqlite/SessionSearch.js';
import { logger } from '../../../../utils/logger.js';
export class HybridSearchStrategy extends BaseSearchStrategy implements SearchStrategy {
readonly name = 'hybrid';
constructor(
private chromaSync: ChromaSync,
private sessionStore: SessionStore,
private sessionSearch: SessionSearch
) {
super();
}
canHandle(options: StrategySearchOptions): boolean {
// Can handle when we have metadata filters and Chroma is available
return !!this.chromaSync && (
!!options.concepts ||
!!options.files ||
(!!options.type && !!options.query) ||
options.strategyHint === 'hybrid'
);
}
async search(options: StrategySearchOptions): Promise<StrategySearchResult> {
// This is the generic hybrid search - specific operations use dedicated methods
const { query, limit = SEARCH_CONSTANTS.DEFAULT_LIMIT, project } = options;
if (!query) {
return this.emptyResult('hybrid');
}
// For generic hybrid search, use the standard Chroma path
// More specific operations (findByConcept, etc.) have dedicated methods
return this.emptyResult('hybrid');
}
/**
* Find observations by concept with semantic ranking
* Pattern: Metadata filter -> Chroma ranking -> Intersection -> Hydrate
*/
async findByConcept(
concept: string,
options: StrategySearchOptions
): Promise<StrategySearchResult> {
const { limit = SEARCH_CONSTANTS.DEFAULT_LIMIT, project, dateRange, orderBy } = options;
const filterOptions = { limit, project, dateRange, orderBy };
try {
logger.debug('SEARCH', 'HybridSearchStrategy: findByConcept', { concept });
// Step 1: SQLite metadata filter
const metadataResults = this.sessionSearch.findByConcept(concept, filterOptions);
logger.debug('SEARCH', 'HybridSearchStrategy: Found metadata matches', {
count: metadataResults.length
});
if (metadataResults.length === 0) {
return this.emptyResult('hybrid');
}
// Step 2: Chroma semantic ranking
const ids = metadataResults.map(obs => obs.id);
const chromaResults = await this.chromaSync.queryChroma(
concept,
Math.min(ids.length, SEARCH_CONSTANTS.CHROMA_BATCH_SIZE)
);
// Step 3: Intersect - keep only IDs from metadata, in Chroma rank order
const rankedIds = this.intersectWithRanking(ids, chromaResults.ids);
logger.debug('SEARCH', 'HybridSearchStrategy: Ranked by semantic relevance', {
count: rankedIds.length
});
// Step 4: Hydrate in semantic rank order
if (rankedIds.length > 0) {
const observations = this.sessionStore.getObservationsByIds(rankedIds, { limit });
// Restore semantic ranking order
observations.sort((a, b) => rankedIds.indexOf(a.id) - rankedIds.indexOf(b.id));
return {
results: { observations, sessions: [], prompts: [] },
usedChroma: true,
fellBack: false,
strategy: 'hybrid'
};
}
return this.emptyResult('hybrid');
} catch (error) {
logger.warn('SEARCH', 'HybridSearchStrategy: findByConcept failed', {}, error as Error);
// Fall back to metadata-only results
const results = this.sessionSearch.findByConcept(concept, filterOptions);
return {
results: { observations: results, sessions: [], prompts: [] },
usedChroma: false,
fellBack: true,
strategy: 'hybrid'
};
}
}
/**
* Find observations by type with semantic ranking
*/
async findByType(
type: string | string[],
options: StrategySearchOptions
): Promise<StrategySearchResult> {
const { limit = SEARCH_CONSTANTS.DEFAULT_LIMIT, project, dateRange, orderBy } = options;
const filterOptions = { limit, project, dateRange, orderBy };
const typeStr = Array.isArray(type) ? type.join(', ') : type;
try {
logger.debug('SEARCH', 'HybridSearchStrategy: findByType', { type: typeStr });
// Step 1: SQLite metadata filter
const metadataResults = this.sessionSearch.findByType(type as any, filterOptions);
logger.debug('SEARCH', 'HybridSearchStrategy: Found metadata matches', {
count: metadataResults.length
});
if (metadataResults.length === 0) {
return this.emptyResult('hybrid');
}
// Step 2: Chroma semantic ranking
const ids = metadataResults.map(obs => obs.id);
const chromaResults = await this.chromaSync.queryChroma(
typeStr,
Math.min(ids.length, SEARCH_CONSTANTS.CHROMA_BATCH_SIZE)
);
// Step 3: Intersect with ranking
const rankedIds = this.intersectWithRanking(ids, chromaResults.ids);
logger.debug('SEARCH', 'HybridSearchStrategy: Ranked by semantic relevance', {
count: rankedIds.length
});
// Step 4: Hydrate in rank order
if (rankedIds.length > 0) {
const observations = this.sessionStore.getObservationsByIds(rankedIds, { limit });
observations.sort((a, b) => rankedIds.indexOf(a.id) - rankedIds.indexOf(b.id));
return {
results: { observations, sessions: [], prompts: [] },
usedChroma: true,
fellBack: false,
strategy: 'hybrid'
};
}
return this.emptyResult('hybrid');
} catch (error) {
logger.warn('SEARCH', 'HybridSearchStrategy: findByType failed', {}, error as Error);
const results = this.sessionSearch.findByType(type as any, filterOptions);
return {
results: { observations: results, sessions: [], prompts: [] },
usedChroma: false,
fellBack: true,
strategy: 'hybrid'
};
}
}
/**
* Find observations and sessions by file path with semantic ranking
*/
async findByFile(
filePath: string,
options: StrategySearchOptions
): Promise<{
observations: ObservationSearchResult[];
sessions: SessionSummarySearchResult[];
usedChroma: boolean;
}> {
const { limit = SEARCH_CONSTANTS.DEFAULT_LIMIT, project, dateRange, orderBy } = options;
const filterOptions = { limit, project, dateRange, orderBy };
try {
logger.debug('SEARCH', 'HybridSearchStrategy: findByFile', { filePath });
// Step 1: SQLite metadata filter
const metadataResults = this.sessionSearch.findByFile(filePath, filterOptions);
logger.debug('SEARCH', 'HybridSearchStrategy: Found file matches', {
observations: metadataResults.observations.length,
sessions: metadataResults.sessions.length
});
// Sessions don't need semantic ranking (already summarized)
const sessions = metadataResults.sessions;
if (metadataResults.observations.length === 0) {
return { observations: [], sessions, usedChroma: false };
}
// Step 2: Chroma semantic ranking for observations
const ids = metadataResults.observations.map(obs => obs.id);
const chromaResults = await this.chromaSync.queryChroma(
filePath,
Math.min(ids.length, SEARCH_CONSTANTS.CHROMA_BATCH_SIZE)
);
// Step 3: Intersect with ranking
const rankedIds = this.intersectWithRanking(ids, chromaResults.ids);
logger.debug('SEARCH', 'HybridSearchStrategy: Ranked observations', {
count: rankedIds.length
});
// Step 4: Hydrate in rank order
if (rankedIds.length > 0) {
const observations = this.sessionStore.getObservationsByIds(rankedIds, { limit });
observations.sort((a, b) => rankedIds.indexOf(a.id) - rankedIds.indexOf(b.id));
return { observations, sessions, usedChroma: true };
}
return { observations: [], sessions, usedChroma: false };
} catch (error) {
logger.warn('SEARCH', 'HybridSearchStrategy: findByFile failed', {}, error as Error);
const results = this.sessionSearch.findByFile(filePath, filterOptions);
return {
observations: results.observations,
sessions: results.sessions,
usedChroma: false
};
}
}
/**
* Intersect metadata IDs with Chroma IDs, preserving Chroma's rank order
*/
private intersectWithRanking(metadataIds: number[], chromaIds: number[]): number[] {
const metadataSet = new Set(metadataIds);
const rankedIds: number[] = [];
for (const chromaId of chromaIds) {
if (metadataSet.has(chromaId) && !rankedIds.includes(chromaId)) {
rankedIds.push(chromaId);
}
}
return rankedIds;
}
}
@@ -0,0 +1,131 @@
/**
* SQLiteSearchStrategy - Direct SQLite queries for filter-only searches
*
* This strategy handles searches without query text (filter-only):
* - Date range filtering
* - Project filtering
* - Type filtering
* - Concept/file filtering
*
* Used when: No query text is provided, or as a fallback when Chroma fails
*/
import { BaseSearchStrategy, SearchStrategy } from './SearchStrategy.js';
import {
StrategySearchOptions,
StrategySearchResult,
SEARCH_CONSTANTS,
ObservationSearchResult,
SessionSummarySearchResult,
UserPromptSearchResult
} from '../types.js';
import { SessionSearch } from '../../../sqlite/SessionSearch.js';
import { logger } from '../../../../utils/logger.js';
export class SQLiteSearchStrategy extends BaseSearchStrategy implements SearchStrategy {
readonly name = 'sqlite';
constructor(private sessionSearch: SessionSearch) {
super();
}
canHandle(options: StrategySearchOptions): boolean {
// Can handle filter-only queries (no query text)
// Also used as fallback when Chroma is unavailable
return !options.query || options.strategyHint === 'sqlite';
}
async search(options: StrategySearchOptions): Promise<StrategySearchResult> {
const {
searchType = 'all',
obsType,
concepts,
files,
limit = SEARCH_CONSTANTS.DEFAULT_LIMIT,
offset = 0,
project,
dateRange,
orderBy = 'date_desc'
} = options;
const searchObservations = searchType === 'all' || searchType === 'observations';
const searchSessions = searchType === 'all' || searchType === 'sessions';
const searchPrompts = searchType === 'all' || searchType === 'prompts';
let observations: ObservationSearchResult[] = [];
let sessions: SessionSummarySearchResult[] = [];
let prompts: UserPromptSearchResult[] = [];
const baseOptions = { limit, offset, orderBy, project, dateRange };
logger.debug('SEARCH', 'SQLiteSearchStrategy: Filter-only query', {
searchType,
hasDateRange: !!dateRange,
hasProject: !!project
});
try {
if (searchObservations) {
const obsOptions = {
...baseOptions,
type: obsType,
concepts,
files
};
observations = this.sessionSearch.searchObservations(undefined, obsOptions);
}
if (searchSessions) {
sessions = this.sessionSearch.searchSessions(undefined, baseOptions);
}
if (searchPrompts) {
prompts = this.sessionSearch.searchUserPrompts(undefined, baseOptions);
}
logger.debug('SEARCH', 'SQLiteSearchStrategy: Results', {
observations: observations.length,
sessions: sessions.length,
prompts: prompts.length
});
return {
results: { observations, sessions, prompts },
usedChroma: false,
fellBack: false,
strategy: 'sqlite'
};
} catch (error) {
logger.warn('SEARCH', 'SQLiteSearchStrategy: Search failed', {}, error as Error);
return this.emptyResult('sqlite');
}
}
/**
* Find observations by concept (used by findByConcept tool)
*/
findByConcept(concept: string, options: StrategySearchOptions): ObservationSearchResult[] {
const { limit = SEARCH_CONSTANTS.DEFAULT_LIMIT, project, dateRange, orderBy = 'date_desc' } = options;
return this.sessionSearch.findByConcept(concept, { limit, project, dateRange, orderBy });
}
/**
* Find observations by type (used by findByType tool)
*/
findByType(type: string | string[], options: StrategySearchOptions): ObservationSearchResult[] {
const { limit = SEARCH_CONSTANTS.DEFAULT_LIMIT, project, dateRange, orderBy = 'date_desc' } = options;
return this.sessionSearch.findByType(type as any, { limit, project, dateRange, orderBy });
}
/**
* Find observations and sessions by file path (used by findByFile tool)
*/
findByFile(filePath: string, options: StrategySearchOptions): {
observations: ObservationSearchResult[];
sessions: SessionSummarySearchResult[];
} {
const { limit = SEARCH_CONSTANTS.DEFAULT_LIMIT, project, dateRange, orderBy = 'date_desc' } = options;
return this.sessionSearch.findByFile(filePath, { limit, project, dateRange, orderBy });
}
}
@@ -0,0 +1,60 @@
/**
* SearchStrategy - Interface for search strategy implementations
*
* Each strategy implements a different approach to searching:
* - ChromaSearchStrategy: Vector-based semantic search via Chroma
* - SQLiteSearchStrategy: Direct SQLite queries for filter-only searches
* - HybridSearchStrategy: Metadata filtering + semantic ranking
*/
import { SearchResults, StrategySearchOptions, StrategySearchResult } from '../types.js';
/**
* Base interface for all search strategies
*/
export interface SearchStrategy {
/**
* Execute a search with the given options
* @param options Search options including query and filters
* @returns Promise resolving to categorized search results
*/
search(options: StrategySearchOptions): Promise<StrategySearchResult>;
/**
* Check if this strategy can handle the given search options
* @param options Search options to evaluate
* @returns true if this strategy can handle the search
*/
canHandle(options: StrategySearchOptions): boolean;
/**
* Strategy name for logging and debugging
*/
readonly name: string;
}
/**
* Abstract base class providing common functionality for strategies
*/
export abstract class BaseSearchStrategy implements SearchStrategy {
abstract readonly name: string;
abstract search(options: StrategySearchOptions): Promise<StrategySearchResult>;
abstract canHandle(options: StrategySearchOptions): boolean;
/**
* Create an empty search result
*/
protected emptyResult(strategy: 'chroma' | 'sqlite' | 'hybrid'): StrategySearchResult {
return {
results: {
observations: [],
sessions: [],
prompts: []
},
usedChroma: strategy === 'chroma' || strategy === 'hybrid',
fellBack: false,
strategy
};
}
}
+120
View File
@@ -0,0 +1,120 @@
/**
* Search Types - Type definitions for the search module
* Centralizes all search-related types, options, and result interfaces
*/
import { ObservationSearchResult, SessionSummarySearchResult, UserPromptSearchResult, SearchOptions, DateRange } from '../../sqlite/types.js';
// Re-export base types for convenience
export { ObservationSearchResult, SessionSummarySearchResult, UserPromptSearchResult, SearchOptions, DateRange };
/**
* Constants used across search strategies
*/
export const SEARCH_CONSTANTS = {
RECENCY_WINDOW_DAYS: 90,
RECENCY_WINDOW_MS: 90 * 24 * 60 * 60 * 1000,
DEFAULT_LIMIT: 20,
CHROMA_BATCH_SIZE: 100
} as const;
/**
* Document types stored in Chroma
*/
export type ChromaDocType = 'observation' | 'session_summary' | 'user_prompt';
/**
* Chroma query result with typed metadata
*/
export interface ChromaQueryResult {
ids: number[];
distances: number[];
metadatas: ChromaMetadata[];
}
/**
* Metadata stored with each Chroma document
*/
export interface ChromaMetadata {
sqlite_id: number;
doc_type: ChromaDocType;
memory_session_id: string;
project: string;
created_at_epoch: number;
type?: string;
title?: string;
subtitle?: string;
concepts?: string;
files_read?: string;
files_modified?: string;
field_type?: string;
prompt_number?: number;
}
/**
* Unified search result type for all document types
*/
export type SearchResult = ObservationSearchResult | SessionSummarySearchResult | UserPromptSearchResult;
/**
* Search results container with categorized results
*/
export interface SearchResults {
observations: ObservationSearchResult[];
sessions: SessionSummarySearchResult[];
prompts: UserPromptSearchResult[];
}
/**
* Extended search options for the search module
*/
export interface ExtendedSearchOptions extends SearchOptions {
/** Type filter for search API (observations, sessions, prompts) */
searchType?: 'observations' | 'sessions' | 'prompts' | 'all';
/** Observation type filter (decision, bugfix, feature, etc.) */
obsType?: string | string[];
/** Concept tags to filter by */
concepts?: string | string[];
/** File paths to filter by */
files?: string | string[];
/** Output format */
format?: 'text' | 'json';
}
/**
* Search strategy selection hint
*/
export type SearchStrategyHint = 'chroma' | 'sqlite' | 'hybrid' | 'auto';
/**
* Options passed to search strategies
*/
export interface StrategySearchOptions extends ExtendedSearchOptions {
/** Query text for semantic search (optional for filter-only queries) */
query?: string;
/** Force a specific strategy */
strategyHint?: SearchStrategyHint;
}
/**
* Result from a search strategy
*/
export interface StrategySearchResult {
results: SearchResults;
/** Whether Chroma was used successfully */
usedChroma: boolean;
/** Whether fallback was triggered */
fellBack: boolean;
/** Strategy that produced the results */
strategy: SearchStrategyHint;
}
/**
* Combined result type for timeline items
*/
export interface CombinedResult {
type: 'observation' | 'session' | 'prompt';
data: SearchResult;
epoch: number;
created_at: string;
}