feat: Mode system with inheritance and multilingual support (#412)

* feat: add domain management system with support for multiple domain profiles - Introduced DomainManager class for loading and managing domain profiles. - Added support for a default domain ('code') and fallback mechanisms. - Implemented domain configuration validation and error handling. - Created types for domain configuration, observation types, and concepts. - Added new directory for domain profiles and ensured its existence. - Updated SettingsDefaultsManager to include CLAUDE_MEM_DOMAIN setting. * Refactor domain management to mode management - Removed DomainManager class and replaced it with ModeManager for better clarity and functionality. - Updated types from DomainConfig to ModeConfig and DomainPrompts to ModePrompts. - Changed references from domains to modes in the settings and paths. - Ensured backward compatibility by maintaining the fallback mechanism to the 'code' mode. * feat: add migration 008 to support mode-agnostic observations and refactor service layer references in documentation * feat: add new modes for code development and email investigation with detailed observation types and concepts * Refactor observation parsing and prompt generation to incorporate mode-specific configurations - Updated `parseObservations` function to use 'observation' as a universal fallback type instead of 'change', utilizing active mode's valid observation types. - Modified `buildInitPrompt` and `buildContinuationPrompt` functions to accept a `ModeConfig` parameter, allowing for dynamic prompt content based on the active mode. - Enhanced `ModePrompts` interface to include additional guidance for observers, such as recording focus and skip guidance. - Adjusted the SDKAgent to load the active mode and pass it to prompt generation functions, ensuring prompts are tailored to the current mode's context. * fix: correct mode prompt injection to preserve exact wording and type list visibility - Add script to extract prompts from main branch prompts.ts into code.yaml - Fix prompts.ts to show type list in XML template (e.g., "[ bugfix | feature | ... ]") - Keep 'change' as fallback type in parser.ts (maintain backwards compatibility) - Regenerate code.yaml with exact wording from original hardcoded prompts - Build succeeds with no TypeScript errors * fix: update ModeManager to load JSON mode files and improve validation - Changed ModeManager to load mode configurations from JSON files instead of YAML. - Removed the requirement for an "observation" type and updated validation to require at least one observation type. - Updated fallback behavior in the parser to use the first type from the active mode's type list. - Added comprehensive tests for mode loading, prompt injection, and parser integration, ensuring correct behavior across different modes. - Introduced new mode JSON files for "Code Development" and "Email Investigation" with detailed observation types and prompts. * Add mode configuration loading and update licensing information for Ragtime - Implemented loading of mode configuration in WorkerService before database initialization. - Added PolyForm Noncommercial License 1.0.0 to Ragtime directory. - Created README.md for Ragtime with licensing details and usage guidelines. * fix: add datasets directory to .gitignore to prevent accidental commits * refactor: remove unused plugin package.json file * chore: add package.json for claude-mem plugin with version 7.4.5 * refactor: remove outdated tests and improve error handling - Deleted tests for ChromaSync error handling, smart install, strip memory tags, and user prompt tag stripping due to redundancy or outdated logic. - Removed vitest configuration as it is no longer needed. - Added a comprehensive implementation plan for fixing the modes system, addressing critical issues and improving functionality. - Created a detailed test analysis report highlighting the quality and effectiveness of the current test suite, identifying areas for improvement. - Introduced a new plugin package.json for runtime dependencies related to claude-mem hooks. * refactor: remove parser regression tests to streamline codebase * docs: update CLAUDE.md to clarify test management and changelog generation * refactor: remove migration008 for mode-agnostic observations * Refactor observation type handling to use ModeManager for icons and emojis - Removed direct mappings of observation types to icons and work emojis in context-generator, FormattingService, SearchManager, and TimelineService. - Integrated ModeManager to dynamically retrieve icons and emojis based on the active mode. - Improved maintainability by centralizing the logic for observation type representation. * Refactor observation metadata constants and update context generator - Removed the explicit declaration of OBSERVATION_TYPES and OBSERVATION_CONCEPTS from observation-metadata.ts. - Introduced fallback default strings for DEFAULT_OBSERVATION_TYPES_STRING and DEFAULT_OBSERVATION_CONCEPTS_STRING. - Updated context-generator.ts to utilize observation types and concepts from ModeManager instead of constants. * refactor: remove intermediate error handling from hooks (Phase 1) Apply "fail fast" error handling strategy - errors propagate and crash loud instead of being caught, wrapped, and re-thrown at intermediate layers. Changes: - Remove try/catch around fetch calls in all hooks - let errors throw - Add try/catch ONLY around JSON.parse at entry points - Delete error-handler.ts and hook-error-handler.ts (no longer needed) - Update worker-utils.ts: functions now throw instead of returning null - Update transcript-parser.ts: throw on missing path, empty file, malformed JSON - Remove all handleWorkerError, handleFetchError imports Philosophy: If something breaks, we KNOW it broke. No silent failures. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * refactor: remove intermediate error handling from worker service (Phase 2) Apply "fail fast" error handling strategy to worker service layer. Changes: - worker-service.ts: Remove try/catch from version endpoint, cleanup, MCP close, process enumeration, force kill, and isAlive check - SessionRoutes.ts: Remove try/catch from JSON.stringify calls, remove .catch() from Chroma sync and SDK agent calls - SettingsRoutes.ts: Remove try/catch from toggleMcp() - DatabaseManager.ts: Remove .catch() from backfill and close operations - SDKAgent.ts: Keep outer try/catch (top-level), remove .catch() from Chroma sync operations - SSEBroadcaster.ts: Remove try/catch from broadcast and sendToClient Philosophy: Errors propagate and crash loud. BaseRouteHandler.wrapHandler provides top-level catching for HTTP routes. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * refactor: remove error swallowing from SQLite services (Phase 3) Apply "fail fast" error handling strategy to database layer. SessionStore.ts migrations: - ensureWorkerPortColumn(): Remove outer try/catch, let it throw - ensurePromptTrackingColumns(): Remove outer try/catch, let it throw - removeSessionSummariesUniqueConstraint(): Keep inner transaction rollback, remove outer catch - addObservationHierarchicalFields(): Remove outer try/catch - makeObservationsTextNullable(): Keep inner transaction rollback, remove outer catch - createUserPromptsTable(): Keep inner transaction rollback, remove outer catch - getFilesForSession(): Remove try/catch around JSON.parse SessionSearch.ts: - ensureFTSTables(): Remove try/catch, let it throw Philosophy: Migration errors that are swallowed mean we think the database is fine when it's not. Keep only inner transaction rollback try/catch blocks. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * refactor: remove error hiding from utilities (Phase 4) Apply "fail fast" error handling strategy to utility layer. logger.ts: - formatTool(): Remove try/catch, let JSON.parse throw on malformed input context-generator.ts: - loadContextConfig(): Remove try/catch, let parseInt throw on invalid settings - Transcript extraction: Remove try/catch, let file read errors propagate ChromaSync.ts: - close(): Remove nested try/catch blocks, let close errors propagate Philosophy: No silent fallbacks or hidden defaults. If something breaks, we know it broke immediately. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * feat: serve static UI assets and update package root path - Added middleware to serve static UI assets (JS, CSS, fonts, etc.) in ViewerRoutes. - Updated getPackageRoot function to correctly return the package root directory as one level up from the current directory. * feat: Enhance mode loading with inheritance support - Introduced parseInheritance method to handle parent--override mode IDs. - Added deepMerge method for recursively merging mode configurations. - Updated loadMode method to support inheritance, loading parent modes and applying overrides. - Improved error handling for missing mode files and logging for better traceability. * fix(modes): correct inheritance file resolution and path handling * Refactor code structure for improved readability and maintainability * feat: Add mode configuration documentation and examples * fix: Improve concurrency handling in translateReadme function * Refactor SDK prompts to enhance clarity and structure - Updated the `buildInitPrompt` and `buildContinuationPrompt` functions in `prompts.ts` to improve the organization of prompt components, including the addition of language instructions and footer messages. - Removed redundant instructions and emphasized the importance of recording observations. - Modified the `ModePrompts` interface in `types.ts` to include new properties for system identity, language instructions, and output format header, ensuring better flexibility and clarity in prompt generation. * Enhance prompts with language instructions and XML formatting - Updated `buildInitPrompt`, `buildSummaryPrompt`, and `buildContinuationPrompt` functions to include detailed language instructions in XML comments. - Ensured that language instructions guide users to keep XML tags in English while writing content in the specified language. - Modified the `buildSummaryPrompt` function to accept `mode` as a parameter for consistency. - Adjusted the call to `buildSummaryPrompt` in `SDKAgent` to pass the `mode` argument. * Refactor XML prompt generation in SDK - Updated the buildInitPrompt, buildSummaryPrompt, and buildContinuationPrompt functions to use new placeholders for XML elements, improving maintainability and readability. - Removed redundant language instructions in comments for clarity. - Added new properties to ModePrompts interface for better structure and organization of XML placeholders and section headers. * feat: Update observation prompts and structure across multiple languages * chore: Remove planning docs and update Ragtime README Remove ephemeral development artifacts: - .claude/plans/modes-system-fixes.md - .claude/test-analysis-report.md - PROMPT_INJECTION_ANALYSIS.md Update ragtime/README.md to explain: - Feature is not yet implemented - Dependency on modes system (now complete in PR #412) - Ready to be scripted out in future release 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com> * fix: Move summary prompts to mode files for multilingual support Summary prompts were hardcoded in English in prompts.ts, breaking multilingual support. Now properly mode-based: - Added summary_instruction, summary_context_label, summary_format_instruction, summary_footer to code.json - Updated buildSummaryPrompt() to use mode fields instead of hardcoded text - Added summary_footer with language instructions to all 10 language modes - Language modes keep English prompts + language requirement footer This fixes the gaslighting where we claimed full multilingual support but summaries were still generated in English. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com> * chore: Clean up README by removing local preview instructions and streamlining beta features section * Add translated README files for Ukrainian, Vietnamese, and Chinese languages * Add new language modes for code development in multiple languages - Introduced JSON configurations for Code Development in Greek, Finnish, Hebrew, Hindi, Hungarian, Indonesian, Italian, Dutch, Norwegian, Polish, Brazilian Portuguese, Romanian, Swedish, Turkish, and Ukrainian. - Each configuration includes prompts for observations, summaries, and instructions tailored to the respective language. - Ensured that all prompts emphasize the importance of generating observations without referencing the agent's actions. * Add multilingual support links to README files in various languages - Updated README.id.md, README.it.md, README.ja.md, README.ko.md, README.nl.md, README.no.md, README.pl.md, README.pt-br.md, README.ro.md, README.ru.md, README.sv.md, README.th.md, README.tr.md, README.uk.md, README.vi.md, and README.zh.md to include links to other language versions. - Each README now features a centered paragraph with flags and links for easy navigation between different language documents. --------- Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
2025-12-22 20:14:18 -05:00
parent db02da148f
commit 3ea0b60b9f
141 changed files with 11834 additions and 6699 deletions
@@ -22,6 +22,7 @@ export interface SettingsDefaults {
  CLAUDE_MEM_LOG_LEVEL: string;
  CLAUDE_MEM_PYTHON_VERSION: string;
  CLAUDE_CODE_PATH: string;
+  CLAUDE_MEM_MODE: string;
  // Token Economics
  CLAUDE_MEM_CONTEXT_SHOW_READ_TOKENS: string;
  CLAUDE_MEM_CONTEXT_SHOW_WORK_TOKENS: string;
@@ -54,6 +55,7 @@ export class SettingsDefaultsManager {
    CLAUDE_MEM_LOG_LEVEL: 'INFO',
    CLAUDE_MEM_PYTHON_VERSION: '3.13',
    CLAUDE_CODE_PATH: '', // Empty means auto-detect via 'which claude'
+    CLAUDE_MEM_MODE: 'code', // Default mode profile
    // Token Economics
    CLAUDE_MEM_CONTEXT_SHOW_READ_TOKENS: 'true',
    CLAUDE_MEM_CONTEXT_SHOW_WORK_TOKENS: 'true',
@@ -1,16 +0,0 @@
-import { getWorkerRestartInstructions } from '../utils/error-messages.js';
-
-/**
- * Handles fetch errors by providing user-friendly messages for connection issues
- * @throws Error with helpful message if worker is unreachable, re-throws original otherwise
- */
-export function handleWorkerError(error: any): never {
-  if (error.cause?.code === 'ECONNREFUSED' ||
-      error.code === 'ConnectionRefused' ||  // Bun-specific error format
-      error.name === 'TimeoutError' ||
-      error.message?.includes('fetch failed') ||
-      error.message?.includes('Unable to connect')) {
-    throw new Error(getWorkerRestartInstructions());
-  }
-  throw error;
-}
@@ -32,6 +32,7 @@ export const ARCHIVES_DIR = join(DATA_DIR, 'archives');
 export const LOGS_DIR = join(DATA_DIR, 'logs');
 export const TRASH_DIR = join(DATA_DIR, 'trash');
 export const BACKUPS_DIR = join(DATA_DIR, 'backups');
+export const MODES_DIR = join(DATA_DIR, 'modes');
 export const USER_SETTINGS_PATH = join(DATA_DIR, 'settings.json');
 export const DB_PATH = join(DATA_DIR, 'claude-mem.db');
 export const VECTOR_DB_DIR = join(DATA_DIR, 'vector-db');
@@ -71,6 +72,14 @@ export function ensureAllDataDirs(): void {
  ensureDir(LOGS_DIR);
  ensureDir(TRASH_DIR);
  ensureDir(BACKUPS_DIR);
+  ensureDir(MODES_DIR);
+}
+
+/**
+ * Ensure modes directory exists
+ */
+export function ensureModesDir(): void {
+  ensureDir(MODES_DIR);
 }

 /**
@@ -102,10 +111,10 @@ export function getCurrentProjectName(): string {
 * Find package root directory
 *
 * Works because bundled hooks are in plugin/scripts/,
- * so package root is always two levels up
+ * so package root is always one level up (the plugin directory)
 */
 export function getPackageRoot(): string {
-  return join(_dirname, '..', '..');
+  return join(_dirname, '..');
 }

 /**
@@ -13,101 +13,52 @@ export function extractLastMessage(
  stripSystemReminders: boolean = false
 ): string {
  if (!transcriptPath || !existsSync(transcriptPath)) {
-    logger.happyPathError(
-      'PARSER',
-      'Transcript path missing or file does not exist',
-      undefined,
-      { transcriptPath, role },
-      ''
-    );
-    return '';
+    throw new Error(`Transcript path missing or file does not exist: ${transcriptPath}`);
  }

-  try {
-    const content = readFileSync(transcriptPath, 'utf-8').trim();
-    if (!content) {
-      logger.happyPathError(
-        'PARSER',
-        'Transcript file exists but is empty',
-        undefined,
-        { transcriptPath, role },
-        ''
-      );
-      return '';
-    }
+  const content = readFileSync(transcriptPath, 'utf-8').trim();
+  if (!content) {
+    throw new Error(`Transcript file exists but is empty: ${transcriptPath}`);
+  }

-    const lines = content.split('\n');
-    let foundMatchingRole = false;
+  const lines = content.split('\n');
+  let foundMatchingRole = false;

-    for (let i = lines.length - 1; i >= 0; i--) {
-      try {
-        const line = JSON.parse(lines[i]);
-        if (line.type === role) {
-          foundMatchingRole = true;
+  for (let i = lines.length - 1; i >= 0; i--) {
+    const line = JSON.parse(lines[i]);
+    if (line.type === role) {
+      foundMatchingRole = true;

-          if (line.message?.content) {
-            let text = '';
-            const msgContent = line.message.content;
+      if (line.message?.content) {
+        let text = '';
+        const msgContent = line.message.content;

-            if (typeof msgContent === 'string') {
-              text = msgContent;
-            } else if (Array.isArray(msgContent)) {
-              text = msgContent
-                .filter((c: any) => c.type === 'text')
-                .map((c: any) => c.text)
-                .join('\n');
-            } else {
-              // Unknown content format - log error and skip this message
-              logger.error(
-                'PARSER',
-                'Unknown message content format',
-                {
-                  role,
-                  transcriptPath,
-                  contentType: typeof msgContent,
-                  content: msgContent
-                },
-                new Error('Message content is neither string nor array')
-              );
-              continue;
-            }
-
-            if (stripSystemReminders) {
-              text = text.replace(/<system-reminder>[\s\S]*?<\/system-reminder>/g, '');
-              text = text.replace(/\n{3,}/g, '\n\n').trim();
-            }
-
-            // Log if we found the role but the text is empty after processing
-            if (!text || text.trim() === '') {
-              logger.happyPathError(
-                'PARSER',
-                'Found message but content is empty after processing',
-                undefined,
-                { role, transcriptPath, msgContentType: typeof msgContent, stripSystemReminders },
-                ''
-              );
-            }
-
-            return text;
-          }
+        if (typeof msgContent === 'string') {
+          text = msgContent;
+        } else if (Array.isArray(msgContent)) {
+          text = msgContent
+            .filter((c: any) => c.type === 'text')
+            .map((c: any) => c.text)
+            .join('\n');
+        } else {
+          // Unknown content format - throw error
+          throw new Error(`Unknown message content format in transcript. Type: ${typeof msgContent}`);
        }
-      } catch {
-        continue;
+
+        if (stripSystemReminders) {
+          text = text.replace(/<system-reminder>[\s\S]*?<\/system-reminder>/g, '');
+          text = text.replace(/\n{3,}/g, '\n\n').trim();
+        }
+
+        // Return text even if empty - caller decides if that's an error
+        return text;
      }
    }
+  }

-    // If we searched the whole transcript and didn't find any message of this role
-    if (!foundMatchingRole) {
-      logger.happyPathError(
-        'PARSER',
-        'No message found for role in transcript',
-        undefined,
-        { role, transcriptPath, totalLines: lines.length },
-        ''
-      );
-    }
-  } catch (error) {
-    logger.error('HOOK', 'Failed to read transcript', { transcriptPath }, error as Error);
+  // If we searched the whole transcript and didn't find any message of this role
+  if (!foundMatchingRole) {
+    throw new Error(`No message found for role '${role}' in transcript: ${transcriptPath}`);
  }

  return '';
@@ -63,55 +63,35 @@ export function clearPortCache(): void {
 * Changed from /health to /api/readiness to ensure MCP initialization is complete
 */
 async function isWorkerHealthy(): Promise<boolean> {
-  try {
-    const port = getWorkerPort();
-    const response = await fetch(`http://127.0.0.1:${port}/api/readiness`, {
-      signal: AbortSignal.timeout(HEALTH_CHECK_TIMEOUT_MS)
-    });
-    return response.ok;
-  } catch (error) {
-    logger.debug('SYSTEM', 'Worker readiness check failed', {
-      error: error instanceof Error ? error.message : String(error),
-      errorType: error?.constructor?.name
-    });
-    return false;
-  }
+  const port = getWorkerPort();
+  const response = await fetch(`http://127.0.0.1:${port}/api/readiness`, {
+    signal: AbortSignal.timeout(HEALTH_CHECK_TIMEOUT_MS)
+  });
+  return response.ok;
 }

 /**
 * Get the current plugin version from package.json
 */
-function getPluginVersion(): string | null {
-  try {
-    const packageJsonPath = path.join(MARKETPLACE_ROOT, 'package.json');
-    const packageJson = JSON.parse(readFileSync(packageJsonPath, 'utf-8'));
-    return packageJson.version;
-  } catch (error) {
-    logger.debug('SYSTEM', 'Failed to read plugin version', {
-      error: error instanceof Error ? error.message : String(error)
-    });
-    return null;
-  }
+function getPluginVersion(): string {
+  const packageJsonPath = path.join(MARKETPLACE_ROOT, 'package.json');
+  const packageJson = JSON.parse(readFileSync(packageJsonPath, 'utf-8'));
+  return packageJson.version;
 }

 /**
 * Get the running worker's version from the API
 */
-async function getWorkerVersion(): Promise<string | null> {
-  try {
-    const port = getWorkerPort();
-    const response = await fetch(`http://127.0.0.1:${port}/api/version`, {
-      signal: AbortSignal.timeout(HEALTH_CHECK_TIMEOUT_MS)
-    });
-    if (!response.ok) return null;
-    const data = await response.json() as { version: string };
-    return data.version;
-  } catch (error) {
-    logger.debug('SYSTEM', 'Failed to get worker version', {
-      error: error instanceof Error ? error.message : String(error)
-    });
-    return null;
+async function getWorkerVersion(): Promise<string> {
+  const port = getWorkerPort();
+  const response = await fetch(`http://127.0.0.1:${port}/api/version`, {
+    signal: AbortSignal.timeout(HEALTH_CHECK_TIMEOUT_MS)
+  });
+  if (!response.ok) {
+    throw new Error(`Failed to get worker version: ${response.status}`);
  }
+  const data = await response.json() as { version: string };
+  return data.version;
 }

 /**
@@ -122,11 +102,6 @@ async function ensureWorkerVersionMatches(): Promise<void> {
  const pluginVersion = getPluginVersion();
  const workerVersion = await getWorkerVersion();

-  if (!pluginVersion || !workerVersion) {
-    // Can't determine versions, skip check
-    return;
-  }
-
  if (pluginVersion !== workerVersion) {
    logger.info('SYSTEM', 'Worker version mismatch detected - restarting worker', {
      pluginVersion,
@@ -144,11 +119,7 @@ async function ensureWorkerVersionMatches(): Promise<void> {

    // Verify it's healthy
    if (!await isWorkerHealthy()) {
-      logger.error('SYSTEM', 'Worker failed to restart after version mismatch', {
-        expectedVersion: pluginVersion,
-        runningVersion: workerVersion,
-        port: getWorkerPort()
-      });
+      throw new Error(`Worker failed to restart after version mismatch. Expected ${pluginVersion}, was running ${workerVersion}`);
    }
  }
 }
@@ -166,15 +137,10 @@ async function startWorker(): Promise<boolean> {
  mkdirSync(dataDir, { recursive: true });

  if (!existsSync(pm2MigratedMarker)) {
-    try {
-      spawnSync('pm2', ['delete', 'claude-mem-worker'], { stdio: 'ignore' });
-      // Mark migration as complete
-      writeFileSync(pm2MigratedMarker, new Date().toISOString(), 'utf-8');
-      logger.debug('SYSTEM', 'PM2 cleanup completed and marked');
-    } catch {
-      // PM2 not installed or process doesn't exist - still mark as migrated
-      writeFileSync(pm2MigratedMarker, new Date().toISOString(), 'utf-8');
-    }
+    spawnSync('pm2', ['delete', 'claude-mem-worker'], { stdio: 'ignore' });
+    // Mark migration as complete
+    writeFileSync(pm2MigratedMarker, new Date().toISOString(), 'utf-8');
+    logger.debug('SYSTEM', 'PM2 cleanup completed and marked');
  }

  const port = getWorkerPort();
@@ -198,8 +164,16 @@ async function startWorker(): Promise<boolean> {
 * Also ensures worker version matches plugin version
 */
 export async function ensureWorkerRunning(): Promise<void> {
-  // Check if already healthy
-  if (await isWorkerHealthy()) {
+  // Check if already healthy (will throw on fetch errors)
+  let healthy = false;
+  try {
+    healthy = await isWorkerHealthy();
+  } catch (error) {
+    // Worker not running or unreachable - continue to start it
+    healthy = false;
+  }
+
+  if (healthy) {
    // Worker is healthy, but check if version matches
    await ensureWorkerVersionMatches();
    return;
@@ -222,9 +196,13 @@ export async function ensureWorkerRunning(): Promise<void> {
  // Try up to 5 times with 500ms delays (2.5 seconds total)
  for (let i = 0; i < 5; i++) {
    await new Promise(resolve => setTimeout(resolve, 500));
-    if (await isWorkerHealthy()) {
-      await ensureWorkerVersionMatches();
-      return;
+    try {
+      if (await isWorkerHealthy()) {
+        await ensureWorkerVersionMatches();
+        return;
+      }
+    } catch (error) {
+      // Continue trying
    }
  }