airkjw/claude-mem
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

feat: Mode system with inheritance and multilingual support (#412)

Browse Source 
* feat: add domain management system with support for multiple domain profiles

- Introduced DomainManager class for loading and managing domain profiles.
- Added support for a default domain ('code') and fallback mechanisms.
- Implemented domain configuration validation and error handling.
- Created types for domain configuration, observation types, and concepts.
- Added new directory for domain profiles and ensured its existence.
- Updated SettingsDefaultsManager to include CLAUDE_MEM_DOMAIN setting.

* Refactor domain management to mode management

- Removed DomainManager class and replaced it with ModeManager for better clarity and functionality.
- Updated types from DomainConfig to ModeConfig and DomainPrompts to ModePrompts.
- Changed references from domains to modes in the settings and paths.
- Ensured backward compatibility by maintaining the fallback mechanism to the 'code' mode.

* feat: add migration 008 to support mode-agnostic observations and refactor service layer references in documentation

* feat: add new modes for code development and email investigation with detailed observation types and concepts

* Refactor observation parsing and prompt generation to incorporate mode-specific configurations

- Updated `parseObservations` function to use 'observation' as a universal fallback type instead of 'change', utilizing active mode's valid observation types.
- Modified `buildInitPrompt` and `buildContinuationPrompt` functions to accept a `ModeConfig` parameter, allowing for dynamic prompt content based on the active mode.
- Enhanced `ModePrompts` interface to include additional guidance for observers, such as recording focus and skip guidance.
- Adjusted the SDKAgent to load the active mode and pass it to prompt generation functions, ensuring prompts are tailored to the current mode's context.

* fix: correct mode prompt injection to preserve exact wording and type list visibility

- Add script to extract prompts from main branch prompts.ts into code.yaml
- Fix prompts.ts to show type list in XML template (e.g., "[ bugfix | feature | ... ]")
- Keep 'change' as fallback type in parser.ts (maintain backwards compatibility)
- Regenerate code.yaml with exact wording from original hardcoded prompts
- Build succeeds with no TypeScript errors

* fix: update ModeManager to load JSON mode files and improve validation

- Changed ModeManager to load mode configurations from JSON files instead of YAML.
- Removed the requirement for an "observation" type and updated validation to require at least one observation type.
- Updated fallback behavior in the parser to use the first type from the active mode's type list.
- Added comprehensive tests for mode loading, prompt injection, and parser integration, ensuring correct behavior across different modes.
- Introduced new mode JSON files for "Code Development" and "Email Investigation" with detailed observation types and prompts.

* Add mode configuration loading and update licensing information for Ragtime

- Implemented loading of mode configuration in WorkerService before database initialization.
- Added PolyForm Noncommercial License 1.0.0 to Ragtime directory.
- Created README.md for Ragtime with licensing details and usage guidelines.

* fix: add datasets directory to .gitignore to prevent accidental commits

* refactor: remove unused plugin package.json file

* chore: add package.json for claude-mem plugin with version 7.4.5

* refactor: remove outdated tests and improve error handling

- Deleted tests for ChromaSync error handling, smart install, strip memory tags, and user prompt tag stripping due to redundancy or outdated logic.
- Removed vitest configuration as it is no longer needed.
- Added a comprehensive implementation plan for fixing the modes system, addressing critical issues and improving functionality.
- Created a detailed test analysis report highlighting the quality and effectiveness of the current test suite, identifying areas for improvement.
- Introduced a new plugin package.json for runtime dependencies related to claude-mem hooks.

* refactor: remove parser regression tests to streamline codebase

* docs: update CLAUDE.md to clarify test management and changelog generation

* refactor: remove migration008 for mode-agnostic observations

* Refactor observation type handling to use ModeManager for icons and emojis

- Removed direct mappings of observation types to icons and work emojis in context-generator, FormattingService, SearchManager, and TimelineService.
- Integrated ModeManager to dynamically retrieve icons and emojis based on the active mode.
- Improved maintainability by centralizing the logic for observation type representation.

* Refactor observation metadata constants and update context generator

- Removed the explicit declaration of OBSERVATION_TYPES and OBSERVATION_CONCEPTS from observation-metadata.ts.
- Introduced fallback default strings for DEFAULT_OBSERVATION_TYPES_STRING and DEFAULT_OBSERVATION_CONCEPTS_STRING.
- Updated context-generator.ts to utilize observation types and concepts from ModeManager instead of constants.

* refactor: remove intermediate error handling from hooks (Phase 1)

Apply "fail fast" error handling strategy - errors propagate and crash loud
instead of being caught, wrapped, and re-thrown at intermediate layers.

Changes:
- Remove try/catch around fetch calls in all hooks - let errors throw
- Add try/catch ONLY around JSON.parse at entry points
- Delete error-handler.ts and hook-error-handler.ts (no longer needed)
- Update worker-utils.ts: functions now throw instead of returning null
- Update transcript-parser.ts: throw on missing path, empty file, malformed JSON
- Remove all handleWorkerError, handleFetchError imports

Philosophy: If something breaks, we KNOW it broke. No silent failures.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

* refactor: remove intermediate error handling from worker service (Phase 2)

Apply "fail fast" error handling strategy to worker service layer.

Changes:
- worker-service.ts: Remove try/catch from version endpoint, cleanup,
  MCP close, process enumeration, force kill, and isAlive check
- SessionRoutes.ts: Remove try/catch from JSON.stringify calls, remove
  .catch() from Chroma sync and SDK agent calls
- SettingsRoutes.ts: Remove try/catch from toggleMcp()
- DatabaseManager.ts: Remove .catch() from backfill and close operations
- SDKAgent.ts: Keep outer try/catch (top-level), remove .catch() from
  Chroma sync operations
- SSEBroadcaster.ts: Remove try/catch from broadcast and sendToClient

Philosophy: Errors propagate and crash loud. BaseRouteHandler.wrapHandler
provides top-level catching for HTTP routes.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

* refactor: remove error swallowing from SQLite services (Phase 3)

Apply "fail fast" error handling strategy to database layer.

SessionStore.ts migrations:
- ensureWorkerPortColumn(): Remove outer try/catch, let it throw
- ensurePromptTrackingColumns(): Remove outer try/catch, let it throw
- removeSessionSummariesUniqueConstraint(): Keep inner transaction
  rollback, remove outer catch
- addObservationHierarchicalFields(): Remove outer try/catch
- makeObservationsTextNullable(): Keep inner transaction rollback,
  remove outer catch
- createUserPromptsTable(): Keep inner transaction rollback, remove
  outer catch
- getFilesForSession(): Remove try/catch around JSON.parse

SessionSearch.ts:
- ensureFTSTables(): Remove try/catch, let it throw

Philosophy: Migration errors that are swallowed mean we think the
database is fine when it's not. Keep only inner transaction rollback
try/catch blocks.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

* refactor: remove error hiding from utilities (Phase 4)

Apply "fail fast" error handling strategy to utility layer.

logger.ts:
- formatTool(): Remove try/catch, let JSON.parse throw on malformed input

context-generator.ts:
- loadContextConfig(): Remove try/catch, let parseInt throw on invalid settings
- Transcript extraction: Remove try/catch, let file read errors propagate

ChromaSync.ts:
- close(): Remove nested try/catch blocks, let close errors propagate

Philosophy: No silent fallbacks or hidden defaults. If something breaks,
we know it broke immediately.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

* feat: serve static UI assets and update package root path

- Added middleware to serve static UI assets (JS, CSS, fonts, etc.) in ViewerRoutes.
- Updated getPackageRoot function to correctly return the package root directory as one level up from the current directory.

* feat: Enhance mode loading with inheritance support

- Introduced parseInheritance method to handle parent--override mode IDs.
- Added deepMerge method for recursively merging mode configurations.
- Updated loadMode method to support inheritance, loading parent modes and applying overrides.
- Improved error handling for missing mode files and logging for better traceability.

* fix(modes): correct inheritance file resolution and path handling

* Refactor code structure for improved readability and maintainability

* feat: Add mode configuration documentation and examples

* fix: Improve concurrency handling in translateReadme function

* Refactor SDK prompts to enhance clarity and structure

- Updated the `buildInitPrompt` and `buildContinuationPrompt` functions in `prompts.ts` to improve the organization of prompt components, including the addition of language instructions and footer messages.
- Removed redundant instructions and emphasized the importance of recording observations.
- Modified the `ModePrompts` interface in `types.ts` to include new properties for system identity, language instructions, and output format header, ensuring better flexibility and clarity in prompt generation.

* Enhance prompts with language instructions and XML formatting

- Updated `buildInitPrompt`, `buildSummaryPrompt`, and `buildContinuationPrompt` functions to include detailed language instructions in XML comments.
- Ensured that language instructions guide users to keep XML tags in English while writing content in the specified language.
- Modified the `buildSummaryPrompt` function to accept `mode` as a parameter for consistency.
- Adjusted the call to `buildSummaryPrompt` in `SDKAgent` to pass the `mode` argument.

* Refactor XML prompt generation in SDK

- Updated the buildInitPrompt, buildSummaryPrompt, and buildContinuationPrompt functions to use new placeholders for XML elements, improving maintainability and readability.
- Removed redundant language instructions in comments for clarity.
- Added new properties to ModePrompts interface for better structure and organization of XML placeholders and section headers.

* feat: Update observation prompts and structure across multiple languages

* chore: Remove planning docs and update Ragtime README

Remove ephemeral development artifacts:
- .claude/plans/modes-system-fixes.md
- .claude/test-analysis-report.md
- PROMPT_INJECTION_ANALYSIS.md

Update ragtime/README.md to explain:
- Feature is not yet implemented
- Dependency on modes system (now complete in PR #412)
- Ready to be scripted out in future release

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>

* fix: Move summary prompts to mode files for multilingual support

Summary prompts were hardcoded in English in prompts.ts, breaking
multilingual support. Now properly mode-based:

- Added summary_instruction, summary_context_label,
  summary_format_instruction, summary_footer to code.json
- Updated buildSummaryPrompt() to use mode fields instead of hardcoded text
- Added summary_footer with language instructions to all 10 language modes
- Language modes keep English prompts + language requirement footer

This fixes the gaslighting where we claimed full multilingual support
but summaries were still generated in English.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>

* chore: Clean up README by removing local preview instructions and streamlining beta features section

* Add translated README files for Ukrainian, Vietnamese, and Chinese languages

* Add new language modes for code development in multiple languages

- Introduced JSON configurations for Code Development in Greek, Finnish, Hebrew, Hindi, Hungarian, Indonesian, Italian, Dutch, Norwegian, Polish, Brazilian Portuguese, Romanian, Swedish, Turkish, and Ukrainian.
- Each configuration includes prompts for observations, summaries, and instructions tailored to the respective language.
- Ensured that all prompts emphasize the importance of generating observations without referencing the agent's actions.

* Add multilingual support links to README files in various languages

- Updated README.id.md, README.it.md, README.ja.md, README.ko.md, README.nl.md, README.no.md, README.pl.md, README.pt-br.md, README.ro.md, README.ru.md, README.sv.md, README.th.md, README.tr.md, README.uk.md, README.vi.md, and README.zh.md to include links to other language versions.
- Each README now features a centered paragraph with flags and links for easy navigation between different language documents.

---------

Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
This commit is contained in:
Alex Newman
2025-12-22 20:14:18 -05:00
committed by GitHub
parent db02da148f
commit 3ea0b60b9f
141 changed files with 11834 additions and 6699 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/services/chroma-sync-errors.test.ts
-233
View File
@@ -1,233 +0,0 @@
/**
* Test: ChromaSync Error Handling
*
* Verifies that ChromaSync fails fast with clear error messages when
* client is not initialized. Prevents regression of observation 25458
* where error messages were inconsistent across client checks.
*/
import { describe, it, expect, beforeEach } from 'vitest';
import { ChromaSync } from '../../src/services/sync/ChromaSync.js';
describe('ChromaSync Error Handling', () => {
let chromaSync: ChromaSync;
const testProject = 'test-project';
beforeEach(() => {
chromaSync = new ChromaSync(testProject);
});
describe('Client initialization checks', () => {
it('ensureCollection throws when client not initialized', async () => {
// Force client to be null (simulates forgetting to call ensureConnection)
(chromaSync as any).client = null;
(chromaSync as any).connected = false;
await expect(async () => {
// This should call ensureConnection internally, but let's test the guard
await (chromaSync as any).ensureCollection();
}).rejects.toThrow();
});
it('addDocuments throws with project name when client not initialized', async () => {
(chromaSync as any).client = null;
(chromaSync as any).connected = false;
const testDocs = [
{
id: 'test_1',
document: 'Test document',
metadata: { type: 'test' }
}
];
try {
await (chromaSync as any).addDocuments(testDocs);
expect.fail('Should have thrown error');
} catch (error: any) {
expect(error.message).toContain('Chroma client not initialized');
expect(error.message).toContain('ensureConnection()');
expect(error.message).toContain(`Project: ${testProject}`);
}
});
it('queryChroma throws with project name when client not initialized', async () => {
(chromaSync as any).client = null;
(chromaSync as any).connected = false;
try {
await chromaSync.queryChroma('test query', 10);
expect.fail('Should have thrown error');
} catch (error: any) {
expect(error.message).toContain('Chroma client not initialized');
expect(error.message).toContain('ensureConnection()');
expect(error.message).toContain(`Project: ${testProject}`);
}
});
it('getExistingChromaIds throws with project name when client not initialized', async () => {
(chromaSync as any).client = null;
(chromaSync as any).connected = false;
try {
await (chromaSync as any).getExistingChromaIds();
expect.fail('Should have thrown error');
} catch (error: any) {
expect(error.message).toContain('Chroma client not initialized');
expect(error.message).toContain('ensureConnection()');
expect(error.message).toContain(`Project: ${testProject}`);
}
});
});
describe('Error message consistency', () => {
it('all client checks use identical error message format', async () => {
(chromaSync as any).client = null;
(chromaSync as any).connected = false;
const errors: string[] = [];
// Collect error messages from all client check locations
try {
await (chromaSync as any).addDocuments([]);
} catch (error: any) {
errors.push(error.message);
}
try {
await chromaSync.queryChroma('test', 10);
} catch (error: any) {
errors.push(error.message);
}
try {
await (chromaSync as any).getExistingChromaIds();
} catch (error: any) {
errors.push(error.message);
}
// All errors should have the same structure
expect(errors.length).toBe(3);
for (const errorMsg of errors) {
expect(errorMsg).toContain('Chroma client not initialized');
expect(errorMsg).toContain('Call ensureConnection()');
expect(errorMsg).toContain('Project:');
}
});
it('error messages include actionable instructions', async () => {
(chromaSync as any).client = null;
(chromaSync as any).connected = false;
try {
await chromaSync.queryChroma('test', 10);
} catch (error: any) {
// Must tell developer what to do
expect(error.message).toContain('Call ensureConnection()');
// Must help with debugging
expect(error.message).toContain('Project:');
}
});
});
describe('Connection failure handling', () => {
it('ensureConnection throws clear error when Chroma MCP fails', async () => {
// This test would require mocking the MCP client
// For now, document the expected behavior:
// When uvx chroma-mcp fails:
// - Error should contain "Chroma connection failed"
// - Error should include original error message
// - Error should be logged before throwing
expect(true).toBe(true); // Placeholder - implement when MCP mocking available
});
it('collection creation throws clear error on failure', async () => {
// When chroma_create_collection fails:
// - Error should contain "Collection creation failed"
// - Error should include collection name
// - Error should be logged with full context
expect(true).toBe(true); // Placeholder - implement when MCP mocking available
});
});
describe('Operation failure handling', () => {
it('addDocuments throws clear error with document count on failure', async () => {
// When chroma_add_documents fails:
// - Error should contain "Document add failed"
// - Log should include document count
// - Original error message should be preserved
expect(true).toBe(true); // Placeholder - implement when MCP mocking available
});
it('backfill throws clear error with progress on failure', async () => {
// When ensureBackfilled() fails:
// - Error should contain "Backfill failed"
// - Error should include project name
// - Database should be closed in finally block
expect(true).toBe(true); // Placeholder - implement when MCP mocking available
});
});
describe('Fail-fast behavior', () => {
it('does not retry failed operations silently', async () => {
(chromaSync as any).client = null;
(chromaSync as any).connected = false;
// Should fail immediately, not retry
const startTime = Date.now();
try {
await chromaSync.queryChroma('test', 10);
} catch (error: any) {
const elapsed = Date.now() - startTime;
// Should fail fast (< 100ms), not retry with delays
expect(elapsed).toBeLessThan(100);
}
});
it('throws errors rather than returning null or empty results', async () => {
(chromaSync as any).client = null;
(chromaSync as any).connected = false;
// Should throw, not return empty array
await expect(async () => {
await chromaSync.queryChroma('test', 10);
}).rejects.toThrow();
// Should not silently return { ids: [], distances: [], metadatas: [] }
});
});
describe('Error context preservation', () => {
it('includes project name in all error messages', async () => {
const projects = ['project-a', 'project-b', 'my-app'];
for (const project of projects) {
const sync = new ChromaSync(project);
(sync as any).client = null;
(sync as any).connected = false;
try {
await sync.queryChroma('test', 10);
} catch (error: any) {
expect(error.message).toContain(`Project: ${project}`);
}
}
});
it('preserves original error messages in wrapped errors', async () => {
// When ChromaSync wraps lower-level errors:
// - Original error message should be included
// - Stack trace should be preserved
// - Error should be logged before re-throwing
expect(true).toBe(true); // Placeholder - implement when error wrapping tested
});
});
});