From 3eb0154d586a51fd7933cb4ab9d6fc0a8e962d18 Mon Sep 17 00:00:00 2001 From: Alex Newman Date: Thu, 5 Feb 2026 22:39:20 -0500 Subject: [PATCH] MAESTRO: Close PR #829 as redundant - empty prompt fix already merged via PR #828 Co-Authored-By: Claude Opus 4.6 --- Auto Run Docs/PR-Triage/PR-Triage-07.md | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/Auto Run Docs/PR-Triage/PR-Triage-07.md b/Auto Run Docs/PR-Triage/PR-Triage-07.md index eb29c30f..79d01a01 100644 --- a/Auto Run Docs/PR-Triage/PR-Triage-07.md +++ b/Auto Run Docs/PR-Triage/PR-Triage-07.md @@ -9,7 +9,8 @@ These PRs all touch `src/cli/handlers/session-init.ts` — review together to av - [x] Review PR #828 (`fix: wait for database initialization before processing session-init requests` by @rajivsinclair). Files: `src/cli/handlers/session-init.ts`, `src/services/worker-service.ts`. The session-init handler processes requests before the database is ready. Steps: (1) `gh pr checkout 828` (2) Review — should add a readiness check before DB operations (3) Verify the approach doesn't reintroduce blocking startup (conflicts with Phase 05 #930) (4) Run `npm run build` (5) If compatible with non-blocking startup: `gh pr merge 828 --rebase --delete-branch` - **MERGED** (2026-02-05): Adds server-side DB readiness wait on `/api/sessions/init` endpoint following the existing `/api/context/inject` pattern. HTTP server still starts immediately (no startup blocking); only the session-init endpoint waits for DB init (30s timeout). Build passes, no merge conflicts. Also bundles empty prompt handling fix (PR #829 overlap — evaluate #829 for redundancy). Note: client-side already handled 500 gracefully, but server-side fix ensures sessions actually get created rather than silently skipping. -- [ ] Review PR #829 (`fix: gracefully handle empty prompts in session-init hook` by @rajivsinclair). File: `src/cli/handlers/session-init.ts`. Steps: (1) `gh pr checkout 829` (2) Review — empty prompt should result in valid exit (not crash) (3) Small change, low risk (4) Run `npm run build` (5) If clean: `gh pr merge 829 --rebase --delete-branch` +- [x] Review PR #829 (`fix: gracefully handle empty prompts in session-init hook` by @rajivsinclair). File: `src/cli/handlers/session-init.ts`. Steps: (1) `gh pr checkout 829` (2) Review — empty prompt should result in valid exit (not crash) (3) Small change, low risk (4) Run `npm run build` (5) If clean: `gh pr merge 829 --rebase --delete-branch` + - **CLOSED AS REDUNDANT** (2026-02-05): The empty prompt handling fix (`!prompt || !prompt.trim()` → `return { continue: true, suppressOutput: true }`) was already merged as part of PR #828 (commit 9789a196). Main branch already has this fix at `src/cli/handlers/session-init.ts` lines 24-27. No action needed. - [ ] Review PR #928 (`Fix: Allow image-only prompts in session-init handler` by @iammike). File: `src/cli/handlers/session-init.ts`. Image-only prompts have no text content, causing the handler to reject them. Steps: (1) `gh pr checkout 928` (2) Review — should check for content blocks (images) not just text (3) Run `npm run build` (4) If clean: `gh pr merge 928 --rebase --delete-branch`