diff --git a/Auto Run Docs/PR-Triage/PR-Triage-05.md b/Auto Run Docs/PR-Triage/PR-Triage-05.md index 41566492..7fdc37f7 100644 --- a/Auto Run Docs/PR-Triage/PR-Triage-05.md +++ b/Auto Run Docs/PR-Triage/PR-Triage-05.md @@ -13,4 +13,5 @@ These PRs fix Windows-specific issues. They should be reviewed in order since so - [x] Review PR #931 (`Prevent repeated worker spawn popups on Windows when startup fails` by @jayvenn21). File: `src/services/worker-service.ts`. Prevents hooks from repeatedly trying to spawn the worker when startup fails, causing visible terminal popups on Windows. Steps: (1) `gh pr checkout 931` (2) Review the spawn-once logic — should track spawn attempt and not retry within a cooldown period (3) Run `npm run build` (4) If clean: `gh pr merge 931 --rebase --delete-branch` > **Closed 2026-02-05**: PR had non-trivial merge conflicts with current main — startup logic was refactored from inline `main()` into `ensureWorkerStarted()` since this PR was written. The concept (file-based spawn cooldown lock) was sound and needed: every hook invocation runs `worker-service start`, so repeated failures on Windows produce visible terminal popups. Implemented the spawn guard directly in `ensureWorkerStarted()` with: (1) `.worker-start-attempted` lock file in claude-mem data dir (2) 2-minute cooldown skips re-spawn after failure (3) Lock cleared on successful start (4) Windows-only guards (no-op on other platforms). Build passes clean. Commit: `0ecb387f`. -- [ ] Review PR #930 (`Fix blocking startup by deferring worker initialization` by @jayvenn21). File: `src/cli/handlers/context.ts`. Defers worker init so Claude UI isn't blocked for 1-2 minutes on WSL2/slow systems. Steps: (1) `gh pr checkout 930` (2) Review that deferred init still ensures context is available when needed (3) Verify this doesn't conflict with #959 (fail-open context inject) (4) Run `npm run build` (5) If clean and compatible with Phase 04 changes: `gh pr merge 930 --rebase --delete-branch` +- [x] Review PR #930 (`Fix blocking startup by deferring worker initialization` by @jayvenn21). File: `src/cli/handlers/context.ts`. Defers worker init so Claude UI isn't blocked for 1-2 minutes on WSL2/slow systems. Steps: (1) `gh pr checkout 930` (2) Review that deferred init still ensures context is available when needed (3) Verify this doesn't conflict with #959 (fail-open context inject) (4) Run `npm run build` (5) If clean and compatible with Phase 04 changes: `gh pr merge 930 --rebase --delete-branch` + > **Closed 2026-02-05**: PR fully superseded by Phase 04 fail-open architecture. Current main already implements non-blocking startup: `ensureWorkerRunning()` does a quick health check returning `false` without blocking (PR #959), and the context handler returns empty context gracefully. PR #930 would have regressed by removing `ensureWorkerRunning()` entirely — skipping the health check and relying solely on fetch try/catch. The three Phase 04 PRs (#959 fail-open context, #973 graceful hook failures, #931 spawn guard) collectively solve the blocking startup issue this PR targeted.