refactor: implement in-process worker architecture for hooks (#722)

* fix: stop generating empty CLAUDE.md files

- Return empty string instead of "No recent activity" when no observations exist
- Skip writing CLAUDE.md files when formatted content is empty
- Remove redundant "auto-generated by claude-mem" HTML comment
- Clean up 98 existing empty CLAUDE.md files across the codebase
- Update tests to expect empty string for empty input

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

* build assets

* refactor: implement in-process worker architecture for hooks

Replaces spawn-based worker startup with in-process architecture:
- Hook processes now become the worker when port 37777 is free
- Eliminates Windows spawn issues (NO SPAWN rule)
- SessionStart chains: smart-install && stop && context

Key changes:
- worker-service.ts: hook case starts WorkerService in-process
- hook-command.ts: skipExit option prevents process.exit() when hosting worker
- hooks.json: single chained command replaces separate start/hook commands
- worker-utils.ts: ensureWorkerRunning() returns boolean, doesn't block
- handlers: graceful fallback when worker unavailable

All 761 tests pass. Manual verification confirms hook stays alive as worker.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

* context

* a

* MAESTRO: Mark PR #722 test verification task complete

All 797 tests passed (3 skipped, 0 failed) after merge conflict resolution.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

* MAESTRO: Mark PR #722 build verification task complete

* MAESTRO: Mark PR #722 code review task complete

Code review verified:
- worker-service.ts hook case starts WorkerService in-process
- hook-command.ts has skipExit option
- hooks.json uses single chained command
- worker-utils.ts ensureWorkerRunning() returns boolean

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

* MAESTRO: Mark PR #722 conflict resolution push task complete

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
This commit is contained in:
Alex Newman
2026-02-04 19:49:15 -05:00
committed by GitHub
parent 14ca7cf7d6
commit 4df9f61347
107 changed files with 804 additions and 4493 deletions
+1 -31
View File
@@ -134,34 +134,4 @@ These files are **NEVER** allowed to have catch-and-continue:
- `SessionStore.ts` - Database errors must propagate
- `worker-service.ts` - Core service errors must be visible
On critical paths, prefer **NO TRY-CATCH** and let errors propagate naturally.
<claude-mem-context>
# Recent Activity
<!-- This section is auto-generated by claude-mem. Edit content outside the tags. -->
### Jan 2, 2026
**detect-error-handling-antipatterns.ts**
| ID | Time | T | Title | Read |
|----|------|---|-------|------|
| #36018 | 9:12 PM | 🔵 | Anti-pattern detection scan shows progress | ~301 |
| #36012 | 9:09 PM | 🔵 | Error Handling Anti-Pattern Detection Baseline | ~222 |
| #36011 | 8:55 PM | 🔄 | Simplified anti-pattern severity levels | ~238 |
| #35810 | 2:15 PM | 🔄 | Relocated Error Handling Detector Script | ~254 |
**CLAUDE.md**
| ID | Time | T | Title | Read |
|----|------|---|-------|------|
| #35901 | 2:49 PM | 🔵 | PR #525 File Changes Summary | ~376 |
| #35812 | 2:15 PM | ✅ | Updated test script path in CLAUDE.md after file relocation | ~298 |
| #35811 | " | ✅ | Created Error Handling Rules Documentation in Test Directory | ~315 |
| #35808 | " | ✅ | Moved CLAUDE.md into anti-pattern-test subfolder | ~140 |
**claude.md**
| ID | Time | T | Title | Read |
|----|------|---|-------|------|
| #35807 | 2:15 PM | ✅ | Reorganized anti-pattern test files into dedicated subfolder | ~265 |
</claude-mem-context>
On critical paths, prefer **NO TRY-CATCH** and let errors propagate naturally.