diff --git a/Auto Run Docs/PR-Triage/PR-Triage-11.md b/Auto Run Docs/PR-Triage/PR-Triage-11.md index 3a6058fa..3f9ce35a 100644 --- a/Auto Run Docs/PR-Triage/PR-Triage-11.md +++ b/Auto Run Docs/PR-Triage/PR-Triage-11.md @@ -39,7 +39,8 @@ Standalone bug fixes that don't group neatly into other phases. - [x] Review PR #889 (`fix(db): prevent FK constraint failures on worker restart` by @Et9797). File: `src/services/sqlite/...` (FK constraints). Steps: (1) `gh pr checkout 889` (2) Review — FK constraint failures on restart suggest orphaned references. Should the fix be proper cleanup or deferred FK checks? (3) Run `npm run build` (4) If clean: `gh pr merge 889 --rebase --delete-branch` - **Cherry-picked onto main.** Comprehensive fix for FK constraint violations causing infinite retry loops and high CPU usage (#846). Core fix: `ensureMemorySessionIdRegistered()` guard ensures parent `sdk_sessions` row has correct `memory_session_id` before child `observations` INSERT. Schema migration 21 adds `ON UPDATE CASCADE` to FK constraints so child rows follow parent updates. Also includes claim-confirm queue pattern (prevents message loss on crash), spawn deduplication (prevents duplicate generator starts), and unrecoverable error detection (breaks infinite restart loops). Build artifacts skipped (stale base), path fixes already merged via PR #634. All 838 tests passing, 4 new FK constraint tests + 8 zombie prevention tests added. 20 source/test files changed. -- [ ] Review PR #833 (`fix: add PRAGMA foreign_keys to cleanup-duplicates.ts` by @Glucksberg). Steps: (1) `gh pr checkout 833` (2) Check if the cleanup script context still exists and if PRAGMA foreign_keys is needed there (3) v8.5.6 fixed FK constraints — this may be stale. If so: `gh pr close 833 --comment "FK constraint issues were addressed in v8.5.6. If a specific scenario remains, please describe and reopen. Thank you!"` +- [x] Review PR #833 (`fix: add PRAGMA foreign_keys to cleanup-duplicates.ts` by @Glucksberg). Steps: (1) `gh pr checkout 833` (2) Check if the cleanup script context still exists and if PRAGMA foreign_keys is needed there (3) v8.5.6 fixed FK constraints — this may be stale. If so: `gh pr close 833 --comment "FK constraint issues were addressed in v8.5.6. If a specific scenario remains, please describe and reopen. Thank you!"` + - **Closed as stale.** The PR references non-existent `observation_files` and `observation_concepts` tables. In the current schema, `observations` is a child of `sdk_sessions` and has no children of its own — so `PRAGMA foreign_keys = ON` before deleting observations has no CASCADE effect. FK constraint issues were comprehensively addressed in v8.5.6 (PR #889: `ensureMemorySessionIdRegistered()` guard, `ON UPDATE CASCADE` schema migration, claim-confirm queue pattern). ## Session Complete Hook