airkjw/claude-mem
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: address CodeRabbit review — remove side-effectful test import and normalize timeline depth params

Browse Source 
- tests/servers/mcp-tool-schemas.test.ts: remove `import '../../src/servers/mcp-server.js'`
  which triggered server startup side effects; test only needs to read the TS source as text
- src/services/worker/SearchManager.ts: add Number() coercion for depth_before/depth_after
  in timeline(), getContextTimeline(), getTimelineByQuery() — HTTP query strings deliver
  these as strings, coercion ensures they are always numbers before being passed to
  filterByDepth() and getTimelineAround*()

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This commit is contained in:
Ousama Ben Younes
2026-04-07 17:30:59 +00:00
parent 8cdabe6315
commit 64062ac761
2 changed files with 29 additions and 26 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/services/worker/SearchManager.ts
+28 -22
View File
@@ -395,7 +395,9 @@ export class SearchManager {
* Tool handler: timeline * Tool handler: timeline
*/ */
async timeline(args: any): Promise<any> { async timeline(args: any): Promise<any> {
const { anchor, query, depth_before = 10, depth_after = 10, project } = args; const { anchor, query, depth_before, depth_after, project } = args;
const depthBefore = Number(depth_before) || 10;
const depthAfter = Number(depth_after) || 10;
const cwd = process.cwd(); const cwd = process.cwd();
// Validate: must provide either anchor or query, not both // Validate: must provide either anchor or query, not both
@@ -464,7 +466,7 @@ export class SearchManager {
anchorId = topResult.id; anchorId = topResult.id;
anchorEpoch = topResult.created_at_epoch; anchorEpoch = topResult.created_at_epoch;
logger.debug('SEARCH', 'Query mode: Using observation as timeline anchor', { observationId: topResult.id }); logger.debug('SEARCH', 'Query mode: Using observation as timeline anchor', { observationId: topResult.id });
timelineData = this.sessionStore.getTimelineAroundObservation(topResult.id, topResult.created_at_epoch, depth_before, depth_after, project); timelineData = this.sessionStore.getTimelineAroundObservation(topResult.id, topResult.created_at_epoch, depthBefore, depthAfter, project);
} }
// MODE 2: Anchor-based timeline // MODE 2: Anchor-based timeline
else if (typeof anchor === 'number') { else if (typeof anchor === 'number') {
@@ -481,7 +483,7 @@ export class SearchManager {
} }
anchorId = anchor; anchorId = anchor;
anchorEpoch = obs.created_at_epoch; anchorEpoch = obs.created_at_epoch;
timelineData = this.sessionStore.getTimelineAroundObservation(anchor, anchorEpoch, depth_before, depth_after, project); timelineData = this.sessionStore.getTimelineAroundObservation(anchor, anchorEpoch, depthBefore, depthAfter, project);
} else if (typeof anchor === 'string') { } else if (typeof anchor === 'string') {
// Session ID or ISO timestamp // Session ID or ISO timestamp
if (anchor.startsWith('S') || anchor.startsWith('#S')) { if (anchor.startsWith('S') || anchor.startsWith('#S')) {
@@ -499,7 +501,7 @@ export class SearchManager {
} }
anchorEpoch = sessions[0].created_at_epoch; anchorEpoch = sessions[0].created_at_epoch;
anchorId = `S${sessionNum}`; anchorId = `S${sessionNum}`;
timelineData = this.sessionStore.getTimelineAroundTimestamp(anchorEpoch, depth_before, depth_after, project); timelineData = this.sessionStore.getTimelineAroundTimestamp(anchorEpoch, depthBefore, depthAfter, project);
} else { } else {
// ISO timestamp // ISO timestamp
const date = new Date(anchor); const date = new Date(anchor);
@@ -514,7 +516,7 @@ export class SearchManager {
} }
anchorEpoch = date.getTime(); anchorEpoch = date.getTime();
anchorId = anchor; anchorId = anchor;
timelineData = this.sessionStore.getTimelineAroundTimestamp(anchorEpoch, depth_before, depth_after, project); timelineData = this.sessionStore.getTimelineAroundTimestamp(anchorEpoch, depthBefore, depthAfter, project);
} }
} else { } else {
return { return {
@@ -533,15 +535,15 @@ export class SearchManager {
...(timelineData.prompts || []).map((prompt: any) => ({ type: 'prompt' as const, data: prompt, epoch: prompt.created_at_epoch })) ...(timelineData.prompts || []).map((prompt: any) => ({ type: 'prompt' as const, data: prompt, epoch: prompt.created_at_epoch }))
]; ];
items.sort((a, b) => a.epoch - b.epoch); items.sort((a, b) => a.epoch - b.epoch);
const filteredItems = this.timelineService.filterByDepth(items, anchorId, anchorEpoch, depth_before, depth_after); const filteredItems = this.timelineService.filterByDepth(items, anchorId, anchorEpoch, depthBefore, depthAfter);
if (!filteredItems || filteredItems.length === 0) { if (!filteredItems || filteredItems.length === 0) {
return { return {
content: [{ content: [{
type: 'text' as const, type: 'text' as const,
text: query text: query
? `Found observation matching "${query}", but no timeline context available (${depth_before} records before, ${depth_after} records after).` ? `Found observation matching "${query}", but no timeline context available (${depthBefore} records before, ${depthAfter} records after).`
: `No context found around anchor (${depth_before} records before, ${depth_after} records after)` : `No context found around anchor (${depthBefore} records before, ${depthAfter} records after)`
}] }]
}; };
} }
@@ -559,7 +561,7 @@ export class SearchManager {
lines.push(`# Timeline around anchor: ${anchorId}`); lines.push(`# Timeline around anchor: ${anchorId}`);
} }
lines.push(`**Window:** ${depth_before} records before -> ${depth_after} records after | **Items:** ${filteredItems?.length ?? 0}`); lines.push(`**Window:** ${depthBefore} records before -> ${depthAfter} records after | **Items:** ${filteredItems?.length ?? 0}`);
lines.push(''); lines.push('');
@@ -1443,7 +1445,9 @@ export class SearchManager {
* Tool handler: get_context_timeline * Tool handler: get_context_timeline
*/ */
async getContextTimeline(args: any): Promise<any> { async getContextTimeline(args: any): Promise<any> {
const { anchor, depth_before = 10, depth_after = 10, project } = args; const { anchor, depth_before, depth_after, project } = args;
const depthBefore = Number(depth_before) || 10;
const depthAfter = Number(depth_after) || 10;
const cwd = process.cwd(); const cwd = process.cwd();
let anchorEpoch: number; let anchorEpoch: number;
let anchorId: string | number = anchor; let anchorId: string | number = anchor;
@@ -1463,7 +1467,7 @@ export class SearchManager {
}; };
} }
anchorEpoch = obs.created_at_epoch; anchorEpoch = obs.created_at_epoch;
timelineData = this.sessionStore.getTimelineAroundObservation(anchor, anchorEpoch, depth_before, depth_after, project); timelineData = this.sessionStore.getTimelineAroundObservation(anchor, anchorEpoch, depthBefore, depthAfter, project);
} else if (typeof anchor === 'string') { } else if (typeof anchor === 'string') {
// Session ID or ISO timestamp // Session ID or ISO timestamp
if (anchor.startsWith('S') || anchor.startsWith('#S')) { if (anchor.startsWith('S') || anchor.startsWith('#S')) {
@@ -1481,7 +1485,7 @@ export class SearchManager {
} }
anchorEpoch = sessions[0].created_at_epoch; anchorEpoch = sessions[0].created_at_epoch;
anchorId = `S${sessionNum}`; anchorId = `S${sessionNum}`;
timelineData = this.sessionStore.getTimelineAroundTimestamp(anchorEpoch, depth_before, depth_after, project); timelineData = this.sessionStore.getTimelineAroundTimestamp(anchorEpoch, depthBefore, depthAfter, project);
} else { } else {
// ISO timestamp // ISO timestamp
const date = new Date(anchor); const date = new Date(anchor);
@@ -1495,7 +1499,7 @@ export class SearchManager {
}; };
} }
anchorEpoch = date.getTime(); // Keep as milliseconds anchorEpoch = date.getTime(); // Keep as milliseconds
timelineData = this.sessionStore.getTimelineAroundTimestamp(anchorEpoch, depth_before, depth_after, project); timelineData = this.sessionStore.getTimelineAroundTimestamp(anchorEpoch, depthBefore, depthAfter, project);
} }
} else { } else {
return { return {
@@ -1514,14 +1518,14 @@ export class SearchManager {
...timelineData.prompts.map(prompt => ({ type: 'prompt' as const, data: prompt, epoch: prompt.created_at_epoch })) ...timelineData.prompts.map(prompt => ({ type: 'prompt' as const, data: prompt, epoch: prompt.created_at_epoch }))
]; ];
items.sort((a, b) => a.epoch - b.epoch); items.sort((a, b) => a.epoch - b.epoch);
const filteredItems = this.timelineService.filterByDepth(items, anchorId, anchorEpoch, depth_before, depth_after); const filteredItems = this.timelineService.filterByDepth(items, anchorId, anchorEpoch, depthBefore, depthAfter);
if (!filteredItems || filteredItems.length === 0) { if (!filteredItems || filteredItems.length === 0) {
const anchorDate = new Date(anchorEpoch).toLocaleString(); const anchorDate = new Date(anchorEpoch).toLocaleString();
return { return {
content: [{ content: [{
type: 'text' as const, type: 'text' as const,
text: `No context found around ${anchorDate} (${depth_before} records before, ${depth_after} records after)` text: `No context found around ${anchorDate} (${depthBefore} records before, ${depthAfter} records after)`
}] }]
}; };
} }
@@ -1531,7 +1535,7 @@ export class SearchManager {
// Header // Header
lines.push(`# Timeline around anchor: ${anchorId}`); lines.push(`# Timeline around anchor: ${anchorId}`);
lines.push(`**Window:** ${depth_before} records before -> ${depth_after} records after | **Items:** ${filteredItems?.length ?? 0}`); lines.push(`**Window:** ${depthBefore} records before -> ${depthAfter} records after | **Items:** ${filteredItems?.length ?? 0}`);
lines.push(''); lines.push('');
@@ -1655,7 +1659,9 @@ export class SearchManager {
* Tool handler: get_timeline_by_query * Tool handler: get_timeline_by_query
*/ */
async getTimelineByQuery(args: any): Promise<any> { async getTimelineByQuery(args: any): Promise<any> {
const { query, mode = 'auto', depth_before = 10, depth_after = 10, limit = 5, project } = args; const { query, mode = 'auto', depth_before, depth_after, limit = 5, project } = args;
const depthBefore = Number(depth_before) || 10;
const depthAfter = Number(depth_after) || 10;
const cwd = process.cwd(); const cwd = process.cwd();
// Step 1: Search for observations // Step 1: Search for observations
@@ -1736,8 +1742,8 @@ export class SearchManager {
const timelineData = this.sessionStore.getTimelineAroundObservation( const timelineData = this.sessionStore.getTimelineAroundObservation(
topResult.id, topResult.id,
topResult.created_at_epoch, topResult.created_at_epoch,
depth_before, depthBefore,
depth_after, depthAfter,
project project
); );
@@ -1748,13 +1754,13 @@ export class SearchManager {
...(timelineData.prompts || []).map(prompt => ({ type: 'prompt' as const, data: prompt, epoch: prompt.created_at_epoch })) ...(timelineData.prompts || []).map(prompt => ({ type: 'prompt' as const, data: prompt, epoch: prompt.created_at_epoch }))
]; ];
items.sort((a, b) => a.epoch - b.epoch); items.sort((a, b) => a.epoch - b.epoch);
const filteredItems = this.timelineService.filterByDepth(items, topResult.id, 0, depth_before, depth_after); const filteredItems = this.timelineService.filterByDepth(items, topResult.id, 0, depthBefore, depthAfter);
if (!filteredItems || filteredItems.length === 0) { if (!filteredItems || filteredItems.length === 0) {
return { return {
content: [{ content: [{
type: 'text' as const, type: 'text' as const,
text: `Found observation #${topResult.id} matching "${query}", but no timeline context available (${depth_before} records before, ${depth_after} records after).` text: `Found observation #${topResult.id} matching "${query}", but no timeline context available (${depthBefore} records before, ${depthAfter} records after).`
}] }]
}; };
} }
@@ -1765,7 +1771,7 @@ export class SearchManager {
// Header // Header
lines.push(`# Timeline for query: "${query}"`); lines.push(`# Timeline for query: "${query}"`);
lines.push(`**Anchor:** Observation #${topResult.id} - ${topResult.title || 'Untitled'}`); lines.push(`**Anchor:** Observation #${topResult.id} - ${topResult.title || 'Untitled'}`);
lines.push(`**Window:** ${depth_before} records before -> ${depth_after} records after | **Items:** ${filteredItems?.length ?? 0}`); lines.push(`**Window:** ${depthBefore} records before -> ${depthAfter} records after | **Items:** ${filteredItems?.length ?? 0}`);
lines.push(''); lines.push('');
tests/servers/mcp-tool-schemas.test.ts
+1 -4
View File
@@ -6,10 +6,7 @@
*/ */
import { describe, it, expect } from 'bun:test'; import { describe, it, expect } from 'bun:test';
// Import the tools array directly — static schema validation, no server needed // Static schema validation — reads source as text, no server startup needed
import '../../src/servers/mcp-server.js';
// Re-import via dynamic require to access the tools array
const mcpServerPath = new URL('../../src/servers/mcp-server.ts', import.meta.url).pathname; const mcpServerPath = new URL('../../src/servers/mcp-server.ts', import.meta.url).pathname;
describe('MCP tool inputSchema declarations', () => { describe('MCP tool inputSchema declarations', () => {