Merge pull request #1555 from ousamabenyounes/fix/issue-1384-mcp-inputschema

fix: declare inputSchema properties for search and timeline MCP tools (#1384 #1413)
2026-04-14 18:41:54 -07:00
parent 40a25e0225 53f98fad67
commit 77a22d30b2
3 changed files with 99 additions and 24 deletions
@@ -0,0 +1,53 @@
+/**
+ * Tests for MCP tool inputSchema declarations (fix for #1384 / #1413)
+ *
+ * Validates that search and timeline tools declare their parameters explicitly
+ * so MCP clients (Claude Code) can expose them to the LLM.
+ */
+import { describe, it, expect } from 'bun:test';
+
+// Static schema validation — reads source as text, no server startup needed
+const mcpServerPath = new URL('../../src/servers/mcp-server.ts', import.meta.url).pathname;
+
+describe('MCP tool inputSchema declarations', () => {
+  let tools: any[];
+
+  // Load tools by reading the source and extracting the exported structure
+  // We test the schema shape directly from the source constants
+  it('search tool declares query parameter', async () => {
+    const src = await Bun.file(mcpServerPath).text();
+
+    // Verify search properties are declared (not empty)
+    expect(src).toContain("name: 'search'");
+    // Check query is declared in properties after the search tool definition
+    const searchSection = src.slice(src.indexOf("name: 'search'"), src.indexOf("name: 'timeline'"));
+    expect(searchSection).toContain("query:");
+    expect(searchSection).toContain("limit:");
+    expect(searchSection).toContain("project:");
+    expect(searchSection).toContain("orderBy:");
+    expect(searchSection).not.toContain("properties: {}");
+  });
+
+  it('timeline tool declares anchor and query parameters', async () => {
+    const src = await Bun.file(mcpServerPath).text();
+
+    const timelineSection = src.slice(
+      src.indexOf("name: 'timeline'"),
+      src.indexOf("name: 'get_observations'")
+    );
+    expect(timelineSection).toContain("anchor:");
+    expect(timelineSection).toContain("query:");
+    expect(timelineSection).toContain("depth_before:");
+    expect(timelineSection).toContain("depth_after:");
+    expect(timelineSection).toContain("project:");
+    expect(timelineSection).not.toContain("properties: {}");
+  });
+
+  it('get_observations still declares ids (regression check)', async () => {
+    const src = await Bun.file(mcpServerPath).text();
+
+    const getObsSection = src.slice(src.indexOf("name: 'get_observations'"));
+    expect(getObsSection).toContain("ids:");
+    expect(getObsSection).toContain("required:");
+  });
+});