refactor: replace happy_path_error__with_fallback with logger.happyPathError (#313)

- Removed all instances of happy_path_error__with_fallback from various hooks, services, and utilities.
- Introduced logger.happyPathError for consistent logging of unexpected nulls and fallback values.
- Updated the logger utility to include a new happyPathError method with enhanced context and stack trace.
- Deprecated silent-debug utility as all logging functionality has been migrated to the logger.

src/hooks/cleanup-hook.ts

@@ -8,7 +8,6 @@
 
 import { stdin } from 'process';
 import { ensureWorkerRunning, getWorkerPort } from '../shared/worker-utils.js';
-import { happy_path_error__with_fallback } from '../utils/silent-debug.js';
 import { HOOK_TIMEOUTS } from '../shared/hook-constants.js';
 
 export interface SessionEndInput {
@@ -23,11 +22,6 @@ async function cleanupHook(input?: SessionEndInput): Promise<void> {
   // Ensure worker is running before any other logic
   await ensureWorkerRunning();
 
-  happy_path_error__with_fallback('[cleanup-hook] Hook fired', {
-    session_id: input?.session_id,
-    reason: input?.reason
-  });
-
   if (!input) {
     throw new Error('cleanup-hook requires input from Claude Code');
   }
@@ -48,18 +42,12 @@ async function cleanupHook(input?: SessionEndInput): Promise<void> {
       signal: AbortSignal.timeout(HOOK_TIMEOUTS.DEFAULT)
     });
 
-    if (response.ok) {
-      const result = await response.json();
-      happy_path_error__with_fallback('[cleanup-hook] Session cleanup completed', result);
-    } else {
+    if (!response.ok) {
       // Non-fatal - session might not exist
-      happy_path_error__with_fallback('[cleanup-hook] Session not found or already cleaned up');
+      console.error('[cleanup-hook] Session not found or already cleaned up');
     }
   } catch (error: any) {
-    // Worker might not be running - that's okay
-    happy_path_error__with_fallback('[cleanup-hook] Worker not reachable (non-critical)', {
-      error: error.message
-    });
+    // Worker might not be running - that's okay (non-critical)
   }
 
   console.log('{"continue": true, "suppressOutput": true}');

src/hooks/new-hook.ts

@@ -2,7 +2,6 @@ import path from 'path';
 import { stdin } from 'process';
 import { createHookResponse } from './hook-response.js';
 import { ensureWorkerRunning, getWorkerPort } from '../shared/worker-utils.js';
-import { happy_path_error__with_fallback } from '../utils/silent-debug.js';
 import { handleWorkerError } from '../shared/hook-error-handler.js';
 import { handleFetchError } from './shared/error-handler.js';
 
@@ -27,12 +26,6 @@ async function newHook(input?: UserPromptSubmitInput): Promise<void> {
   const { session_id, cwd, prompt } = input;
   const project = path.basename(cwd);
 
-  happy_path_error__with_fallback('[new-hook] Input received', {
-    session_id,
-    project,
-    prompt_length: prompt?.length
-  });
-
   const port = getWorkerPort();
 
   // Initialize session via HTTP - handles DB operations and privacy checks

src/hooks/save-hook.ts

@@ -11,7 +11,6 @@ import { createHookResponse } from './hook-response.js';
 import { logger } from '../utils/logger.js';
 import { ensureWorkerRunning, getWorkerPort } from '../shared/worker-utils.js';
 import { HOOK_TIMEOUTS } from '../shared/hook-constants.js';
-import { happy_path_error__with_fallback } from '../utils/silent-debug.js';
 import { handleWorkerError } from '../shared/hook-error-handler.js';
 import { handleFetchError } from './shared/error-handler.js';
 
@@ -54,8 +53,10 @@ async function saveHook(input?: PostToolUseInput): Promise<void> {
         tool_name,
         tool_input,
         tool_response,
-        cwd: cwd || happy_path_error__with_fallback(
+        cwd: cwd || logger.happyPathError(
+          'HOOK',
           'Missing cwd in PostToolUse hook input',
+          undefined,
           { session_id, tool_name },
           ''
         )

src/hooks/summary-hook.ts

@@ -14,7 +14,6 @@ import { createHookResponse } from './hook-response.js';
 import { logger } from '../utils/logger.js';
 import { ensureWorkerRunning, getWorkerPort } from '../shared/worker-utils.js';
 import { HOOK_TIMEOUTS } from '../shared/hook-constants.js';
-import { happy_path_error__with_fallback } from '../utils/silent-debug.js';
 import { handleWorkerError } from '../shared/hook-error-handler.js';
 import { handleFetchError } from './shared/error-handler.js';
 import { extractLastMessage } from '../shared/transcript-parser.js';
@@ -41,8 +40,10 @@ async function summaryHook(input?: StopInput): Promise<void> {
   const port = getWorkerPort();
 
   // Extract last user AND assistant messages from transcript
-  const transcriptPath = input.transcript_path || happy_path_error__with_fallback(
+  const transcriptPath = input.transcript_path || logger.happyPathError(
+    'HOOK',
     'Missing transcript_path in Stop hook input',
+    undefined,
     { session_id },
     ''
   );