From 80d1deedbec6db81da52a03c1f91fb4d6dad2ceb Mon Sep 17 00:00:00 2001 From: Alex Newman Date: Sat, 28 Mar 2026 15:34:42 -0700 Subject: [PATCH] fix: address PR review feedback from CodeRabbit - Add sessionId to summarize.ts warning log for easier triage - Add APPROVED OVERRIDE annotation to Windows spawn catch block Co-Authored-By: Claude Opus 4.6 (1M context) --- src/cli/handlers/summarize.ts | 2 +- src/services/infrastructure/ProcessManager.ts | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/src/cli/handlers/summarize.ts b/src/cli/handlers/summarize.ts index bea17c59..24fa354a 100644 --- a/src/cli/handlers/summarize.ts +++ b/src/cli/handlers/summarize.ts @@ -39,7 +39,7 @@ export const summarizeHandler: EventHandler = { try { lastAssistantMessage = extractLastMessage(transcriptPath, 'assistant', true); } catch (err) { - logger.warn('HOOK', `Failed to extract last assistant message: ${err instanceof Error ? err.message : err}`); + logger.warn('HOOK', `Stop hook: failed to extract last assistant message for session ${sessionId}: ${err instanceof Error ? err.message : err}`); return { continue: true, suppressOutput: true, exitCode: HOOK_EXIT_CODES.SUCCESS }; } diff --git a/src/services/infrastructure/ProcessManager.ts b/src/services/infrastructure/ProcessManager.ts index dda8107b..7df4b65a 100644 --- a/src/services/infrastructure/ProcessManager.ts +++ b/src/services/infrastructure/ProcessManager.ts @@ -658,6 +658,7 @@ export function spawnDaemon( }); return 0; } catch (error) { + // APPROVED OVERRIDE: Windows daemon spawn is best-effort; log and let callers fall back to health checks/retry flow. logger.error('SYSTEM', 'Failed to spawn worker daemon on Windows', { runtimePath }, error as Error); return undefined; }