From 8de8afbab880a38e26a8c925d8aeb613eb963ffe Mon Sep 17 00:00:00 2001 From: Alex Newman Date: Fri, 6 Feb 2026 02:52:24 -0500 Subject: [PATCH] MAESTRO: Mark PR #862 complete in PR-Triage-11 - transcript parser graceful empty handling merged Co-Authored-By: Claude Opus 4.6 --- Auto Run Docs/PR-Triage/PR-Triage-11.md | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/Auto Run Docs/PR-Triage/PR-Triage-11.md b/Auto Run Docs/PR-Triage/PR-Triage-11.md index cbd7bc01..faaece03 100644 --- a/Auto Run Docs/PR-Triage/PR-Triage-11.md +++ b/Auto Run Docs/PR-Triage/PR-Triage-11.md @@ -7,7 +7,8 @@ Standalone bug fixes that don't group neatly into other phases. - [x] Review PR #835 (`fix: handle nested XML tags in parser extractField and extractArrayElements` by @Glucksberg). File: `src/sdk/parser.ts`. Nested XML tags break field extraction. Steps: (1) `gh pr checkout 835` (2) Review regex/parser changes — should handle `content` patterns (3) Run `npm run build` (4) If correct: `gh pr merge 835 --rebase --delete-branch` - **Merged.** Clean regex fix: `[^<]*` → `[\s\S]*?` (non-greedy) in `extractField()` and `extractArrayElements()`. Also adds empty element filtering. Greptile 5/5 confidence. Build failure is pre-existing (dompurify dep), not introduced by this PR. TypeScript compilation passes for parser.ts. -- [ ] Review PR #862 (`fix: handle missing assistant messages gracefully in transcript parser` by @DennisHartrampf). File: `src/shared/transcript-parser.ts`. Missing assistant messages cause parser crash. Steps: (1) `gh pr checkout 862` (2) Review — should skip or handle gracefully, not crash (3) Run `npm run build` (4) If clean: `gh pr merge 862 --rebase --delete-branch` +- [x] Review PR #862 (`fix: handle missing assistant messages gracefully in transcript parser` by @DennisHartrampf). File: `src/shared/transcript-parser.ts`. Missing assistant messages cause parser crash. Steps: (1) `gh pr checkout 862` (2) Review — should skip or handle gracefully, not crash (3) Run `npm run build` (4) If clean: `gh pr merge 862 --rebase --delete-branch` + - **Merged.** One-line fix: `throw new Error(...)` → `return ''` in `extractLastMessage()` when no message of requested role is found. Consistent with the function's existing behavior (already returns `''` at line 64 for found-but-empty cases). Fixes crash in summarize hook when user exits before assistant responds. ## Gemini Model Name