fix: address PR review feedback - remove duplicate signal handlers and ensure PID cleanup

Browse Source

Addresses code review feedback from PR #489:

1. Moved PID file cleanup into shutdown() method to ensure it's always
   cleaned up regardless of how shutdown is triggered
2. Removed duplicate signal handlers in main() function that were
   redundant with the handlers in start() method

This eliminates the race condition where both sets of handlers could
trigger, and ensures consistent PID file cleanup behavior.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>

...

This commit is contained in:

Alex Newman

2025-12-29 16:10:19 -05:00

parent 5bd8181db9

commit 9eedbd4fbd

2 changed files with 49 additions and 60 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download Patch File Download Diff File Expand all files Collapse all files

plugin/scripts/worker-service.cjs

+46 -46

File diff suppressed because one or more lines are too long