From c6f932988a71e4eb0bf15108c91eec7d9eb64349 Mon Sep 17 00:00:00 2001 From: Alex Newman Date: Mon, 23 Feb 2026 19:34:35 -0500 Subject: [PATCH] Fix 30+ root-cause bugs across 10 triage phases (#1214) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit * MAESTRO: fix ChromaDB core issues — Python pinning, Windows paths, disable toggle, metadata sanitization, transport errors - Add --python version pinning to uvx args in both local and remote mode (fixes #1196, #1206, #1208) - Convert backslash paths to forward slashes for --data-dir on Windows (fixes #1199) - Add CLAUDE_MEM_CHROMA_ENABLED setting for SQLite-only fallback mode (fixes #707) - Sanitize metadata in addDocuments() to filter null/undefined/empty values (fixes #1183, #1188) - Wrap callTool() in try/catch for transport errors with auto-reconnect (fixes #1162) Co-Authored-By: Claude Opus 4.6 * MAESTRO: fix data integrity — content-hash deduplication, project name collision, empty project guard, stuck isProcessing - Add SHA-256 content-hash deduplication to observations INSERT (store.ts, transactions.ts, SessionStore.ts) - Add content_hash column via migration 22 with backfill and index - Fix project name collision: getCurrentProjectName() now returns parent/basename - Guard against empty project string with cwd-derived fallback - Fix stuck isProcessing: hasAnyPendingWork() resets processing messages older than 5 minutes - Add 12 new tests covering all four fixes Co-Authored-By: Claude Opus 4.6 * MAESTRO: fix hook lifecycle — stderr suppression, output isolation, conversation pollution prevention - Suppress process.stderr.write in hookCommand() to prevent Claude Code showing diagnostic output as error UI (#1181). Restores stderr in finally block for worker-continues case. - Convert console.error() to logger.warn()/error() in hook-command.ts and handlers/index.ts so all diagnostics route to log file instead of stderr. - Verified all 7 handlers return suppressOutput: true (prevents conversation pollution #598, #784). - Verified session-complete is a recognized event type (fixes #984). - Verified unknown event types return no-op handler with exit 0 (graceful degradation). - Added 10 new tests in tests/hook-lifecycle.test.ts covering event dispatch, adapter defaults, stderr suppression, and standard response constants. Co-Authored-By: Claude Opus 4.6 * MAESTRO: fix worker lifecycle — restart loop coordination, stale transport retry, ENOENT shutdown race - Add PID file mtime guard to prevent concurrent restart storms (#1145): isPidFileRecent() + touchPidFile() coordinate across sessions - Add transparent retry in ChromaMcpManager.callTool() on transport error — reconnects and retries once instead of failing (#1131) - Wrap getInstalledPluginVersion() with ENOENT/EBUSY handling (#1042) - Verified ChromaMcpManager.stop() already called on all shutdown paths Co-Authored-By: Claude Opus 4.6 * MAESTRO: fix Windows platform support — uvx.cmd spawn, PowerShell $_ elimination, windowsHide, FTS5 fallback - Route uvx spawn through cmd.exe /c on Windows since MCP SDK lacks shell:true (#1190, #1192, #1199) - Replace all PowerShell Where-Object {$_} pipelines with WQL -Filter server-side filtering (#1024, #1062) - Add windowsHide: true to all exec/spawn calls missing it to prevent console popups (#1048) - Add FTS5 runtime probe with graceful fallback when unavailable on Windows (#791) - Guard FTS5 table creation in migrations, SessionSearch, and SessionStore with try/catch Co-Authored-By: Claude Opus 4.6 * MAESTRO: fix skills/ distribution — build-time verification and regression tests (#1187) Add post-build verification in build-hooks.js that fails if critical distribution files (skills, hooks, plugin manifest) are missing. Add 10 regression tests covering skill file presence, YAML frontmatter, hooks.json integrity, and package.json files field. Co-Authored-By: Claude Opus 4.6 * MAESTRO: fix MigrationRunner schema initialization (#979) — version conflict between parallel migration systems Root cause: old DatabaseManager migrations 1-7 shared schema_versions table with MigrationRunner's 4-22, causing version number collisions (5=drop tables vs add column, 6=FTS5 vs prompt tracking, 7=discovery_tokens vs remove UNIQUE). initializeSchema() was gated behind maxApplied===0, so core tables were never created when old versions were present. Fixes: - initializeSchema() always creates core tables via CREATE TABLE IF NOT EXISTS - Migrations 5-7 check actual DB state (columns/constraints) not just version tracking - Crash-safe temp table rebuilds (DROP IF EXISTS _new before CREATE) - Added missing migration 21 (ON UPDATE CASCADE) to MigrationRunner - Added ON UPDATE CASCADE to FK definitions in initializeSchema() - All changes applied to both runner.ts and SessionStore.ts Tests: 13 new tests in migration-runner.test.ts covering fresh DB, idempotency, version conflicts, crash recovery, FK constraints, and data integrity. Co-Authored-By: Claude Opus 4.6 * MAESTRO: fix 21 test failures — stale mocks, outdated assertions, missing OpenClaw guards Server tests (12): Added missing workerPath and getAiStatus to ServerOptions mocks after interface expansion. ChromaSync tests (3): Updated to verify transport cleanup in ChromaMcpManager after architecture refactor. OpenClaw (2): Added memory_ tool skipping and response truncation to prevent recursive loops and oversized payloads. MarkdownFormatter (2): Updated assertions to match current output. SettingsDefaultsManager (1): Used correct default key for getBool test. Logger standards (1): Excluded CLI transcript command from background service check. Co-Authored-By: Claude Opus 4.6 * MAESTRO: fix Codex CLI compatibility (#744) — session_id fallbacks, unknown platform tolerance, undefined guard Co-Authored-By: Claude Opus 4.6 * MAESTRO: fix Cursor IDE integration (#838, #1049) — adapter field fallbacks, tolerant session-init validation Co-Authored-By: Claude Opus 4.6 * MAESTRO: fix /api/logs OOM (#1203) — tail-read replaces full-file readFileSync Replace readFileSync (loads entire file into memory) with readLastLines() that reads only from the end of the file in expanding chunks (64KB → 10MB cap). Prevents OOM on large log files while preserving the same API response shape. Co-Authored-By: Claude Opus 4.6 * MAESTRO: fix Settings CORS error (#1029) — explicit methods and allowedHeaders in CORS config Co-Authored-By: Claude Opus 4.6 * MAESTRO: add session custom_title for agent attribution (#1213) — migration 23, endpoint + store support Co-Authored-By: Claude Opus 4.6 * MAESTRO: prevent CLAUDE.md/AGENTS.md writes inside .git/ directories (#1165) Add .git path guard to all 4 write sites to prevent ref corruption when paths resolve inside .git internals. Co-Authored-By: Claude Opus 4.6 * MAESTRO: fix plugin disabled state not respected (#781) — early exit check in all hook entry points Co-Authored-By: Claude Opus 4.6 * MAESTRO: fix UserPromptSubmit context re-injection on every turn (#1079) — contextInjected session flag Co-Authored-By: Claude Opus 4.6 * MAESTRO: fix stale AbortController queue stall (#1099) — lastGeneratorActivity tracking + 30s timeout Three-layer fix: 1. Added lastGeneratorActivity timestamp to ActiveSession, updated by processAgentResponse (all agents), getMessageIterator (queue yields), and startGeneratorWithProvider (generator launch) 2. Added stale generator detection in ensureGeneratorRunning — if no activity for >30s, aborts stale controller, resets state, restarts 3. Added AbortSignal.timeout(30000) in deleteSession to prevent indefinite hang when awaiting a stuck generator promise Co-Authored-By: Claude Opus 4.6 --------- Co-authored-by: Claude Opus 4.6 --- openclaw/src/index.ts | 9 + plugin/scripts/bun-runner.js | 20 +- plugin/scripts/context-generator.cjs | 80 +-- plugin/scripts/mcp-server.cjs | 42 +- plugin/scripts/smart-install.js | 16 + plugin/scripts/worker-service.cjs | 499 +++++++++--------- scripts/build-hooks.js | 14 + scripts/regenerate-claude-md.ts | 5 + src/cli/adapters/claude-code.ts | 2 +- src/cli/adapters/cursor.ts | 11 +- src/cli/adapters/index.ts | 3 +- src/cli/claude-md-commands.ts | 5 + src/cli/handlers/index.ts | 3 +- src/cli/handlers/session-init.ts | 19 +- src/cli/hook-command.ts | 17 +- src/services/infrastructure/HealthMonitor.ts | 22 +- src/services/infrastructure/ProcessManager.ts | 81 ++- src/services/sqlite/PendingMessageStore.ts | 15 +- src/services/sqlite/SessionSearch.ts | 174 +++--- src/services/sqlite/SessionStore.ts | 300 +++++++---- src/services/sqlite/migrations.ts | 10 + src/services/sqlite/migrations/runner.ts | 449 ++++++++++++---- src/services/sqlite/observations/store.ts | 55 +- src/services/sqlite/sessions/create.ts | 16 +- src/services/sqlite/sessions/get.ts | 4 +- src/services/sqlite/sessions/types.ts | 2 + src/services/sqlite/transactions.ts | 29 +- src/services/sync/ChromaMcpManager.ts | 54 +- src/services/sync/ChromaSync.ts | 28 +- src/services/worker-service.ts | 50 +- src/services/worker-types.ts | 1 + src/services/worker/DatabaseManager.ts | 19 +- src/services/worker/SearchManager.ts | 2 +- src/services/worker/SessionManager.ts | 16 +- .../worker/agents/ResponseProcessor.ts | 11 +- src/services/worker/http/middleware.ts | 2 + src/services/worker/http/routes/LogsRoutes.ts | 87 ++- .../worker/http/routes/SessionRoutes.ts | 50 +- src/shared/SettingsDefaultsManager.ts | 2 + src/shared/paths.ts | 9 +- src/shared/plugin-state.ts | 29 + src/utils/agents-md-utils.ts | 6 +- src/utils/claude-md-utils.ts | 5 + .../formatters/markdown-formatter.test.ts | 8 +- tests/hook-lifecycle.test.ts | 374 +++++++++++++ tests/hooks/context-reinjection-guard.test.ts | 310 +++++++++++ tests/infrastructure/health-monitor.test.ts | 63 ++- .../plugin-disabled-check.test.ts | 91 ++++ .../plugin-distribution.test.ts | 105 ++++ tests/infrastructure/process-manager.test.ts | 54 ++ tests/integration/chroma-vector-sync.test.ts | 96 ++-- tests/integration/hook-execution-e2e.test.ts | 10 + .../integration/worker-api-endpoints.test.ts | 14 + tests/server/server.test.ts | 10 + tests/services/logs-routes-tail-read.test.ts | 128 +++++ .../services/sqlite/migration-runner.test.ts | 315 +++++++++++ .../stale-abort-controller-guard.test.ts | 146 +++++ .../shared/settings-defaults-manager.test.ts | 2 +- tests/sqlite/data-integrity.test.ts | 199 +++++++ tests/sqlite/sessions.test.ts | 46 ++ tests/utils/claude-md-utils.test.ts | 42 ++ .../middleware/cors-restriction.test.ts | 146 ++++- 62 files changed, 3639 insertions(+), 793 deletions(-) create mode 100644 src/shared/plugin-state.ts create mode 100644 tests/hook-lifecycle.test.ts create mode 100644 tests/hooks/context-reinjection-guard.test.ts create mode 100644 tests/infrastructure/plugin-disabled-check.test.ts create mode 100644 tests/infrastructure/plugin-distribution.test.ts create mode 100644 tests/services/logs-routes-tail-read.test.ts create mode 100644 tests/services/sqlite/migration-runner.test.ts create mode 100644 tests/services/stale-abort-controller-guard.test.ts create mode 100644 tests/sqlite/data-integrity.test.ts diff --git a/openclaw/src/index.ts b/openclaw/src/index.ts index 97ba4503..cbc510c6 100644 --- a/openclaw/src/index.ts +++ b/openclaw/src/index.ts @@ -642,6 +642,9 @@ export default function claudeMemPlugin(api: OpenClawPluginApi): void { const toolName = event.toolName; if (!toolName) return; + // Skip memory_ tools to prevent recursive observation loops + if (toolName.startsWith("memory_")) return; + const contentSessionId = getContentSessionId(ctx.sessionKey); // Extract result text from all content blocks @@ -654,6 +657,12 @@ export default function claudeMemPlugin(api: OpenClawPluginApi): void { .join("\n"); } + // Truncate long responses to prevent oversized payloads + const MAX_TOOL_RESPONSE_LENGTH = 1000; + if (toolResponseText.length > MAX_TOOL_RESPONSE_LENGTH) { + toolResponseText = toolResponseText.slice(0, MAX_TOOL_RESPONSE_LENGTH); + } + // Fire-and-forget: send observation + sync MEMORY.md in parallel workerPostFireAndForget(workerPort, "/api/sessions/observations", { contentSessionId, diff --git a/plugin/scripts/bun-runner.js b/plugin/scripts/bun-runner.js index 414fc332..0de7c876 100644 --- a/plugin/scripts/bun-runner.js +++ b/plugin/scripts/bun-runner.js @@ -12,7 +12,7 @@ * Fixes #818: Worker fails to start on fresh install */ import { spawnSync, spawn } from 'child_process'; -import { existsSync } from 'fs'; +import { existsSync, readFileSync } from 'fs'; import { join } from 'path'; import { homedir } from 'os'; @@ -54,6 +54,24 @@ function findBun() { return null; } +// Early exit if plugin is disabled in Claude Code settings (#781). +// Sync read + JSON parse — fastest possible check before spawning Bun. +function isPluginDisabledInClaudeSettings() { + try { + const configDir = process.env.CLAUDE_CONFIG_DIR || join(homedir(), '.claude'); + const settingsPath = join(configDir, 'settings.json'); + if (!existsSync(settingsPath)) return false; + const settings = JSON.parse(readFileSync(settingsPath, 'utf-8')); + return settings?.enabledPlugins?.['claude-mem@thedotmack'] === false; + } catch { + return false; + } +} + +if (isPluginDisabledInClaudeSettings()) { + process.exit(0); +} + // Get args: node bun-runner.js