diff --git a/Auto Run Docs/PR-Triage/PR-Triage-06.md b/Auto Run Docs/PR-Triage/PR-Triage-06.md index 4c69b7a5..205d02aa 100644 --- a/Auto Run Docs/PR-Triage/PR-Triage-06.md +++ b/Auto Run Docs/PR-Triage/PR-Triage-06.md @@ -20,6 +20,7 @@ These PRs address orphaned/zombie processes. This is a recurring theme — v9.0. - [x] Review PR #738 (`fix(worker): add subprocess lifecycle cleanup for zombie haiku agents` by @fedosov). Files: 8 source files + tests. Adds QueryWrapper/QueryWrapperManager for subprocess lifecycle management. Steps: (1) `gh pr checkout 738` (2) Check overlap with ProcessRegistry (v9.0.8) — does this add a parallel tracking system? That would be redundant. (3) If it extends ProcessRegistry, good. If it introduces a separate system, close and suggest integrating with ProcessRegistry. (4) Run `npm run build` and tests. > **Result: CLOSED** — Introduces a parallel process tracking system (QueryWrapper/QueryWrapperManager, 413 lines) with a separate `activeQueries` Map alongside the existing `processRegistry` Map. The orphan cleanup function (`cleanupOrphanedClaudeSubprocesses`) duplicates two existing functions: `killSystemOrphans()` (ppid=1 claude+haiku detection) and `killIdleDaemonChildren()` (idle daemon child cleanup, merged via PR #879). The periodic 15-minute cleanup is already covered by the 5-minute orphan reaper. Suggested the author contribute Windows orphan detection as a small extension to ProcessRegistry instead. -- [ ] Review PR #713 (`fix: prevent SDK subprocess accumulation` by @cjpeterein). Files: 17 files (very large PR). Steps: (1) `gh pr checkout 713` (2) This is a large PR touching many files — check how much overlaps with v9.0.8 ProcessRegistry work (3) Large PRs on process management are risky. If substantial overlap exists with shipped code, close with explanation. (4) If unique value remains, request the author to rebase and reduce scope. +- [x] Review PR #713 (`fix: prevent SDK subprocess accumulation` by @cjpeterein). Files: 17 files (very large PR). Steps: (1) `gh pr checkout 713` (2) This is a large PR touching many files — check how much overlaps with v9.0.8 ProcessRegistry work (3) Large PRs on process management are risky. If substantial overlap exists with shipped code, close with explanation. (4) If unique value remains, request the author to rebase and reduce scope. + > **Result: CLOSED** — 873 additions across 18 files with extensive overlap with shipped infrastructure. ProcessRegistry (v9.0.8) provides PID tracking and 3-layer orphan reaper, SessionQueueProcessor (v9.0.13) provides 3-minute idle timeout, and ProcessManager.ts already handles startup orphan cleanup. The only genuinely new addition was a try/finally wrapper around the SDK query loop, which is redundant given deleteSession() → abort() → ensureProcessExit() → SIGKILL escalation already handles subprocess cleanup. The large surface area (18 files) makes this high-risk for marginal defensive benefit. - [ ] Review PR #687 (`fix: expand orphaned process cleanup to include mcp-server and worker-service` by @MrSaneApps). File: `src/services/infrastructure/ProcessManager.ts`. Steps: (1) `gh pr checkout 687` (2) Single-file change expanding what processes the reaper targets — low risk (3) Verify it correctly identifies mcp-server and worker-service processes (4) Run `npm run build` (5) If clean: `gh pr merge 687 --rebase --delete-branch`