airkjw/claude-mem
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: resolve issues #543, #544, #545, #557 (#558)

Browse Source 
* docs: add investigation reports for 5 open GitHub issues

Comprehensive analysis of issues #543, #544, #545, #555, and #557:

- #557: settings.json not generated, module loader error (node/bun mismatch)
- #555: Windows hooks not executing, hasIpc always false
- #545: formatTool crashes on non-JSON tool_input strings
- #544: mem-search skill hint shown incorrectly to Claude Code users
- #543: /claude-mem slash command unavailable despite installation

Each report includes root cause analysis, affected files, and proposed fixes.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

* fix(logger): handle non-JSON tool_input in formatTool (#545)

Wrap JSON.parse in try-catch to handle raw string inputs (e.g., Bash
commands) that aren't valid JSON. Falls back to using the string as-is.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

* fix(context): update mem-search hint to reference MCP tools (#544)

Update hint messages to reference MCP tools (search, get_observations)
instead of the deprecated "mem-search skill" terminology.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

* fix(settings): auto-create settings.json on first load (#557, #543)

When settings.json doesn't exist, create it with defaults instead of
returning in-memory defaults. Creates parent directory if needed.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

* fix(hooks): use bun runtime for hooks except smart-install (#557)

Change hook commands from node to bun since hooks use bun:sqlite.
Keep smart-install.js on node since it bootstraps bun installation.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

* chore: rebuild plugin scripts

* docs: clarify that build artifacts must be committed

* fix(docs): update build artifacts directory reference in CLAUDE.md

* test: add test coverage for PR #558 fixes

- Fix 2 failing tests: update "mem-search skill" → "MCP tools" expectations
- Add 56 tests for formatTool() JSON.parse crash fix (Issue #545)
- Add 27 tests for settings.json auto-creation (Issue #543)

Test coverage includes:
- formatTool: JSON parsing, raw strings, objects, null/undefined, all tool types
- Settings: file creation, directory creation, schema migration, edge cases

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

* fix(tests): clean up flaky tests and fix circular dependency

Phase 1 of test quality improvements:

- Delete 6 harmful/worthless test files that used problematic mock.module()
  patterns or tested implementation details rather than behavior:
  - context-builder.test.ts (tested internal implementation)
  - export-types.test.ts (fragile mock patterns)
  - smart-install.test.ts (shell script testing antipattern)
  - session_id_refactor.test.ts (outdated, tested refactoring itself)
  - validate_sql_update.test.ts (one-time migration validation)
  - observation-broadcaster.test.ts (excessive mocking)

- Fix circular dependency between logger.ts and SettingsDefaultsManager.ts
  by using late binding pattern - logger now lazily loads settings

- Refactor mock.module() to spyOn() in several test files for more
  maintainable and less brittle tests:
  - observation-compiler.test.ts
  - gemini_agent.test.ts
  - error-handler.test.ts
  - server.test.ts
  - response-processor.test.ts

All 649 tests pass.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

* refactor(tests): phase 2 - reduce mock-heavy tests and improve focus

- Remove mock-heavy query tests from observation-compiler.test.ts, keep real buildTimeline tests
- Convert session_id_usage_validation.test.ts from 477 to 178 lines of focused smoke tests
- Remove tests for language built-ins from worker-spawn.test.ts (JSON.parse, array indexing)
- Rename logger-coverage.test.ts to logger-usage-standards.test.ts for clarity

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

* docs(tests): phase 3 - add JSDoc mock justification to test files

Document mock usage rationale in 5 test files to improve maintainability:
- error-handler.test.ts: Express req/res mocks, logger spies (~11%)
- fallback-error-handler.test.ts: Zero mocks, pure function tests
- session-cleanup-helper.test.ts: Session fixtures, worker mocks (~19%)
- hook-constants.test.ts: process.platform mock for Windows tests (~12%)
- session_store.test.ts: Zero mocks, real SQLite :memory: database

Part of ongoing effort to document mock justifications per TESTING.md guidelines.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

* test(integration): phase 5 - add 72 tests for critical coverage gaps

Add comprehensive test coverage for previously untested areas:

- tests/integration/hook-execution-e2e.test.ts (10 tests)
  Tests lifecycle hooks execution flow and context propagation

- tests/integration/worker-api-endpoints.test.ts (19 tests)
  Tests all worker service HTTP endpoints without heavy mocking

- tests/integration/chroma-vector-sync.test.ts (16 tests)
  Tests vector embedding synchronization with ChromaDB

- tests/utils/tag-stripping.test.ts (27 tests)
  Tests privacy tag stripping utilities for both <private> and
  <meta-observation> tags

All tests use real implementations where feasible, following the
project's testing philosophy of preferring integration-style tests
over unit tests with extensive mocking.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

* context update

* docs: add comment linking DEFAULT_DATA_DIR locations

Added NOTE comment in logger.ts pointing to the canonical DEFAULT_DATA_DIR
in SettingsDefaultsManager.ts. This addresses PR reviewer feedback about
the fragility of having the default defined in two places to avoid
circular dependencies.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
This commit is contained in:
Alex Newman
2026-01-05 19:45:09 -05:00
committed by GitHub
parent f1ccc22593
commit f38b5b85bc
55 changed files with 4712 additions and 2676 deletions
Download Patch File Download Diff File Expand all files Collapse all files
.claude/plans/2026-01-05-fix-81-test-failures.md
+299
View File
@@ -0,0 +1,299 @@
# Plan: Fix 81 Test Failures from Incomplete Logger Mocks
## Problem Summary
**Root Cause**: NOT circular dependency (which is handled gracefully), but **incomplete logger mocks** that pollute across test files when Bun runs tests in alphabetical order.
When `tests/context/` runs before `tests/utils/`, the incomplete mocks replace the real logger module globally, causing subsequent tests to fail with `TypeError: logger.formatTool is not a function`.
## Phase 0: Documentation Discovery (COMPLETED)
### Sources Consulted
- `src/utils/logger.ts` - Full logger interface (lines 136, 289-373)
- `tests/context/context-builder.test.ts` - Mock pattern (lines 22-29)
- `tests/context/observation-compiler.test.ts` - Mock pattern (lines 4-10)
- `tests/server/server.test.ts` - Mock pattern (lines 4-11)
- `tests/server/error-handler.test.ts` - Mock pattern (lines 5-12)
- `tests/worker/agents/response-processor.test.ts` - Mock pattern (lines 32-39)
### Logger Methods (Complete List)
All 11 methods that must be in any logger mock:
1. `formatTool(toolName: string, toolInput?: any): string` (line 136)
2. `debug(component, message, context?, data?): void` (line 289)
3. `info(component, message, context?, data?): void` (line 293)
4. `warn(component, message, context?, data?): void` (line 297)
5. `error(component, message, context?, data?): void` (line 301)
6. `dataIn(component, message, context?, data?): void` (line 308)
7. `dataOut(component, message, context?, data?): void` (line 315)
8. `success(component, message, context?, data?): void` (line 322)
9. `failure(component, message, context?, data?): void` (line 329)
10. `timing(component, message, durationMs, context?): void` (line 336)
11. `happyPathError<T>(message, context?): T` (line 362)
### Files Requiring Updates
1. `tests/context/observation-compiler.test.ts` (lines 4-10)
2. `tests/context/context-builder.test.ts` (lines 22-29)
3. `tests/server/server.test.ts` (lines 4-11)
4. `tests/server/error-handler.test.ts` (lines 5-12)
5. `tests/worker/agents/response-processor.test.ts` (lines 32-39)
---
## Phase 1: Create Shared Logger Mock Utility
### Objective
Create a reusable complete logger mock to avoid duplication and ensure consistency.
### Implementation
**Create new file**: `tests/test-utils/mock-logger.ts`
```typescript
/**
* Complete logger mock for tests.
* Includes ALL logger methods to prevent mock pollution across test files.
*/
import { mock } from 'bun:test';
export function createMockLogger() {
return {
logger: {
// Core logging methods
debug: mock(() => {}),
info: mock(() => {}),
warn: mock(() => {}),
error: mock(() => {}),
// Data flow logging
dataIn: mock(() => {}),
dataOut: mock(() => {}),
// Status logging
success: mock(() => {}),
failure: mock(() => {}),
// Performance logging
timing: mock(() => {}),
// Tool formatting - returns string
formatTool: mock((toolName: string, _toolInput?: any) => toolName),
// Error helper - returns the message
happyPathError: mock((message: string, _context?: any) => message),
},
};
}
```
### Verification Checklist
- [ ] File created at `tests/test-utils/mock-logger.ts`
- [ ] All 11 logger methods included
- [ ] `formatTool` returns string (not void)
- [ ] `happyPathError` returns the message (not void)
- [ ] File compiles without errors: `bunx tsc --noEmit tests/test-utils/mock-logger.ts`
### Anti-Patterns to Avoid
- ❌ Don't forget `formatTool` - it returns a string, not void
- ❌ Don't forget `happyPathError` - it's generic and returns the message
- ❌ Don't use `() => {}` for methods that return values
---
## Phase 2: Update Affected Test Files
### Objective
Replace incomplete logger mocks with the complete shared mock.
### Files to Update (5 total)
#### 2.1 `tests/context/observation-compiler.test.ts`
**Current (lines 4-10)**:
```typescript
mock.module('../../src/utils/logger.js', () => ({
logger: {
debug: mock(() => {}),
failure: mock(() => {}),
error: mock(() => {}),
},
}));
```
**Replace with**:
```typescript
import { createMockLogger } from '../test-utils/mock-logger.js';
mock.module('../../src/utils/logger.js', () => createMockLogger());
```
#### 2.2 `tests/context/context-builder.test.ts`
**Current (lines 22-29)**:
```typescript
mock.module('../../src/utils/logger.js', () => ({
logger: {
debug: mock(() => {}),
failure: mock(() => {}),
error: mock(() => {}),
info: mock(() => {}),
},
}));
```
**Replace with**:
```typescript
import { createMockLogger } from '../test-utils/mock-logger.js';
mock.module('../../src/utils/logger.js', () => createMockLogger());
```
#### 2.3 `tests/server/server.test.ts`
**Current (lines 4-11)**:
```typescript
mock.module('../../src/utils/logger.js', () => ({
logger: {
info: () => {},
debug: () => {},
warn: () => {},
error: () => {},
},
}));
```
**Replace with**:
```typescript
import { createMockLogger } from '../test-utils/mock-logger.js';
mock.module('../../src/utils/logger.js', () => createMockLogger());
```
#### 2.4 `tests/server/error-handler.test.ts`
**Current (lines 5-12)**:
```typescript
mock.module('../../src/utils/logger.js', () => ({
logger: {
info: () => {},
debug: () => {},
warn: () => {},
error: () => {},
},
}));
```
**Replace with**:
```typescript
import { createMockLogger } from '../test-utils/mock-logger.js';
mock.module('../../src/utils/logger.js', () => createMockLogger());
```
#### 2.5 `tests/worker/agents/response-processor.test.ts`
**Current (lines 32-39)**:
```typescript
mock.module('../../../src/utils/logger.js', () => ({
logger: {
info: () => {},
debug: () => {},
warn: () => {},
error: () => {},
},
}));
```
**Replace with**:
```typescript
import { createMockLogger } from '../../test-utils/mock-logger.js';
mock.module('../../../src/utils/logger.js', () => createMockLogger());
```
### Verification Checklist
- [ ] All 5 files updated with import statement
- [ ] All 5 files use `createMockLogger()` instead of inline mock
- [ ] Import paths are correct (relative to each file's location)
- [ ] Each file still has `mock.module` BEFORE the module imports it mocks
### Anti-Patterns to Avoid
- ❌ Don't place import AFTER the mock.module call
- ❌ Don't use wrong relative path (../test-utils vs ../../test-utils)
- ❌ Don't forget the .js extension in imports
---
## Phase 3: Verification
### Objective
Confirm all 81 failures are fixed.
### Test Commands
```bash
# 1. Run individual test groups first
bun test tests/context/
bun test tests/server/
bun test tests/utils/
bun test tests/shared/
bun test tests/worker/
# 2. Run full suite
bun test
# 3. Verify specific test counts
# Expected: 733+ tests pass (was 652 before)
```
### Verification Checklist
- [ ] `bun test tests/context/` - all pass
- [ ] `bun test tests/server/` - all pass
- [ ] `bun test tests/utils/` - all pass (including 56 formatTool tests)
- [ ] `bun test tests/shared/` - all pass (including 27 settings tests)
- [ ] `bun test` - 730+ tests pass, 0 failures
- [ ] No `TypeError: logger.formatTool is not a function` errors
### Anti-Pattern Grep Checks
```bash
# Check no incomplete logger mocks remain
grep -r "logger: {" tests/ --include="*.ts" | grep -v mock-logger
# Verify all test files use createMockLogger
grep -r "createMockLogger" tests/ --include="*.ts"
```
---
## Phase 4: Commit
### Commit Message
```
fix(tests): complete logger mocks to prevent cross-test pollution
The 81 test failures were caused by incomplete logger mocks that
polluted the module cache when tests ran in alphabetical order.
Changes:
- Create shared mock-logger.ts with all 11 logger methods
- Update 5 test files to use complete mock
- Fix TypeError: logger.formatTool is not a function
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
```
---
## Summary
| Phase | Files Changed | Purpose |
|-------|--------------|---------|
| 1 | 1 new file | Create shared mock utility |
| 2 | 5 files | Update to use shared mock |
| 3 | 0 files | Verification only |
| 4 | 0 files | Commit |
**Total**: 6 files changed, fixing all 81 test failures.