From f62b5d248c7405e8a24fb1cebc21f96c7104853a Mon Sep 17 00:00:00 2001 From: Alex Newman Date: Fri, 6 Feb 2026 02:04:53 -0500 Subject: [PATCH] MAESTRO: Mark PR #615 task complete in PR-Triage-08 Co-Authored-By: Claude Opus 4.6 --- Auto Run Docs/PR-Triage/PR-Triage-08.md | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/Auto Run Docs/PR-Triage/PR-Triage-08.md b/Auto Run Docs/PR-Triage/PR-Triage-08.md index 50318fe8..ba432f30 100644 --- a/Auto Run Docs/PR-Triage/PR-Triage-08.md +++ b/Auto Run Docs/PR-Triage/PR-Triage-08.md @@ -34,4 +34,5 @@ These fix Gemini/OpenRouter providers that don't have SDK sessions. - [x] Review PR #910 (`fix: complete stateless provider support with enhanced validation` by @Scheevel). WARNING: This PR modifies ~90 files, most of which are CLAUDE.md files that should NOT have been included. Steps: (1) `gh pr checkout 910` (2) Identify the actual source changes (look at `.ts` files only, ignore CLAUDE.md files) (3) Key files: `src/services/sqlite/SessionStore.ts`, `src/services/worker/GeminiAgent.ts`, `src/services/worker/OpenRouterAgent.ts`, `src/services/worker/agents/ResponseProcessor.ts` (4) If the core logic is good but CLAUDE.md pollution is unacceptable, request changes to remove all CLAUDE.md files from the PR. Or cherry-pick just the source changes. - **CLOSED** (2026-02-06): Stale branch with critical regressions against 5 recently merged PRs. Reverts: `consecutiveRestarts` (PR #693 — infinite restart prevention), `removeSessionImmediate()` (PR #937 — orphaned message handling), `getCredential()` (Issue #733 — centralized env), `CLAUDE_MEM_FOLDER_CLAUDEMD_ENABLED` check (PR #913), and `createIterator()` onIdleTimeout. Also bundles 3 unrelated features: observation deduplication (+285 lines Levenshtein in ResponseProcessor), summary soft-delete (hidden column + PATCH API), and deletion of ~80 CLAUDE.md files + compiled plugin artifacts. Core synthetic memorySessionId generation is valuable — requested re-submission as focused PRs: (1) synthetic ID gen for stateless providers, (2) observation deduplication, (3) summary soft-delete. -- [ ] Evaluate PR #615 (`fix: generate memorySessionId for stateless providers` by @JiehoonKwak). Files: 6 files. Steps: (1) `gh pr checkout 615` (2) Check if #910 supersedes this (both fix stateless provider session IDs) (3) If #910 is more complete, close #615: `gh pr close 615 --comment "Superseded by PR #910 which provides more complete stateless provider support. Thank you!"` (4) If #615 has unique value, rebase and merge first. +- [x] Evaluate PR #615 (`fix: generate memorySessionId for stateless providers` by @JiehoonKwak). Files: 6 files. Steps: (1) `gh pr checkout 615` (2) Check if #910 supersedes this (both fix stateless provider session IDs) (3) If #910 is more complete, close #615: `gh pr close 615 --comment "Superseded by PR #910 which provides more complete stateless provider support. Thank you!"` (4) If #615 has unique value, rebase and merge first. + - **APPLIED TO MAIN** (2026-02-06): PR #910 was already CLOSED (regressions), so #615 was NOT superseded. Core synthetic memorySessionId generation (+8 lines each in GeminiAgent.ts and OpenRouterAgent.ts) applied directly to main — PR was 1 month old with conflicts from PRs #693, #913, #940. The fix generates `gemini-{contentSessionId}-{timestamp}` / `openrouter-{contentSessionId}-{timestamp}` IDs before the first API call, fixing a real bug where PR #693's defensive `!session.memorySessionId` checks would throw errors for all stateless provider sessions. Other PR changes (sessions/create.ts backfill, CLAUDE_MEM_FOLDER_CLAUDEMD_ENABLED, quote style changes) already in main or formatting-only. Build passes.