fix: complete better-sqlite3 to bun:sqlite migration

Must Fix:
- Remove better-sqlite3 logic from smart-install.js (5 sections)
- Update all documentation to reference bun:sqlite (7 files)

Should Fix:
- Add defensive break statement in worker-cli.ts:38

Nice to Have:
- Add port validation in ProcessManager.start() (1024-65535)
- Add one-time marker for PM2 cleanup migration
- Verify clearPortCache() wiring (already correct)

Addresses PR #248 review feedback (comment #3648517713)

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>

src/cli/worker-cli.ts

@@ -35,6 +35,7 @@ async function main() {
         console.error(`Failed to restart: ${result.error}`);
         process.exit(1);
       }
+      break;
     }
 
     case 'status': {

src/services/process/ProcessManager.ts

@@ -25,6 +25,14 @@ interface PidInfo {
 
 export class ProcessManager {
   static async start(port: number): Promise<{ success: boolean; pid?: number; error?: string }> {
+    // Validate port range
+    if (isNaN(port) || port < 1024 || port > 65535) {
+      return {
+        success: false,
+        error: `Invalid port ${port}. Must be between 1024 and 65535`
+      };
+    }
+
     // Check if already running
     if (await this.isRunning()) {
       const info = this.getPidInfo();

src/shared/worker-utils.ts

@@ -1,6 +1,7 @@
 import path from "path";
 import { homedir } from "os";
 import { spawnSync } from "child_process";
+import { existsSync, writeFileSync } from "fs";
 import { logger } from "../utils/logger.js";
 import { HOOK_TIMEOUTS, getTimeout } from "./hook-constants.js";
 import { ProcessManager } from "../services/process/ProcessManager.js";
@@ -70,11 +71,17 @@ async function isWorkerHealthy(): Promise<boolean> {
  */
 async function startWorker(): Promise<boolean> {
   // Clean up legacy PM2 (one-time migration)
-  if (process.platform !== 'win32') {
+  const pm2MigratedMarker = path.join(SettingsDefaultsManager.get('CLAUDE_MEM_DATA_DIR'), '.pm2-migrated');
+
+  if (process.platform !== 'win32' && !existsSync(pm2MigratedMarker)) {
     try {
       spawnSync('pm2', ['delete', 'claude-mem-worker'], { stdio: 'ignore' });
+      // Mark migration as complete
+      writeFileSync(pm2MigratedMarker, new Date().toISOString(), 'utf-8');
+      logger.debug('SYSTEM', 'PM2 cleanup completed and marked');
     } catch {
-      // PM2 not installed or process doesn't exist - ignore
+      // PM2 not installed or process doesn't exist - still mark as migrated
+      writeFileSync(pm2MigratedMarker, new Date().toISOString(), 'utf-8');
     }
   }
 

src/types/database.ts

@@ -1,6 +1,6 @@
 /**
  * TypeScript types for database query results
- * Provides type safety for better-sqlite3 query results
+ * Provides type safety for bun:sqlite query results
  */
 
 /**