e3475180cd
- Sort within-day observations chronologically (was specificity-ordered) - Canonicalize relative paths to POSIX format before DB lookup - Skip projects param when allProjects is empty (prevents cross-project leaks) - Remove dead stderrMessage field and hook-command block (unused after permissionDecision switch) - Type permissionDecision as 'allow' | 'deny' union instead of string - Remove redundant non-null assertions in getObservationsByFilePath - Add edit guidance to deny message (use sed via Bash with smart tools) Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
113 lines
4.5 KiB
TypeScript
113 lines
4.5 KiB
TypeScript
import { readJsonFromStdin } from './stdin-reader.js';
|
|
import { getPlatformAdapter } from './adapters/index.js';
|
|
import { getEventHandler } from './handlers/index.js';
|
|
import { HOOK_EXIT_CODES } from '../shared/hook-constants.js';
|
|
import { logger } from '../utils/logger.js';
|
|
|
|
export interface HookCommandOptions {
|
|
/** If true, don't call process.exit() - let caller handle process lifecycle */
|
|
skipExit?: boolean;
|
|
}
|
|
|
|
/**
|
|
* Classify whether an error indicates the worker is unavailable (graceful degradation)
|
|
* vs a handler/client bug (blocking error that developers need to see).
|
|
*
|
|
* Exit 0 (graceful degradation):
|
|
* - Transport failures: ECONNREFUSED, ECONNRESET, EPIPE, ETIMEDOUT, fetch failed
|
|
* - Timeout errors: timed out, timeout
|
|
* - Server errors: HTTP 5xx status codes
|
|
*
|
|
* Exit 2 (blocking error — handler/client bug):
|
|
* - HTTP 4xx status codes (bad request, not found, validation error)
|
|
* - Programming errors (TypeError, ReferenceError, SyntaxError)
|
|
* - All other unexpected errors
|
|
*/
|
|
export function isWorkerUnavailableError(error: unknown): boolean {
|
|
const message = error instanceof Error ? error.message : String(error);
|
|
const lower = message.toLowerCase();
|
|
|
|
// Transport failures — worker unreachable
|
|
const transportPatterns = [
|
|
'econnrefused',
|
|
'econnreset',
|
|
'epipe',
|
|
'etimedout',
|
|
'enotfound',
|
|
'econnaborted',
|
|
'enetunreach',
|
|
'ehostunreach',
|
|
'fetch failed',
|
|
'unable to connect',
|
|
'socket hang up',
|
|
];
|
|
if (transportPatterns.some(p => lower.includes(p))) return true;
|
|
|
|
// Timeout errors — worker didn't respond in time
|
|
if (lower.includes('timed out') || lower.includes('timeout')) return true;
|
|
|
|
// HTTP 5xx server errors — worker has internal problems
|
|
if (/failed:\s*5\d{2}/.test(message) || /status[:\s]+5\d{2}/.test(message)) return true;
|
|
|
|
// HTTP 429 (rate limit) — treat as transient unavailability, not a bug
|
|
if (/failed:\s*429/.test(message) || /status[:\s]+429/.test(message)) return true;
|
|
|
|
// HTTP 4xx client errors — our bug, NOT worker unavailability
|
|
if (/failed:\s*4\d{2}/.test(message) || /status[:\s]+4\d{2}/.test(message)) return false;
|
|
|
|
// Programming errors — code bugs, not worker unavailability
|
|
// Note: TypeError('fetch failed') already handled by transport patterns above
|
|
if (error instanceof TypeError || error instanceof ReferenceError || error instanceof SyntaxError) {
|
|
return false;
|
|
}
|
|
|
|
// Default: treat unknown errors as blocking (conservative — surface bugs)
|
|
return false;
|
|
}
|
|
|
|
export async function hookCommand(platform: string, event: string, options: HookCommandOptions = {}): Promise<number> {
|
|
// Suppress stderr in hook context — Claude Code shows stderr as error UI (#1181)
|
|
// Exit 1: stderr shown to user. Exit 2: stderr fed to Claude for processing.
|
|
// All diagnostics go to log file via logger; stderr must stay clean.
|
|
const originalStderrWrite = process.stderr.write.bind(process.stderr);
|
|
process.stderr.write = (() => true) as typeof process.stderr.write;
|
|
|
|
try {
|
|
const adapter = getPlatformAdapter(platform);
|
|
const handler = getEventHandler(event);
|
|
|
|
const rawInput = await readJsonFromStdin();
|
|
const input = adapter.normalizeInput(rawInput);
|
|
input.platform = platform; // Inject platform for handler-level decisions
|
|
const result = await handler.execute(input);
|
|
const output = adapter.formatOutput(result);
|
|
|
|
console.log(JSON.stringify(output));
|
|
const exitCode = result.exitCode ?? HOOK_EXIT_CODES.SUCCESS;
|
|
if (!options.skipExit) {
|
|
process.exit(exitCode);
|
|
}
|
|
return exitCode;
|
|
} catch (error) {
|
|
if (isWorkerUnavailableError(error)) {
|
|
// Worker unavailable — degrade gracefully, don't block the user
|
|
// Log to file instead of stderr (#1181)
|
|
logger.warn('HOOK', `Worker unavailable, skipping hook: ${error instanceof Error ? error.message : error}`);
|
|
if (!options.skipExit) {
|
|
process.exit(HOOK_EXIT_CODES.SUCCESS); // = 0 (graceful)
|
|
}
|
|
return HOOK_EXIT_CODES.SUCCESS;
|
|
}
|
|
|
|
// Handler/client bug — log to file instead of stderr (#1181)
|
|
logger.error('HOOK', `Hook error: ${error instanceof Error ? error.message : error}`, {}, error instanceof Error ? error : undefined);
|
|
if (!options.skipExit) {
|
|
process.exit(HOOK_EXIT_CODES.BLOCKING_ERROR); // = 2
|
|
}
|
|
return HOOK_EXIT_CODES.BLOCKING_ERROR;
|
|
} finally {
|
|
// Restore stderr for non-hook code paths (e.g., when skipExit is true and process continues as worker)
|
|
process.stderr.write = originalStderrWrite;
|
|
}
|
|
}
|