* docs: pathfinder refactor corpus + Node 20 preflight
Adds the PATHFINDER-2026-04-22 principle-driven refactor plan (11 docs,
cross-checked PASS) plus the exploratory PATHFINDER-2026-04-21 corpus
that motivated it. Bumps engines.node to >=20.0.0 per the ingestion-path
plan preflight (recursive fs.watch). Adds the pathfinder skill.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
* refactor: land PATHFINDER Plan 01 — data integrity
Schema, UNIQUE constraints, self-healing claim, Chroma upsert fallback.
- Phase 1: fresh schema.sql regenerated at post-refactor shape.
- Phase 2: migrations 23+24 — rebuild pending_messages without
started_processing_at_epoch; UNIQUE(session_id, tool_use_id);
UNIQUE(memory_session_id, content_hash) on observations; dedup
duplicate rows before adding indexes.
- Phase 3: claimNextMessage rewritten to self-healing query using
worker_pid NOT IN live_worker_pids; STALE_PROCESSING_THRESHOLD_MS
and the 60-s stale-reset block deleted.
- Phase 4: DEDUP_WINDOW_MS and findDuplicateObservation deleted;
observations.insert now uses ON CONFLICT DO NOTHING.
- Phase 5: failed-message purge block deleted from worker-service
2-min interval; clearFailedOlderThan method deleted.
- Phase 6: repairMalformedSchema and its Python subprocess repair
path deleted from Database.ts; SQLite errors now propagate.
- Phase 7: Chroma delete-then-add fallback gated behind
CHROMA_SYNC_FALLBACK_ON_CONFLICT env flag as bridge until
Chroma MCP ships native upsert.
- Phase 8: migration 19 no-op block absorbed into fresh schema.sql.
Verification greps all return 0 matches. bun test tests/sqlite/
passes 63/63. bun run build succeeds.
Plan: PATHFINDER-2026-04-22/01-data-integrity.md
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
* refactor: land PATHFINDER Plan 02 — process lifecycle
OS process groups replace hand-rolled reapers. Worker runs until
killed; orphans are prevented by detached spawn + kill(-pgid).
- Phase 1: src/services/worker/ProcessRegistry.ts DELETED. The
canonical registry at src/supervisor/process-registry.ts is the
sole survivor; SDK spawn site consolidated into it via new
createSdkSpawnFactory/spawnSdkProcess/getSdkProcessForSession/
ensureSdkProcessExit/waitForSlot helpers.
- Phase 2: SDK children spawn with detached:true + stdio:
['ignore','pipe','pipe']; pgid recorded on ManagedProcessInfo.
- Phase 3: shutdown.ts signalProcess teardown uses
process.kill(-pgid, signal) on Unix when pgid is recorded;
Windows path unchanged (tree-kill/taskkill).
- Phase 4: all reaper intervals deleted — startOrphanReaper call,
staleSessionReaperInterval setInterval (including the co-located
WAL checkpoint — SQLite's built-in wal_autocheckpoint handles
WAL growth without an app-level timer), killIdleDaemonChildren,
killSystemOrphans, reapOrphanedProcesses, reapStaleSessions, and
detectStaleGenerator. MAX_GENERATOR_IDLE_MS and MAX_SESSION_IDLE_MS
constants deleted.
- Phase 5: abandonedTimer — already 0 matches; primary-path cleanup
via generatorPromise.finally() already lives in worker-service
startSessionProcessor and SessionRoutes ensureGeneratorRunning.
- Phase 6: evictIdlestSession and its evict callback deleted from
SessionManager. Pool admission gates backpressure upstream.
- Phase 7: SDK-failure fallback — SessionManager has zero matches
for fallbackAgent/Gemini/OpenRouter. Failures surface to hooks
via exit code 2 through SessionRoutes error mapping.
- Phase 8: ensureWorkerRunning in worker-utils.ts rewritten to
lazy-spawn — consults isWorkerPortAlive (which gates
captureProcessStartToken for PID-reuse safety via commit
99060bac), then spawns detached with unref(), then
waitForWorkerPort({ attempts: 3, backoffMs: 250 }) hand-rolled
exponential backoff 250→500→1000ms. No respawn npm dep.
- Phase 9: idle self-shutdown — zero matches for
idleCheck/idleTimeout/IDLE_MAX_MS/idleShutdown. Worker exits
only on external SIGTERM via supervisor signal handlers.
Three test files that exercised deleted code removed:
tests/worker/process-registry.test.ts,
tests/worker/session-lifecycle-guard.test.ts,
tests/services/worker/reap-stale-sessions.test.ts.
Pass count: 1451 → 1407 (-44), all attributable to deleted test
files. Zero new failures. 31 pre-existing failures remain
(schema-repair suite, logger-usage-standards, environmental
openclaw / plugin-distribution) — none introduced by Plan 02.
All 10 verification greps return 0. bun run build succeeds.
Plan: PATHFINDER-2026-04-22/02-process-lifecycle.md
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
* refactor: land PATHFINDER Plan 04 (narrowed) — search fail-fast
Phases 3, 5, 6 only. Plan-doc inaccuracies for phases 1/2/4/7/8/9
deferred for plan reconciliation:
- Phase 1/2: ObservationRow type doesn't exist; the four
"formatters" operate on three incompatible types.
- Phase 4: RECENCY_WINDOW_MS already imported from
SEARCH_CONSTANTS at every call site.
- Phase 7: getExistingChromaIds is NOT @deprecated and has an
active caller in ChromaSync.backfillMissingSyncs.
- Phase 8: estimateTokens already consolidated.
- Phase 9: knowledge-corpus rewrite blocked on PG-3
prompt-caching cost smoke test.
Phase 3 — Delete SearchManager.findByConcept/findByFile/findByType.
SearchRoutes handlers (handleSearchByConcept/File/Type) now call
searchManager.getOrchestrator().findByXxx() directly via new
getter accessors on SearchManager. ~250 LoC deleted.
Phase 5 — Fail-fast Chroma. Created
src/services/worker/search/errors.ts with ChromaUnavailableError
extends AppError(503, 'CHROMA_UNAVAILABLE'). Deleted
SearchOrchestrator.executeWithFallback's Chroma-failed
SQLite-fallback branch; runtime Chroma errors now throw 503.
"Path 3" (chromaSync was null at construction — explicit-
uninitialized config) preserved as legitimate empty-result state
per plan text. ChromaSearchStrategy.search no longer wraps in
try/catch — errors propagate.
Phase 6 — Delete HybridSearchStrategy three try/catch silent
fallback blocks (findByConcept, findByType, findByFile) at lines
~82-95, ~120-132, ~161-172. Removed `fellBack` field from
StrategySearchResult type and every return site
(SQLiteSearchStrategy, BaseSearchStrategy.emptyResult,
SearchOrchestrator).
Tests updated (Principle 7 — delete in same PR):
- search-orchestrator.test.ts: "fall back to SQLite" rewritten
as "throw ChromaUnavailableError (HTTP 503)".
- chroma/hybrid/sqlite-search-strategy tests: rewritten to
rejects.toThrow; removed fellBack assertions.
Verification: SearchManager.findBy → 0; fellBack → 0 in src/.
bun test tests/worker/search/ → 122 pass, 0 fail.
bun test (suite-wide) → 1407 pass, baseline maintained, 0 new
failures. bun run build succeeds.
Plan: PATHFINDER-2026-04-22/04-read-path.md (Phases 3, 5, 6)
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
* refactor: land PATHFINDER Plan 03 — ingestion path
Fail-fast parser, direct in-process ingest, recursive fs.watch,
DB-backed tool pairing. Worker-internal HTTP loopback eliminated.
- Phase 0: Created src/services/worker/http/shared.ts exporting
ingestObservation/ingestPrompt/ingestSummary as direct
in-process functions plus ingestEventBus (Node EventEmitter,
reusing existing pattern — no third event bus introduced).
setIngestContext wires the SessionManager dependency from
worker-service constructor.
- Phase 1: src/sdk/parser.ts collapsed to one parseAgentXml
returning { valid:true; kind: 'observation'|'summary'; data }
| { valid:false; reason: string }. Inspects root element;
<skip_summary reason="…"/> is a first-class summary case
with skipped:true. NEVER returns undefined. NEVER coerces.
- Phase 2: ResponseProcessor calls parseAgentXml exactly once,
branches on the discriminated union. On invalid → markFailed
+ logger.warn(reason). On observation → ingestObservation.
On summary → ingestSummary then emit summaryStoredEvent
{ sessionId, messageId } (consumed by Plan 05's blocking
/api/session/end).
- Phase 3: Deleted consecutiveSummaryFailures field
(ResponseProcessor + SessionManager + worker-types) and
MAX_CONSECUTIVE_SUMMARY_FAILURES constant. Circuit-breaker
guards and "tripped" log lines removed.
- Phase 4: coerceObservationToSummary deleted from sdk/parser.ts.
- Phase 5: src/services/transcripts/watcher.ts rescan setInterval
replaced with fs.watch(transcriptsRoot, { recursive: true,
persistent: true }) — Node 20+ recursive mode.
- Phase 6: src/services/transcripts/processor.ts pendingTools
Map deleted. tool_use rows insert with INSERT OR IGNORE on
UNIQUE(session_id, tool_use_id) (added by Plan 01). New
pairToolUsesByJoin query in PendingMessageStore for read-time
pairing (UNIQUE INDEX provides idempotency; explicit consumer
not yet wired).
- Phase 7: HTTP loopback at processor.ts:252 replaced with
direct ingestObservation call. maybeParseJson silent-passthrough
rewritten to fail-fast (throws on malformed JSON).
- Phase 8: src/utils/tag-stripping.ts countTags + stripTagsInternal
collapsed into one alternation regex, single-pass over input.
- Phase 9: src/utils/transcript-parser.ts (dead TranscriptParser
class) deleted. The active extractLastMessage at
src/shared/transcript-parser.ts:41-144 is the sole survivor.
Tests updated (Principle 7 — same-PR delete):
- tests/sdk/parser.test.ts + parse-summary.test.ts: rewritten
to assert discriminated-union shape; coercion-specific
scenarios collapse into { valid:false } assertions.
- tests/worker/agents/response-processor.test.ts: circuit-breaker
describe block skipped; non-XML/empty-response tests assert
fail-fast markFailed behavior.
Verification: every grep returns 0. transcript-parser.ts deleted.
bun run build succeeds. bun test → 1399 pass / 28 fail / 7 skip
(net -8 pass = the 4 retired circuit-breaker tests + 4 collapsed
parser cases). Zero new failures vs baseline.
Deferred (out of Plan 03 scope, will land in Plan 06): SessionRoutes
HTTP route handlers still call sessionManager.queueObservation
inline rather than the new shared helpers — the helpers are ready,
the route swap is mechanical and belongs with the Zod refactor.
Plan: PATHFINDER-2026-04-22/03-ingestion-path.md
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
* refactor: land PATHFINDER Plan 05 — hook surface
Worker-call plumbing collapsed to one helper. Polling replaced by
server-side blocking endpoint. Fail-loud counter surfaces persistent
worker outages via exit code 2.
- Phase 1: plugin/hooks/hooks.json — three 20-iteration `for i in
1..20; do curl -sf .../health && break; sleep 0.1; done` shell
retry wrappers deleted. Hook commands invoke their bun entry
point directly.
- Phase 2: src/shared/worker-utils.ts — added
executeWithWorkerFallback<T>(url, method, body) returning
T | { continue: true; reason?: string }. All 8 hook handlers
(observation, session-init, context, file-context, file-edit,
summarize, session-complete, user-message) rewritten to use
it instead of duplicating the ensureWorkerRunning →
workerHttpRequest → fallback sequence.
- Phase 3: blocking POST /api/session/end in SessionRoutes.ts
using validateBody + sessionEndSchema (z.object({sessionId})).
One-shot ingestEventBus.on('summaryStoredEvent') listener,
30 s timer, req.aborted handler — all share one cleanup so
the listener cannot leak. summarize.ts polling loop, plus
MAX_WAIT_FOR_SUMMARY_MS / POLL_INTERVAL_MS constants, deleted.
- Phase 4: src/shared/hook-settings.ts — loadFromFileOnce()
memoizes SettingsDefaultsManager.loadFromFile per process.
Per-handler settings reads collapsed.
- Phase 5: src/shared/should-track-project.ts — single exclusion
check entry; isProjectExcluded no longer referenced from
src/cli/handlers/.
- Phase 6: cwd validation pushed into adapter normalizeInput
(all 6 adapters: claude-code, cursor, raw, gemini-cli,
windsurf). New AdapterRejectedInput error in
src/cli/adapters/errors.ts. Handler-level isValidCwd checks
deleted from file-edit.ts and observation.ts. hook-command.ts
catches AdapterRejectedInput → graceful fallback.
- Phase 7: session-init.ts conditional initAgent guard deleted;
initAgent is idempotent. tests/hooks/context-reinjection-guard
test (validated the deleted conditional) deleted in same PR
per Principle 7.
- Phase 8: fail-loud counter at ~/.claude-mem/state/hook-failures
.json. Atomic write via .tmp + rename. CLAUDE_MEM_HOOK_FAIL_LOUD
_THRESHOLD setting (default 3). On consecutive worker-unreachable
≥ N: process.exit(2). On success: reset to 0. NOT a retry.
- Phase 9: ensureWorkerAliveOnce() module-scope memoization
wrapping ensureWorkerRunning. executeWithWorkerFallback calls
the memoized version.
Minimal validateBody middleware stub at
src/services/worker/http/middleware/validateBody.ts. Plan 06 will
expand with typed inference + error envelope conventions.
Verification: 4/4 grep targets pass. bun run build succeeds.
bun test → 1393 pass / 28 fail / 7 skip; -6 pass attributable
solely to deleted context-reinjection-guard test file. Zero new
failures vs baseline.
Plan: PATHFINDER-2026-04-22/05-hook-surface.md
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
* refactor: land PATHFINDER Plan 06 — API surface
One Zod-based validator wrapping every POST/PUT. Rate limiter,
diagnostic endpoints, and shutdown wrappers deleted. Failure-
marking consolidated to one helper.
- Phase 1 (preflight): zod@^3 already installed.
- Phase 2: validateBody middleware confirmed at canonical shape
in src/services/worker/http/middleware/validateBody.ts —
safeParse → 400 { error: 'ValidationError', issues: [...] }
on failure, replaces req.body with parsed value on success.
- Phase 3: Per-route Zod schemas declared at the top of each
route file. 24 POST endpoints across SessionRoutes,
CorpusRoutes, DataRoutes, MemoryRoutes, SearchRoutes,
LogsRoutes, SettingsRoutes now wrap with validateBody().
/api/session/end (Plan 05) confirmed using same middleware.
- Phase 4: validateRequired() deleted from BaseRouteHandler
along with every call site. Inline coercion helpers
(coerceStringArray, coercePositiveInteger) and inline
if (!req.body...) guards deleted across all route files.
- Phase 5: Rate limiter middleware and its registration deleted
from src/services/worker/http/middleware.ts. Worker binds
127.0.0.1:37777 — no untrusted caller.
- Phase 6: viewer.html cached at module init in ViewerRoutes.ts
via fs.readFileSync; served as Buffer with text/html content
type. SKILL.md + per-operation .md files cached in
Server.ts as Map<string, string>; loadInstructionContent
helper deleted. NO fs.watch, NO TTL — process restart is the
cache-invalidation event.
- Phase 7: Four diagnostic endpoints deleted from DataRoutes.ts
— /api/pending-queue (GET), /api/pending-queue/process (POST),
/api/pending-queue/failed (DELETE), /api/pending-queue/all
(DELETE). Helper methods that ONLY served them
(getQueueMessages, getStuckCount, getRecentlyProcessed,
clearFailed, clearAll) deleted from PendingMessageStore.
KEPT: /api/processing-status (observability), /health
(used by ensureWorkerRunning).
- Phase 8: stopSupervisor wrapper deleted from supervisor/index.ts.
GracefulShutdown now calls getSupervisor().stop() directly.
Two functions retained with clear roles:
- performGracefulShutdown — worker-side 6-step shutdown
- runShutdownCascade — supervisor-side child teardown
(process.kill(-pgid), Windows tree-kill, PID-file cleanup)
Each has unique non-trivial logic and a single canonical caller.
- Phase 9: transitionMessagesTo(status, filter) is the sole
failure-marking path on PendingMessageStore. Old methods
markSessionMessagesFailed and markAllSessionMessagesAbandoned
deleted along with all callers (worker-service,
SessionCompletionHandler, tests/zombie-prevention).
Tests updated (Principle 7 same-PR delete): coercion test files
refactored to chain validateBody → handler. Zombie-prevention
tests rewritten to call transitionMessagesTo.
Verification: all 4 grep targets → 0. bun run build succeeds.
bun test → 1393 pass / 28 fail / 7 skip — exact match to
baseline. Zero new failures.
Plan: PATHFINDER-2026-04-22/06-api-surface.md
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
* refactor: land PATHFINDER Plan 07 — dead code sweep
ts-prune-driven sweep across the tree after Plans 01-06 landed.
Deleted unused exports, orphan helpers, and one fully orphaned
file. Earlier-plan deletions verified.
Deleted:
- src/utils/bun-path.ts (entire file — getBunPath, getBunPathOrThrow,
isBunAvailable: zero importers)
- bun-resolver.getBunVersionString: zero callers
- PendingMessageStore.retryMessage / resetProcessingToPending /
abortMessage: superseded by transitionMessagesTo (Plan 06 Phase 9)
- EnvManager.MANAGED_CREDENTIAL_KEYS, EnvManager.setCredential:
zero callers
- CodexCliInstaller.checkCodexCliStatus: zero callers; no status
command exists in npx-cli
- Two "REMOVED: cleanupOrphanedSessions" stale-fence comments
Kept (with documented justification):
- Public API surface in dist/sdk/* (parseAgentXml, prompt
builders, ParsedObservation, ParsedSummary, ParseResult,
SUMMARY_MODE_MARKER) — exported via package.json sdk path.
- generateContext / loadContextConfig / token utilities — used
via dynamic await import('../../../context-generator.js') in
worker SearchRoutes.
- MCP_IDE_INSTALLERS, install/uninstall functions for codex/goose
— used via dynamic await import in npx-cli/install.ts +
uninstall.ts (ts-prune cannot trace dynamic imports).
- getExistingChromaIds — active caller in
ChromaSync.backfillMissingSyncs (Plan 04 narrowed scope).
- processPendingQueues / getSessionsWithPendingMessages — active
orphan-recovery caller in worker-service.ts plus
zombie-prevention test coverage.
- StoreAndMarkCompleteResult legacy alias — return-type annotation
in same file.
- All Database.ts barrel re-exports — used downstream.
Earlier-plan verification:
- Plan 03 Phase 9: VERIFIED — src/utils/transcript-parser.ts
is gone; TranscriptParser has 0 references in src/.
- Plan 01 Phase 8: VERIFIED — migration 19 no-op absorbed.
- SessionStore.ts:52-70 consolidation NOT executed (deferred):
the methods are not thin wrappers but ~900 LoC of bodies, and
two methods are documented as intentional mirrors so the
context-generator.cjs bundle stays schema-consistent without
pulling MigrationRunner. Deserves its own plan, not a sweep.
Verification: TranscriptParser → 0; transcript-parser.ts → gone;
no commented-out code markers remain. bun run build succeeds.
bun test → 1393 pass / 28 fail / 7 skip — EXACT match to
baseline. Zero regressions.
Plan: PATHFINDER-2026-04-22/07-dead-code.md
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
* chore: remove residual ProcessRegistry comment reference
Plan 07 dead-code sweep missed one comment-level reference to the
deleted in-memory ProcessRegistry class in SessionManager.ts:347.
Rewritten to describe the supervisor.json scope without naming the
deleted class, completing the verification grep target.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
* fix: address Greptile review (P1 + 2× P2)
P1 — Plan 05 Phase 3 blocking endpoint was non-functional:
executeWithWorkerFallback used HEALTH_CHECK_TIMEOUT_MS (3 s) for
the POST /api/session/end call, but the server holds the
connection for SERVER_SIDE_SUMMARY_TIMEOUT_MS (30 s). Client
always raced to a "timed out" rejection that isWorkerUnavailable
classified as worker-unreachable, so the hook silently degraded
instead of waiting for summaryStoredEvent.
- Added optional timeoutMs to executeWithWorkerFallback,
forwarded to workerHttpRequest.
- summarize.ts call site now passes 35_000 (5 s above server
hold window).
P2 — ingestSummary({ kind: 'parsed' }) branch was dead code:
ResponseProcessor emitted summaryStoredEvent directly via the
event bus, bypassing the centralized helper that the comment
claimed was the single source.
- ResponseProcessor now calls ingestSummary({ kind: 'parsed',
sessionDbId, messageId, contentSessionId, parsed }) so the
event-emission path is single-sourced.
- ingestSummary's requireContext() resolution moved inside the
'queue' branch (the only branch that needs sessionManager /
dbManager). 'parsed' is a pure event-bus emission and
doesn't need worker-internal context — fixes mocked
ResponseProcessor unit tests that don't call
setIngestContext.
P2 — isWorkerFallback could false-positive on legitimate API
responses whose schema includes { continue: true, ... }:
- Added a Symbol.for('claude-mem/worker-fallback') brand to
WorkerFallback. isWorkerFallback now checks the brand, not
a duck-typed property name.
Verification: bun run build succeeds. bun test → 1393 pass /
28 fail / 7 skip — exact baseline match. Zero new failures.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
* fix: address Greptile iteration 2 (P1 + P2)
P1 — summaryStoredEvent fired regardless of whether the row was
persisted. ResponseProcessor's call to ingestSummary({ kind:
'parsed' }) ran for every parsed.kind === 'summary' even when
result.summaryId came back null (e.g. FK violation, null
memory_session_id at commit). The blocking /api/session/end
endpoint then returned { ok: true } and the Stop hook logged
'Summary stored' for a non-existent row.
- Gate ingestSummary call on (parsed.data.skipped ||
session.lastSummaryStored). Skipped summaries are an explicit
no-op bypass and still confirm; real summaries only confirm
when storage actually wrote a row.
- Non-skipped + summaryId === null path logs a warn and lets
the server-side timeout (504) surface to the hook instead of
a false ok:true.
P2 — PendingMessageStore.enqueue() returns 0 when INSERT OR
IGNORE suppresses a duplicate (the UNIQUE(session_id, tool_use_id)
constraint added by Plan 01 Phase 1). The two callers
(SessionManager.queueObservation and queueSummarize) previously
logged 'ENQUEUED messageId=0' which read like a row was inserted.
- Branch on messageId === 0 and emit a 'DUP_SUPPRESSED' debug
log instead of the misleading ENQUEUED line. No behavior
change — the duplicate is still correctly suppressed by the
DB (Principle 3); only the log surface is corrected.
- confirmProcessed is never called with the enqueue() return
value (it operates on session.processingMessageIds[] from
claimNextMessage), so no caller is broken; the visibility
fix prevents future misuse.
Verification: bun run build succeeds. bun test → 1393 pass /
28 fail / 7 skip — exact baseline match. Zero new failures.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
* fix: address Greptile iteration 3 (P1 + 2× P2)
- P1 worker-service.ts: wire ensureGeneratorRunning into the ingest
context after SessionRoutes is constructed. setIngestContext runs
before routes exist, so transcript-watcher observations queued via
ingestObservation() had no way to auto-start the SDK generator.
Added attachIngestGeneratorStarter() to patch the callback in.
- P2 shared.ts: IngestEventBus now sets maxListeners to 0. Concurrent
/api/session/end calls register one listener each and clean up on
completion, so the default-10 warning fires spuriously under normal
load.
- P2 SessionRoutes.ts: handleObservationsByClaudeId now delegates to
ingestObservation() instead of duplicating skip-tool / meta /
privacy / queue logic. Single helper, matching the Plan 03 goal.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
* fix: address Greptile iteration 4 (P1 tool-pair + P2 parse/path/doc)
- processor.handleToolResult: restore in-memory tool-use→tool-result
pairing via session.pendingTools for schemas (e.g. Codex) whose
tool_result events carry only tool_use_id + output. Without this,
neither handler fired — all tool observations silently dropped.
- processor.maybeParseJson: return raw string on parse failure instead
of throwing. Previously a single malformed JSON-shaped field caused
handleLine's outer catch to discard the entire transcript line.
- watcher.deepestNonGlobAncestor: split on / and \\, emit empty string
for purely-glob inputs so the caller skips the watch instead of
anchoring fs.watch at the filesystem root. Windows-compatible.
- PendingMessageStore.enqueue: tighten docstring — callers today only
log on the returned id; the SessionManager branches on id === 0.
* fix: forward tool_use_id through ingestObservation (Greptile iter 5)
P1 — Plan 01's UNIQUE(content_session_id, tool_use_id) dedup never
fired because the new shared ingest path dropped the toolUseId before
queueObservation. SQLite treats NULL values as distinct for UNIQUE,
so every replayed transcript line landed a duplicate row.
- shared.ingestObservation: forward payload.toolUseId to
queueObservation so INSERT OR IGNORE can actually collapse.
- SessionRoutes.handleObservationsByClaudeId: destructure both
tool_use_id (HTTP convention) and toolUseId (JS convention) from
req.body and pass into ingestObservation.
- observationsByClaudeIdSchema: declare both keys explicitly so the
validator doesn't rely on .passthrough() alone.
* fix: drop dead pairToolUsesByJoin, close session-end listener race
- PendingMessageStore: delete pairToolUsesByJoin. The method was never
called and its self-join semantics are structurally incompatible
with UNIQUE(content_session_id, tool_use_id): INSERT OR IGNORE
collapses any second row with the same pair, so a self-join can
only ever match a row to itself. In-memory pendingTools in
processor.ts remains the pairing path for split-event schemas.
- IngestEventBus: retain a short-lived (60s) recentStored map keyed
by sessionId. Populated on summaryStoredEvent emit, evicted on
consume or TTL.
- handleSessionEnd: drain the recent-events buffer before attaching
the listener. Closes the register-after-emit race where the summary
can persist between the hook's summarize POST and its session/end
POST — previously that window returned 504 after the 30s timeout.
* chore: merge origin/main into vivacious-teeth
Resolves conflicts with 15 commits on main (v12.3.9, security
observation types, Telegram notifier, PID-reuse worker start-guard).
Conflict resolution strategy:
- plugin/hooks/hooks.json, plugin/scripts/*.cjs, plugin/ui/viewer-bundle.js:
kept ours — PATHFINDER Plan 05 deletes the for-i-in-1-to-20 curl retry
loops and the built artifacts regenerate on build.
- src/cli/handlers/summarize.ts: kept ours — Plan 05 blocking
POST /api/session/end supersedes main's fire-and-forget path.
- src/services/worker-service.ts: kept ours — Plan 05 ingest bus +
summaryStoredEvent supersedes main's SessionCompletionHandler DI
refactor + orphan-reaper fallback.
- src/services/worker/http/routes/SessionRoutes.ts: kept ours — same
reason; generator .finally() Stop-hook self-clean is a guard for a
path our blocking endpoint removes.
- src/services/worker/http/routes/CorpusRoutes.ts: merged — added
security_alert / security_note to ALLOWED_CORPUS_TYPES (feature from
#2084) while preserving our Zod validateBody schema.
Typecheck: 294 errors (vs 298 pre-merge). No new errors introduced; all
remaining are pre-existing (Component-enum gaps, DOM lib for viewer,
bun:sqlite types).
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
* fix: address Greptile P2 findings
1) SessionRoutes.handleSessionEnd was the only route handler not wrapped
in wrapHandler — synchronous exceptions would hang the client rather
than surfacing as 500s. Wrap it like every other handler.
2) processor.handleToolResult only consumed the session.pendingTools
entry when the tool_result arrived without a toolName. In the
split-schema path where tool_result carries both toolName and toolId,
the entry was never deleted and the map grew for the life of the
session. Consume the entry whenever toolId is present.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
* fix: typing cleanup and viewer tsconfig split for PR feedback
- Add explicit return types for SessionStore query methods
- Exclude src/ui/viewer from root tsconfig, give it its own DOM-typed config
- Add bun to root tsconfig types, plus misc typing tweaks flagged by Greptile
- Rebuilt plugin/scripts/* artifacts
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
* fix: address Greptile P2 findings (iter 2)
- PendingMessageStore.transitionMessagesTo: require sessionDbId (drop
the unscoped-drain branch that would nuke every pending/processing
row across all sessions if a future caller omitted the filter).
- IngestEventBus.takeRecentSummaryStored: make idempotent — keep the
cached event until TTL eviction so a retried Stop hook's second
/api/session/end returns immediately instead of hanging 30 s.
- TranscriptWatcher fs.watch callback: skip full glob scan for paths
already tailed (JSONL appends fire on every line; only unknown
paths warrant a rescan).
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
* fix: call finalizeSession in terminal session paths (Greptile iter 3)
terminateSession and runFallbackForTerminatedSession previously called
SessionCompletionHandler.finalizeSession before removeSessionImmediate;
the refactor dropped those calls, leaving sdk_sessions.status='active'
for every session killed by wall-clock limit, unrecoverable error, or
exhausted fallback chain. The deleted reapStaleSessions interval was
the only prior backstop.
Re-wires finalizeSession (idempotent: marks completed, drains pending,
broadcasts) into both paths; no reaper reintroduced.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
* fix: GC failed pending_messages rows at startup (Greptile iter 4)
Plan 07 deleted clearFailed/clearFailedOlderThan as "dead code", but
with the periodic sweep also removed, nothing reaps status='failed'
rows now — they accumulate indefinitely. Since claimNextMessage's
self-healing subquery scans this table, unbounded growth degrades
claim latency over time.
Re-introduces clearFailedOlderThan and calls it once at worker startup
(not a reaper — one-shot, idempotent). 7-day retention keeps enough
history for operator inspection while bounding the table.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
* fix: finalize sessions on normal exit; cleanup hoist; share handler (iter 5)
1. startSessionProcessor success branch now calls completionHandler.
finalizeSession before removeSessionImmediate. Hooks-disabled installs
(and any Stop hook that fails before POST /api/sessions/complete) no
longer leave sdk_sessions rows as status='active' forever. Idempotent
— a subsequent /api/sessions/complete is a no-op.
2. Hoist SessionRoutes.handleSessionEnd cleanup declaration above the
closures that reference it (TDZ safety; safe at runtime today but
fragile if timeout ever shrinks).
3. SessionRoutes now receives WorkerService's shared SessionCompletionHandler
instead of constructing its own — prevents silent divergence if the
handler ever becomes stateful.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
* fix: stop runaway crash-recovery loop on dead sessions
Two distinct bugs were combining to keep a dead session restarting forever:
Bug 1 (uncaught "The operation was aborted."):
child_process.spawn emits 'error' asynchronously for ENOENT/EACCES/abort
signal aborts. spawnSdkProcess() never attached an 'error' listener, so
any async spawn failure became uncaughtException and escaped to the
daemon-level handler. Attach an 'error' listener immediately after spawn,
before the !child.pid early-return, so async spawn errors are logged
(with errno code) and swallowed locally.
Bug 2 (sliding-window limiter never trips on slow restart cadence):
RestartGuard tripped only when restartTimestamps.length exceeded
MAX_WINDOWED_RESTARTS (10) within RESTART_WINDOW_MS (60s). With the 8s
exponential-backoff cap, only ~7-8 restarts fit in the window, so a dead
session that fail-restart-fail-restart on 8s cycles would loop forever
(consecutiveRestarts climbing past 30+ in observed logs). Add a
consecutiveFailures counter that increments on every restart and resets
only on recordSuccess(). Trip when consecutive failures exceed
MAX_CONSECUTIVE_FAILURES (5) — meaning 5 restarts with zero successful
processing in between proves the session is dead. Both guards now run in
parallel: tight loops still trip the windowed cap; slow loops trip the
consecutive-failure cap.
Also: when the SessionRoutes path trips the guard, drain pending messages
to 'abandoned' so the session does not reappear in
getSessionsWithPendingMessages and trigger another auto-start cycle. The
worker-service.ts path already does this via terminateSession.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
* perf: streamline worker startup and consolidate database connections
1. Database Pooling: Modified DatabaseManager, SessionStore, and SessionSearch to share a single bun:sqlite connection, eliminating redundant file descriptors.
2. Non-blocking Startup: Refactored WorktreeAdoption and Chroma backfill to run in the background (fire-and-forget), preventing them from stalling core initialization.
3. Diagnostic Routes: Added /api/chroma/status and bypassed the initialization guard for health/readiness endpoints to allow diagnostics during startup.
4. Robust Search: Implemented reliable SQLite FTS5 fallback in SearchManager for when Chroma (uvx) fails or is unavailable.
5. Code Cleanup: Removed redundant loopback MCP checks and mangled initialization logic from WorkerService.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
* fix: hard-exclude observer-sessions from hooks; bundle migration 29 (#2124)
* fix: hard-exclude observer-sessions from hooks; backfill bundle migrations
Stop hook + SessionEnd hook were storing the SDK observer's own
init/continuation/summary prompts in user_prompts, leaking into the
viewer (meta-observation regression). 25 such rows accumulated.
- shouldTrackProject: hard-reject OBSERVER_SESSIONS_DIR (and its subtree)
before consulting user-configured exclusion globs.
- summarize.ts (Stop) and session-complete.ts (SessionEnd): early-return
when shouldTrackProject(cwd) is false, so the observer's own hooks
cannot bootstrap the worker or queue a summary against the meta-session.
- SessionRoutes: cap user-prompt body at 256 KiB at the session-init
boundary so a runaway observer prompt cannot blow up storage.
- SessionStore: add migration 29 (UNIQUE(memory_session_id, content_hash)
on observations) inline so bundled artifacts (worker-service.cjs,
context-generator.cjs) stay schema-consistent — without it, the
ON CONFLICT clause in observation inserts throws.
- spawnSdkProcess: stdio[stdin] from 'ignore' to 'pipe' so the
supervisor can actually feed the observer's stdin.
Also rebuilds plugin/scripts/{worker-service,context-generator}.cjs.
* fix: walk back to UTF-8 boundary on prompt truncation (Greptile P2)
Plain Buffer.subarray at MAX_USER_PROMPT_BYTES can land mid-codepoint,
which the utf8 decoder silently rewrites to U+FFFD. Walk back over any
continuation bytes (0b10xxxxxx) before decoding so the truncated prompt
ends on a valid sequence boundary instead of a replacement character.
* fix: cross-platform observer-dir containment; clarify SDK stdin pipe
claude-review feedback on PR #2124.
- shouldTrackProject: literal `cwd.startsWith(OBSERVER_SESSIONS_DIR + '/')`
hard-coded a POSIX separator and missed Windows backslash paths plus any
trailing-slash variance. Switched to a path.relative-based isWithin()
helper so Windows hook input under observer-sessions\\... is also excluded.
- spawnSdkProcess: added a comment explaining why stdin must be 'pipe' —
SpawnedSdkProcess.stdin is typed NonNullable and the Claude Agent SDK
consumes that pipe; 'ignore' would null it and the null-check below
would tear the child down on every spawn.
* fix: make Stop hook fire-and-forget; remove dead /api/session/end
The Stop hook was awaiting a 35-second long-poll on /api/session/end,
which the worker held open until the summary-stored event fired (or its
30s server-side timeout elapsed). Followed by another await on
/api/sessions/complete. Three sequential awaits, the middle one a 30s
hold — not fire-and-forget despite repeated requests.
The Stop hook now does ONE thing: POST /api/sessions/summarize to
queue the summary work and return. The worker drives the rest async.
Session-map cleanup is performed by the SessionEnd handler
(session-complete.ts), not duplicated here.
- summarize.ts: drop the /api/session/end long-poll and the trailing
/api/sessions/complete await; ~40 lines removed; unused
SessionEndResponse interface gone; header comment rewritten.
- SessionRoutes: delete handleSessionEnd, sessionEndSchema, the
SERVER_SIDE_SUMMARY_TIMEOUT_MS constant, and the /api/session/end
route registration. Drop the now-unused ingestEventBus and
SummaryStoredEvent imports.
- ResponseProcessor + shared.ts + worker-utils.ts: update stale
comments that referenced the dead endpoint. The IngestEventBus is
left in place dormant (no listeners) for follow-up cleanup so this
PR stays focused on the blocker.
Bundle artifact (worker-service.cjs) rebuilt via build-and-sync.
Verification:
- grep '/api/session/end' plugin/scripts/worker-service.cjs → 0
- grep 'timeoutMs:35' plugin/scripts/worker-service.cjs → 0
- Worker restarted clean, /api/health ok at pid 92368
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
* deps: bump all dependencies to latest including majors
Upgrades: React 18→19, Express 4→5, Zod 3→4, TypeScript 5→6,
@types/node 20→25, @anthropic-ai/claude-agent-sdk 0.1→0.2,
@clack/prompts 0.9→1.2, plus minors. Adds Daily Maintenance section
to CLAUDE.md mandating latest-version policy across manifests.
Express 5 surfaced a race in Server.listen() where the 'error' handler
was attached after listen() was invoked; refactored to use
http.createServer with both 'error' and 'listening' handlers attached
before listen(), restoring port-conflict rejection semantics.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
* fix: surface real chroma errors and add deep status probe
Replace the misleading "Vector search failed - semantic search unavailable.
Install uv... restart the worker." string in SearchManager with the actual
exception text from chroma_query_documents. The lying message blamed `uv`
for any failure — even when the real cause was a chroma-mcp transport
timeout, an empty collection, or a dead subprocess.
Also add /api/chroma/status?deep=1 backed by a new
ChromaMcpManager.probeSemanticSearch() that round-trips a real query
(chroma_list_collections + chroma_query_documents) instead of just
checking the stdio handshake. The cheap default path is unchanged.
Includes the diagnostic plan (PLAN-fix-mcp-search.md) and updated test
fixtures for the new structured failure message.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
* chore: rebuild worker-service bundle to match merged src
Bundle was stale after the squash merge of #2124 — it still contained
the old "Install uv... semantic search unavailable" string and lacked
probeSemanticSearch. Rebuilt via bun run build-and-sync.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
* docs: address coderabbit feedback on PLAN-fix-mcp-search.md
- replace machine-specific /Users/alexnewman absolute paths with portable
<repo-root> placeholder (MD-style portability)
- add blank lines around the TypeScript fenced block (MD031)
- tag the bare fenced block with `text` (MD040)
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
29 KiB
PATHFINDER-2026-04-22 Rewrite Plan
Purpose: Execute a clean rewrite of the claude-mem refactor corpus, replacing PATHFINDER-2026-04-21/ with a principle-driven 8-plan corpus. Each phase can be executed consecutively in a fresh chat context.
Inputs (already in this directory):
_reference.md— verified current-code anchors + external API signatures_mapping.md— section-by-section migration map from old → new
Outputs (to be produced by executing this plan):
00-principles.md— unifying criteria every plan is measured against01-data-integrity.md— UNIQUE constraints, idempotency, self-healing claim02-process-lifecycle.md— delete supervisor, lazy-spawn, process groups03-ingestion-path.md— fail-fast parser, direct ingest, recursive fs.watch04-read-path.md— 1 renderer, 1 search path, delete SearchManager.findBy*05-hook-surface.md— fail-loud hooks, blocking endpoint, cached alive06-api-surface.md— Zod middleware, delete diagnostic endpoints07-dead-code.md— TranscriptParser class, migration 19, @deprecated sweep98-execution-order.md— DAG + preflight gates + post-landing greps99-verification.md— grep targets, acceptance criteria, viewer lockdown
Target lines deleted across the corpus: ~3,800 LoC net, after double-count correction.
Global principles (cite in every plan)
- No recovery code for fixable failures. If the primary path is correct, recovery never runs. If it's broken, recovery hides the bug.
- Fail-fast over grace-degrade. Local code does not circuit-break, coerce, or silently fall back. It throws and lets the caller decide.
- UNIQUE constraint over dedup window. DB schema prevents duplicates; don't time-gate them.
- Event-driven over polling.
fs.watchoversetIntervalrescan. Server-side wait over client-side poll.child.on('exit')over periodic scan. - OS-supervised process groups over hand-rolled reapers.
detached: true+kill(-pgid)replaces orphan sweeps. - One helper, N callers. Not N copies of a helper. Not a strategy class for each config.
- Delete code in the same PR it becomes unused. No
@deprecatedfence, no "remove next release."
These are repeated verbatim in 00-principles.md. Every other plan cites them.
Anti-pattern guards (check in every plan)
- No new
setIntervalinsrc/services/worker/or the plan text (plan 99 greps for this) - No new
coerce*,recover*,heal*,repair*,reap*,kill*Orphans*function names - No new try/catch that swallows errors and returns a fallback value
- No new schema column whose only purpose is to feed a recovery query
- No new strategy class when a config object would do
- No new HTTP endpoint for diagnostic / manual-repair purposes
Phase 0 — Documentation discovery (DONE)
Status: Complete. See _reference.md (API + code anchors) and _mapping.md (old→new section mapping). Phase 0 subagents verified 12 old plans, every audit-cited file:line, every external API in use.
Phase 1 — Write 00-principles.md
Task: Draft the principles document that every other plan cites.
Sections:
- The seven principles (copy verbatim from "Global principles" section above)
- The six anti-pattern guards (copy verbatim from "Anti-pattern guards" above)
- The unifying diagnosis (one paragraph): missing primary-path correctness gets papered over with defensive code; defensive code hides bugs in the primary path; hidden bugs spawn more defensive code. Same disease, five organs.
- Five cures table: one row per subsystem (lifecycle, data, search, ingestion, hooks) stating the concrete cure from the principles.
- Glossary: "second-system effect," "lease pattern," "self-healing claim," "fail-fast contract" — one-sentence definitions with the canonical example.
Doc refs: none outside this plan — 00-principles.md is the anchor every other plan cites.
Verification:
- File exists at
PATHFINDER-2026-04-22/00-principles.md - Seven principles are numbered and quotable
- Five cures table has all five subsystems
- Glossary has one-sentence definitions for the four terms
Anti-pattern guards for this phase:
- Don't add principles that don't have a cure in the table
- Don't add cures for problems not in the audit
- Don't add a "see also" subsection — principles stand alone
Phase 2 — Write 01-data-integrity.md + 02-process-lifecycle.md
These two plans define the tectonic primitives other plans depend on. Both run in the same phase because they're the foundation.
2A. 01-data-integrity.md
Task: Draft the data-layer plan covering schema UNIQUE constraints, idempotency tokens, self-healing claim query, Chroma sync, migration cleanup.
Phases inside this plan:
- Fresh
schema.sql— regenerate from current migrations, removestarted_processing_at_epochcolumn, addworker_pid INTEGER, addUNIQUE(session_id, tool_use_id)onpending_messages, addUNIQUE(memory_session_id, content_hash)onobservations. - Migrate existing databases — ALTER TABLE for the new columns, backfill, create UNIQUE indexes.
- Self-healing claim query — replace 60-s stale-reset-inside-claim with
UPDATE pending_messages SET worker_pid=?, status='processing' WHERE status='pending' OR (status='processing' AND worker_pid NOT IN live_worker_pids) ORDER BY created_at_epoch LIMIT 1. DeleteSTALE_PROCESSING_THRESHOLD_MS, deletestarted_processing_at_epochcolumn. - Delete dedup window — remove
DEDUP_WINDOW_MS+findDuplicateObservation; replace withINSERT … ON CONFLICT DO NOTHING. - Delete
clearFailedOlderThaninterval — failed rows are a retention policy question. Make them a query-time filter (WHERE status != 'failed' OR updated_at > now-1h) or just let them accumulate until a user explicitly purges. - Delete
repairMalformedSchemaPython subprocess — root-cause WAL corruption if it recurs; do not ship repair code. - Chroma sync — upsert semantics — document delete-then-add as a bridge pattern; gate behind
CHROMA_SYNC_FALLBACK_ON_CONFLICT=trueflag; remove once Chroma MCP adds upsert natively. - Delete migration 19 no-op — absorbed into the fresh
schema.sql.
Doc refs: _reference.md Part 1 §Data layer + §Chroma sync; SQLite docs on ON CONFLICT DO NOTHING + UNIQUE on added columns; migration 22 precedent in runner.ts:658-837.
Verification:
grep -n STALE_PROCESSING_THRESHOLD_MS src/→ 0grep -n started_processing_at_epoch src/→ 0grep -n DEDUP_WINDOW_MS src/→ 0grep -n findDuplicateObservation src/→ 0grep -n repairMalformedSchema src/→ 0grep -n clearFailedOlderThan src/services/worker-service.ts→ 0 (interval deletion)- Integration test: kill worker mid-claim; next worker's claim succeeds and row is re-processed
Anti-pattern guards:
- Do NOT keep
recoverStuckProcessing()as a boot-once function. Self-healing claim replaces it entirely. - Do NOT add a new timer for Chroma backfill. Backfill runs at boot-once OR on-demand when a downstream reader requests.
- Do NOT add "repair" CLI commands.
2B. 02-process-lifecycle.md
Task: Draft the lifecycle plan: delete src/supervisor/, lazy-spawn from hooks, process groups for SDK children, no reapers, no idle-shutdown.
Phases inside this plan:
- Delete
src/services/worker/ProcessRegistry.ts(the worker-side parallel registry). Consolidate tosrc/supervisor/process-registry.ts. - Change SDK spawn to use process groups —
src/services/worker/ProcessRegistry.ts:452-465(to be moved to supervisor):spawn(cmd, args, { detached: true, stdio: ['ignore','pipe','pipe'] }). Trackpgid = proc.pid. - Change shutdown cascade to kill groups —
src/supervisor/shutdown.ts:116, 163:process.kill(-record.pgid, 'SIGTERM')→ wait 5s →process.kill(-record.pgid, 'SIGKILL'). - Delete all reaper intervals —
startOrphanReaper,staleSessionReaperInterval,clearFailedOlderThaninterval atworker-service.ts:537, 547, 567. DeletekillSystemOrphans,killIdleDaemonChildren,reapOrphanedProcesses,reapStaleSessions. - Delete the
abandonedTimerper-session setTimeout — replace with synchronous cleanup ingeneratorPromise.finallyat the session itself. - Delete idle-eviction —
SessionManager.evictIdlestSessionat:477-506. Pool backpressure via queue depth instead. - Delete fallback agent chain (Gemini → OpenRouter) in SessionManager. Fail-fast on SDK failure; surface to hook via exit 2.
- Lazy-spawn wrapper — every hook's
ensureWorkerRunning()(src/shared/worker-utils.ts:221-239): check port → if dead,spawn(bunPath, [workerPath], { detached: true, stdio: ['ignore','ignore','ignore'] })→proc.unref()→ return. Optionalrespawndep for 3-attempt startup retry with backoff. - Delete worker self-shutdown — no idle timer. Worker runs until killed.
Doc refs: _reference.md Part 1 §Worker/lifecycle + Part 2 API verification rows 1-3 (Node detached, kill(-pgid)); commit 99060bac for PID-reuse pattern.
Verification:
grep -rn setInterval src/services/worker/→ 0grep -rn startOrphanReaper src/→ 0grep -rn staleSessionReaperInterval src/→ 0grep -rn killSystemOrphans src/→ 0grep -rn killIdleDaemonChildren src/→ 0grep -rn reapStaleSessions src/→ 0grep -rn reapOrphanedProcesses src/→ 0grep -rn evictIdlestSession src/→ 0grep -rn abandonedTimer src/→ 0grep -rn "fallbackAgent\|Gemini\|OpenRouter" src/services/worker/SessionManager.ts→ 0src/services/worker/ProcessRegistry.tsfile does NOT existsrc/supervisor/directory DOES still exist (canonical registry + shutdown)- Integration test: kill worker via
kill -9 <pid>; next hook respawns worker; no orphan children remain - Integration test: graceful SIGTERM to worker; all SDK children exit within 6s
Anti-pattern guards:
- Do NOT keep
killSystemOrphansas a boot-once function — orphans are PREVENTED by process groups, not swept. - Do NOT add idle-timer self-shutdown to the worker.
- Do NOT introduce a third process registry during the migration.
Phase 3 — Write 03-ingestion-path.md + 04-read-path.md
3A. 03-ingestion-path.md
Task: Draft the ingestion plan: fail-fast parser, direct ingestObservation() call, recursive fs.watch, DB-backed tool pairing, single-regex tag strip, delete TranscriptParser dead class.
Phases inside this plan:
0. Ingest helpers (prerequisite for plans 05, 06, 07) — ingestObservation(payload), ingestPrompt(payload), ingestSummary(payload) as direct functions on the worker. No HTTP loopback.
parseAgentXml— single entry point returning{ valid: true, data } | { valid: false, reason }discriminated union. ReplacesparseObservations+parseSummary+coerceObservationToSummary.- ResponseProcessor migration — call
parseAgentXmlonce; on invalid,markFailed(messageId, reason). On valid summary, emitsummaryStoredEvent(consumed by05-hook-surface.mdblocking endpoint). - Delete circuit breaker —
consecutiveSummaryFailures,MAX_CONSECUTIVE_SUMMARY_FAILURES, SessionManager guards on it. - Delete coerce function —
coerceObservationToSummaryinsrc/sdk/parser.ts:222-259removed entirely. - Recursive
fs.watch—src/services/transcripts/watcher.ts:124-132replaces 5-s rescansetIntervalwithfs.watch(transcriptsRoot, { recursive: true }). Preflight:engines.node >= 20.0.0. - DB-backed tool pairing — delete
pendingToolsMap atprocessor.ts:23. Insert bothtool_useandtool_resultrows intopending_messageswithUNIQUE(session_id, tool_use_id)constraint. Pair by JOIN at read time. - Direct
ingestObservation—processor.ts:252calls the helper from Phase 0, notobservationHandler.execute(). - Single-regex tag strip — consolidate
src/utils/tag-stripping.tscountTags/stripTagsInternalto one regex with alternation. - Delete dead
TranscriptParserclass —src/utils/transcript-parser.ts:28-90.
Doc refs: _reference.md Part 1 §Ingestion; old Plan 01/03/08 for prior work; fs.watch Node 20+ release notes.
Verification:
grep -n coerceObservationToSummary src/→ 0grep -n consecutiveSummaryFailures src/→ 0grep -n "pendingTools" src/services/transcripts/→ 0grep -n "setInterval" src/services/transcripts/watcher.ts→ 0grep -n "observationHandler.execute" src/services/transcripts/→ 0grep -n "TranscriptParser" src/utils/transcript-parser.ts→ file does not existpackage.jsonengines.node ≥ 20.0.0- Fuzz test: drop JSONL with
tool_usebut notool_result→ row stays pending, no pair emitted, no crash - Fuzz test: drop JSONL with
tool_resultreferencing unknowntool_use_id→ debug log, no crash, no phantom observation
Anti-pattern guards:
- Do NOT keep coercion as a "lenient mode" flag.
- Do NOT ship a polling fallback for
fs.watch— Node 20+ handles recursive Linux natively. - Do NOT preserve the in-memory Map behind a feature flag.
3B. 04-read-path.md
Task: Draft the read-path plan: one renderer with strategy config, one search path, delete SearchManager.findBy*, consolidate recency filter, throw 503 on Chroma failure.
Phases inside this plan:
renderObservations(obs, strategy: RenderStrategy)— single function replacingAgentFormatter,HumanFormatter,ResultFormatter,CorpusRenderer.RenderStrategyis a config object with knobs:header,grouping,rowDensity,colors,columns.- Delete four formatter classes —
src/services/context/formatters/*.tsreplaced by four configs passed torenderObservations. - Delete SearchManager duplicated methods —
findByConcept,findByFile,findByTypeatSearchManager.ts:1209-1310, 1277, 1399. Route all calls throughSearchOrchestrator. - Consolidate recency filter — import
RECENCY_WINDOW_MSfromtypes.ts:16into every call site. Delete all seven hand-rolled copies in SearchManager. - Fail-fast Chroma —
SearchOrchestrator.ts:85-110throws 503 on Chroma error instead of stripping query and re-querying SQLite.ChromaSearchStrategy.ts:76-86returnsusedChroma: falseonly when Chroma is explicitly uninitialized; propagates real errors. - Delete hybrid silent fallbacks —
HybridSearchStrategy.ts:82-95, 120-134, 161-173: propagate errors instead of returning metadata-only. - Delete
@deprecated getExistingChromaIds— dead code fence removed in same PR. - Single
estimateTokensutility —src/shared/estimate-tokens.ts. Delete duplicates inResultFormatter.ts:264andCorpusRenderer.ts:90. - Knowledge-corpus simplification — delete
session_idpersistence,prime/reprimeoperations, auto-reprime regex in KnowledgeAgent; rewrite/queryto fresh SDK call with systemPrompt; rely on SDK prompt caching.
Doc refs: _reference.md Part 1 §Search + §Context; old Plans 05, 06, 10.
Verification:
grep -n "SearchManager\.findBy" src/→ 0 (definitions deleted)grep -rn "RECENCY_WINDOW_MS" src/services/worker/SearchManager.ts→ 0 (constants inlined in 7 places deleted)grep -n "fellBack: true" src/→ 0 (silent fallback flag deleted)grep -n "getExistingChromaIds" src/→ 0ls src/services/context/formatters/→ empty or deleted- Integration test: Chroma down → request fails with 503 (not empty result)
- Snapshot test:
renderObservationswith agent config produces byte-identical output to the oldAgentFormatteron the same input
Anti-pattern guards:
- Do NOT create a
RenderStrategyclass hierarchy. Config object only. - Do NOT add a feature flag to "disable fail-fast Chroma" — callers either handle 503 or they don't.
Phase 4 — Write 05-hook-surface.md + 06-api-surface.md
4A. 05-hook-surface.md
Task: Draft the hook plan: consolidate worker HTTP plumbing, cache settings, delete shell retry loops, delete polling in summarize, fail-loud after N consecutive failures.
Phases inside this plan:
- Delete shell retry loops —
plugin/hooks/hooks.json:27, 32, 43— remove the 20-iterationcurlretry loops.ensureWorkerRunning()does the one check. executeWithWorkerFallback(url, method, body)helper — consolidate the 8-handler copy ofensureWorkerRunning → workerHttpRequest → if (!ok) return { continue: true }. Move tosrc/shared/worker-utils.tsas a new export.- Blocking
/api/session/endendpoint — server-side wait-for-summaryStoredEvent(emitted by03-ingestion-pathPhase 2). Single POST, single response. Deletesrc/cli/handlers/summarize.ts:117-150polling loop. - Cache settings once per hook process — module-scope
loadFromFileOnce()replaces per-handlerSettingsDefaultsManager.loadFromFile(USER_SETTINGS_PATH)calls atcontext.ts:36,session-init.ts:57,observation.ts:58,file-context.ts:211. shouldTrackProject(cwd)helper — consolidate the three duplicatedisProjectExcluded(cwd, settings.CLAUDE_MEM_EXCLUDED_PROJECTS)call sites.- cwd validation at adapter boundary — move from
file-edit.ts:50-51,observation.ts:53-54to the adapter'snormalizeInput()function. Validation happens once. - Always-init agent — delete conditional in
session-init.ts:120-129. Agent init is idempotent. - Fail-loud after N consecutive failures — track consecutive
ensureWorkerRunning == falsein settings file; after N (e.g., 3), exit code 2 to surface to Claude. Reset on first success. - Delete cache alive heuristic duplication — single
ensureWorkerAliveOnce()with module-scope cache.
Doc refs: _reference.md Part 1 §Hooks/CLI; old Plan 09 for endpoint consolidation (10 → 4).
Verification:
grep -rn "for i in 1 2 3 4 5 6 7" plugin/hooks/hooks.json→ 0grep -rn "SettingsDefaultsManager.loadFromFile" src/cli/handlers/→ 1 (cached location only)grep -rn "isProjectExcluded" src/cli/handlers/→ 1 (insideshouldTrackProjectonly)grep -rn "MAX_WAIT_FOR_SUMMARY_MS\|POLL_INTERVAL_MS" src/cli/handlers/→ 0- Integration test: block worker port → hook exits 0 first time, exits 2 after 3 consecutive failures
- Integration test: session end hook blocks until summary stored (single POST, no polling)
Anti-pattern guards:
- Do NOT add a retry loop inside the hook (any kind).
- Do NOT add a timeout-and-exit-0 pattern.
- Do NOT keep the shell retry loops behind a feature flag.
4B. 06-api-surface.md
Task: Draft the API-surface plan: Zod middleware, delete rate limiter, delete diagnostic endpoints, cache static files, consolidate shutdown paths.
Phases inside this plan:
- Preflight:
npm install zod@^3.x. validateBodymiddleware — single Express middleware using ZodsafeParse. Returns 400 with field errors on failure.- Per-route Zod schemas — one per POST/PUT endpoint, defined at top of route file.
- Delete hand-rolled validation — grep-and-delete
validateRequired, inlinetypeofchecks, coerce helpers across route files. - Delete rate limiter — worker is localhost-only; rate limiting is a second-system effect masking a real concurrency bug (if one exists, find it).
- Cache viewer.html + /api/instructions — load at boot into Buffer, serve from memory. Per-process lifecycle.
- Delete diagnostic endpoints —
/api/pending-queueGET,/api/pending-queue/process,/api/pending-queue/failedDELETE,/api/pending-queue/allDELETE atDataRoutes.ts:475, 510, 529, 548. Keep/api/processing-statusat:305and/healthatViewerRoutes.ts:32. - Consolidate shutdown paths — delete
WorkerService.shutdown,runShutdownCascade,stopSupervisorwrappers. SingleperformGracefulShutdownatGracefulShutdown.ts:52-86is the only shutdown path. - Consolidate failure-marking paths — delete
markSessionMessagesFailedatSessionRoutes.ts:256andmarkAllSessionMessagesAbandonedatworker-service.ts:943. SingletransitionMessagesTo(status)method onPendingMessageStore.
Doc refs: _reference.md Part 1 §API surface; old Plan 11 for Zod strategy.
Verification:
grep -rn "validateRequired\|rateLimit" src/services/worker/http/→ 0grep -rn "/api/pending-queue" src/→ 0grep -rn "markSessionMessagesFailed\|markAllSessionMessagesAbandoned" src/→ 0 (or 1, only insidetransitionMessagesTo)grep -rn "WorkerService.prototype.shutdown\|runShutdownCascade\|stopSupervisor" src/→ 0 (or 1 at the canonical call site)- Integration test: POST /api/observations with malformed body → 400 with field errors (not 500)
- Integration test: viewer.html served from memory (no disk read after boot)
Anti-pattern guards:
- Do NOT add per-route middleware stacks; one middleware for all validated POST/PUT.
- Do NOT add a diagnostic endpoint "for debugging only."
- Do NOT keep a shutdown wrapper "for backward compat."
Phase 5 — Write 07-dead-code.md
Task: Draft the sweep plan that catches everything the other plans don't explicitly delete.
Scope:
TranscriptParserclass atsrc/utils/transcript-parser.ts:28-90(no active importers)- Migration 19 no-op at
src/services/sqlite/migrations/runner.ts:621-628(absorbed into fresh schema) @deprecated getExistingChromaIds(noted in04-read-pathbut deleted here if missed)- Any
// removedor// oldor// legacycommented-out blocks - Any unused exports (grep for exports never imported)
- Any
bun-resolver.ts,bun-path.ts,BranchManager.ts,runtime.tsspawn sites that are unused - Migration logic duplicated in
SessionStore.ts:52-70(delegates toMigrationRunner)
Phases:
- Run
ts-pruneorknipto identify unused exports. - Grep for commented-out code patterns.
- Delete identified dead code with rationale in the commit message.
- Re-run build + tests to verify no accidental removal.
Doc refs: _reference.md Part 1 §Data layer (SessionStore duplication), §Ingestion (TranscriptParser).
Verification:
npx ts-pruneor equivalent shows zero unused exports insrc/- Build passes
- Test suite passes
grep -rn "// @deprecated\|// TODO remove\|// old\|// legacy" src/→ 0
Anti-pattern guards:
- Do NOT delete anything still imported by a test.
- Do NOT delete types still referenced by exported interfaces.
Phase 6 — Write 98-execution-order.md + 99-verification.md
6A. 98-execution-order.md
Task: Produce the dependency DAG, preflight gates, critical path, parallel branches, and blocking issues.
Contents:
- DAG:
00is the root (no deps).01+02are foundational.03depends on01(UNIQUE constraint) +02(process groups implied in spawn refactor).04depends on01(Chroma table shape).05depends on02(lazy-spawn),03(summaryStoredEvent).06depends on05(Zod schemas for hook endpoints).07runs last (sweep after everything else deletes its code).99runs alongside each plan (acceptance checks). - Preflight gates:
engines.node >= 20.0.0bumpnpm install zod@^3.x- Prompt-caching cost smoke test (for
04knowledge-corpus phases) - Chroma MCP availability + error-text pattern documented
- Critical path:
00 → 01 → 02 → 03 → 05 → 06 → 07(seven sequential plans). - Parallel branches:
04runs after01independently of02.07runs after everything. - Blocking issues: carried forward from old
08-reconciliation.mdPart 5. - Post-landing verification: grep chains from every plan's verification section.
Doc refs: _mapping.md Cross-plan coupling table; old 07-master-plan.md + 08-reconciliation.md.
6B. 99-verification.md
Task: The acceptance-criteria document for the whole refactor.
Contents:
- Timer census: 3 → 0 repeating background timers.
- Polling loops: 1 → 0.
- Full grep target list: consolidated from every plan's verification section, grouped by pattern:
grep -rn "setInterval" src/services/worker/→ 0grep -rn "coerceObservationToSummary\|consecutiveSummaryFailures" src/→ 0grep -rn "recoverStuckProcessing\|killSystemOrphans\|reapStaleSessions\|reapOrphanedProcesses\|killIdleDaemonChildren" src/→ 0grep -rn "ProcessRegistry" src/services/worker/→ 0grep -rn "/api/pending-queue" src/→ 0grep -rn "DEDUP_WINDOW_MS\|findDuplicateObservation" src/→ 0grep -rn "abandonedTimer\|evictIdlestSession" src/→ 0grep -rn "fallbackAgent\|Gemini\|OpenRouter" src/services/worker/→ 0
- Prompt-caching cost smoke test: three sequential
/api/corpus/:name/querycalls assertcache_read_input_tokens > 0on calls 2 and 3. - Viewer regression harness: 12 invariants (I1–I12), 11 tests (T1–T11), baseline capture + re-run schedule.
- Integration tests (consolidated from per-plan verification):
- Kill worker mid-claim → next worker picks up the row
- SIGTERM worker → all SDK children exit within 6s (process-group teardown)
- Chroma down → search returns 503 (no silent fallback)
- Malformed POST → 400 with field errors (Zod)
- Consecutive hook failures → exit 2 after N
- Acceptance criteria — final net lines, full test pass, viewer regression pass, cost smoke pass.
Doc refs: Every other plan's verification section.
Verification:
- Every grep target is sourced from at least one plan
- Every integration test has a corresponding plan that introduces the behavior
- Viewer lockdown section cites
tests/viewer-lockdown/artifacts
Phase 7 — Principle cross-check
Task: Before the new corpus ships, verify each new plan passes its own principles. Run as a meta-review.
Checks:
grep -rn "recover\|reap\|heal\|repair\|orphan\|coerce\|fallback" PATHFINDER-2026-04-22/*.md— every hit must be in a "DELETE" or "NEVER add" context, never as an acceptable future pattern.grep -rn "setInterval\|setTimeout" PATHFINDER-2026-04-22/*.md— every hit must be either a deletion target or a narrowly-justified per-operation timer.grep -rn "strategy\|factory\|builder" PATHFINDER-2026-04-22/*.md— every hit must justify why a config object won't do.grep -rn "for backward compat\|for one release\|@deprecated" PATHFINDER-2026-04-22/*.md— must be 0.- Verify every plan cites
_reference.mdPart 1 for its code anchors and Part 2 for its external APIs. - Verify
_mapping.mdaccounts for every old section (no orphans). - Verify
98-execution-order.mdDAG is acyclic and covers all plans.
Deliverable: A short _principle-crosscheck.md in the new corpus directory logging the results. If ANY check fails, the corresponding plan gets sent back for revision before ship.
Execution instructions
Each phase (1 through 7) can be executed in a fresh chat context. To execute phase N:
- Open a new chat
- Load
PATHFINDER-2026-04-22/_reference.mdand_mapping.mdand this file - Scroll to "Phase N" and execute its tasks verbatim
- Commit each new plan file as it's produced (
git add PATHFINDER-2026-04-22/<plan>.md) - Run the verification checklist; if any check fails, revise the plan before moving on
Total estimated effort: 4 engineer-days for Phases 1–6 (plan authoring), 2 engineer-days for Phase 7 (cross-check + revisions), then the plans themselves execute the refactor over ~3 weeks.
Confidence + known gaps
Confidence: HIGH. Phase 0 agents verified every anchor against live code. The principle list is derived from five independent audits that independently converged on the same diagnosis. The DAG is internally consistent (every new plan has exactly one owner for each cross-plan invariant — see _mapping.md coupling table).
Known gaps:
- Chroma upsert fallback is brittle — document the error-text pattern in
01-data-integrity.md§Chroma, gate behind a flag. - Prompt-caching TTL assumption — cost smoke test must pass before
04-read-pathknowledge-corpus phases ship. - Windows process-group behavior —
process.kill(-pgid)is Unix-only; document Windows Job Objects as a gap-to-fix in02-process-lifecycle.md. respawndep decision —02-process-lifecycle.mdmust decide: adoptrespawnor hand-roll a 3-attempt retry in the lazy-spawn wrapper.- Snapshot tests for renderer collapse —
04-read-path.md§Phase 1 must freeze byte-equality snapshots BEFORE deleting the four formatters, otherwise regressions are undetectable.
Status: READY FOR PHASE 1. Next action: open a fresh chat, load this file + _reference.md + _mapping.md, execute Phase 1 to produce 00-principles.md.