f38b5b85bc
* docs: add investigation reports for 5 open GitHub issues Comprehensive analysis of issues #543, #544, #545, #555, and #557: - #557: settings.json not generated, module loader error (node/bun mismatch) - #555: Windows hooks not executing, hasIpc always false - #545: formatTool crashes on non-JSON tool_input strings - #544: mem-search skill hint shown incorrectly to Claude Code users - #543: /claude-mem slash command unavailable despite installation Each report includes root cause analysis, affected files, and proposed fixes. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * fix(logger): handle non-JSON tool_input in formatTool (#545) Wrap JSON.parse in try-catch to handle raw string inputs (e.g., Bash commands) that aren't valid JSON. Falls back to using the string as-is. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * fix(context): update mem-search hint to reference MCP tools (#544) Update hint messages to reference MCP tools (search, get_observations) instead of the deprecated "mem-search skill" terminology. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * fix(settings): auto-create settings.json on first load (#557, #543) When settings.json doesn't exist, create it with defaults instead of returning in-memory defaults. Creates parent directory if needed. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * fix(hooks): use bun runtime for hooks except smart-install (#557) Change hook commands from node to bun since hooks use bun:sqlite. Keep smart-install.js on node since it bootstraps bun installation. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * chore: rebuild plugin scripts * docs: clarify that build artifacts must be committed * fix(docs): update build artifacts directory reference in CLAUDE.md * test: add test coverage for PR #558 fixes - Fix 2 failing tests: update "mem-search skill" → "MCP tools" expectations - Add 56 tests for formatTool() JSON.parse crash fix (Issue #545) - Add 27 tests for settings.json auto-creation (Issue #543) Test coverage includes: - formatTool: JSON parsing, raw strings, objects, null/undefined, all tool types - Settings: file creation, directory creation, schema migration, edge cases 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * fix(tests): clean up flaky tests and fix circular dependency Phase 1 of test quality improvements: - Delete 6 harmful/worthless test files that used problematic mock.module() patterns or tested implementation details rather than behavior: - context-builder.test.ts (tested internal implementation) - export-types.test.ts (fragile mock patterns) - smart-install.test.ts (shell script testing antipattern) - session_id_refactor.test.ts (outdated, tested refactoring itself) - validate_sql_update.test.ts (one-time migration validation) - observation-broadcaster.test.ts (excessive mocking) - Fix circular dependency between logger.ts and SettingsDefaultsManager.ts by using late binding pattern - logger now lazily loads settings - Refactor mock.module() to spyOn() in several test files for more maintainable and less brittle tests: - observation-compiler.test.ts - gemini_agent.test.ts - error-handler.test.ts - server.test.ts - response-processor.test.ts All 649 tests pass. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * refactor(tests): phase 2 - reduce mock-heavy tests and improve focus - Remove mock-heavy query tests from observation-compiler.test.ts, keep real buildTimeline tests - Convert session_id_usage_validation.test.ts from 477 to 178 lines of focused smoke tests - Remove tests for language built-ins from worker-spawn.test.ts (JSON.parse, array indexing) - Rename logger-coverage.test.ts to logger-usage-standards.test.ts for clarity 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * docs(tests): phase 3 - add JSDoc mock justification to test files Document mock usage rationale in 5 test files to improve maintainability: - error-handler.test.ts: Express req/res mocks, logger spies (~11%) - fallback-error-handler.test.ts: Zero mocks, pure function tests - session-cleanup-helper.test.ts: Session fixtures, worker mocks (~19%) - hook-constants.test.ts: process.platform mock for Windows tests (~12%) - session_store.test.ts: Zero mocks, real SQLite :memory: database Part of ongoing effort to document mock justifications per TESTING.md guidelines. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * test(integration): phase 5 - add 72 tests for critical coverage gaps Add comprehensive test coverage for previously untested areas: - tests/integration/hook-execution-e2e.test.ts (10 tests) Tests lifecycle hooks execution flow and context propagation - tests/integration/worker-api-endpoints.test.ts (19 tests) Tests all worker service HTTP endpoints without heavy mocking - tests/integration/chroma-vector-sync.test.ts (16 tests) Tests vector embedding synchronization with ChromaDB - tests/utils/tag-stripping.test.ts (27 tests) Tests privacy tag stripping utilities for both <private> and <meta-observation> tags All tests use real implementations where feasible, following the project's testing philosophy of preferring integration-style tests over unit tests with extensive mocking. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * context update * docs: add comment linking DEFAULT_DATA_DIR locations Added NOTE comment in logger.ts pointing to the canonical DEFAULT_DATA_DIR in SettingsDefaultsManager.ts. This addresses PR reviewer feedback about the fragility of having the default defined in two places to avoid circular dependencies. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
158 lines
6.4 KiB
TypeScript
158 lines
6.4 KiB
TypeScript
/**
|
|
* Tests for fallback error classification logic
|
|
*
|
|
* Mock Justification: NONE (0% mock code)
|
|
* - Tests pure functions directly with no external dependencies
|
|
* - shouldFallbackToClaude: Pattern matching on error messages
|
|
* - isAbortError: Simple type checking
|
|
*
|
|
* High-value tests: Ensure correct provider fallback behavior for transient errors
|
|
*/
|
|
import { describe, it, expect } from 'bun:test';
|
|
|
|
// Import directly from specific files to avoid worker-service import chain
|
|
import { shouldFallbackToClaude, isAbortError } from '../../../src/services/worker/agents/FallbackErrorHandler.js';
|
|
import { FALLBACK_ERROR_PATTERNS } from '../../../src/services/worker/agents/types.js';
|
|
|
|
describe('FallbackErrorHandler', () => {
|
|
describe('FALLBACK_ERROR_PATTERNS', () => {
|
|
it('should contain all 7 expected patterns', () => {
|
|
expect(FALLBACK_ERROR_PATTERNS).toHaveLength(7);
|
|
expect(FALLBACK_ERROR_PATTERNS).toContain('429');
|
|
expect(FALLBACK_ERROR_PATTERNS).toContain('500');
|
|
expect(FALLBACK_ERROR_PATTERNS).toContain('502');
|
|
expect(FALLBACK_ERROR_PATTERNS).toContain('503');
|
|
expect(FALLBACK_ERROR_PATTERNS).toContain('ECONNREFUSED');
|
|
expect(FALLBACK_ERROR_PATTERNS).toContain('ETIMEDOUT');
|
|
expect(FALLBACK_ERROR_PATTERNS).toContain('fetch failed');
|
|
});
|
|
});
|
|
|
|
describe('shouldFallbackToClaude', () => {
|
|
describe('returns true for fallback patterns', () => {
|
|
it('should return true for 429 rate limit errors', () => {
|
|
expect(shouldFallbackToClaude('Rate limit exceeded: 429')).toBe(true);
|
|
expect(shouldFallbackToClaude(new Error('429 Too Many Requests'))).toBe(true);
|
|
});
|
|
|
|
it('should return true for 500 internal server errors', () => {
|
|
expect(shouldFallbackToClaude('500 Internal Server Error')).toBe(true);
|
|
expect(shouldFallbackToClaude(new Error('Server returned 500'))).toBe(true);
|
|
});
|
|
|
|
it('should return true for 502 bad gateway errors', () => {
|
|
expect(shouldFallbackToClaude('502 Bad Gateway')).toBe(true);
|
|
expect(shouldFallbackToClaude(new Error('Upstream returned 502'))).toBe(true);
|
|
});
|
|
|
|
it('should return true for 503 service unavailable errors', () => {
|
|
expect(shouldFallbackToClaude('503 Service Unavailable')).toBe(true);
|
|
expect(shouldFallbackToClaude(new Error('Server is 503'))).toBe(true);
|
|
});
|
|
|
|
it('should return true for ECONNREFUSED errors', () => {
|
|
expect(shouldFallbackToClaude('connect ECONNREFUSED 127.0.0.1:8080')).toBe(true);
|
|
expect(shouldFallbackToClaude(new Error('ECONNREFUSED'))).toBe(true);
|
|
});
|
|
|
|
it('should return true for ETIMEDOUT errors', () => {
|
|
expect(shouldFallbackToClaude('connect ETIMEDOUT')).toBe(true);
|
|
expect(shouldFallbackToClaude(new Error('Request ETIMEDOUT'))).toBe(true);
|
|
});
|
|
|
|
it('should return true for fetch failed errors', () => {
|
|
expect(shouldFallbackToClaude('fetch failed')).toBe(true);
|
|
expect(shouldFallbackToClaude(new Error('fetch failed: network error'))).toBe(true);
|
|
});
|
|
});
|
|
|
|
describe('returns false for non-fallback errors', () => {
|
|
it('should return false for 400 Bad Request', () => {
|
|
expect(shouldFallbackToClaude('400 Bad Request')).toBe(false);
|
|
expect(shouldFallbackToClaude(new Error('400 Invalid argument'))).toBe(false);
|
|
});
|
|
|
|
it('should return false for 401 Unauthorized', () => {
|
|
expect(shouldFallbackToClaude('401 Unauthorized')).toBe(false);
|
|
});
|
|
|
|
it('should return false for 403 Forbidden', () => {
|
|
expect(shouldFallbackToClaude('403 Forbidden')).toBe(false);
|
|
});
|
|
|
|
it('should return false for 404 Not Found', () => {
|
|
expect(shouldFallbackToClaude('404 Not Found')).toBe(false);
|
|
});
|
|
|
|
it('should return false for generic errors', () => {
|
|
expect(shouldFallbackToClaude('Something went wrong')).toBe(false);
|
|
expect(shouldFallbackToClaude(new Error('Unknown error'))).toBe(false);
|
|
});
|
|
});
|
|
|
|
describe('handles various error types', () => {
|
|
it('should handle string errors', () => {
|
|
expect(shouldFallbackToClaude('429 rate limited')).toBe(true);
|
|
expect(shouldFallbackToClaude('invalid input')).toBe(false);
|
|
});
|
|
|
|
it('should handle Error objects', () => {
|
|
expect(shouldFallbackToClaude(new Error('429 Too Many Requests'))).toBe(true);
|
|
expect(shouldFallbackToClaude(new Error('Bad Request'))).toBe(false);
|
|
});
|
|
|
|
it('should handle objects with message property', () => {
|
|
expect(shouldFallbackToClaude({ message: '503 unavailable' })).toBe(true);
|
|
expect(shouldFallbackToClaude({ message: 'ok' })).toBe(false);
|
|
});
|
|
|
|
it('should handle null and undefined', () => {
|
|
expect(shouldFallbackToClaude(null)).toBe(false);
|
|
expect(shouldFallbackToClaude(undefined)).toBe(false);
|
|
});
|
|
|
|
it('should handle non-error objects by stringifying', () => {
|
|
expect(shouldFallbackToClaude({ code: 429 })).toBe(false); // toString won't include 429
|
|
expect(shouldFallbackToClaude(429)).toBe(true); // number 429 stringifies to "429"
|
|
});
|
|
});
|
|
});
|
|
|
|
describe('isAbortError', () => {
|
|
it('should return true for Error with name "AbortError"', () => {
|
|
const abortError = new Error('The operation was aborted');
|
|
abortError.name = 'AbortError';
|
|
expect(isAbortError(abortError)).toBe(true);
|
|
});
|
|
|
|
it('should return true for objects with name "AbortError"', () => {
|
|
expect(isAbortError({ name: 'AbortError', message: 'aborted' })).toBe(true);
|
|
});
|
|
|
|
it('should return false for regular Error objects', () => {
|
|
expect(isAbortError(new Error('Some error'))).toBe(false);
|
|
expect(isAbortError(new TypeError('Type error'))).toBe(false);
|
|
});
|
|
|
|
it('should return false for errors with other names', () => {
|
|
const error = new Error('timeout');
|
|
error.name = 'TimeoutError';
|
|
expect(isAbortError(error)).toBe(false);
|
|
});
|
|
|
|
it('should return false for null and undefined', () => {
|
|
expect(isAbortError(null)).toBe(false);
|
|
expect(isAbortError(undefined)).toBe(false);
|
|
});
|
|
|
|
it('should return false for strings', () => {
|
|
expect(isAbortError('AbortError')).toBe(false);
|
|
});
|
|
|
|
it('should return false for objects without name property', () => {
|
|
expect(isAbortError({ message: 'error' })).toBe(false);
|
|
expect(isAbortError({})).toBe(false);
|
|
});
|
|
});
|
|
});
|