Files
claude-mem/PATHFINDER-2026-04-21/07-plans/09-lifecycle-hooks.md
T
Alex Newman 94d592f212 perf: streamline worker startup and consolidate database connections (#2122)
* docs: pathfinder refactor corpus + Node 20 preflight

Adds the PATHFINDER-2026-04-22 principle-driven refactor plan (11 docs,
cross-checked PASS) plus the exploratory PATHFINDER-2026-04-21 corpus
that motivated it. Bumps engines.node to >=20.0.0 per the ingestion-path
plan preflight (recursive fs.watch). Adds the pathfinder skill.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

* refactor: land PATHFINDER Plan 01 — data integrity

Schema, UNIQUE constraints, self-healing claim, Chroma upsert fallback.

- Phase 1: fresh schema.sql regenerated at post-refactor shape.
- Phase 2: migrations 23+24 — rebuild pending_messages without
  started_processing_at_epoch; UNIQUE(session_id, tool_use_id);
  UNIQUE(memory_session_id, content_hash) on observations; dedup
  duplicate rows before adding indexes.
- Phase 3: claimNextMessage rewritten to self-healing query using
  worker_pid NOT IN live_worker_pids; STALE_PROCESSING_THRESHOLD_MS
  and the 60-s stale-reset block deleted.
- Phase 4: DEDUP_WINDOW_MS and findDuplicateObservation deleted;
  observations.insert now uses ON CONFLICT DO NOTHING.
- Phase 5: failed-message purge block deleted from worker-service
  2-min interval; clearFailedOlderThan method deleted.
- Phase 6: repairMalformedSchema and its Python subprocess repair
  path deleted from Database.ts; SQLite errors now propagate.
- Phase 7: Chroma delete-then-add fallback gated behind
  CHROMA_SYNC_FALLBACK_ON_CONFLICT env flag as bridge until
  Chroma MCP ships native upsert.
- Phase 8: migration 19 no-op block absorbed into fresh schema.sql.

Verification greps all return 0 matches. bun test tests/sqlite/
passes 63/63. bun run build succeeds.

Plan: PATHFINDER-2026-04-22/01-data-integrity.md

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

* refactor: land PATHFINDER Plan 02 — process lifecycle

OS process groups replace hand-rolled reapers. Worker runs until
killed; orphans are prevented by detached spawn + kill(-pgid).

- Phase 1: src/services/worker/ProcessRegistry.ts DELETED. The
  canonical registry at src/supervisor/process-registry.ts is the
  sole survivor; SDK spawn site consolidated into it via new
  createSdkSpawnFactory/spawnSdkProcess/getSdkProcessForSession/
  ensureSdkProcessExit/waitForSlot helpers.
- Phase 2: SDK children spawn with detached:true + stdio:
  ['ignore','pipe','pipe']; pgid recorded on ManagedProcessInfo.
- Phase 3: shutdown.ts signalProcess teardown uses
  process.kill(-pgid, signal) on Unix when pgid is recorded;
  Windows path unchanged (tree-kill/taskkill).
- Phase 4: all reaper intervals deleted — startOrphanReaper call,
  staleSessionReaperInterval setInterval (including the co-located
  WAL checkpoint — SQLite's built-in wal_autocheckpoint handles
  WAL growth without an app-level timer), killIdleDaemonChildren,
  killSystemOrphans, reapOrphanedProcesses, reapStaleSessions, and
  detectStaleGenerator. MAX_GENERATOR_IDLE_MS and MAX_SESSION_IDLE_MS
  constants deleted.
- Phase 5: abandonedTimer — already 0 matches; primary-path cleanup
  via generatorPromise.finally() already lives in worker-service
  startSessionProcessor and SessionRoutes ensureGeneratorRunning.
- Phase 6: evictIdlestSession and its evict callback deleted from
  SessionManager. Pool admission gates backpressure upstream.
- Phase 7: SDK-failure fallback — SessionManager has zero matches
  for fallbackAgent/Gemini/OpenRouter. Failures surface to hooks
  via exit code 2 through SessionRoutes error mapping.
- Phase 8: ensureWorkerRunning in worker-utils.ts rewritten to
  lazy-spawn — consults isWorkerPortAlive (which gates
  captureProcessStartToken for PID-reuse safety via commit
  99060bac), then spawns detached with unref(), then
  waitForWorkerPort({ attempts: 3, backoffMs: 250 }) hand-rolled
  exponential backoff 250→500→1000ms. No respawn npm dep.
- Phase 9: idle self-shutdown — zero matches for
  idleCheck/idleTimeout/IDLE_MAX_MS/idleShutdown. Worker exits
  only on external SIGTERM via supervisor signal handlers.

Three test files that exercised deleted code removed:
tests/worker/process-registry.test.ts,
tests/worker/session-lifecycle-guard.test.ts,
tests/services/worker/reap-stale-sessions.test.ts.
Pass count: 1451 → 1407 (-44), all attributable to deleted test
files. Zero new failures. 31 pre-existing failures remain
(schema-repair suite, logger-usage-standards, environmental
openclaw / plugin-distribution) — none introduced by Plan 02.

All 10 verification greps return 0. bun run build succeeds.

Plan: PATHFINDER-2026-04-22/02-process-lifecycle.md

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

* refactor: land PATHFINDER Plan 04 (narrowed) — search fail-fast

Phases 3, 5, 6 only. Plan-doc inaccuracies for phases 1/2/4/7/8/9
deferred for plan reconciliation:
  - Phase 1/2: ObservationRow type doesn't exist; the four
    "formatters" operate on three incompatible types.
  - Phase 4: RECENCY_WINDOW_MS already imported from
    SEARCH_CONSTANTS at every call site.
  - Phase 7: getExistingChromaIds is NOT @deprecated and has an
    active caller in ChromaSync.backfillMissingSyncs.
  - Phase 8: estimateTokens already consolidated.
  - Phase 9: knowledge-corpus rewrite blocked on PG-3
    prompt-caching cost smoke test.

Phase 3 — Delete SearchManager.findByConcept/findByFile/findByType.
SearchRoutes handlers (handleSearchByConcept/File/Type) now call
searchManager.getOrchestrator().findByXxx() directly via new
getter accessors on SearchManager. ~250 LoC deleted.

Phase 5 — Fail-fast Chroma. Created
src/services/worker/search/errors.ts with ChromaUnavailableError
extends AppError(503, 'CHROMA_UNAVAILABLE'). Deleted
SearchOrchestrator.executeWithFallback's Chroma-failed
SQLite-fallback branch; runtime Chroma errors now throw 503.
"Path 3" (chromaSync was null at construction — explicit-
uninitialized config) preserved as legitimate empty-result state
per plan text. ChromaSearchStrategy.search no longer wraps in
try/catch — errors propagate.

Phase 6 — Delete HybridSearchStrategy three try/catch silent
fallback blocks (findByConcept, findByType, findByFile) at lines
~82-95, ~120-132, ~161-172. Removed `fellBack` field from
StrategySearchResult type and every return site
(SQLiteSearchStrategy, BaseSearchStrategy.emptyResult,
SearchOrchestrator).

Tests updated (Principle 7 — delete in same PR):
  - search-orchestrator.test.ts: "fall back to SQLite" rewritten
    as "throw ChromaUnavailableError (HTTP 503)".
  - chroma/hybrid/sqlite-search-strategy tests: rewritten to
    rejects.toThrow; removed fellBack assertions.

Verification: SearchManager.findBy → 0; fellBack → 0 in src/.
bun test tests/worker/search/ → 122 pass, 0 fail.
bun test (suite-wide) → 1407 pass, baseline maintained, 0 new
failures. bun run build succeeds.

Plan: PATHFINDER-2026-04-22/04-read-path.md (Phases 3, 5, 6)

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

* refactor: land PATHFINDER Plan 03 — ingestion path

Fail-fast parser, direct in-process ingest, recursive fs.watch,
DB-backed tool pairing. Worker-internal HTTP loopback eliminated.

- Phase 0: Created src/services/worker/http/shared.ts exporting
  ingestObservation/ingestPrompt/ingestSummary as direct
  in-process functions plus ingestEventBus (Node EventEmitter,
  reusing existing pattern — no third event bus introduced).
  setIngestContext wires the SessionManager dependency from
  worker-service constructor.
- Phase 1: src/sdk/parser.ts collapsed to one parseAgentXml
  returning { valid:true; kind: 'observation'|'summary'; data }
  | { valid:false; reason: string }. Inspects root element;
  <skip_summary reason="…"/> is a first-class summary case
  with skipped:true. NEVER returns undefined. NEVER coerces.
- Phase 2: ResponseProcessor calls parseAgentXml exactly once,
  branches on the discriminated union. On invalid → markFailed
  + logger.warn(reason). On observation → ingestObservation.
  On summary → ingestSummary then emit summaryStoredEvent
  { sessionId, messageId } (consumed by Plan 05's blocking
  /api/session/end).
- Phase 3: Deleted consecutiveSummaryFailures field
  (ResponseProcessor + SessionManager + worker-types) and
  MAX_CONSECUTIVE_SUMMARY_FAILURES constant. Circuit-breaker
  guards and "tripped" log lines removed.
- Phase 4: coerceObservationToSummary deleted from sdk/parser.ts.
- Phase 5: src/services/transcripts/watcher.ts rescan setInterval
  replaced with fs.watch(transcriptsRoot, { recursive: true,
  persistent: true }) — Node 20+ recursive mode.
- Phase 6: src/services/transcripts/processor.ts pendingTools
  Map deleted. tool_use rows insert with INSERT OR IGNORE on
  UNIQUE(session_id, tool_use_id) (added by Plan 01). New
  pairToolUsesByJoin query in PendingMessageStore for read-time
  pairing (UNIQUE INDEX provides idempotency; explicit consumer
  not yet wired).
- Phase 7: HTTP loopback at processor.ts:252 replaced with
  direct ingestObservation call. maybeParseJson silent-passthrough
  rewritten to fail-fast (throws on malformed JSON).
- Phase 8: src/utils/tag-stripping.ts countTags + stripTagsInternal
  collapsed into one alternation regex, single-pass over input.
- Phase 9: src/utils/transcript-parser.ts (dead TranscriptParser
  class) deleted. The active extractLastMessage at
  src/shared/transcript-parser.ts:41-144 is the sole survivor.

Tests updated (Principle 7 — same-PR delete):
  - tests/sdk/parser.test.ts + parse-summary.test.ts: rewritten
    to assert discriminated-union shape; coercion-specific
    scenarios collapse into { valid:false } assertions.
  - tests/worker/agents/response-processor.test.ts: circuit-breaker
    describe block skipped; non-XML/empty-response tests assert
    fail-fast markFailed behavior.

Verification: every grep returns 0. transcript-parser.ts deleted.
bun run build succeeds. bun test → 1399 pass / 28 fail / 7 skip
(net -8 pass = the 4 retired circuit-breaker tests + 4 collapsed
parser cases). Zero new failures vs baseline.

Deferred (out of Plan 03 scope, will land in Plan 06): SessionRoutes
HTTP route handlers still call sessionManager.queueObservation
inline rather than the new shared helpers — the helpers are ready,
the route swap is mechanical and belongs with the Zod refactor.

Plan: PATHFINDER-2026-04-22/03-ingestion-path.md

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

* refactor: land PATHFINDER Plan 05 — hook surface

Worker-call plumbing collapsed to one helper. Polling replaced by
server-side blocking endpoint. Fail-loud counter surfaces persistent
worker outages via exit code 2.

- Phase 1: plugin/hooks/hooks.json — three 20-iteration `for i in
  1..20; do curl -sf .../health && break; sleep 0.1; done` shell
  retry wrappers deleted. Hook commands invoke their bun entry
  point directly.
- Phase 2: src/shared/worker-utils.ts — added
  executeWithWorkerFallback<T>(url, method, body) returning
  T | { continue: true; reason?: string }. All 8 hook handlers
  (observation, session-init, context, file-context, file-edit,
  summarize, session-complete, user-message) rewritten to use
  it instead of duplicating the ensureWorkerRunning →
  workerHttpRequest → fallback sequence.
- Phase 3: blocking POST /api/session/end in SessionRoutes.ts
  using validateBody + sessionEndSchema (z.object({sessionId})).
  One-shot ingestEventBus.on('summaryStoredEvent') listener,
  30 s timer, req.aborted handler — all share one cleanup so
  the listener cannot leak. summarize.ts polling loop, plus
  MAX_WAIT_FOR_SUMMARY_MS / POLL_INTERVAL_MS constants, deleted.
- Phase 4: src/shared/hook-settings.ts — loadFromFileOnce()
  memoizes SettingsDefaultsManager.loadFromFile per process.
  Per-handler settings reads collapsed.
- Phase 5: src/shared/should-track-project.ts — single exclusion
  check entry; isProjectExcluded no longer referenced from
  src/cli/handlers/.
- Phase 6: cwd validation pushed into adapter normalizeInput
  (all 6 adapters: claude-code, cursor, raw, gemini-cli,
  windsurf). New AdapterRejectedInput error in
  src/cli/adapters/errors.ts. Handler-level isValidCwd checks
  deleted from file-edit.ts and observation.ts. hook-command.ts
  catches AdapterRejectedInput → graceful fallback.
- Phase 7: session-init.ts conditional initAgent guard deleted;
  initAgent is idempotent. tests/hooks/context-reinjection-guard
  test (validated the deleted conditional) deleted in same PR
  per Principle 7.
- Phase 8: fail-loud counter at ~/.claude-mem/state/hook-failures
  .json. Atomic write via .tmp + rename. CLAUDE_MEM_HOOK_FAIL_LOUD
  _THRESHOLD setting (default 3). On consecutive worker-unreachable
  ≥ N: process.exit(2). On success: reset to 0. NOT a retry.
- Phase 9: ensureWorkerAliveOnce() module-scope memoization
  wrapping ensureWorkerRunning. executeWithWorkerFallback calls
  the memoized version.

Minimal validateBody middleware stub at
src/services/worker/http/middleware/validateBody.ts. Plan 06 will
expand with typed inference + error envelope conventions.

Verification: 4/4 grep targets pass. bun run build succeeds.
bun test → 1393 pass / 28 fail / 7 skip; -6 pass attributable
solely to deleted context-reinjection-guard test file. Zero new
failures vs baseline.

Plan: PATHFINDER-2026-04-22/05-hook-surface.md

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

* refactor: land PATHFINDER Plan 06 — API surface

One Zod-based validator wrapping every POST/PUT. Rate limiter,
diagnostic endpoints, and shutdown wrappers deleted. Failure-
marking consolidated to one helper.

- Phase 1 (preflight): zod@^3 already installed.
- Phase 2: validateBody middleware confirmed at canonical shape
  in src/services/worker/http/middleware/validateBody.ts —
  safeParse → 400 { error: 'ValidationError', issues: [...] }
  on failure, replaces req.body with parsed value on success.
- Phase 3: Per-route Zod schemas declared at the top of each
  route file. 24 POST endpoints across SessionRoutes,
  CorpusRoutes, DataRoutes, MemoryRoutes, SearchRoutes,
  LogsRoutes, SettingsRoutes now wrap with validateBody().
  /api/session/end (Plan 05) confirmed using same middleware.
- Phase 4: validateRequired() deleted from BaseRouteHandler
  along with every call site. Inline coercion helpers
  (coerceStringArray, coercePositiveInteger) and inline
  if (!req.body...) guards deleted across all route files.
- Phase 5: Rate limiter middleware and its registration deleted
  from src/services/worker/http/middleware.ts. Worker binds
  127.0.0.1:37777 — no untrusted caller.
- Phase 6: viewer.html cached at module init in ViewerRoutes.ts
  via fs.readFileSync; served as Buffer with text/html content
  type. SKILL.md + per-operation .md files cached in
  Server.ts as Map<string, string>; loadInstructionContent
  helper deleted. NO fs.watch, NO TTL — process restart is the
  cache-invalidation event.
- Phase 7: Four diagnostic endpoints deleted from DataRoutes.ts
  — /api/pending-queue (GET), /api/pending-queue/process (POST),
  /api/pending-queue/failed (DELETE), /api/pending-queue/all
  (DELETE). Helper methods that ONLY served them
  (getQueueMessages, getStuckCount, getRecentlyProcessed,
  clearFailed, clearAll) deleted from PendingMessageStore.
  KEPT: /api/processing-status (observability), /health
  (used by ensureWorkerRunning).
- Phase 8: stopSupervisor wrapper deleted from supervisor/index.ts.
  GracefulShutdown now calls getSupervisor().stop() directly.
  Two functions retained with clear roles:
    - performGracefulShutdown — worker-side 6-step shutdown
    - runShutdownCascade — supervisor-side child teardown
      (process.kill(-pgid), Windows tree-kill, PID-file cleanup)
  Each has unique non-trivial logic and a single canonical caller.
- Phase 9: transitionMessagesTo(status, filter) is the sole
  failure-marking path on PendingMessageStore. Old methods
  markSessionMessagesFailed and markAllSessionMessagesAbandoned
  deleted along with all callers (worker-service,
  SessionCompletionHandler, tests/zombie-prevention).

Tests updated (Principle 7 same-PR delete): coercion test files
refactored to chain validateBody → handler. Zombie-prevention
tests rewritten to call transitionMessagesTo.

Verification: all 4 grep targets → 0. bun run build succeeds.
bun test → 1393 pass / 28 fail / 7 skip — exact match to
baseline. Zero new failures.

Plan: PATHFINDER-2026-04-22/06-api-surface.md

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

* refactor: land PATHFINDER Plan 07 — dead code sweep

ts-prune-driven sweep across the tree after Plans 01-06 landed.
Deleted unused exports, orphan helpers, and one fully orphaned
file. Earlier-plan deletions verified.

Deleted:
- src/utils/bun-path.ts (entire file — getBunPath, getBunPathOrThrow,
  isBunAvailable: zero importers)
- bun-resolver.getBunVersionString: zero callers
- PendingMessageStore.retryMessage / resetProcessingToPending /
  abortMessage: superseded by transitionMessagesTo (Plan 06 Phase 9)
- EnvManager.MANAGED_CREDENTIAL_KEYS, EnvManager.setCredential:
  zero callers
- CodexCliInstaller.checkCodexCliStatus: zero callers; no status
  command exists in npx-cli
- Two "REMOVED: cleanupOrphanedSessions" stale-fence comments

Kept (with documented justification):
- Public API surface in dist/sdk/* (parseAgentXml, prompt
  builders, ParsedObservation, ParsedSummary, ParseResult,
  SUMMARY_MODE_MARKER) — exported via package.json sdk path.
- generateContext / loadContextConfig / token utilities — used
  via dynamic await import('../../../context-generator.js') in
  worker SearchRoutes.
- MCP_IDE_INSTALLERS, install/uninstall functions for codex/goose
  — used via dynamic await import in npx-cli/install.ts +
  uninstall.ts (ts-prune cannot trace dynamic imports).
- getExistingChromaIds — active caller in
  ChromaSync.backfillMissingSyncs (Plan 04 narrowed scope).
- processPendingQueues / getSessionsWithPendingMessages — active
  orphan-recovery caller in worker-service.ts plus
  zombie-prevention test coverage.
- StoreAndMarkCompleteResult legacy alias — return-type annotation
  in same file.
- All Database.ts barrel re-exports — used downstream.

Earlier-plan verification:
- Plan 03 Phase 9: VERIFIED — src/utils/transcript-parser.ts
  is gone; TranscriptParser has 0 references in src/.
- Plan 01 Phase 8: VERIFIED — migration 19 no-op absorbed.
- SessionStore.ts:52-70 consolidation NOT executed (deferred):
  the methods are not thin wrappers but ~900 LoC of bodies, and
  two methods are documented as intentional mirrors so the
  context-generator.cjs bundle stays schema-consistent without
  pulling MigrationRunner. Deserves its own plan, not a sweep.

Verification: TranscriptParser → 0; transcript-parser.ts → gone;
no commented-out code markers remain. bun run build succeeds.
bun test → 1393 pass / 28 fail / 7 skip — EXACT match to
baseline. Zero regressions.

Plan: PATHFINDER-2026-04-22/07-dead-code.md

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

* chore: remove residual ProcessRegistry comment reference

Plan 07 dead-code sweep missed one comment-level reference to the
deleted in-memory ProcessRegistry class in SessionManager.ts:347.
Rewritten to describe the supervisor.json scope without naming the
deleted class, completing the verification grep target.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

* fix: address Greptile review (P1 + 2× P2)

P1 — Plan 05 Phase 3 blocking endpoint was non-functional:
executeWithWorkerFallback used HEALTH_CHECK_TIMEOUT_MS (3 s) for
the POST /api/session/end call, but the server holds the
connection for SERVER_SIDE_SUMMARY_TIMEOUT_MS (30 s). Client
always raced to a "timed out" rejection that isWorkerUnavailable
classified as worker-unreachable, so the hook silently degraded
instead of waiting for summaryStoredEvent.
  - Added optional timeoutMs to executeWithWorkerFallback,
    forwarded to workerHttpRequest.
  - summarize.ts call site now passes 35_000 (5 s above server
    hold window).

P2 — ingestSummary({ kind: 'parsed' }) branch was dead code:
ResponseProcessor emitted summaryStoredEvent directly via the
event bus, bypassing the centralized helper that the comment
claimed was the single source.
  - ResponseProcessor now calls ingestSummary({ kind: 'parsed',
    sessionDbId, messageId, contentSessionId, parsed }) so the
    event-emission path is single-sourced.
  - ingestSummary's requireContext() resolution moved inside the
    'queue' branch (the only branch that needs sessionManager /
    dbManager). 'parsed' is a pure event-bus emission and
    doesn't need worker-internal context — fixes mocked
    ResponseProcessor unit tests that don't call
    setIngestContext.

P2 — isWorkerFallback could false-positive on legitimate API
responses whose schema includes { continue: true, ... }:
  - Added a Symbol.for('claude-mem/worker-fallback') brand to
    WorkerFallback. isWorkerFallback now checks the brand, not
    a duck-typed property name.

Verification: bun run build succeeds. bun test → 1393 pass /
28 fail / 7 skip — exact baseline match. Zero new failures.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

* fix: address Greptile iteration 2 (P1 + P2)

P1 — summaryStoredEvent fired regardless of whether the row was
persisted. ResponseProcessor's call to ingestSummary({ kind:
'parsed' }) ran for every parsed.kind === 'summary' even when
result.summaryId came back null (e.g. FK violation, null
memory_session_id at commit). The blocking /api/session/end
endpoint then returned { ok: true } and the Stop hook logged
'Summary stored' for a non-existent row.

  - Gate ingestSummary call on (parsed.data.skipped ||
    session.lastSummaryStored). Skipped summaries are an explicit
    no-op bypass and still confirm; real summaries only confirm
    when storage actually wrote a row.
  - Non-skipped + summaryId === null path logs a warn and lets
    the server-side timeout (504) surface to the hook instead of
    a false ok:true.

P2 — PendingMessageStore.enqueue() returns 0 when INSERT OR
IGNORE suppresses a duplicate (the UNIQUE(session_id, tool_use_id)
constraint added by Plan 01 Phase 1). The two callers
(SessionManager.queueObservation and queueSummarize) previously
logged 'ENQUEUED messageId=0' which read like a row was inserted.

  - Branch on messageId === 0 and emit a 'DUP_SUPPRESSED' debug
    log instead of the misleading ENQUEUED line. No behavior
    change — the duplicate is still correctly suppressed by the
    DB (Principle 3); only the log surface is corrected.
  - confirmProcessed is never called with the enqueue() return
    value (it operates on session.processingMessageIds[] from
    claimNextMessage), so no caller is broken; the visibility
    fix prevents future misuse.

Verification: bun run build succeeds. bun test → 1393 pass /
28 fail / 7 skip — exact baseline match. Zero new failures.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

* fix: address Greptile iteration 3 (P1 + 2× P2)

- P1 worker-service.ts: wire ensureGeneratorRunning into the ingest
  context after SessionRoutes is constructed. setIngestContext runs
  before routes exist, so transcript-watcher observations queued via
  ingestObservation() had no way to auto-start the SDK generator.
  Added attachIngestGeneratorStarter() to patch the callback in.
- P2 shared.ts: IngestEventBus now sets maxListeners to 0. Concurrent
  /api/session/end calls register one listener each and clean up on
  completion, so the default-10 warning fires spuriously under normal
  load.
- P2 SessionRoutes.ts: handleObservationsByClaudeId now delegates to
  ingestObservation() instead of duplicating skip-tool / meta /
  privacy / queue logic. Single helper, matching the Plan 03 goal.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

* fix: address Greptile iteration 4 (P1 tool-pair + P2 parse/path/doc)

- processor.handleToolResult: restore in-memory tool-use→tool-result
  pairing via session.pendingTools for schemas (e.g. Codex) whose
  tool_result events carry only tool_use_id + output. Without this,
  neither handler fired — all tool observations silently dropped.
- processor.maybeParseJson: return raw string on parse failure instead
  of throwing. Previously a single malformed JSON-shaped field caused
  handleLine's outer catch to discard the entire transcript line.
- watcher.deepestNonGlobAncestor: split on / and \\, emit empty string
  for purely-glob inputs so the caller skips the watch instead of
  anchoring fs.watch at the filesystem root. Windows-compatible.
- PendingMessageStore.enqueue: tighten docstring — callers today only
  log on the returned id; the SessionManager branches on id === 0.

* fix: forward tool_use_id through ingestObservation (Greptile iter 5)

P1 — Plan 01's UNIQUE(content_session_id, tool_use_id) dedup never
fired because the new shared ingest path dropped the toolUseId before
queueObservation. SQLite treats NULL values as distinct for UNIQUE,
so every replayed transcript line landed a duplicate row.

- shared.ingestObservation: forward payload.toolUseId to
  queueObservation so INSERT OR IGNORE can actually collapse.
- SessionRoutes.handleObservationsByClaudeId: destructure both
  tool_use_id (HTTP convention) and toolUseId (JS convention) from
  req.body and pass into ingestObservation.
- observationsByClaudeIdSchema: declare both keys explicitly so the
  validator doesn't rely on .passthrough() alone.

* fix: drop dead pairToolUsesByJoin, close session-end listener race

- PendingMessageStore: delete pairToolUsesByJoin. The method was never
  called and its self-join semantics are structurally incompatible
  with UNIQUE(content_session_id, tool_use_id): INSERT OR IGNORE
  collapses any second row with the same pair, so a self-join can
  only ever match a row to itself. In-memory pendingTools in
  processor.ts remains the pairing path for split-event schemas.

- IngestEventBus: retain a short-lived (60s) recentStored map keyed
  by sessionId. Populated on summaryStoredEvent emit, evicted on
  consume or TTL.

- handleSessionEnd: drain the recent-events buffer before attaching
  the listener. Closes the register-after-emit race where the summary
  can persist between the hook's summarize POST and its session/end
  POST — previously that window returned 504 after the 30s timeout.

* chore: merge origin/main into vivacious-teeth

Resolves conflicts with 15 commits on main (v12.3.9, security
observation types, Telegram notifier, PID-reuse worker start-guard).

Conflict resolution strategy:
- plugin/hooks/hooks.json, plugin/scripts/*.cjs, plugin/ui/viewer-bundle.js:
  kept ours — PATHFINDER Plan 05 deletes the for-i-in-1-to-20 curl retry
  loops and the built artifacts regenerate on build.
- src/cli/handlers/summarize.ts: kept ours — Plan 05 blocking
  POST /api/session/end supersedes main's fire-and-forget path.
- src/services/worker-service.ts: kept ours — Plan 05 ingest bus +
  summaryStoredEvent supersedes main's SessionCompletionHandler DI
  refactor + orphan-reaper fallback.
- src/services/worker/http/routes/SessionRoutes.ts: kept ours — same
  reason; generator .finally() Stop-hook self-clean is a guard for a
  path our blocking endpoint removes.
- src/services/worker/http/routes/CorpusRoutes.ts: merged — added
  security_alert / security_note to ALLOWED_CORPUS_TYPES (feature from
  #2084) while preserving our Zod validateBody schema.

Typecheck: 294 errors (vs 298 pre-merge). No new errors introduced; all
remaining are pre-existing (Component-enum gaps, DOM lib for viewer,
bun:sqlite types).

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

* fix: address Greptile P2 findings

1) SessionRoutes.handleSessionEnd was the only route handler not wrapped
   in wrapHandler — synchronous exceptions would hang the client rather
   than surfacing as 500s. Wrap it like every other handler.

2) processor.handleToolResult only consumed the session.pendingTools
   entry when the tool_result arrived without a toolName. In the
   split-schema path where tool_result carries both toolName and toolId,
   the entry was never deleted and the map grew for the life of the
   session. Consume the entry whenever toolId is present.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

* fix: typing cleanup and viewer tsconfig split for PR feedback

- Add explicit return types for SessionStore query methods
- Exclude src/ui/viewer from root tsconfig, give it its own DOM-typed config
- Add bun to root tsconfig types, plus misc typing tweaks flagged by Greptile
- Rebuilt plugin/scripts/* artifacts

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

* fix: address Greptile P2 findings (iter 2)

- PendingMessageStore.transitionMessagesTo: require sessionDbId (drop
  the unscoped-drain branch that would nuke every pending/processing
  row across all sessions if a future caller omitted the filter).
- IngestEventBus.takeRecentSummaryStored: make idempotent — keep the
  cached event until TTL eviction so a retried Stop hook's second
  /api/session/end returns immediately instead of hanging 30 s.
- TranscriptWatcher fs.watch callback: skip full glob scan for paths
  already tailed (JSONL appends fire on every line; only unknown
  paths warrant a rescan).

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

* fix: call finalizeSession in terminal session paths (Greptile iter 3)

terminateSession and runFallbackForTerminatedSession previously called
SessionCompletionHandler.finalizeSession before removeSessionImmediate;
the refactor dropped those calls, leaving sdk_sessions.status='active'
for every session killed by wall-clock limit, unrecoverable error, or
exhausted fallback chain. The deleted reapStaleSessions interval was
the only prior backstop.

Re-wires finalizeSession (idempotent: marks completed, drains pending,
broadcasts) into both paths; no reaper reintroduced.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

* fix: GC failed pending_messages rows at startup (Greptile iter 4)

Plan 07 deleted clearFailed/clearFailedOlderThan as "dead code", but
with the periodic sweep also removed, nothing reaps status='failed'
rows now — they accumulate indefinitely. Since claimNextMessage's
self-healing subquery scans this table, unbounded growth degrades
claim latency over time.

Re-introduces clearFailedOlderThan and calls it once at worker startup
(not a reaper — one-shot, idempotent). 7-day retention keeps enough
history for operator inspection while bounding the table.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

* fix: finalize sessions on normal exit; cleanup hoist; share handler (iter 5)

1. startSessionProcessor success branch now calls completionHandler.
   finalizeSession before removeSessionImmediate. Hooks-disabled installs
   (and any Stop hook that fails before POST /api/sessions/complete) no
   longer leave sdk_sessions rows as status='active' forever. Idempotent
   — a subsequent /api/sessions/complete is a no-op.

2. Hoist SessionRoutes.handleSessionEnd cleanup declaration above the
   closures that reference it (TDZ safety; safe at runtime today but
   fragile if timeout ever shrinks).

3. SessionRoutes now receives WorkerService's shared SessionCompletionHandler
   instead of constructing its own — prevents silent divergence if the
   handler ever becomes stateful.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

* fix: stop runaway crash-recovery loop on dead sessions

Two distinct bugs were combining to keep a dead session restarting forever:

Bug 1 (uncaught "The operation was aborted."):
  child_process.spawn emits 'error' asynchronously for ENOENT/EACCES/abort
  signal aborts. spawnSdkProcess() never attached an 'error' listener, so
  any async spawn failure became uncaughtException and escaped to the
  daemon-level handler. Attach an 'error' listener immediately after spawn,
  before the !child.pid early-return, so async spawn errors are logged
  (with errno code) and swallowed locally.

Bug 2 (sliding-window limiter never trips on slow restart cadence):
  RestartGuard tripped only when restartTimestamps.length exceeded
  MAX_WINDOWED_RESTARTS (10) within RESTART_WINDOW_MS (60s). With the 8s
  exponential-backoff cap, only ~7-8 restarts fit in the window, so a dead
  session that fail-restart-fail-restart on 8s cycles would loop forever
  (consecutiveRestarts climbing past 30+ in observed logs). Add a
  consecutiveFailures counter that increments on every restart and resets
  only on recordSuccess(). Trip when consecutive failures exceed
  MAX_CONSECUTIVE_FAILURES (5) — meaning 5 restarts with zero successful
  processing in between proves the session is dead. Both guards now run in
  parallel: tight loops still trip the windowed cap; slow loops trip the
  consecutive-failure cap.

Also: when the SessionRoutes path trips the guard, drain pending messages
to 'abandoned' so the session does not reappear in
getSessionsWithPendingMessages and trigger another auto-start cycle. The
worker-service.ts path already does this via terminateSession.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

* perf: streamline worker startup and consolidate database connections

1. Database Pooling: Modified DatabaseManager, SessionStore, and SessionSearch to share a single bun:sqlite connection, eliminating redundant file descriptors.
2. Non-blocking Startup: Refactored WorktreeAdoption and Chroma backfill to run in the background (fire-and-forget), preventing them from stalling core initialization.
3. Diagnostic Routes: Added /api/chroma/status and bypassed the initialization guard for health/readiness endpoints to allow diagnostics during startup.
4. Robust Search: Implemented reliable SQLite FTS5 fallback in SearchManager for when Chroma (uvx) fails or is unavailable.
5. Code Cleanup: Removed redundant loopback MCP checks and mangled initialization logic from WorkerService.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

* fix: hard-exclude observer-sessions from hooks; bundle migration 29 (#2124)

* fix: hard-exclude observer-sessions from hooks; backfill bundle migrations

Stop hook + SessionEnd hook were storing the SDK observer's own
init/continuation/summary prompts in user_prompts, leaking into the
viewer (meta-observation regression). 25 such rows accumulated.

- shouldTrackProject: hard-reject OBSERVER_SESSIONS_DIR (and its subtree)
  before consulting user-configured exclusion globs.
- summarize.ts (Stop) and session-complete.ts (SessionEnd): early-return
  when shouldTrackProject(cwd) is false, so the observer's own hooks
  cannot bootstrap the worker or queue a summary against the meta-session.
- SessionRoutes: cap user-prompt body at 256 KiB at the session-init
  boundary so a runaway observer prompt cannot blow up storage.
- SessionStore: add migration 29 (UNIQUE(memory_session_id, content_hash)
  on observations) inline so bundled artifacts (worker-service.cjs,
  context-generator.cjs) stay schema-consistent — without it, the
  ON CONFLICT clause in observation inserts throws.
- spawnSdkProcess: stdio[stdin] from 'ignore' to 'pipe' so the
  supervisor can actually feed the observer's stdin.

Also rebuilds plugin/scripts/{worker-service,context-generator}.cjs.

* fix: walk back to UTF-8 boundary on prompt truncation (Greptile P2)

Plain Buffer.subarray at MAX_USER_PROMPT_BYTES can land mid-codepoint,
which the utf8 decoder silently rewrites to U+FFFD. Walk back over any
continuation bytes (0b10xxxxxx) before decoding so the truncated prompt
ends on a valid sequence boundary instead of a replacement character.

* fix: cross-platform observer-dir containment; clarify SDK stdin pipe

claude-review feedback on PR #2124.

- shouldTrackProject: literal `cwd.startsWith(OBSERVER_SESSIONS_DIR + '/')`
  hard-coded a POSIX separator and missed Windows backslash paths plus any
  trailing-slash variance. Switched to a path.relative-based isWithin()
  helper so Windows hook input under observer-sessions\\... is also excluded.
- spawnSdkProcess: added a comment explaining why stdin must be 'pipe' —
  SpawnedSdkProcess.stdin is typed NonNullable and the Claude Agent SDK
  consumes that pipe; 'ignore' would null it and the null-check below
  would tear the child down on every spawn.

* fix: make Stop hook fire-and-forget; remove dead /api/session/end

The Stop hook was awaiting a 35-second long-poll on /api/session/end,
which the worker held open until the summary-stored event fired (or its
30s server-side timeout elapsed). Followed by another await on
/api/sessions/complete. Three sequential awaits, the middle one a 30s
hold — not fire-and-forget despite repeated requests.

The Stop hook now does ONE thing: POST /api/sessions/summarize to
queue the summary work and return. The worker drives the rest async.
Session-map cleanup is performed by the SessionEnd handler
(session-complete.ts), not duplicated here.

- summarize.ts: drop the /api/session/end long-poll and the trailing
  /api/sessions/complete await; ~40 lines removed; unused
  SessionEndResponse interface gone; header comment rewritten.
- SessionRoutes: delete handleSessionEnd, sessionEndSchema, the
  SERVER_SIDE_SUMMARY_TIMEOUT_MS constant, and the /api/session/end
  route registration. Drop the now-unused ingestEventBus and
  SummaryStoredEvent imports.
- ResponseProcessor + shared.ts + worker-utils.ts: update stale
  comments that referenced the dead endpoint. The IngestEventBus is
  left in place dormant (no listeners) for follow-up cleanup so this
  PR stays focused on the blocker.

Bundle artifact (worker-service.cjs) rebuilt via build-and-sync.

Verification:
- grep '/api/session/end' plugin/scripts/worker-service.cjs → 0
- grep 'timeoutMs:35' plugin/scripts/worker-service.cjs → 0
- Worker restarted clean, /api/health ok at pid 92368

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

* deps: bump all dependencies to latest including majors

Upgrades: React 18→19, Express 4→5, Zod 3→4, TypeScript 5→6,
@types/node 20→25, @anthropic-ai/claude-agent-sdk 0.1→0.2,
@clack/prompts 0.9→1.2, plus minors. Adds Daily Maintenance section
to CLAUDE.md mandating latest-version policy across manifests.

Express 5 surfaced a race in Server.listen() where the 'error' handler
was attached after listen() was invoked; refactored to use
http.createServer with both 'error' and 'listening' handlers attached
before listen(), restoring port-conflict rejection semantics.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

* fix: surface real chroma errors and add deep status probe

Replace the misleading "Vector search failed - semantic search unavailable.
Install uv... restart the worker." string in SearchManager with the actual
exception text from chroma_query_documents. The lying message blamed `uv`
for any failure — even when the real cause was a chroma-mcp transport
timeout, an empty collection, or a dead subprocess.

Also add /api/chroma/status?deep=1 backed by a new
ChromaMcpManager.probeSemanticSearch() that round-trips a real query
(chroma_list_collections + chroma_query_documents) instead of just
checking the stdio handshake. The cheap default path is unchanged.

Includes the diagnostic plan (PLAN-fix-mcp-search.md) and updated test
fixtures for the new structured failure message.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

* chore: rebuild worker-service bundle to match merged src

Bundle was stale after the squash merge of #2124 — it still contained
the old "Install uv... semantic search unavailable" string and lacked
probeSemanticSearch. Rebuilt via bun run build-and-sync.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

* docs: address coderabbit feedback on PLAN-fix-mcp-search.md

- replace machine-specific /Users/alexnewman absolute paths with portable
  <repo-root> placeholder (MD-style portability)
- add blank lines around the TypeScript fenced block (MD031)
- tag the bare fenced block with `text` (MD040)

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
2026-04-25 13:37:40 -07:00

36 KiB
Raw Blame History

Phase Plan 09 — lifecycle-hooks (clean)

Date: 2026-04-22 Target flowchart: PATHFINDER-2026-04-21/05-clean-flowcharts.md §3.1 ("lifecycle-hooks (clean)") Before-state: PATHFINDER-2026-04-21/01-flowcharts/lifecycle-hooks.md Scope: Collapse the 10 current SessionRoutes endpoints + the 500-ms polling Stop hook + the 8 per-handler ensureWorkerRunning calls + the duplicate /api/context/* fetches into the clean 4-endpoint, no-polling, hook-cached design from §3.1. Zero user-facing change. Exit codes preserved.


Header: Dependencies

Upstream (must land first):

  • Plan 01 — privacy-tag-filtering (Phases 12 of the implementation plan — stripMemoryTags + ingestObservation/ingestPrompt/ingestSummary helpers). Required because the new POST /api/session/observation, POST /api/session/prompt, and POST /api/session/end endpoints call those ingest helpers rather than re-implementing tag stripping. Cite: 06-implementation-plan.md Phase 1 + Phase 2 (plan authoring pipeline; 01-privacy-tag-filtering.md when landed).
  • Plan 05 — context-injection-engine — introduces GET /api/session/start returning {sessionDbId, contextMarkdown, semanticMarkdown}. Phase 1 of this plan depends on that endpoint existing on the worker side. Cite: 05-clean-flowcharts.md §3.5 + §3.1 arrow SS → SSR.
  • Plan 07 — session-lifecycle-management — introduces blocking POST /api/session/end (per-session Deferred<SummaryResult> resolved by ResponseProcessor when the summary row is written; 110 s hard timeout). Phase 3 of this plan switches the Stop hook to call that endpoint. Cite: 05-clean-flowcharts.md §3.8 (POST /api/session/end → queueSummarize → await summary_stored flag OR 110s timeout), Part 2 decision D6 (blocking endpoints over polling), 06-implementation-plan.md Phase 11 step 2.

Downstream: none. This is a leaf cleanup in the dependency DAG — no other feature plan reads from the hook layer.


Sources Consulted (what this plan is built from)

  1. PATHFINDER-2026-04-21/05-clean-flowcharts.md — full read. Authoritative §3.1 diagram (lines 89123); §3.9 route inventory (lines 382418); Part 1 bullshit-inventory items #11 (500 ms poll), #12 (double /api/context/inject), #13 (ensureWorkerRunning every entry), #14 (/api/context/inject + /api/context/semantic both at UserPromptSubmit); Part 2 decision D6 (blocking endpoints over polling, line 79); Part 4 timer census (Summary poll 500 ms × 220 iter → endpoint blocks, line 520); Part 5 deletion ledger rows Summarize 500-ms polling hook -60/+20 and Double /api/context/* fetches → /api/session/start -120/+60 (lines 552553).
  2. PATHFINDER-2026-04-21/06-implementation-plan.md — Phase 0 verified-findings V8 (500 ms poll @ summarize.ts:117150, POLL_INTERVAL_MS=500 @ :24, MAX_WAIT_FOR_SUMMARY_MS=110_000 @ :25), V9 (SessionRoutes is actually 10 endpoints, not 8: six /sessions/:sessionDbId/* at :377:382 + five /api/sessions/* at :385:389; /api/sessions/status is the polled one), V10 (ensureWorkerRunning in all 8 CLI handlers: context.ts:19, user-message.ts:35, summarize.ts:44, observation.ts:34, file-context.ts:218, file-edit.ts:32, session-init.ts:41, session-complete.ts:35). Phase 2 (unified ingest helpers) and Phase 11 (endpoint consolidation) define the shared contract.
  3. PATHFINDER-2026-04-21/01-flowcharts/lifecycle-hooks.md — "before" diagram. 10 hook→worker HTTP edges enumerated (lines 8492 — side effects). Two-phase Stop handling (summarize → poll → session-complete) at lines 6873.
  4. Live codebase (verified Read/Grep during authoring, 2026-04-22):
    • src/cli/handlers/context.ts:19await ensureWorkerRunning() at SessionStart.
    • src/cli/handlers/user-message.ts:35await ensureWorkerRunning() at SessionStart (parallel).
    • src/cli/handlers/session-init.ts:41 — UserPromptSubmit.
    • src/cli/handlers/observation.ts:34 — PostToolUse.
    • src/cli/handlers/summarize.ts:17 (import), :24 (POLL_INTERVAL_MS = 500), :25 (MAX_WAIT_FOR_SUMMARY_MS = 110_000), :44 (ensureWorkerRunning), :89 (POST /api/sessions/summarize), :117150 (poll loop against /api/sessions/status?contentSessionId=…), :156 (POST /api/sessions/complete).
    • src/cli/handlers/session-complete.ts:18 (POST /api/sessions/complete), :35 (ensureWorkerRunning).
    • src/cli/handlers/file-context.ts:218 (ensureWorkerRunning), :237 (GET /api/observations/by-file).
    • src/cli/handlers/file-edit.ts:15 (POST /api/sessions/observations), :32 (ensureWorkerRunning).
    • src/services/worker/http/routes/SessionRoutes.ts:375389setupRoutes registers 10 routes:
      • Legacy /sessions/:sessionDbId/* × 6 (:377 init, :378 observations, :379 summarize, :380 status, :381 delete, :382 complete).
      • /api/sessions/* × 5 (:385 init, :386 observations, :387 summarize, :388 complete, :389 status).
      • (Earlier sections above register :setupRoutes itself on the Express app; the 11 .get/.post/.delete( tokens outside setupRoutes are internal maps, not routes — verified.)
    • src/shared/hook-constants.ts:2122HOOK_EXIT_CODES.SUCCESS = 0. Every handler returns it on the graceful-degradation path (required by CLAUDE.md exit-code strategy — Windows Terminal tab preservation depends on exit 0).
  5. Dependency plans: not yet written on disk. Plans 01, 05, 07 will be authored in parallel to this one; citations above reference their planned phase numbers per 06-implementation-plan.md (authoritative sequencing doc).

Endpoint Reality Check (numbers — V9 vs §3.9 claim)

Source Claimed current count Verified current count
05-clean-flowcharts.md §3.1 "Endpoint count: 8 → 4" (line 123) 8
06-implementation-plan.md Phase 0 V9 10 (six :377:382 + five :385:389)
Live Grep router\. / .post/.get/.delete on SessionRoutes.ts (2026-04-22) 10 (confirms V9; §3.9 "8" is an undercount)

This plan uses 10 → 4 as the verified target. The §3.1 "8 → 4" claim is footnoted as an undercount of the legacy /sessions/:sessionDbId/* subtree.


Hook → Endpoint Mapping (current vs clean)

Claude Code event Current hook handler Current endpoints called Clean endpoint (§3.1)
SessionStart context.ts GET /api/context/inject?projects=… (:41) + (conditionally) GET /api/context/inject?colors=true (:42) GET /api/session/start?project=… — returns {sessionDbId, contextMarkdown, semanticMarkdown}
SessionStart (parallel) user-message.ts GET /api/context/inject?project=…&colors=true (:14) (same) — reads from the cached /api/session/start response in context.ts; no second HTTP call
UserPromptSubmit session-init.ts POST /api/sessions/init (:75), POST /sessions/{id}/init (:141), POST /api/context/semantic (:23) POST /api/session/prompt {sessionDbId, prompt} → returns {promptId} (SDK-start implicit inside prompt handler)
PostToolUse observation.ts POST /api/sessions/observations (:17) POST /api/session/observation {sessionDbId, tool_use_id, name, input, output}{observationId}
PostToolUse (Cursor file-edit) file-edit.ts POST /api/sessions/observations (:15) POST /api/session/observation (same endpoint, same payload shape)
PreToolUse (file-context gate) file-context.ts GET /api/observations/by-file (:237) Unchanged — this is a read endpoint outside the Session lifecycle; belongs to Plan 08 (DataRoutes), not this one
Stop summarize.ts POST /api/sessions/summarize (:89) + poll GET /api/sessions/status 500 ms × up to 220 iter (:117150) + POST /api/sessions/complete (:156) POST /api/session/end {sessionDbId, last_assistant_message} — blocks until summary written or 110 s timeout; returns `{summaryId
Stop (phase 2) session-complete.ts POST /api/sessions/complete (:18) Deleted. Folded into POST /api/session/end (§3.1: "Two-phase Stop handling (summarize then session-complete) — one endpoint, one response").

Endpoints before: 10 on SessionRoutes + 2 on SearchRoutes (/api/context/inject, /api/context/semantic) = 12 lifecycle-touching endpoints. Endpoints after: 4 on SessionRoutes (start, prompt, observation, end). /api/context/* removed (folded into /api/session/start). Net delete: 10 4 = 6 from SessionRoutes; 2 from SearchRoutes; 8 total.


Phase Contract (applied to every phase below)

Each phase specifies:

  • (a) What to implement — "Copy from §X.Y / V-finding / file:line" — no invention.
  • (b) Docs05-clean-flowcharts.md section + V8/V9/V10 + live file:line.
  • (c) Verification — grep counts, before/after.
  • (d) Anti-pattern guardsA (invent hook event types), B (polling — replace 500 ms loop with blocking endpoint + SSE), D (two context fetches collapse to one GET /api/session/start), E (duplicate /api/context/inject at SessionStart + user-message — single cache).

Phase 1 — Collapse double /api/context/* fetches into single GET /api/session/start

(a) What to implement

Copy from 05-clean-flowcharts.md §3.1 lines 95, 100 (SS --> SSR["Returns {sessionDbId, contextMarkdown, semanticMarkdown}"]) and §3.5 line 236 (generateContext(projects, forHuman=false) + generateContext(projects, forHuman=true) on one route handler).

Switch context.ts + user-message.ts to a single GET /api/session/start call. The worker route is produced by Plan 05 Phase 1; this phase only rewires the two hook handlers.

  1. Rewrite src/cli/handlers/context.ts:4174: replace the two-URL Promise.all([workerHttpRequest(apiPath), showTerminalOutput ? workerHttpRequest(colorApiPath).catch(()=>null) : …]) with one workerHttpRequest('/api/session/start?project=…&colors=…&semantic=…'). Parse response as {sessionDbId, contextMarkdown, humanMarkdown?, semanticMarkdown}. contextMarkdownadditionalContext; humanMarkdown (present when colors=true) → systemMessage block.
  2. Delete user-message.ts:fetchAndDisplayContext (lines 1330) entirely. The parallel SessionStart display becomes a second consumer of context.ts's cached /api/session/start result — see Phase 2 for the shared cache. In the interim (before Phase 2 lands), user-message.ts calls /api/session/start?colors=true&display=true with its own request — one HTTP call, still replaces the old /api/context/inject double-call. Remove the fetchAndDisplayContext helper + its usage at :46.
  3. Delete hook-side calls to /api/context/inject anywhere they appear. Grep: only context.ts:41,42 + user-message.ts:1416 touch it. After this phase: zero hook-side references to /api/context/inject.
  4. session-init.ts:23 (POST /api/context/semantic) moves to Phase 6 (consolidated with session-prompt); leave untouched here.

(b) Docs

  • §3.1 lines 95, 100 — SS → SSR edge.
  • §3.5 line 236 — generateContext(projects, forHuman=false) + generateContext(projects, forHuman=true) (dual-strategy render).
  • Part 1 items #12 ("double /api/context/inject at SessionStart") and #14 ("/api/context/inject + /api/context/semantic both at UserPromptSubmit — fold into /api/session/start").
  • V10 — both context.ts:19 and user-message.ts:35 currently bootstrap the worker then each fire a GET.
  • Live: src/cli/handlers/context.ts:4174, src/cli/handlers/user-message.ts:1330,46.

(c) Verification

grep -rn "/api/context/inject" src/cli/handlers/          → 0 matches
grep -rn "/api/session/start" src/cli/handlers/            → 2 matches (context.ts + user-message.ts)
grep -c "workerHttpRequest" src/cli/handlers/context.ts    → 1 (was 2 — the `apiPath` + `colorApiPath` pair collapses)

Snapshot test: capture additionalContext bytes from an existing SessionStart fixture and assert byte-equal after the rewire (strategy-driven rendering must be indistinguishable in forHuman=false mode).

(d) Anti-pattern guards

  • D — no two fetches for the same data. /api/session/start is one request returning both markdowns.
  • E — the parallel SessionStart display in user-message.ts shares the response shape; Phase 2 collapses to one cache entry.
  • A — no new hookEventName values. Still 'SessionStart' at context.ts:88.

Phase 2 — Cache alive=true in the hook process for the session lifetime

(a) What to implement

Copy from 05-clean-flowcharts.md §3.1 "Deleted from old flowchart" bullet 1 ("ensureWorkerRunning at every entry point (cache alive for the hook lifetime)") + Part 1 item #13 ("Hook has no shared state. — Cache alive=true in the hook process for the session.").

  1. Create src/hooks/worker-cache.ts (new file, ~25 lines):

    // One variable in the hook's process; lives as long as the hook process does.
    let alive: boolean | null = null;
    // Cached /api/session/start response, shared between context + user-message handlers
    // within the same hook process (invoked once per SessionStart fan-out).
    let sessionStartResponse: SessionStartResponse | null = null;
    
    export async function ensureWorkerAliveOnce(): Promise<boolean> {
      if (alive !== null) return alive;
      alive = await originalEnsureWorkerRunning();
      return alive;
    }
    
    export function cacheSessionStart(response: SessionStartResponse): void { sessionStartResponse = response; }
    export function getCachedSessionStart(): SessionStartResponse | null { return sessionStartResponse; }
    

    "Hook process" = one Node/Bun invocation per Claude Code hook event. Lifetime ~50 ms ~120 s. Module-scope let is sufficient; no cross-process state needed.

  2. Switch all 8 CLI handlers to import ensureWorkerAliveOnce instead of ensureWorkerRunning:

    • context.ts:19, user-message.ts:35, summarize.ts:44, observation.ts:34, file-context.ts:218, file-edit.ts:32, session-init.ts:41, session-complete.ts:35.
  3. First-call behaviour: the first handler in a given hook process spawns/pings the worker (same code path as today's ensureWorkerRunning in src/shared/worker-utils.ts). Subsequent calls in the same process skip.

  4. Cross-handler coordination for SessionStart: when context.ts receives the /api/session/start response it calls cacheSessionStart(response). user-message.ts (running as a parallel handler in the same hook process when both are wired to SessionStart) calls getCachedSessionStart() first; falls back to its own fetch if null (separate hook-process invocations).

(b) Docs

  • §3.1 "Deleted from old flowchart" bullet 1.
  • Part 1 item #13.
  • V10 — 8 live callsites today.
  • Live: src/shared/worker-utils.ts (current ensureWorkerRunning implementation is the one ensureWorkerAliveOnce delegates to internally).

(c) Verification

grep -rn "ensureWorkerRunning" src/cli/handlers/           → 0 matches (was 8 import lines + 8 callsites)
grep -rn "ensureWorkerAliveOnce" src/cli/handlers/         → 8 import + 8 callsite matches
grep -c "ensureWorkerRunning" src/cli/handlers/*.ts        → reduces from 8 to 0 (cached)

Instrumentation test: start a Claude Code session, trigger SessionStart → UserPromptSubmit → 2× PostToolUse → Stop. Assert the worker's GET /health (or equivalent startup ping) is called once per hook process, not once per handler. (Today it's 5 calls in the SessionStart fan-out alone.)

(d) Anti-pattern guards

  • E — one cache, two readers (context.ts + user-message.ts). No duplicate cache keys.
  • A — no WorkerCacheService class. Module-scope let is sufficient; adding a class would be invention (CLAUDE.md: YAGNI, simple-first).

Exit-code invariant

The caller still returns HOOK_EXIT_CODES.SUCCESS when ensureWorkerAliveOnce() returns false (worker unavailable → empty context → exit 0). CLAUDE.md exit-code strategy preserved: Windows Terminal tabs continue to close on exit 0 even when the worker is down.


Phase 3 — Replace summarize.ts 500 ms poll loop with single blocking POST /api/session/end

(a) What to implement

Copy from 05-clean-flowcharts.md §3.1 lines 98, 107 (STOP --> STOPR["Returns {summaryId or null}"]) + §3.8 lines 346349 (POST /api/session/end → queueSummarize → await summary_stored flag OR 110s timeout → abortController.abort → Delete) + Part 2 decision D6. The worker-side blocking endpoint is implemented by Plan 07 Phase 2 (per-session Deferred<SummaryResult> resolved by ResponseProcessor when the summary row is written).

  1. Rewrite src/cli/handlers/summarize.ts:86167 (the queue + poll + complete block) into:
    const response = await workerHttpRequest('/api/session/end', {
      method: 'POST',
      headers: { 'Content-Type': 'application/json' },
      body: JSON.stringify({ contentSessionId: sessionId, last_assistant_message: lastAssistantMessage, platformSource }),
      timeoutMs: MAX_WAIT_FOR_SUMMARY_MS + 5_000  // 115s — hook times out slightly after server
    });
    // Response: { summaryId: number | null, timedOut?: boolean }
    
  2. Delete constants POLL_INTERVAL_MS = 500 (:24) and POLL_INTERVAL_MS references. MAX_WAIT_FOR_SUMMARY_MS stays — migrates from poll-duration cap to HTTP-client timeout (preserves the 110 s semantic).
  3. Delete the poll loop (summarize.ts:117150).
  4. Delete the explicit session-complete call (summarize.ts:155161) — folded into the worker's /api/session/end handler on the other side of the wire.
  5. Preserve the subagent guard at :3441 (exits early before any HTTP).
  6. Preserve the transcript-extract guard at :6078 (exits 0 when no assistant message).
  7. Preserve the exit-code contract: successful completion, timeout, and worker-unreachable all return HOOK_EXIT_CODES.SUCCESS (exit 0). This matches today's summarize.ts:47,56,67,77,103,107,167 — every return path exits 0. CLAUDE.md exit-code strategy: Windows Terminal closes tabs on exit 0, so the 110 s timeout path must also exit 0, not 2.

(b) Docs

  • §3.1 lines 98, 107 — STOP edge.
  • §3.8 lines 346349 — End → Queue_Sum → WaitSum → Abort → Delete.
  • Part 2 D6 (blocking endpoints over polling, line 79).
  • Part 4 timer census line 520 (Summary poll (500 ms × 220 iter) ✓ before / ✗ after).
  • V8summarize.ts:117150 + :24 + :25.
  • V9/api/sessions/status is deleted in Phase 5.
  • Live: src/cli/handlers/summarize.ts:2425,86167.

(c) Verification

grep -n "POLL_INTERVAL_MS" src/                            → 0 matches
grep -n "MAX_WAIT_FOR_SUMMARY_MS" src/cli/handlers/summarize.ts → 1 match (used as HTTP timeout)
grep -n "/api/sessions/status" src/                        → 0 matches in src/cli/
grep -n "/api/session/end" src/cli/handlers/summarize.ts   → 1 match
wc -l src/cli/handlers/summarize.ts                        → < 90 (was 169)

End-to-end: run a Claude Code session that produces a summary. Assert the Stop hook returns within ~(summary-processing time + 1 s), not ≥500 ms (the old minimum due to the first poll interval). Assert no GET /api/sessions/status requests hit the worker log.

Timeout path test: configure the SDK agent to hang past 110 s. Assert Stop hook returns exit 0 with summaryId: null, timedOut: true. This is the exit-code invariant that CLAUDE.md's Windows Terminal note demands — confirm explicitly (see "Confidence + Gaps" below).

(d) Anti-pattern guards

  • B — polling replaced by blocking endpoint + HTTP-client timeout. The hook-side client timeout is MAX_WAIT_FOR_SUMMARY_MS + 5_000 to give the server side first claim on the 110 s budget.
  • A — no new SessionStopResult type; reuse the existing {summaryId, timedOut?} shape Plan 07 Phase 2 defines.

Phase 4 — Delete /sessions/:sessionDbId/* legacy endpoints (6)

(a) What to implement

Copy from 06-implementation-plan.md Phase 11 step 3 ("Delete the old 10 endpoints under /sessions/:sessionDbId/* and /api/sessions/* after all hook-side callers are switched"). Also §3.9 line 403 (SessionRoutes: "/api/session/* (4 endpoints — see 3.1)").

  1. Delete registrations at SessionRoutes.ts:377382:
    • app.post('/sessions/:sessionDbId/init', this.handleSessionInit.bind(this));
    • app.post('/sessions/:sessionDbId/observations', this.handleObservations.bind(this));
    • app.post('/sessions/:sessionDbId/summarize', this.handleSummarize.bind(this));
    • app.get('/sessions/:sessionDbId/status', this.handleSessionStatus.bind(this));
    • app.delete('/sessions/:sessionDbId', this.handleSessionDelete.bind(this));
    • app.post('/sessions/:sessionDbId/complete', this.handleSessionComplete.bind(this));
  2. Delete handler methods handleSessionInit, handleObservations, handleSummarize, handleSessionStatus, handleSessionDelete, handleSessionComplete (the legacy six) if no other code references them.
  3. Keep the handle*ByClaudeId variants in place for this phase — Phase 5 deletes /api/sessions/status specifically; Phase 6 replaces the remaining four /api/sessions/* with the unified four /api/session/*.

(b) Docs

  • §3.1 line 123 ("Endpoint count: 8 → 4") — corrected to 10 → 4 per V9.
  • §3.9 line 403 — final target R3["SessionRoutes: /api/session/* (4 endpoints — see 3.1)"].
  • V9.
  • Live: src/services/worker/http/routes/SessionRoutes.ts:377382.

(c) Verification

grep -n "app\.\(post\|get\|delete\)\('/sessions/" src/services/worker/http/routes/SessionRoutes.ts → 0 matches
grep -n "app\.\(post\|get\|delete\)\('/api/sessions/" src/services/worker/http/routes/SessionRoutes.ts → 5 matches (Phase 5+6 reduce to 0)
wc -l src/services/worker/http/routes/SessionRoutes.ts   → drops by ~250 lines (legacy handlers removed)

Integration test: send POST /sessions/1/init to a running worker. Assert 404. Send to /api/session/prompt (Phase 6's replacement). Assert 200.

(d) Anti-pattern guards

  • D — pure deletion; no "forwarding shim" to the new endpoints.
  • A — no "LegacySessionRoutes" compatibility module. Delete means delete. Users who pinned an old plugin version still have the old worker binary shipped with their install.

Phase 5 — Delete /api/sessions/status (polling endpoint is obsolete)

(a) What to implement

Copy from §3.1 "Deleted from old flowchart" bullet 5 ("500-ms poll loop on /api/sessions/status (replaced by blocking /api/session/end)"). Phase 3 removes the only consumer; this phase deletes the supply.

  1. Delete registration at SessionRoutes.ts:389 (app.get('/api/sessions/status', this.handleStatusByClaudeId.bind(this));).
  2. Delete handler method handleStatusByClaudeId + any private helpers it uses (if no other code references them).
  3. Sanity-grep for any residual polling client.

(b) Docs

  • §3.1 deletion bullet 5.
  • Part 2 D6.
  • V9 (endpoint 10 of 10).
  • Live: src/services/worker/http/routes/SessionRoutes.ts:389.

(c) Verification

grep -rn "/api/sessions/status" src/                       → 0 matches (hook side removed in Phase 3)
grep -n "handleStatusByClaudeId" src/                       → 0 matches

(d) Anti-pattern guards

  • B — no polling endpoint means no one can be tempted to re-add a 500 ms loop against it later.

Phase 6 — Consolidate session-init / session-complete handlers into unified session endpoints

(a) What to implement

Copy from §3.1 diagram edges:

  • UPS["POST /api/session/prompt<br/>{sessionDbId, prompt}"] --> UPSR["Returns {promptId}"] (lines 96, 103).
  • PTU["POST /api/session/observation<br/>{sessionDbId, tool_use_id, name, input, output}"] --> PTUR["Returns {observationId}"] (lines 97, 105).
  • "Deleted" bullet 3: "POST /sessions/{id}/init SDK-start endpoint (implicit inside /api/session/prompt)".
  • "Deleted" bullet 6: "Two-phase Stop handling (summarize then session-complete) — one endpoint, one response".
  1. Rewrite src/cli/handlers/session-init.ts:72150 as a single POST /api/session/prompt call:
    • Replace /api/sessions/init (:75) + /sessions/{sessionDbId}/init (:141) + /api/context/semantic (:23) with one workerHttpRequest('/api/session/prompt', {body: JSON.stringify({sessionId, project, prompt, platformSource})}).
    • The worker-side /api/session/prompt handler (implemented by Plan 07 Phase 3) does: (a) resolve/create sessionDbId, (b) ingestPrompt (Plan 01 Phase 2), (c) start the SDK agent if not already running for this session, (d) fetch semantic markdown via SearchOrchestrator, (e) return {promptId, sessionDbId, semanticMarkdown?}.
    • session-init.ts passes semanticMarkdown into additionalContext (preserves the user-facing semantic injection feature — §3.5 + §3.1 SS → SSR).
  2. Rewrite src/cli/handlers/observation.ts:17 to call POST /api/session/observation with the new {sessionDbId, tool_use_id, name, input, output} payload. tool_use_id is passed through from the Claude Code hook input (already captured in NormalizedHookInput — verify before landing; if not, Plan 01 Phase 2 adds it because the UNIQUE constraint in Phase 9 depends on it).
  3. Rewrite src/cli/handlers/file-edit.ts:15 similarly — same endpoint, Cursor flow generates a synthetic tool_use_id (file-edit:<path>:<mtime>) if none exists.
  4. Delete src/cli/handlers/session-complete.ts entirely. Its only role (mark session inactive) moves server-side into /api/session/end.
  5. Delete hook wiring for the Stop-phase-2 sessionCompleteHandler in the adapter layer (src/cli/adapters/claude-code.ts — verify dispatcher mapping; this handler was the second callsite for the Stop event, feeding the old two-phase flow).
  6. Delete the remaining four /api/sessions/* legacy endpoints at SessionRoutes.ts:385388 (init, observations, summarize, complete) — Phase 5 already deleted status. Their handlers handleSessionInitByClaudeId, handleObservationsByClaudeId, handleSummarizeByClaudeId, handleCompleteByClaudeId are deleted.

(b) Docs

  • §3.1 lines 96, 97, 103, 105 + deletion bullets 3, 6.
  • §3.8 lines 325332 (A POST /api/session/promptSessionManager.initializeSession → Create → ActiveSession → spawn SDK) — implicit SDK start.
  • V9 endpoints :385:388.
  • Live: src/cli/handlers/session-init.ts:75,141,23; src/cli/handlers/observation.ts:17; src/cli/handlers/file-edit.ts:15; src/cli/handlers/session-complete.ts (entire file).

(c) Verification

grep -rn "/api/sessions/" src/                              → 0 matches (all five legacy paths deleted)
grep -rn "/sessions/.*sessionDbId" src/                      → 0 matches (legacy six deleted in Phase 4)
grep -rn "/api/session/" src/                                → exactly 4 distinct paths: start, prompt, observation, end
grep -rn "/api/context/semantic" src/                        → 0 matches (folded into /api/session/prompt)
grep -rn "sessionCompleteHandler" src/                       → 0 matches (file deleted)
test -f src/cli/handlers/session-complete.ts                 → false

End-to-end: full SessionStart → UserPromptSubmit → PostToolUse × 3 → Stop cycle against a fresh worker. Assert exactly these HTTP calls (verified via worker access log):

  1. GET /api/session/start?project=… (SessionStart, from context.ts)
  2. (Maybe) GET /api/session/start?project=…&colors=true (SessionStart parallel, from user-message.ts) — if Phase 2 cache misses because the two handlers run in separate hook processes; otherwise 0 calls.
  3. POST /api/session/prompt (UserPromptSubmit)
  4. POST /api/session/observation × 3 (PostToolUse)
  5. POST /api/session/end (Stop)

Total: 5 or 6 HTTP calls per session (was 1014: one ensureWorkerRunning ping per handler + two /api/context/inject + /api/sessions/init + /sessions/1/init + /api/context/semantic + 3× /api/sessions/observations + /api/sessions/summarize + ~220× poll /api/sessions/status + /api/sessions/complete × 2).

(d) Anti-pattern guards

  • A — no new event type; POST /api/session/prompt maps 1:1 to the existing UserPromptSubmit hook. No hookEventName changes.
  • D/api/session/prompt is the single source of truth for "start processing this user prompt". No facade calling an internal /api/sessions/init.
  • Esession-init.ts and observation.ts both land on the same backend ingestObservation/ingestPrompt helpers via their respective endpoints; no duplicate tag-strip / privacy check paths.

Phase 7 — Verification (grep counts, exit codes, Windows Terminal)

(a) What to verify

  1. Grep counts (final "clean" state):
    grep -rn "ensureWorkerRunning" src/cli/handlers/           → 0
    grep -rn "ensureWorkerAliveOnce" src/cli/handlers/         → 8
    grep -n "POLL_INTERVAL_MS" src/                             → 0
    grep -n "MAX_WAIT_FOR_SUMMARY_MS" src/cli/handlers/summarize.ts → 1 (HTTP client timeout)
    grep -rn "/api/sessions/" src/                              → 0
    grep -rn "/sessions/.*sessionDbId" src/                      → 0
    grep -rn "/api/context/inject" src/                          → 0
    grep -rn "/api/context/semantic" src/                        → 0
    grep -rn "/api/session/" src/                                → exactly 4 paths
    grep -c "app\.\(post\|get\|delete\)" src/services/worker/http/routes/SessionRoutes.ts → 4
    
  2. Exit-code census (preserves CLAUDE.md contract):
    • Every hook-handler return path uses HOOK_EXIT_CODES.SUCCESS (= 0) on the graceful-degradation branch. Run:
      grep -B1 "HOOK_EXIT_CODES" src/cli/handlers/*.ts
      
      Expected: exit 0 on (worker-unreachable, empty context, empty transcript, 110 s timeout, subagent, project excluded). No new exit 2 paths.
    • Windows Terminal tab behaviour: exit 0 closes the tab on successful completion. The blocking /api/session/end 110 s path MUST also return exit 0 (not exit 2), so tabs close on timeout. Ship a Windows-Terminal integration test: trigger a synthetic 110 s timeout; confirm tab closes.
  3. Timer census:
    grep -n "setInterval\|setTimeout.*recursive" src/cli/        → 0 in CLI handlers
    grep -n "setTimeout.*POLL" src/cli/                           → 0
    
  4. Endpoint count on SessionRoutes.ts: exactly 4 route registrations. Matches §3.1.

(b) Docs

  • Whole §3.1 diagram, Part 4 timer census, Part 5 deletion ledger rows for "Summarize 500-ms polling hook" and "Double /api/context/* fetches".
  • V8, V9, V10.
  • CLAUDE.md exit-code strategy section ("Exit 0: Success or graceful shutdown — Windows Terminal closes tabs").

(c) Verification (running the phase)

The phase produces no new code; it runs the grep + integration tests above and fails the rollout if any gate trips. Land only when:

  • all greps pass,
  • synthetic 110 s timeout → exit 0 → tab closes (Windows),
  • full session cycle reports 56 HTTP calls (was 1014).

(d) Anti-pattern guards

  • B/D/E — verified by absence (grep). A — verified by "hookEventName value set unchanged" (SessionStart, UserPromptSubmit, PostToolUse, Stop).

Copy-Ready Snippet Locations

Hook-side session-alive cache (Phase 2): Location: new file src/hooks/worker-cache.ts (create; this is the one file added by this plan). Shape: one module-scope let alive: boolean | null = null; + one let sessionStartResponse: SessionStartResponse | null = null;. Lives as long as the hook process does (≤120 s). No persistence, no cross-process sharing — that's the point. Plan 07 owns the server-side session state; Plan 09 owns only the per-hook-process cache.

Poll loop deletion target (Phase 3): src/cli/handlers/summarize.ts:117150 — the entire while ((Date.now() - waitStart) < MAX_WAIT_FOR_SUMMARY_MS) { await sleep(POLL_INTERVAL_MS); … } block plus summarize.ts:24 (POLL_INTERVAL_MS = 500).

Double-fetch deletion target (Phase 1): src/cli/handlers/context.ts:4157 (the Promise.all([workerHttpRequest(apiPath), workerHttpRequest(colorApiPath)])) + src/cli/handlers/user-message.ts:1330 (fetchAndDisplayContext).

ensureWorkerRunning 8 callsites (Phase 2 rewires all 8):

src/cli/handlers/context.ts:19
src/cli/handlers/user-message.ts:35
src/cli/handlers/session-init.ts:41
src/cli/handlers/observation.ts:34
src/cli/handlers/summarize.ts:44
src/cli/handlers/session-complete.ts:35  (file deleted in Phase 6 — callsite deleted with it)
src/cli/handlers/file-context.ts:218
src/cli/handlers/file-edit.ts:32

Confidence + Gaps

High confidence

  • Hook → endpoint mapping (enumerated against live code).
  • V8/V9/V10 verified against Grep output this session (2026-04-22).
  • Endpoint count 10 → 4 verified at SessionRoutes.ts:377389 — supersedes the §3.1 "8 → 4" claim.
  • HOOK_EXIT_CODES.SUCCESS = 0 is the sole value used in every return branch of every handler today. Every phase preserves exit-0 semantics.

Gaps (call out before executing)

  1. Stop-hook exit codes on 110 s timeout path — NEEDS CONFIRMATION. Current summarize.ts returns exit 0 on all branches (poll timeout falls through to /api/sessions/completereturn { exitCode: undefined } implicitly → adapter defaults to 0). The new blocking /api/session/end must explicitly return exit 0 when the server responds {timedOut: true, summaryId: null}. §3.1 ("Exit 0") and CLAUDE.md ("Exit 0: graceful shutdown — Windows Terminal closes tabs") agree. Phase 3 verification step must include a synthetic-timeout Windows Terminal test — otherwise the refactor could silently introduce an exit-2 path that blocks tab closure, which CLAUDE.md explicitly warns against.

  2. tool_use_id availability in CLI hook payloads. POST /api/session/observation requires tool_use_id (§3.1 PTU edge). Current NormalizedHookInput may or may not already carry it — src/shared/NormalizedHookInput needs a verification pass in Phase 6 (deferred to Plan 01 Phase 2 if absent). This gates the UNIQUE constraint in Plan 09 Phase 9 (SQLite); out of scope here but a coupling to flag.

  3. user-message.ts + context.ts run as separate hook processes on some Claude Code versions. Module-scope let in worker-cache.ts won't share state across processes. If the Claude Code hook runner invokes them sequentially in one process: 1 HTTP call. If in parallel processes: 2 HTTP calls (still one each, still ≤2 total — acceptable, same as today's /api/context/inject double-fetch but under the new endpoint). Not a correctness issue; a minor perf claim in Phase 1 verification needs empirical confirmation, not a blocker.

Out-of-scope adjacencies (flagged)

  • Worker-side implementation of GET /api/session/start, POST /api/session/prompt, POST /api/session/end → Plans 05 + 07.
  • ingestObservation/ingestPrompt/ingestSummary helpers → Plan 01.
  • file-context.ts GET /api/observations/by-file endpoint → Plan 08 (DataRoutes), not touched here.
  • pre-compact.ts (delegates to summarizeHandler) inherits the Phase 3 rewrite automatically; no extra work.

Summary

  • 7 phases, executed in order (1 → 7). Phases 1, 2, 3 are independent of each other on the hook side (different files) but all depend on worker-side Plans 01, 05, 07 Phase-N endpoints existing; Phases 4, 5, 6 delete worker-side code after hooks stop calling it.
  • Lines deleted (hook side): summarize.ts loses ~80 lines (lines 86167 collapse to ~10); user-message.ts loses ~17 lines; context.ts loses ~15 lines; session-complete.ts deleted entirely (65 lines); session-init.ts loses ~60 lines. ~237 lines gone from src/cli/handlers/.
  • Lines deleted (worker side, SessionRoutes.ts): ~250 lines (6 legacy handlers + 5 ByClaudeId handlers).
  • Lines added: src/hooks/worker-cache.ts ~25 lines; 8 handler rewires net ~0. Total net: ~-460 lines in this plan's scope (consistent with Part 5 ledger rows -60/+20 summarize + -120/+60 context = -100 net, plus the Phase 4+5+6 SessionRoutes delete not counted in §5 because §5 lumped it into "session-lifecycle-management").
  • Top gaps: (1) 110 s timeout exit code must be 0 (Windows Terminal contract); (2) tool_use_id presence in NormalizedHookInput needs verification before Phase 6.