f38b5b85bc
* docs: add investigation reports for 5 open GitHub issues Comprehensive analysis of issues #543, #544, #545, #555, and #557: - #557: settings.json not generated, module loader error (node/bun mismatch) - #555: Windows hooks not executing, hasIpc always false - #545: formatTool crashes on non-JSON tool_input strings - #544: mem-search skill hint shown incorrectly to Claude Code users - #543: /claude-mem slash command unavailable despite installation Each report includes root cause analysis, affected files, and proposed fixes. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * fix(logger): handle non-JSON tool_input in formatTool (#545) Wrap JSON.parse in try-catch to handle raw string inputs (e.g., Bash commands) that aren't valid JSON. Falls back to using the string as-is. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * fix(context): update mem-search hint to reference MCP tools (#544) Update hint messages to reference MCP tools (search, get_observations) instead of the deprecated "mem-search skill" terminology. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * fix(settings): auto-create settings.json on first load (#557, #543) When settings.json doesn't exist, create it with defaults instead of returning in-memory defaults. Creates parent directory if needed. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * fix(hooks): use bun runtime for hooks except smart-install (#557) Change hook commands from node to bun since hooks use bun:sqlite. Keep smart-install.js on node since it bootstraps bun installation. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * chore: rebuild plugin scripts * docs: clarify that build artifacts must be committed * fix(docs): update build artifacts directory reference in CLAUDE.md * test: add test coverage for PR #558 fixes - Fix 2 failing tests: update "mem-search skill" → "MCP tools" expectations - Add 56 tests for formatTool() JSON.parse crash fix (Issue #545) - Add 27 tests for settings.json auto-creation (Issue #543) Test coverage includes: - formatTool: JSON parsing, raw strings, objects, null/undefined, all tool types - Settings: file creation, directory creation, schema migration, edge cases 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * fix(tests): clean up flaky tests and fix circular dependency Phase 1 of test quality improvements: - Delete 6 harmful/worthless test files that used problematic mock.module() patterns or tested implementation details rather than behavior: - context-builder.test.ts (tested internal implementation) - export-types.test.ts (fragile mock patterns) - smart-install.test.ts (shell script testing antipattern) - session_id_refactor.test.ts (outdated, tested refactoring itself) - validate_sql_update.test.ts (one-time migration validation) - observation-broadcaster.test.ts (excessive mocking) - Fix circular dependency between logger.ts and SettingsDefaultsManager.ts by using late binding pattern - logger now lazily loads settings - Refactor mock.module() to spyOn() in several test files for more maintainable and less brittle tests: - observation-compiler.test.ts - gemini_agent.test.ts - error-handler.test.ts - server.test.ts - response-processor.test.ts All 649 tests pass. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * refactor(tests): phase 2 - reduce mock-heavy tests and improve focus - Remove mock-heavy query tests from observation-compiler.test.ts, keep real buildTimeline tests - Convert session_id_usage_validation.test.ts from 477 to 178 lines of focused smoke tests - Remove tests for language built-ins from worker-spawn.test.ts (JSON.parse, array indexing) - Rename logger-coverage.test.ts to logger-usage-standards.test.ts for clarity 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * docs(tests): phase 3 - add JSDoc mock justification to test files Document mock usage rationale in 5 test files to improve maintainability: - error-handler.test.ts: Express req/res mocks, logger spies (~11%) - fallback-error-handler.test.ts: Zero mocks, pure function tests - session-cleanup-helper.test.ts: Session fixtures, worker mocks (~19%) - hook-constants.test.ts: process.platform mock for Windows tests (~12%) - session_store.test.ts: Zero mocks, real SQLite :memory: database Part of ongoing effort to document mock justifications per TESTING.md guidelines. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * test(integration): phase 5 - add 72 tests for critical coverage gaps Add comprehensive test coverage for previously untested areas: - tests/integration/hook-execution-e2e.test.ts (10 tests) Tests lifecycle hooks execution flow and context propagation - tests/integration/worker-api-endpoints.test.ts (19 tests) Tests all worker service HTTP endpoints without heavy mocking - tests/integration/chroma-vector-sync.test.ts (16 tests) Tests vector embedding synchronization with ChromaDB - tests/utils/tag-stripping.test.ts (27 tests) Tests privacy tag stripping utilities for both <private> and <meta-observation> tags All tests use real implementations where feasible, following the project's testing philosophy of preferring integration-style tests over unit tests with extensive mocking. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * context update * docs: add comment linking DEFAULT_DATA_DIR locations Added NOTE comment in logger.ts pointing to the canonical DEFAULT_DATA_DIR in SettingsDefaultsManager.ts. This addresses PR reviewer feedback about the fragility of having the default defined in two places to avoid circular dependencies. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
147 lines
4.7 KiB
TypeScript
147 lines
4.7 KiB
TypeScript
import { describe, it, expect } from 'bun:test';
|
|
import { buildTimeline } from '../../src/services/context/index.js';
|
|
import type { Observation, SummaryTimelineItem } from '../../src/services/context/types.js';
|
|
|
|
/**
|
|
* Timeline building tests - validates real sorting and merging logic
|
|
*
|
|
* Removed: queryObservations, querySummaries tests (mock database - not testing real behavior)
|
|
* Kept: buildTimeline tests (tests actual sorting algorithm)
|
|
*/
|
|
|
|
// Helper to create a minimal observation
|
|
function createTestObservation(overrides: Partial<Observation> = {}): Observation {
|
|
return {
|
|
id: 1,
|
|
memory_session_id: 'session-123',
|
|
type: 'discovery',
|
|
title: 'Test Observation',
|
|
subtitle: null,
|
|
narrative: 'A test narrative',
|
|
facts: '["fact1"]',
|
|
concepts: '["concept1"]',
|
|
files_read: null,
|
|
files_modified: null,
|
|
discovery_tokens: 100,
|
|
created_at: '2025-01-01T12:00:00.000Z',
|
|
created_at_epoch: 1735732800000,
|
|
...overrides,
|
|
};
|
|
}
|
|
|
|
// Helper to create a summary timeline item
|
|
function createTestSummaryTimelineItem(overrides: Partial<SummaryTimelineItem> = {}): SummaryTimelineItem {
|
|
return {
|
|
id: 1,
|
|
memory_session_id: 'session-123',
|
|
request: 'Test Request',
|
|
investigated: 'Investigated things',
|
|
learned: 'Learned things',
|
|
completed: 'Completed things',
|
|
next_steps: 'Next steps',
|
|
created_at: '2025-01-01T12:00:00.000Z',
|
|
created_at_epoch: 1735732800000,
|
|
displayEpoch: 1735732800000,
|
|
displayTime: '2025-01-01T12:00:00.000Z',
|
|
shouldShowLink: false,
|
|
...overrides,
|
|
};
|
|
}
|
|
|
|
describe('buildTimeline', () => {
|
|
it('should combine observations and summaries into timeline', () => {
|
|
const observations = [
|
|
createTestObservation({ id: 1, created_at_epoch: 1000 }),
|
|
];
|
|
const summaries = [
|
|
createTestSummaryTimelineItem({ id: 1, displayEpoch: 2000 }),
|
|
];
|
|
|
|
const timeline = buildTimeline(observations, summaries);
|
|
|
|
expect(timeline).toHaveLength(2);
|
|
});
|
|
|
|
it('should sort timeline items chronologically by epoch', () => {
|
|
const observations = [
|
|
createTestObservation({ id: 1, created_at_epoch: 3000 }),
|
|
createTestObservation({ id: 2, created_at_epoch: 1000 }),
|
|
];
|
|
const summaries = [
|
|
createTestSummaryTimelineItem({ id: 1, displayEpoch: 2000 }),
|
|
];
|
|
|
|
const timeline = buildTimeline(observations, summaries);
|
|
|
|
// Should be sorted: obs2 (1000), summary (2000), obs1 (3000)
|
|
expect(timeline).toHaveLength(3);
|
|
expect(timeline[0].type).toBe('observation');
|
|
expect((timeline[0].data as Observation).id).toBe(2);
|
|
expect(timeline[1].type).toBe('summary');
|
|
expect(timeline[2].type).toBe('observation');
|
|
expect((timeline[2].data as Observation).id).toBe(1);
|
|
});
|
|
|
|
it('should handle empty observations array', () => {
|
|
const summaries = [
|
|
createTestSummaryTimelineItem({ id: 1, displayEpoch: 1000 }),
|
|
];
|
|
|
|
const timeline = buildTimeline([], summaries);
|
|
|
|
expect(timeline).toHaveLength(1);
|
|
expect(timeline[0].type).toBe('summary');
|
|
});
|
|
|
|
it('should handle empty summaries array', () => {
|
|
const observations = [
|
|
createTestObservation({ id: 1, created_at_epoch: 1000 }),
|
|
];
|
|
|
|
const timeline = buildTimeline(observations, []);
|
|
|
|
expect(timeline).toHaveLength(1);
|
|
expect(timeline[0].type).toBe('observation');
|
|
});
|
|
|
|
it('should handle both empty arrays', () => {
|
|
const timeline = buildTimeline([], []);
|
|
|
|
expect(timeline).toHaveLength(0);
|
|
});
|
|
|
|
it('should correctly tag items with their type', () => {
|
|
const observations = [createTestObservation()];
|
|
const summaries = [createTestSummaryTimelineItem()];
|
|
|
|
const timeline = buildTimeline(observations, summaries);
|
|
|
|
const observationItem = timeline.find(item => item.type === 'observation');
|
|
const summaryItem = timeline.find(item => item.type === 'summary');
|
|
|
|
expect(observationItem).toBeDefined();
|
|
expect(summaryItem).toBeDefined();
|
|
expect(observationItem!.data).toHaveProperty('narrative');
|
|
expect(summaryItem!.data).toHaveProperty('request');
|
|
});
|
|
|
|
it('should use displayEpoch for summary sorting, not created_at_epoch', () => {
|
|
const observations = [
|
|
createTestObservation({ id: 1, created_at_epoch: 2000 }),
|
|
];
|
|
const summaries = [
|
|
createTestSummaryTimelineItem({
|
|
id: 1,
|
|
created_at_epoch: 3000, // Created later
|
|
displayEpoch: 1000, // But displayed earlier
|
|
}),
|
|
];
|
|
|
|
const timeline = buildTimeline(observations, summaries);
|
|
|
|
// Summary should come first because its displayEpoch is earlier
|
|
expect(timeline[0].type).toBe('summary');
|
|
expect(timeline[1].type).toBe('observation');
|
|
});
|
|
});
|