f38b5b85bc
* docs: add investigation reports for 5 open GitHub issues Comprehensive analysis of issues #543, #544, #545, #555, and #557: - #557: settings.json not generated, module loader error (node/bun mismatch) - #555: Windows hooks not executing, hasIpc always false - #545: formatTool crashes on non-JSON tool_input strings - #544: mem-search skill hint shown incorrectly to Claude Code users - #543: /claude-mem slash command unavailable despite installation Each report includes root cause analysis, affected files, and proposed fixes. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * fix(logger): handle non-JSON tool_input in formatTool (#545) Wrap JSON.parse in try-catch to handle raw string inputs (e.g., Bash commands) that aren't valid JSON. Falls back to using the string as-is. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * fix(context): update mem-search hint to reference MCP tools (#544) Update hint messages to reference MCP tools (search, get_observations) instead of the deprecated "mem-search skill" terminology. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * fix(settings): auto-create settings.json on first load (#557, #543) When settings.json doesn't exist, create it with defaults instead of returning in-memory defaults. Creates parent directory if needed. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * fix(hooks): use bun runtime for hooks except smart-install (#557) Change hook commands from node to bun since hooks use bun:sqlite. Keep smart-install.js on node since it bootstraps bun installation. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * chore: rebuild plugin scripts * docs: clarify that build artifacts must be committed * fix(docs): update build artifacts directory reference in CLAUDE.md * test: add test coverage for PR #558 fixes - Fix 2 failing tests: update "mem-search skill" → "MCP tools" expectations - Add 56 tests for formatTool() JSON.parse crash fix (Issue #545) - Add 27 tests for settings.json auto-creation (Issue #543) Test coverage includes: - formatTool: JSON parsing, raw strings, objects, null/undefined, all tool types - Settings: file creation, directory creation, schema migration, edge cases 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * fix(tests): clean up flaky tests and fix circular dependency Phase 1 of test quality improvements: - Delete 6 harmful/worthless test files that used problematic mock.module() patterns or tested implementation details rather than behavior: - context-builder.test.ts (tested internal implementation) - export-types.test.ts (fragile mock patterns) - smart-install.test.ts (shell script testing antipattern) - session_id_refactor.test.ts (outdated, tested refactoring itself) - validate_sql_update.test.ts (one-time migration validation) - observation-broadcaster.test.ts (excessive mocking) - Fix circular dependency between logger.ts and SettingsDefaultsManager.ts by using late binding pattern - logger now lazily loads settings - Refactor mock.module() to spyOn() in several test files for more maintainable and less brittle tests: - observation-compiler.test.ts - gemini_agent.test.ts - error-handler.test.ts - server.test.ts - response-processor.test.ts All 649 tests pass. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * refactor(tests): phase 2 - reduce mock-heavy tests and improve focus - Remove mock-heavy query tests from observation-compiler.test.ts, keep real buildTimeline tests - Convert session_id_usage_validation.test.ts from 477 to 178 lines of focused smoke tests - Remove tests for language built-ins from worker-spawn.test.ts (JSON.parse, array indexing) - Rename logger-coverage.test.ts to logger-usage-standards.test.ts for clarity 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * docs(tests): phase 3 - add JSDoc mock justification to test files Document mock usage rationale in 5 test files to improve maintainability: - error-handler.test.ts: Express req/res mocks, logger spies (~11%) - fallback-error-handler.test.ts: Zero mocks, pure function tests - session-cleanup-helper.test.ts: Session fixtures, worker mocks (~19%) - hook-constants.test.ts: process.platform mock for Windows tests (~12%) - session_store.test.ts: Zero mocks, real SQLite :memory: database Part of ongoing effort to document mock justifications per TESTING.md guidelines. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * test(integration): phase 5 - add 72 tests for critical coverage gaps Add comprehensive test coverage for previously untested areas: - tests/integration/hook-execution-e2e.test.ts (10 tests) Tests lifecycle hooks execution flow and context propagation - tests/integration/worker-api-endpoints.test.ts (19 tests) Tests all worker service HTTP endpoints without heavy mocking - tests/integration/chroma-vector-sync.test.ts (16 tests) Tests vector embedding synchronization with ChromaDB - tests/utils/tag-stripping.test.ts (27 tests) Tests privacy tag stripping utilities for both <private> and <meta-observation> tags All tests use real implementations where feasible, following the project's testing philosophy of preferring integration-style tests over unit tests with extensive mocking. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * context update * docs: add comment linking DEFAULT_DATA_DIR locations Added NOTE comment in logger.ts pointing to the canonical DEFAULT_DATA_DIR in SettingsDefaultsManager.ts. This addresses PR reviewer feedback about the fragility of having the default defined in two places to avoid circular dependencies. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
177 lines
5.6 KiB
TypeScript
177 lines
5.6 KiB
TypeScript
/**
|
|
* Tests for session cleanup helper functionality
|
|
*
|
|
* Mock Justification (~19% mock code):
|
|
* - Session fixtures: Required to create valid ActiveSession objects with
|
|
* all required fields - tests the actual cleanup logic
|
|
* - Worker mocks: Verify broadcast notification calls - the actual
|
|
* cleanupProcessedMessages logic is tested against real session mutation
|
|
*
|
|
* What's NOT mocked: Session state mutation, null/undefined handling
|
|
*/
|
|
import { describe, it, expect, mock } from 'bun:test';
|
|
|
|
// Import directly from specific files to avoid worker-service import chain
|
|
import { cleanupProcessedMessages } from '../../../src/services/worker/agents/SessionCleanupHelper.js';
|
|
import type { WorkerRef } from '../../../src/services/worker/agents/types.js';
|
|
import type { ActiveSession } from '../../../src/services/worker-types.js';
|
|
|
|
describe('SessionCleanupHelper', () => {
|
|
// Helper to create a minimal mock session
|
|
function createMockSession(
|
|
overrides: Partial<ActiveSession> = {}
|
|
): ActiveSession {
|
|
return {
|
|
sessionDbId: 1,
|
|
contentSessionId: 'content-session-123',
|
|
memorySessionId: 'memory-session-456',
|
|
project: 'test-project',
|
|
userPrompt: 'Test prompt',
|
|
pendingMessages: [],
|
|
abortController: new AbortController(),
|
|
generatorPromise: null,
|
|
lastPromptNumber: 5,
|
|
startTime: Date.now(),
|
|
cumulativeInputTokens: 100,
|
|
cumulativeOutputTokens: 50,
|
|
earliestPendingTimestamp: Date.now() - 10000, // 10 seconds ago
|
|
conversationHistory: [],
|
|
currentProvider: 'claude',
|
|
...overrides,
|
|
};
|
|
}
|
|
|
|
// Helper to create mock worker
|
|
function createMockWorker() {
|
|
const broadcastProcessingStatusMock = mock(() => {});
|
|
const worker: WorkerRef = {
|
|
sseBroadcaster: {
|
|
broadcast: mock(() => {}),
|
|
},
|
|
broadcastProcessingStatus: broadcastProcessingStatusMock,
|
|
};
|
|
return { worker, broadcastProcessingStatusMock };
|
|
}
|
|
|
|
describe('cleanupProcessedMessages', () => {
|
|
it('should reset session.earliestPendingTimestamp to null', () => {
|
|
const session = createMockSession({
|
|
earliestPendingTimestamp: 1700000000000,
|
|
});
|
|
const { worker } = createMockWorker();
|
|
|
|
expect(session.earliestPendingTimestamp).toBe(1700000000000);
|
|
|
|
cleanupProcessedMessages(session, worker);
|
|
|
|
expect(session.earliestPendingTimestamp).toBeNull();
|
|
});
|
|
|
|
it('should reset earliestPendingTimestamp even when already null', () => {
|
|
const session = createMockSession({
|
|
earliestPendingTimestamp: null,
|
|
});
|
|
const { worker } = createMockWorker();
|
|
|
|
cleanupProcessedMessages(session, worker);
|
|
|
|
expect(session.earliestPendingTimestamp).toBeNull();
|
|
});
|
|
|
|
it('should call worker.broadcastProcessingStatus() if available', () => {
|
|
const session = createMockSession();
|
|
const { worker, broadcastProcessingStatusMock } = createMockWorker();
|
|
|
|
cleanupProcessedMessages(session, worker);
|
|
|
|
expect(broadcastProcessingStatusMock).toHaveBeenCalledTimes(1);
|
|
});
|
|
|
|
it('should handle missing worker gracefully (no crash)', () => {
|
|
const session = createMockSession({
|
|
earliestPendingTimestamp: 1700000000000,
|
|
});
|
|
|
|
// Should not throw
|
|
expect(() => {
|
|
cleanupProcessedMessages(session, undefined);
|
|
}).not.toThrow();
|
|
|
|
// Should still reset timestamp
|
|
expect(session.earliestPendingTimestamp).toBeNull();
|
|
});
|
|
|
|
it('should handle worker without broadcastProcessingStatus', () => {
|
|
const session = createMockSession({
|
|
earliestPendingTimestamp: 1700000000000,
|
|
});
|
|
const worker: WorkerRef = {
|
|
sseBroadcaster: {
|
|
broadcast: mock(() => {}),
|
|
},
|
|
// No broadcastProcessingStatus
|
|
};
|
|
|
|
// Should not throw
|
|
expect(() => {
|
|
cleanupProcessedMessages(session, worker);
|
|
}).not.toThrow();
|
|
|
|
// Should still reset timestamp
|
|
expect(session.earliestPendingTimestamp).toBeNull();
|
|
});
|
|
|
|
it('should handle empty worker object', () => {
|
|
const session = createMockSession({
|
|
earliestPendingTimestamp: 1700000000000,
|
|
});
|
|
const worker: WorkerRef = {};
|
|
|
|
// Should not throw
|
|
expect(() => {
|
|
cleanupProcessedMessages(session, worker);
|
|
}).not.toThrow();
|
|
|
|
// Should still reset timestamp
|
|
expect(session.earliestPendingTimestamp).toBeNull();
|
|
});
|
|
|
|
it('should handle worker with null broadcastProcessingStatus', () => {
|
|
const session = createMockSession({
|
|
earliestPendingTimestamp: 1700000000000,
|
|
});
|
|
const worker: WorkerRef = {
|
|
broadcastProcessingStatus: undefined,
|
|
};
|
|
|
|
// Should not throw
|
|
expect(() => {
|
|
cleanupProcessedMessages(session, worker);
|
|
}).not.toThrow();
|
|
|
|
// Should still reset timestamp
|
|
expect(session.earliestPendingTimestamp).toBeNull();
|
|
});
|
|
|
|
it('should not modify other session properties', () => {
|
|
const session = createMockSession({
|
|
earliestPendingTimestamp: 1700000000000,
|
|
lastPromptNumber: 10,
|
|
cumulativeInputTokens: 500,
|
|
cumulativeOutputTokens: 250,
|
|
project: 'my-project',
|
|
});
|
|
const { worker } = createMockWorker();
|
|
|
|
cleanupProcessedMessages(session, worker);
|
|
|
|
// Only earliestPendingTimestamp should change
|
|
expect(session.earliestPendingTimestamp).toBeNull();
|
|
expect(session.lastPromptNumber).toBe(10);
|
|
expect(session.cumulativeInputTokens).toBe(500);
|
|
expect(session.cumulativeOutputTokens).toBe(250);
|
|
expect(session.project).toBe('my-project');
|
|
});
|
|
});
|
|
});
|