f38b5b85bc
* docs: add investigation reports for 5 open GitHub issues Comprehensive analysis of issues #543, #544, #545, #555, and #557: - #557: settings.json not generated, module loader error (node/bun mismatch) - #555: Windows hooks not executing, hasIpc always false - #545: formatTool crashes on non-JSON tool_input strings - #544: mem-search skill hint shown incorrectly to Claude Code users - #543: /claude-mem slash command unavailable despite installation Each report includes root cause analysis, affected files, and proposed fixes. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * fix(logger): handle non-JSON tool_input in formatTool (#545) Wrap JSON.parse in try-catch to handle raw string inputs (e.g., Bash commands) that aren't valid JSON. Falls back to using the string as-is. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * fix(context): update mem-search hint to reference MCP tools (#544) Update hint messages to reference MCP tools (search, get_observations) instead of the deprecated "mem-search skill" terminology. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * fix(settings): auto-create settings.json on first load (#557, #543) When settings.json doesn't exist, create it with defaults instead of returning in-memory defaults. Creates parent directory if needed. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * fix(hooks): use bun runtime for hooks except smart-install (#557) Change hook commands from node to bun since hooks use bun:sqlite. Keep smart-install.js on node since it bootstraps bun installation. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * chore: rebuild plugin scripts * docs: clarify that build artifacts must be committed * fix(docs): update build artifacts directory reference in CLAUDE.md * test: add test coverage for PR #558 fixes - Fix 2 failing tests: update "mem-search skill" → "MCP tools" expectations - Add 56 tests for formatTool() JSON.parse crash fix (Issue #545) - Add 27 tests for settings.json auto-creation (Issue #543) Test coverage includes: - formatTool: JSON parsing, raw strings, objects, null/undefined, all tool types - Settings: file creation, directory creation, schema migration, edge cases 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * fix(tests): clean up flaky tests and fix circular dependency Phase 1 of test quality improvements: - Delete 6 harmful/worthless test files that used problematic mock.module() patterns or tested implementation details rather than behavior: - context-builder.test.ts (tested internal implementation) - export-types.test.ts (fragile mock patterns) - smart-install.test.ts (shell script testing antipattern) - session_id_refactor.test.ts (outdated, tested refactoring itself) - validate_sql_update.test.ts (one-time migration validation) - observation-broadcaster.test.ts (excessive mocking) - Fix circular dependency between logger.ts and SettingsDefaultsManager.ts by using late binding pattern - logger now lazily loads settings - Refactor mock.module() to spyOn() in several test files for more maintainable and less brittle tests: - observation-compiler.test.ts - gemini_agent.test.ts - error-handler.test.ts - server.test.ts - response-processor.test.ts All 649 tests pass. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * refactor(tests): phase 2 - reduce mock-heavy tests and improve focus - Remove mock-heavy query tests from observation-compiler.test.ts, keep real buildTimeline tests - Convert session_id_usage_validation.test.ts from 477 to 178 lines of focused smoke tests - Remove tests for language built-ins from worker-spawn.test.ts (JSON.parse, array indexing) - Rename logger-coverage.test.ts to logger-usage-standards.test.ts for clarity 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * docs(tests): phase 3 - add JSDoc mock justification to test files Document mock usage rationale in 5 test files to improve maintainability: - error-handler.test.ts: Express req/res mocks, logger spies (~11%) - fallback-error-handler.test.ts: Zero mocks, pure function tests - session-cleanup-helper.test.ts: Session fixtures, worker mocks (~19%) - hook-constants.test.ts: process.platform mock for Windows tests (~12%) - session_store.test.ts: Zero mocks, real SQLite :memory: database Part of ongoing effort to document mock justifications per TESTING.md guidelines. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * test(integration): phase 5 - add 72 tests for critical coverage gaps Add comprehensive test coverage for previously untested areas: - tests/integration/hook-execution-e2e.test.ts (10 tests) Tests lifecycle hooks execution flow and context propagation - tests/integration/worker-api-endpoints.test.ts (19 tests) Tests all worker service HTTP endpoints without heavy mocking - tests/integration/chroma-vector-sync.test.ts (16 tests) Tests vector embedding synchronization with ChromaDB - tests/utils/tag-stripping.test.ts (27 tests) Tests privacy tag stripping utilities for both <private> and <meta-observation> tags All tests use real implementations where feasible, following the project's testing philosophy of preferring integration-style tests over unit tests with extensive mocking. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * context update * docs: add comment linking DEFAULT_DATA_DIR locations Added NOTE comment in logger.ts pointing to the canonical DEFAULT_DATA_DIR in SettingsDefaultsManager.ts. This addresses PR reviewer feedback about the fragility of having the default defined in two places to avoid circular dependencies. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
281 lines
10 KiB
TypeScript
281 lines
10 KiB
TypeScript
/**
|
|
* Tag Stripping Utility Tests
|
|
*
|
|
* Tests the dual-tag privacy system for <private> and <claude-mem-context> tags.
|
|
* These tags enable users and the system to exclude content from memory storage.
|
|
*
|
|
* Sources:
|
|
* - Implementation from src/utils/tag-stripping.ts
|
|
* - Privacy patterns from src/services/worker/http/routes/SessionRoutes.ts
|
|
*/
|
|
|
|
import { describe, it, expect, beforeEach, afterEach, spyOn, mock } from 'bun:test';
|
|
import { stripMemoryTagsFromPrompt, stripMemoryTagsFromJson } from '../../src/utils/tag-stripping.js';
|
|
import { logger } from '../../src/utils/logger.js';
|
|
|
|
// Suppress logger output during tests
|
|
let loggerSpies: ReturnType<typeof spyOn>[] = [];
|
|
|
|
describe('Tag Stripping Utilities', () => {
|
|
beforeEach(() => {
|
|
loggerSpies = [
|
|
spyOn(logger, 'info').mockImplementation(() => {}),
|
|
spyOn(logger, 'debug').mockImplementation(() => {}),
|
|
spyOn(logger, 'warn').mockImplementation(() => {}),
|
|
spyOn(logger, 'error').mockImplementation(() => {}),
|
|
];
|
|
});
|
|
|
|
afterEach(() => {
|
|
loggerSpies.forEach(spy => spy.mockRestore());
|
|
});
|
|
|
|
describe('stripMemoryTagsFromPrompt', () => {
|
|
describe('basic tag removal', () => {
|
|
it('should strip single <private> tag and preserve surrounding content', () => {
|
|
const input = 'public content <private>secret stuff</private> more public';
|
|
const result = stripMemoryTagsFromPrompt(input);
|
|
expect(result).toBe('public content more public');
|
|
});
|
|
|
|
it('should strip single <claude-mem-context> tag', () => {
|
|
const input = 'public content <claude-mem-context>injected context</claude-mem-context> more public';
|
|
const result = stripMemoryTagsFromPrompt(input);
|
|
expect(result).toBe('public content more public');
|
|
});
|
|
|
|
it('should strip both tag types in mixed content', () => {
|
|
const input = '<private>secret</private> public <claude-mem-context>context</claude-mem-context> end';
|
|
const result = stripMemoryTagsFromPrompt(input);
|
|
expect(result).toBe('public end');
|
|
});
|
|
});
|
|
|
|
describe('multiple tags handling', () => {
|
|
it('should strip multiple <private> blocks', () => {
|
|
const input = '<private>first secret</private> middle <private>second secret</private> end';
|
|
const result = stripMemoryTagsFromPrompt(input);
|
|
expect(result).toBe('middle end');
|
|
});
|
|
|
|
it('should strip multiple <claude-mem-context> blocks', () => {
|
|
const input = '<claude-mem-context>ctx1</claude-mem-context><claude-mem-context>ctx2</claude-mem-context> content';
|
|
const result = stripMemoryTagsFromPrompt(input);
|
|
expect(result).toBe('content');
|
|
});
|
|
|
|
it('should handle many interleaved tags', () => {
|
|
let input = 'start';
|
|
for (let i = 0; i < 10; i++) {
|
|
input += ` <private>p${i}</private> <claude-mem-context>c${i}</claude-mem-context>`;
|
|
}
|
|
input += ' end';
|
|
const result = stripMemoryTagsFromPrompt(input);
|
|
// Tags are stripped but spaces between them remain
|
|
expect(result).not.toContain('<private>');
|
|
expect(result).not.toContain('<claude-mem-context>');
|
|
expect(result).toContain('start');
|
|
expect(result).toContain('end');
|
|
});
|
|
});
|
|
|
|
describe('empty and private-only prompts', () => {
|
|
it('should return empty string for entirely private prompt', () => {
|
|
const input = '<private>entire prompt is private</private>';
|
|
const result = stripMemoryTagsFromPrompt(input);
|
|
expect(result).toBe('');
|
|
});
|
|
|
|
it('should return empty string for entirely context-tagged prompt', () => {
|
|
const input = '<claude-mem-context>all is context</claude-mem-context>';
|
|
const result = stripMemoryTagsFromPrompt(input);
|
|
expect(result).toBe('');
|
|
});
|
|
|
|
it('should preserve content with no tags', () => {
|
|
const input = 'no tags here at all';
|
|
const result = stripMemoryTagsFromPrompt(input);
|
|
expect(result).toBe('no tags here at all');
|
|
});
|
|
|
|
it('should handle empty input', () => {
|
|
const result = stripMemoryTagsFromPrompt('');
|
|
expect(result).toBe('');
|
|
});
|
|
|
|
it('should handle whitespace-only after stripping', () => {
|
|
const input = '<private>content</private> <claude-mem-context>more</claude-mem-context>';
|
|
const result = stripMemoryTagsFromPrompt(input);
|
|
expect(result).toBe('');
|
|
});
|
|
});
|
|
|
|
describe('content preservation', () => {
|
|
it('should preserve non-tagged content exactly', () => {
|
|
const input = 'keep this <private>remove this</private> and this';
|
|
const result = stripMemoryTagsFromPrompt(input);
|
|
expect(result).toBe('keep this and this');
|
|
});
|
|
|
|
it('should preserve special characters in non-tagged content', () => {
|
|
const input = 'code: const x = 1; <private>secret</private> more: { "key": "value" }';
|
|
const result = stripMemoryTagsFromPrompt(input);
|
|
expect(result).toBe('code: const x = 1; more: { "key": "value" }');
|
|
});
|
|
|
|
it('should preserve newlines in non-tagged content', () => {
|
|
const input = 'line1\n<private>secret</private>\nline2';
|
|
const result = stripMemoryTagsFromPrompt(input);
|
|
expect(result).toBe('line1\n\nline2');
|
|
});
|
|
});
|
|
|
|
describe('multiline content in tags', () => {
|
|
it('should strip multiline content within <private> tags', () => {
|
|
const input = `public
|
|
<private>
|
|
multi
|
|
line
|
|
secret
|
|
</private>
|
|
end`;
|
|
const result = stripMemoryTagsFromPrompt(input);
|
|
expect(result).toBe('public\n\nend');
|
|
});
|
|
|
|
it('should strip multiline content within <claude-mem-context> tags', () => {
|
|
const input = `start
|
|
<claude-mem-context>
|
|
# Recent Activity
|
|
- Item 1
|
|
- Item 2
|
|
</claude-mem-context>
|
|
finish`;
|
|
const result = stripMemoryTagsFromPrompt(input);
|
|
expect(result).toBe('start\n\nfinish');
|
|
});
|
|
});
|
|
|
|
describe('ReDoS protection', () => {
|
|
it('should handle content with many tags without hanging (< 1 second)', async () => {
|
|
// Generate content with many tags
|
|
let content = '';
|
|
for (let i = 0; i < 150; i++) {
|
|
content += `<private>secret${i}</private> text${i} `;
|
|
}
|
|
|
|
const startTime = Date.now();
|
|
const result = stripMemoryTagsFromPrompt(content);
|
|
const duration = Date.now() - startTime;
|
|
|
|
// Should complete quickly despite many tags
|
|
expect(duration).toBeLessThan(1000);
|
|
// Should not contain any private content
|
|
expect(result).not.toContain('<private>');
|
|
// Should warn about exceeding tag limit
|
|
expect(loggerSpies[2]).toHaveBeenCalled(); // warn spy
|
|
});
|
|
|
|
it('should process within reasonable time with nested-looking patterns', () => {
|
|
// Content that looks like it could cause backtracking
|
|
const content = '<private>' + 'x'.repeat(10000) + '</private> keep this';
|
|
|
|
const startTime = Date.now();
|
|
const result = stripMemoryTagsFromPrompt(content);
|
|
const duration = Date.now() - startTime;
|
|
|
|
expect(duration).toBeLessThan(1000);
|
|
expect(result).toBe('keep this');
|
|
});
|
|
});
|
|
});
|
|
|
|
describe('stripMemoryTagsFromJson', () => {
|
|
describe('JSON content stripping', () => {
|
|
it('should strip tags from stringified JSON', () => {
|
|
const jsonContent = JSON.stringify({
|
|
file_path: '/path/to/file',
|
|
content: '<private>secret</private> public'
|
|
});
|
|
const result = stripMemoryTagsFromJson(jsonContent);
|
|
const parsed = JSON.parse(result);
|
|
expect(parsed.content).toBe(' public');
|
|
});
|
|
|
|
it('should strip claude-mem-context tags from JSON', () => {
|
|
const jsonContent = JSON.stringify({
|
|
data: '<claude-mem-context>injected</claude-mem-context> real data'
|
|
});
|
|
const result = stripMemoryTagsFromJson(jsonContent);
|
|
const parsed = JSON.parse(result);
|
|
expect(parsed.data).toBe(' real data');
|
|
});
|
|
|
|
it('should handle tool_input with tags', () => {
|
|
const toolInput = {
|
|
command: 'echo hello',
|
|
args: '<private>secret args</private>'
|
|
};
|
|
const result = stripMemoryTagsFromJson(JSON.stringify(toolInput));
|
|
const parsed = JSON.parse(result);
|
|
expect(parsed.args).toBe('');
|
|
});
|
|
|
|
it('should handle tool_response with tags', () => {
|
|
const toolResponse = {
|
|
output: 'result <claude-mem-context>context data</claude-mem-context>',
|
|
status: 'success'
|
|
};
|
|
const result = stripMemoryTagsFromJson(JSON.stringify(toolResponse));
|
|
const parsed = JSON.parse(result);
|
|
expect(parsed.output).toBe('result ');
|
|
});
|
|
});
|
|
|
|
describe('edge cases', () => {
|
|
it('should handle empty JSON object', () => {
|
|
const result = stripMemoryTagsFromJson('{}');
|
|
expect(result).toBe('{}');
|
|
});
|
|
|
|
it('should handle JSON with no tags', () => {
|
|
const input = JSON.stringify({ key: 'value' });
|
|
const result = stripMemoryTagsFromJson(input);
|
|
expect(result).toBe(input);
|
|
});
|
|
|
|
it('should handle nested JSON structures', () => {
|
|
const input = JSON.stringify({
|
|
outer: {
|
|
inner: '<private>secret</private> visible'
|
|
}
|
|
});
|
|
const result = stripMemoryTagsFromJson(input);
|
|
const parsed = JSON.parse(result);
|
|
expect(parsed.outer.inner).toBe(' visible');
|
|
});
|
|
});
|
|
});
|
|
|
|
describe('privacy enforcement integration', () => {
|
|
it('should allow empty result to trigger privacy skip', () => {
|
|
// Simulates what SessionRoutes does with private-only prompts
|
|
const prompt = '<private>entirely private prompt</private>';
|
|
const cleanedPrompt = stripMemoryTagsFromPrompt(prompt);
|
|
|
|
// Empty/whitespace prompts should trigger skip
|
|
const shouldSkip = !cleanedPrompt || cleanedPrompt.trim() === '';
|
|
expect(shouldSkip).toBe(true);
|
|
});
|
|
|
|
it('should allow partial content when not entirely private', () => {
|
|
const prompt = '<private>password123</private> Please help me with my code';
|
|
const cleanedPrompt = stripMemoryTagsFromPrompt(prompt);
|
|
|
|
const shouldSkip = !cleanedPrompt || cleanedPrompt.trim() === '';
|
|
expect(shouldSkip).toBe(false);
|
|
expect(cleanedPrompt.trim()).toBe('Please help me with my code');
|
|
});
|
|
});
|
|
});
|