Merge pull request #275 from router-for-me/iflow

Iflow
fix(iflow): adjust auth filename email sanitization
2025-11-19 20:44:54 +08:00 · 2025-11-19 19:50:06 +08:00 · 2025-11-19 17:40:06 +08:00 · 2025-11-19 14:45:33 +08:00
2 changed files with 12 additions and 6 deletions
--- a/internal/cmd/iflow_cookie.go
+++ b/internal/cmd/iflow_cookie.go
@@ -95,14 +95,13 @@ func promptForCookie(promptFn func(string) (string, error)) (string, error) {
 // getAuthFilePath returns the auth file path for the given provider and email
 func getAuthFilePath(cfg *config.Config, provider, email string) string {
 	// Clean email to make it filename-safe
-	cleanEmail := strings.ReplaceAll(email, "@", "_at_")
-	cleanEmail = strings.ReplaceAll(cleanEmail, ".", "_")
-	cleanEmail = strings.ReplaceAll(cleanEmail, "-", "_")
+	cleanEmail := strings.ReplaceAll(email, "*", "x")

-	// Remove any remaining special characters
+	// Remove any unsafe characters, but allow standard email chars (@, ., -)
 	var result strings.Builder
 	for _, r := range cleanEmail {
-		if (r >= 'a' && r <= 'z') || (r >= 'A' && r <= 'Z') || (r >= '0' && r <= '9') || r == '_' {
+		if (r >= 'a' && r <= 'z') || (r >= 'A' && r <= 'Z') || (r >= '0' && r <= '9') ||
+			r == '_' || r == '@' || r == '.' || r == '-' {
 			result.WriteRune(r)
 		}
 	}
--- a/internal/runtime/executor/logging_helpers.go
+++ b/internal/runtime/executor/logging_helpers.go
@@ -323,7 +323,14 @@ func formatAuthInfo(info upstreamRequestLog) string {
 }

 func summarizeErrorBody(contentType string, body []byte) string {
-	if strings.Contains(strings.ToLower(contentType), "text/html") {
+	isHTML := strings.Contains(strings.ToLower(contentType), "text/html")
+	if !isHTML {
+		trimmed := bytes.TrimSpace(bytes.ToLower(body))
+		if bytes.HasPrefix(trimmed, []byte("<!doctype html")) || bytes.HasPrefix(trimmed, []byte("<html")) {
+			isHTML = true
+		}
+	}
+	if isHTML {
 		if title := extractHTMLTitle(body); title != "" {
 			return title
 		}
Author	SHA1	Message	Date
Luis Pater	9acfbcc2a0	Merge pull request #275 from router-for-me/iflow Some checks failed docker-image / docker (push) Has been cancelled Details goreleaser / goreleaser (push) Has been cancelled Details Iflow	2025-11-19 20:44:54 +08:00
hkfires	b285b07986	fix(iflow): adjust auth filename email sanitization	2025-11-19 19:50:06 +08:00
Luis Pater	c40e00526b	Merge pull request #274 from router-for-me/log fix: detect HTML error bodies without text/html content type	2025-11-19 17:40:06 +08:00
hkfires	8a33f3ef69	fix: detect HTML error bodies without text/html content type	2025-11-19 14:45:33 +08:00