Fix SSE stream URL consistency, multi-line data parsing, and test mocks

- Use workerBaseUrl() for SSE stream URL instead of hardcoded localhost
- Concatenate all SSE data: lines per frame per SSE spec
- Update WhatsApp mock to accept third options argument
- Restrict SSE mock server to only respond on /stream path

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This commit is contained in:
Alex Newman
2026-02-09 21:54:02 -05:00
parent e13562e4cb
commit 05b615c858
2 changed files with 17 additions and 10 deletions
+9 -4
View File
@@ -8,7 +8,7 @@ import claudeMemPlugin from "./index.js";
function createMockApi(pluginConfigOverride: Record<string, any> = {}) {
const logs: string[] = [];
const sentMessages: Array<{ to: string; text: string; channel: string }> = [];
const sentMessages: Array<{ to: string; text: string; channel: string; opts?: any }> = [];
let registeredService: any = null;
const registeredCommands: Map<string, any> = new Map();
@@ -62,8 +62,8 @@ function createMockApi(pluginConfigOverride: Record<string, any> = {}) {
},
},
whatsapp: {
sendMessageWhatsApp: async (to: string, text: string) => {
sentMessages.push({ to, text, channel: "whatsapp" });
sendMessageWhatsApp: async (to: string, text: string, opts?: { verbose: boolean }) => {
sentMessages.push({ to, text, channel: "whatsapp", opts });
},
},
line: {
@@ -761,6 +761,11 @@ describe("SSE stream integration", () => {
function startSSEServer(): Promise<number> {
return new Promise((resolve) => {
server = createServer((req: IncomingMessage, res: ServerResponse) => {
if (req.url !== "/stream") {
res.writeHead(404);
res.end();
return;
}
res.writeHead(200, {
"Content-Type": "text/event-stream",
"Cache-Control": "no-cache",
@@ -923,7 +928,7 @@ describe("SSE stream integration", () => {
await getService().start({});
await new Promise((resolve) => setTimeout(resolve, 200));
assert.ok(logs.some((l) => l.includes(`localhost:${serverPort}`)));
assert.ok(logs.some((l) => l.includes(`127.0.0.1:${serverPort}`)));
await getService().stop({});
});
+8 -6
View File
@@ -301,9 +301,9 @@ async function connectToSSEStream(
while (!abortController.signal.aborted) {
try {
setConnectionState("reconnecting");
api.logger.info(`[claude-mem] Connecting to SSE stream at http://localhost:${port}/stream`);
api.logger.info(`[claude-mem] Connecting to SSE stream at ${workerBaseUrl(port)}/stream`);
const response = await fetch(`http://localhost:${port}/stream`, {
const response = await fetch(`${workerBaseUrl(port)}/stream`, {
signal: abortController.signal,
headers: { Accept: "text/event-stream" },
});
@@ -339,12 +339,14 @@ async function connectToSSEStream(
buffer = frames.pop() || "";
for (const frame of frames) {
const dataLine = frame
// SSE spec: concatenate all data: lines with \n
const dataLines = frame
.split("\n")
.find((line) => line.startsWith("data:"));
if (!dataLine) continue;
.filter((line) => line.startsWith("data:"))
.map((line) => line.slice(5).trim());
if (dataLines.length === 0) continue;
const jsonStr = dataLine.slice(5).trim();
const jsonStr = dataLines.join("\n");
if (!jsonStr) continue;
try {