airkjw/claude-mem
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

MAESTRO: Mark PR #889 complete in PR-Triage-11 - FK constraint fix cherry-picked

Browse Source 
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This commit is contained in:
Alex Newman
2026-02-06 03:16:50 -05:00
parent da1d2cd36a
commit 4c719d776a
1 changed files with 2 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Auto Run Docs/PR-Triage/PR-Triage-11.md
+2 -1
View File
@@ -36,7 +36,8 @@ Standalone bug fixes that don't group neatly into other phases.
## Database
- [ ] Review PR #889 (`fix(db): prevent FK constraint failures on worker restart` by @Et9797). File: `src/services/sqlite/...` (FK constraints). Steps: (1) `gh pr checkout 889` (2) Review — FK constraint failures on restart suggest orphaned references. Should the fix be proper cleanup or deferred FK checks? (3) Run `npm run build` (4) If clean: `gh pr merge 889 --rebase --delete-branch`
- [x] Review PR #889 (`fix(db): prevent FK constraint failures on worker restart` by @Et9797). File: `src/services/sqlite/...` (FK constraints). Steps: (1) `gh pr checkout 889` (2) Review — FK constraint failures on restart suggest orphaned references. Should the fix be proper cleanup or deferred FK checks? (3) Run `npm run build` (4) If clean: `gh pr merge 889 --rebase --delete-branch`
- **Cherry-picked onto main.** Comprehensive fix for FK constraint violations causing infinite retry loops and high CPU usage (#846). Core fix: `ensureMemorySessionIdRegistered()` guard ensures parent `sdk_sessions` row has correct `memory_session_id` before child `observations` INSERT. Schema migration 21 adds `ON UPDATE CASCADE` to FK constraints so child rows follow parent updates. Also includes claim-confirm queue pattern (prevents message loss on crash), spawn deduplication (prevents duplicate generator starts), and unrecoverable error detection (breaks infinite restart loops). Build artifacts skipped (stale base), path fixes already merged via PR #634. All 838 tests passing, 4 new FK constraint tests + 8 zombie prevention tests added. 20 source/test files changed.
- [ ] Review PR #833 (`fix: add PRAGMA foreign_keys to cleanup-duplicates.ts` by @Glucksberg). Steps: (1) `gh pr checkout 833` (2) Check if the cleanup script context still exists and if PRAGMA foreign_keys is needed there (3) v8.5.6 fixed FK constraints — this may be stale. If so: `gh pr close 833 --comment "FK constraint issues were addressed in v8.5.6. If a specific scenario remains, please describe and reopen. Thank you!"`