airkjw/claude-mem
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

MAESTRO: Fix console usage in EnvManager.ts and verify build/tests pass

Browse Source 
- Replaced console.warn/error with logger.warn/error calls per project standards
- Test suite enforces no console.* in background services (logs are invisible)
- Build verified: worker-service, mcp-server, context-generator, viewer UI all built
- All 797 tests pass (0 fail)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This commit is contained in:
Alex Newman
2026-02-04 20:12:27 -05:00
parent 53f6f57420
commit ce576db0dc
2 changed files with 8 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Auto Run Docs/Bigph00t-PRs/Phase-01-Merge-PR-745-Isolated-Credentials.md
+5 -2
View File
@@ -51,8 +51,11 @@ Fixes API key hijacking issue (#733) where SDK would use `ANTHROPIC_API_KEY` fro
- Well-documented with JSDoc comments explaining Issue #733 fix
- Type-safe with `ClaudeMemEnv` interface
- Essential vars list covers cross-platform needs (Windows, Linux, macOS)
- [ ] Verify build succeeds after rebase
- [ ] Run test suite to ensure no regressions
- [x] Verify build succeeds after rebase
- ✓ Build completed successfully: worker-service (1788KB), mcp-server (332KB), context-generator (61KB), viewer UI
- [x] Run test suite to ensure no regressions
- ✓ Fixed console.log/console.error usage in EnvManager.ts (replaced with logger calls per project standards)
- ✓ All 797 tests pass (0 fail, 3 skip)
- [ ] Merge PR #745 to main with admin override if needed
- [ ] Verify auth method shows "Claude Code CLI (subscription billing)" in logs after merge
src/shared/EnvManager.ts
+3 -2
View File
@@ -12,6 +12,7 @@
import { existsSync, readFileSync, writeFileSync, mkdirSync } from 'fs';
import { join, dirname } from 'path';
import { homedir } from 'os';
import { logger } from '../utils/logger.js';
// Path to claude-mem's centralized .env file
const DATA_DIR = join(homedir(), '.claude-mem');
@@ -136,7 +137,7 @@ export function loadClaudeMemEnv(): ClaudeMemEnv {
return result;
} catch (error) {
console.warn('[EnvManager] Failed to load .env file:', error);
logger.warn('ENV', 'Failed to load .env file', { path: ENV_FILE_PATH }, error as Error);
return {};
}
}
@@ -184,7 +185,7 @@ export function saveClaudeMemEnv(env: ClaudeMemEnv): void {
writeFileSync(ENV_FILE_PATH, serializeEnvFile(updated), 'utf-8');
} catch (error) {
console.error('[EnvManager] Failed to save .env file:', error);
logger.error('ENV', 'Failed to save .env file', { path: ENV_FILE_PATH }, error as Error);
throw error;
}
}