c6f932988a
* MAESTRO: fix ChromaDB core issues — Python pinning, Windows paths, disable toggle, metadata sanitization, transport errors - Add --python version pinning to uvx args in both local and remote mode (fixes #1196, #1206, #1208) - Convert backslash paths to forward slashes for --data-dir on Windows (fixes #1199) - Add CLAUDE_MEM_CHROMA_ENABLED setting for SQLite-only fallback mode (fixes #707) - Sanitize metadata in addDocuments() to filter null/undefined/empty values (fixes #1183, #1188) - Wrap callTool() in try/catch for transport errors with auto-reconnect (fixes #1162) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * MAESTRO: fix data integrity — content-hash deduplication, project name collision, empty project guard, stuck isProcessing - Add SHA-256 content-hash deduplication to observations INSERT (store.ts, transactions.ts, SessionStore.ts) - Add content_hash column via migration 22 with backfill and index - Fix project name collision: getCurrentProjectName() now returns parent/basename - Guard against empty project string with cwd-derived fallback - Fix stuck isProcessing: hasAnyPendingWork() resets processing messages older than 5 minutes - Add 12 new tests covering all four fixes Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * MAESTRO: fix hook lifecycle — stderr suppression, output isolation, conversation pollution prevention - Suppress process.stderr.write in hookCommand() to prevent Claude Code showing diagnostic output as error UI (#1181). Restores stderr in finally block for worker-continues case. - Convert console.error() to logger.warn()/error() in hook-command.ts and handlers/index.ts so all diagnostics route to log file instead of stderr. - Verified all 7 handlers return suppressOutput: true (prevents conversation pollution #598, #784). - Verified session-complete is a recognized event type (fixes #984). - Verified unknown event types return no-op handler with exit 0 (graceful degradation). - Added 10 new tests in tests/hook-lifecycle.test.ts covering event dispatch, adapter defaults, stderr suppression, and standard response constants. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * MAESTRO: fix worker lifecycle — restart loop coordination, stale transport retry, ENOENT shutdown race - Add PID file mtime guard to prevent concurrent restart storms (#1145): isPidFileRecent() + touchPidFile() coordinate across sessions - Add transparent retry in ChromaMcpManager.callTool() on transport error — reconnects and retries once instead of failing (#1131) - Wrap getInstalledPluginVersion() with ENOENT/EBUSY handling (#1042) - Verified ChromaMcpManager.stop() already called on all shutdown paths Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * MAESTRO: fix Windows platform support — uvx.cmd spawn, PowerShell $_ elimination, windowsHide, FTS5 fallback - Route uvx spawn through cmd.exe /c on Windows since MCP SDK lacks shell:true (#1190, #1192, #1199) - Replace all PowerShell Where-Object {$_} pipelines with WQL -Filter server-side filtering (#1024, #1062) - Add windowsHide: true to all exec/spawn calls missing it to prevent console popups (#1048) - Add FTS5 runtime probe with graceful fallback when unavailable on Windows (#791) - Guard FTS5 table creation in migrations, SessionSearch, and SessionStore with try/catch Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * MAESTRO: fix skills/ distribution — build-time verification and regression tests (#1187) Add post-build verification in build-hooks.js that fails if critical distribution files (skills, hooks, plugin manifest) are missing. Add 10 regression tests covering skill file presence, YAML frontmatter, hooks.json integrity, and package.json files field. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * MAESTRO: fix MigrationRunner schema initialization (#979) — version conflict between parallel migration systems Root cause: old DatabaseManager migrations 1-7 shared schema_versions table with MigrationRunner's 4-22, causing version number collisions (5=drop tables vs add column, 6=FTS5 vs prompt tracking, 7=discovery_tokens vs remove UNIQUE). initializeSchema() was gated behind maxApplied===0, so core tables were never created when old versions were present. Fixes: - initializeSchema() always creates core tables via CREATE TABLE IF NOT EXISTS - Migrations 5-7 check actual DB state (columns/constraints) not just version tracking - Crash-safe temp table rebuilds (DROP IF EXISTS _new before CREATE) - Added missing migration 21 (ON UPDATE CASCADE) to MigrationRunner - Added ON UPDATE CASCADE to FK definitions in initializeSchema() - All changes applied to both runner.ts and SessionStore.ts Tests: 13 new tests in migration-runner.test.ts covering fresh DB, idempotency, version conflicts, crash recovery, FK constraints, and data integrity. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * MAESTRO: fix 21 test failures — stale mocks, outdated assertions, missing OpenClaw guards Server tests (12): Added missing workerPath and getAiStatus to ServerOptions mocks after interface expansion. ChromaSync tests (3): Updated to verify transport cleanup in ChromaMcpManager after architecture refactor. OpenClaw (2): Added memory_ tool skipping and response truncation to prevent recursive loops and oversized payloads. MarkdownFormatter (2): Updated assertions to match current output. SettingsDefaultsManager (1): Used correct default key for getBool test. Logger standards (1): Excluded CLI transcript command from background service check. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * MAESTRO: fix Codex CLI compatibility (#744) — session_id fallbacks, unknown platform tolerance, undefined guard Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * MAESTRO: fix Cursor IDE integration (#838, #1049) — adapter field fallbacks, tolerant session-init validation Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * MAESTRO: fix /api/logs OOM (#1203) — tail-read replaces full-file readFileSync Replace readFileSync (loads entire file into memory) with readLastLines() that reads only from the end of the file in expanding chunks (64KB → 10MB cap). Prevents OOM on large log files while preserving the same API response shape. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * MAESTRO: fix Settings CORS error (#1029) — explicit methods and allowedHeaders in CORS config Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * MAESTRO: add session custom_title for agent attribution (#1213) — migration 23, endpoint + store support Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * MAESTRO: prevent CLAUDE.md/AGENTS.md writes inside .git/ directories (#1165) Add .git path guard to all 4 write sites to prevent ref corruption when paths resolve inside .git internals. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * MAESTRO: fix plugin disabled state not respected (#781) — early exit check in all hook entry points Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * MAESTRO: fix UserPromptSubmit context re-injection on every turn (#1079) — contextInjected session flag Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * MAESTRO: fix stale AbortController queue stall (#1099) — lastGeneratorActivity tracking + 30s timeout Three-layer fix: 1. Added lastGeneratorActivity timestamp to ActiveSession, updated by processAgentResponse (all agents), getMessageIterator (queue yields), and startGeneratorWithProvider (generator launch) 2. Added stale generator detection in ensureGeneratorRunning — if no activity for >30s, aborts stale controller, resets state, restarts 3. Added AbortSignal.timeout(30000) in deleteSession to prevent indefinite hang when awaiting a stuck generator promise Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
403 lines
13 KiB
TypeScript
403 lines
13 KiB
TypeScript
/**
|
|
* Worker API Endpoints Integration Tests
|
|
*
|
|
* Tests all REST API endpoints with real HTTP and database.
|
|
* Uses real Server instance with in-memory database.
|
|
*
|
|
* Sources:
|
|
* - Server patterns from tests/server/server.test.ts
|
|
* - Session routes from src/services/worker/http/routes/SessionRoutes.ts
|
|
* - Search routes from src/services/worker/http/routes/SearchRoutes.ts
|
|
*/
|
|
|
|
import { describe, it, expect, beforeEach, afterEach, spyOn, mock } from 'bun:test';
|
|
import { logger } from '../../src/utils/logger.js';
|
|
|
|
// Mock middleware to avoid complex dependencies
|
|
mock.module('../../src/services/worker/http/middleware.js', () => ({
|
|
createMiddleware: () => [],
|
|
requireLocalhost: (_req: any, _res: any, next: any) => next(),
|
|
summarizeRequestBody: () => 'test body',
|
|
}));
|
|
|
|
// Import after mocks
|
|
import { Server } from '../../src/services/server/Server.js';
|
|
import type { ServerOptions } from '../../src/services/server/Server.js';
|
|
|
|
// Suppress logger output during tests
|
|
let loggerSpies: ReturnType<typeof spyOn>[] = [];
|
|
|
|
describe('Worker API Endpoints Integration', () => {
|
|
let server: Server;
|
|
let testPort: number;
|
|
let mockOptions: ServerOptions;
|
|
|
|
beforeEach(() => {
|
|
loggerSpies = [
|
|
spyOn(logger, 'info').mockImplementation(() => {}),
|
|
spyOn(logger, 'debug').mockImplementation(() => {}),
|
|
spyOn(logger, 'warn').mockImplementation(() => {}),
|
|
spyOn(logger, 'error').mockImplementation(() => {}),
|
|
];
|
|
|
|
mockOptions = {
|
|
getInitializationComplete: () => true,
|
|
getMcpReady: () => true,
|
|
onShutdown: mock(() => Promise.resolve()),
|
|
onRestart: mock(() => Promise.resolve()),
|
|
workerPath: '/test/worker-service.cjs',
|
|
getAiStatus: () => ({
|
|
provider: 'claude',
|
|
authMethod: 'cli',
|
|
lastInteraction: null,
|
|
}),
|
|
};
|
|
|
|
testPort = 40000 + Math.floor(Math.random() * 10000);
|
|
});
|
|
|
|
afterEach(async () => {
|
|
loggerSpies.forEach(spy => spy.mockRestore());
|
|
|
|
if (server && server.getHttpServer()) {
|
|
try {
|
|
await server.close();
|
|
} catch {
|
|
// Ignore cleanup errors
|
|
}
|
|
}
|
|
mock.restore();
|
|
});
|
|
|
|
describe('Health/Readiness/Version Endpoints', () => {
|
|
describe('GET /api/health', () => {
|
|
it('should return status, initialized, mcpReady, platform, pid', async () => {
|
|
server = new Server(mockOptions);
|
|
await server.listen(testPort, '127.0.0.1');
|
|
|
|
const response = await fetch(`http://127.0.0.1:${testPort}/api/health`);
|
|
expect(response.status).toBe(200);
|
|
|
|
const body = await response.json();
|
|
expect(body).toHaveProperty('status', 'ok');
|
|
expect(body).toHaveProperty('initialized', true);
|
|
expect(body).toHaveProperty('mcpReady', true);
|
|
expect(body).toHaveProperty('platform');
|
|
expect(body).toHaveProperty('pid');
|
|
expect(typeof body.platform).toBe('string');
|
|
expect(typeof body.pid).toBe('number');
|
|
});
|
|
|
|
it('should reflect uninitialized state', async () => {
|
|
const uninitOptions: ServerOptions = {
|
|
getInitializationComplete: () => false,
|
|
getMcpReady: () => false,
|
|
onShutdown: mock(() => Promise.resolve()),
|
|
onRestart: mock(() => Promise.resolve()),
|
|
workerPath: '/test/worker-service.cjs',
|
|
getAiStatus: () => ({ provider: 'claude', authMethod: 'cli', lastInteraction: null }),
|
|
};
|
|
|
|
server = new Server(uninitOptions);
|
|
await server.listen(testPort, '127.0.0.1');
|
|
|
|
const response = await fetch(`http://127.0.0.1:${testPort}/api/health`);
|
|
const body = await response.json();
|
|
|
|
expect(body.status).toBe('ok'); // Health always returns ok
|
|
expect(body.initialized).toBe(false);
|
|
expect(body.mcpReady).toBe(false);
|
|
});
|
|
});
|
|
|
|
describe('GET /api/readiness', () => {
|
|
it('should return 200 with status ready when initialized', async () => {
|
|
server = new Server(mockOptions);
|
|
await server.listen(testPort, '127.0.0.1');
|
|
|
|
const response = await fetch(`http://127.0.0.1:${testPort}/api/readiness`);
|
|
expect(response.status).toBe(200);
|
|
|
|
const body = await response.json();
|
|
expect(body.status).toBe('ready');
|
|
expect(body.mcpReady).toBe(true);
|
|
});
|
|
|
|
it('should return 503 with status initializing when not ready', async () => {
|
|
const uninitOptions: ServerOptions = {
|
|
getInitializationComplete: () => false,
|
|
getMcpReady: () => false,
|
|
onShutdown: mock(() => Promise.resolve()),
|
|
onRestart: mock(() => Promise.resolve()),
|
|
workerPath: '/test/worker-service.cjs',
|
|
getAiStatus: () => ({ provider: 'claude', authMethod: 'cli', lastInteraction: null }),
|
|
};
|
|
|
|
server = new Server(uninitOptions);
|
|
await server.listen(testPort, '127.0.0.1');
|
|
|
|
const response = await fetch(`http://127.0.0.1:${testPort}/api/readiness`);
|
|
expect(response.status).toBe(503);
|
|
|
|
const body = await response.json();
|
|
expect(body.status).toBe('initializing');
|
|
expect(body.message).toContain('initializing');
|
|
});
|
|
});
|
|
|
|
describe('GET /api/version', () => {
|
|
it('should return version string', async () => {
|
|
server = new Server(mockOptions);
|
|
await server.listen(testPort, '127.0.0.1');
|
|
|
|
const response = await fetch(`http://127.0.0.1:${testPort}/api/version`);
|
|
expect(response.status).toBe(200);
|
|
|
|
const body = await response.json();
|
|
expect(body).toHaveProperty('version');
|
|
expect(typeof body.version).toBe('string');
|
|
});
|
|
});
|
|
});
|
|
|
|
describe('Error Handling', () => {
|
|
describe('404 Not Found', () => {
|
|
it('should return 404 for unknown GET routes', async () => {
|
|
server = new Server(mockOptions);
|
|
server.finalizeRoutes();
|
|
await server.listen(testPort, '127.0.0.1');
|
|
|
|
const response = await fetch(`http://127.0.0.1:${testPort}/api/unknown-endpoint`);
|
|
expect(response.status).toBe(404);
|
|
|
|
const body = await response.json();
|
|
expect(body.error).toBe('NotFound');
|
|
});
|
|
|
|
it('should return 404 for unknown POST routes', async () => {
|
|
server = new Server(mockOptions);
|
|
server.finalizeRoutes();
|
|
await server.listen(testPort, '127.0.0.1');
|
|
|
|
const response = await fetch(`http://127.0.0.1:${testPort}/api/unknown-endpoint`, {
|
|
method: 'POST',
|
|
headers: { 'Content-Type': 'application/json' },
|
|
body: JSON.stringify({ test: 'data' })
|
|
});
|
|
expect(response.status).toBe(404);
|
|
});
|
|
|
|
it('should return 404 for nested unknown routes', async () => {
|
|
server = new Server(mockOptions);
|
|
server.finalizeRoutes();
|
|
await server.listen(testPort, '127.0.0.1');
|
|
|
|
const response = await fetch(`http://127.0.0.1:${testPort}/api/search/nonexistent/nested`);
|
|
expect(response.status).toBe(404);
|
|
});
|
|
});
|
|
|
|
describe('Method handling', () => {
|
|
it('should handle OPTIONS requests', async () => {
|
|
server = new Server(mockOptions);
|
|
await server.listen(testPort, '127.0.0.1');
|
|
|
|
const response = await fetch(`http://127.0.0.1:${testPort}/api/health`, {
|
|
method: 'OPTIONS'
|
|
});
|
|
// OPTIONS should either return 200 or 204 (CORS preflight)
|
|
expect([200, 204]).toContain(response.status);
|
|
});
|
|
});
|
|
});
|
|
|
|
describe('Content-Type Handling', () => {
|
|
it('should accept application/json content type', async () => {
|
|
server = new Server(mockOptions);
|
|
server.finalizeRoutes();
|
|
await server.listen(testPort, '127.0.0.1');
|
|
|
|
const response = await fetch(`http://127.0.0.1:${testPort}/api/nonexistent`, {
|
|
method: 'POST',
|
|
headers: { 'Content-Type': 'application/json' },
|
|
body: JSON.stringify({ key: 'value' })
|
|
});
|
|
|
|
// Should get 404 (route not found), not a content-type error
|
|
expect(response.status).toBe(404);
|
|
});
|
|
|
|
it('should return JSON responses with correct content type', async () => {
|
|
server = new Server(mockOptions);
|
|
await server.listen(testPort, '127.0.0.1');
|
|
|
|
const response = await fetch(`http://127.0.0.1:${testPort}/api/health`);
|
|
const contentType = response.headers.get('content-type');
|
|
|
|
expect(contentType).toContain('application/json');
|
|
});
|
|
});
|
|
|
|
describe('Server State Management', () => {
|
|
it('should track initialization state dynamically', async () => {
|
|
let initialized = false;
|
|
const dynamicOptions: ServerOptions = {
|
|
getInitializationComplete: () => initialized,
|
|
getMcpReady: () => true,
|
|
onShutdown: mock(() => Promise.resolve()),
|
|
onRestart: mock(() => Promise.resolve()),
|
|
workerPath: '/test/worker-service.cjs',
|
|
getAiStatus: () => ({ provider: 'claude', authMethod: 'cli', lastInteraction: null }),
|
|
};
|
|
|
|
server = new Server(dynamicOptions);
|
|
await server.listen(testPort, '127.0.0.1');
|
|
|
|
// Check uninitialized
|
|
let response = await fetch(`http://127.0.0.1:${testPort}/api/readiness`);
|
|
expect(response.status).toBe(503);
|
|
|
|
// Initialize
|
|
initialized = true;
|
|
|
|
// Check initialized
|
|
response = await fetch(`http://127.0.0.1:${testPort}/api/readiness`);
|
|
expect(response.status).toBe(200);
|
|
});
|
|
|
|
it('should track MCP ready state dynamically', async () => {
|
|
let mcpReady = false;
|
|
const dynamicOptions: ServerOptions = {
|
|
getInitializationComplete: () => true,
|
|
getMcpReady: () => mcpReady,
|
|
onShutdown: mock(() => Promise.resolve()),
|
|
onRestart: mock(() => Promise.resolve()),
|
|
workerPath: '/test/worker-service.cjs',
|
|
getAiStatus: () => ({ provider: 'claude', authMethod: 'cli', lastInteraction: null }),
|
|
};
|
|
|
|
server = new Server(dynamicOptions);
|
|
await server.listen(testPort, '127.0.0.1');
|
|
|
|
// Check MCP not ready
|
|
let response = await fetch(`http://127.0.0.1:${testPort}/api/health`);
|
|
let body = await response.json();
|
|
expect(body.mcpReady).toBe(false);
|
|
|
|
// Set MCP ready
|
|
mcpReady = true;
|
|
|
|
// Check MCP ready
|
|
response = await fetch(`http://127.0.0.1:${testPort}/api/health`);
|
|
body = await response.json();
|
|
expect(body.mcpReady).toBe(true);
|
|
});
|
|
});
|
|
|
|
describe('Server Lifecycle', () => {
|
|
it('should start listening on specified port', async () => {
|
|
server = new Server(mockOptions);
|
|
await server.listen(testPort, '127.0.0.1');
|
|
|
|
const httpServer = server.getHttpServer();
|
|
expect(httpServer).not.toBeNull();
|
|
expect(httpServer!.listening).toBe(true);
|
|
});
|
|
|
|
it('should close gracefully', async () => {
|
|
server = new Server(mockOptions);
|
|
await server.listen(testPort, '127.0.0.1');
|
|
|
|
// Verify it's running
|
|
const response = await fetch(`http://127.0.0.1:${testPort}/api/health`);
|
|
expect(response.status).toBe(200);
|
|
|
|
// Close
|
|
try {
|
|
await server.close();
|
|
} catch (e: any) {
|
|
if (e.code !== 'ERR_SERVER_NOT_RUNNING') throw e;
|
|
}
|
|
|
|
// Verify closed
|
|
const httpServer = server.getHttpServer();
|
|
if (httpServer) {
|
|
expect(httpServer.listening).toBe(false);
|
|
}
|
|
});
|
|
|
|
it('should handle port conflicts', async () => {
|
|
server = new Server(mockOptions);
|
|
const server2 = new Server(mockOptions);
|
|
|
|
await server.listen(testPort, '127.0.0.1');
|
|
|
|
// Second server should fail on same port
|
|
await expect(server2.listen(testPort, '127.0.0.1')).rejects.toThrow();
|
|
|
|
// Clean up second server if it has a reference
|
|
const httpServer2 = server2.getHttpServer();
|
|
if (httpServer2) {
|
|
expect(httpServer2.listening).toBe(false);
|
|
}
|
|
});
|
|
|
|
it('should allow restart on same port after close', async () => {
|
|
server = new Server(mockOptions);
|
|
await server.listen(testPort, '127.0.0.1');
|
|
|
|
// Close first server
|
|
try {
|
|
await server.close();
|
|
} catch (e: any) {
|
|
if (e.code !== 'ERR_SERVER_NOT_RUNNING') throw e;
|
|
}
|
|
|
|
// Wait for port to be released
|
|
await new Promise(resolve => setTimeout(resolve, 100));
|
|
|
|
// Start second server on same port
|
|
const server2 = new Server(mockOptions);
|
|
await server2.listen(testPort, '127.0.0.1');
|
|
|
|
expect(server2.getHttpServer()!.listening).toBe(true);
|
|
|
|
// Clean up
|
|
try {
|
|
await server2.close();
|
|
} catch {
|
|
// Ignore cleanup errors
|
|
}
|
|
});
|
|
});
|
|
|
|
describe('Route Registration', () => {
|
|
it('should register route handlers', () => {
|
|
server = new Server(mockOptions);
|
|
|
|
const setupRoutesMock = mock(() => {});
|
|
const mockRouteHandler = {
|
|
setupRoutes: setupRoutesMock,
|
|
};
|
|
|
|
server.registerRoutes(mockRouteHandler);
|
|
|
|
expect(setupRoutesMock).toHaveBeenCalledTimes(1);
|
|
expect(setupRoutesMock).toHaveBeenCalledWith(server.app);
|
|
});
|
|
|
|
it('should register multiple route handlers', () => {
|
|
server = new Server(mockOptions);
|
|
|
|
const handler1Mock = mock(() => {});
|
|
const handler2Mock = mock(() => {});
|
|
|
|
server.registerRoutes({ setupRoutes: handler1Mock });
|
|
server.registerRoutes({ setupRoutes: handler2Mock });
|
|
|
|
expect(handler1Mock).toHaveBeenCalledTimes(1);
|
|
expect(handler2Mock).toHaveBeenCalledTimes(1);
|
|
});
|
|
});
|
|
});
|