Lindsey Catlett
d9e966d8f4
* fix: make migration 17 idempotent and standardize column names Migration 17 renamed columns from sdk_session_id to memory_session_id, but the migration wasn't fully idempotent - it could fail on databases in intermediate states. This caused errors like: - "no such column: sdk_session_id" (when columns already renamed) - "table observations has no column named memory_session_id" (when not renamed) Changes: - Rewrite renameSessionIdColumns() to check each table individually - Use safeRenameColumn() helper that handles all edge cases gracefully - Deprecate migration 19 (repair migration) since 17 is now idempotent - Update maintenance scripts to use memory_session_id column name - Update test files to use new column names Fixes column mismatch bug in v8.2.6+ * Merge origin/main into column-mismatch --------- Co-authored-by: Alex Newman <thedotmack@gmail.com>
54 lines
1.9 KiB
TypeScript
54 lines
1.9 KiB
TypeScript
import { Database } from 'bun:sqlite';
|
|
import { describe, it, expect, beforeEach, afterEach } from 'bun:test';
|
|
|
|
describe('Refactor Validation: SQL Updates', () => {
|
|
let db: Database;
|
|
|
|
beforeEach(() => {
|
|
db = new Database(':memory:');
|
|
// Minimal schema for sdk_sessions based on SessionStore.ts migration004
|
|
// Uses new column names: content_session_id and memory_session_id
|
|
db.run(`
|
|
CREATE TABLE sdk_sessions (
|
|
id INTEGER PRIMARY KEY AUTOINCREMENT,
|
|
content_session_id TEXT UNIQUE NOT NULL,
|
|
memory_session_id TEXT UNIQUE,
|
|
project TEXT NOT NULL,
|
|
user_prompt TEXT,
|
|
started_at TEXT,
|
|
started_at_epoch INTEGER,
|
|
completed_at TEXT,
|
|
completed_at_epoch INTEGER,
|
|
status TEXT DEFAULT 'active'
|
|
);
|
|
`);
|
|
});
|
|
|
|
afterEach(() => {
|
|
db.close();
|
|
});
|
|
|
|
it('should update memory_session_id using direct SQL (replacing updateSDKSessionId)', () => {
|
|
// Setup initial state: A session without a memory_session_id
|
|
const contentId = 'content-session-123';
|
|
const memoryId = 'memory-session-456';
|
|
|
|
db.prepare(`
|
|
INSERT INTO sdk_sessions (content_session_id, project, started_at, started_at_epoch)
|
|
VALUES (?, ?, ?, ?)
|
|
`).run(contentId, 'test-project', '2025-01-01T00:00:00Z', 1735689600000);
|
|
|
|
// Verify initial state
|
|
const before = db.prepare('SELECT memory_session_id FROM sdk_sessions WHERE content_session_id = ?').get(contentId) as any;
|
|
expect(before.memory_session_id).toBeNull();
|
|
|
|
// EXECUTE: The exact SQL statement from the refactor
|
|
const stmt = db.prepare('UPDATE sdk_sessions SET memory_session_id = ? WHERE content_session_id = ?');
|
|
stmt.run(memoryId, contentId);
|
|
|
|
// VERIFY: The update happened
|
|
const after = db.prepare('SELECT memory_session_id FROM sdk_sessions WHERE content_session_id = ?').get(contentId) as any;
|
|
expect(after.memory_session_id).toBe(memoryId);
|
|
});
|
|
});
|