2659ec3231
* Refactor CLAUDE.md and related files for December 2025 updates - Updated CLAUDE.md in src/services/worker with new entries for December 2025, including changes to Search.ts, GeminiAgent.ts, SDKAgent.ts, and SessionManager.ts. - Revised CLAUDE.md in src/shared to reflect updates and new entries for December 2025, including paths.ts and worker-utils.ts. - Modified hook-constants.ts to clarify exit codes and their behaviors. - Added comprehensive hooks reference documentation for Claude Code, detailing usage, events, and examples. - Created initial CLAUDE.md files in various directories to track recent activity. * fix: Merge user-message-hook output into context-hook hookSpecificOutput - Add footer message to additionalContext in context-hook.ts - Remove user-message-hook from SessionStart hooks array - Fixes issue where stderr+exit(1) approach was silently discarded Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * Update logs and documentation for recent plugin and worker service changes - Added detailed logs for worker service activities from Dec 10, 2025 to Jan 7, 2026, including initialization patterns, cleanup confirmations, and diagnostic logging. - Updated plugin documentation with recent activities, including plugin synchronization and configuration changes from Dec 3, 2025 to Jan 7, 2026. - Enhanced the context hook and worker service logs to reflect improvements and fixes in the plugin architecture. - Documented the migration and verification processes for the Claude memory system and its integration with the marketplace. * Refactor hooks architecture and remove deprecated user-message-hook - Updated hook configurations in CLAUDE.md and hooks.json to reflect changes in session start behavior. - Removed user-message-hook functionality as it is no longer utilized in Claude Code 2.1.0; context is now injected silently. - Enhanced context-hook to handle session context injection without user-visible messages. - Cleaned up documentation across multiple files to align with the new hook structure and removed references to obsolete hooks. - Adjusted timing and command execution for hooks to improve performance and reliability. * fix: Address PR #610 review issues - Replace USER_MESSAGE_ONLY test with BLOCKING_ERROR test in hook-constants.test.ts - Standardize Claude Code 2.1.0 note wording across all three documentation files - Exclude deprecated user-message-hook.ts from logger-usage-standards test Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * fix: Remove hardcoded fake token counts from context injection Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * Address PR #610 review issues by fixing test files, standardizing documentation notes, and verifying code quality improvements. * fix: Add path validation to CLAUDE.md distribution to prevent invalid directory creation - Add isValidPathForClaudeMd() function to reject invalid paths: - Tilde paths (~) that Node.js doesn't expand - URLs (http://, https://) - Paths with spaces (likely command text or PR references) - Paths with # (GitHub issue/PR references) - Relative paths that escape project boundary - Integrate validation in updateFolderClaudeMdFiles loop - Add 6 unit tests for path validation - Update .gitignore to prevent accidental commit of malformed directories - Clean up existing invalid directories (~/, PR #610..., git diff..., https:) Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com> * fix: Implement path validation in CLAUDE.md generation to prevent invalid directory creation - Added `isValidPathForClaudeMd()` function to validate file paths in `src/utils/claude-md-utils.ts`. - Integrated path validation in `updateFolderClaudeMdFiles` to skip invalid paths. - Added 6 new unit tests in `tests/utils/claude-md-utils.test.ts` to cover various rejection cases. - Updated `.gitignore` to prevent tracking of invalid directories. - Cleaned up existing invalid directories in the repository. * feat: Promote critical WARN logs to ERROR level across codebase Comprehensive log-level audit promoting 38+ WARN messages to ERROR for improved debugging and incident response: - Parser: observation type errors, data contamination - SDK/Agents: empty init responses (Gemini, OpenRouter) - Worker/Queue: session recovery, auto-recovery failures - Chroma: sync failures, search failures (now treated as critical) - SQLite: search failures (primary data store) - Session/Generator: failures, missing context - Infrastructure: shutdown, process management failures - File Operations: CLAUDE.md updates, config reads - Branch Management: recovery checkout failures Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com> * fix: Address PR #614 review issues - Remove incorrectly tracked tilde-prefixed files from git - Fix absolute path validation to check projectRoot boundaries - Add test coverage for absolute path validation edge cases Closes review issues: - Issue 1: ~/ prefixed files removed from tracking - Issue 3: Absolute paths now validated against projectRoot - Issue 4: Added 3 new test cases for absolute path scenarios Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * build assets and context --------- Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
637 lines
20 KiB
TypeScript
637 lines
20 KiB
TypeScript
import { describe, it, expect, mock, afterEach, beforeEach } from 'bun:test';
|
|
import { mkdirSync, writeFileSync, readFileSync, existsSync, rmSync } from 'fs';
|
|
import path, { join } from 'path';
|
|
import { tmpdir } from 'os';
|
|
|
|
// Mock logger BEFORE imports (required pattern)
|
|
mock.module('../../src/utils/logger.js', () => ({
|
|
logger: {
|
|
info: () => {},
|
|
debug: () => {},
|
|
warn: () => {},
|
|
error: () => {},
|
|
},
|
|
}));
|
|
|
|
// Import after mocks
|
|
import {
|
|
replaceTaggedContent,
|
|
formatTimelineForClaudeMd,
|
|
writeClaudeMdToFolder,
|
|
updateFolderClaudeMdFiles
|
|
} from '../../src/utils/claude-md-utils.js';
|
|
|
|
let tempDir: string;
|
|
const originalFetch = global.fetch;
|
|
|
|
beforeEach(() => {
|
|
tempDir = join(tmpdir(), `test-${Date.now()}-${Math.random().toString(36).slice(2)}`);
|
|
mkdirSync(tempDir, { recursive: true });
|
|
});
|
|
|
|
afterEach(() => {
|
|
mock.restore();
|
|
global.fetch = originalFetch;
|
|
try {
|
|
rmSync(tempDir, { recursive: true, force: true });
|
|
} catch {
|
|
// Ignore cleanup errors
|
|
}
|
|
});
|
|
|
|
describe('replaceTaggedContent', () => {
|
|
it('should wrap new content in tags when existing content is empty', () => {
|
|
const result = replaceTaggedContent('', 'New content here');
|
|
|
|
expect(result).toBe('<claude-mem-context>\nNew content here\n</claude-mem-context>');
|
|
});
|
|
|
|
it('should replace only tagged section when existing content has tags', () => {
|
|
const existingContent = 'User content before\n<claude-mem-context>\nOld generated content\n</claude-mem-context>\nUser content after';
|
|
const newContent = 'New generated content';
|
|
|
|
const result = replaceTaggedContent(existingContent, newContent);
|
|
|
|
expect(result).toBe('User content before\n<claude-mem-context>\nNew generated content\n</claude-mem-context>\nUser content after');
|
|
});
|
|
|
|
it('should append tagged content with separator when no tags exist in existing content', () => {
|
|
const existingContent = 'User written documentation';
|
|
const newContent = 'Generated timeline';
|
|
|
|
const result = replaceTaggedContent(existingContent, newContent);
|
|
|
|
expect(result).toBe('User written documentation\n\n<claude-mem-context>\nGenerated timeline\n</claude-mem-context>');
|
|
});
|
|
|
|
it('should append when only opening tag exists (no matching end tag)', () => {
|
|
const existingContent = 'Some content\n<claude-mem-context>\nIncomplete tag section';
|
|
const newContent = 'New content';
|
|
|
|
const result = replaceTaggedContent(existingContent, newContent);
|
|
|
|
expect(result).toBe('Some content\n<claude-mem-context>\nIncomplete tag section\n\n<claude-mem-context>\nNew content\n</claude-mem-context>');
|
|
});
|
|
|
|
it('should append when only closing tag exists (no matching start tag)', () => {
|
|
const existingContent = 'Some content\n</claude-mem-context>\nMore content';
|
|
const newContent = 'New content';
|
|
|
|
const result = replaceTaggedContent(existingContent, newContent);
|
|
|
|
expect(result).toBe('Some content\n</claude-mem-context>\nMore content\n\n<claude-mem-context>\nNew content\n</claude-mem-context>');
|
|
});
|
|
|
|
it('should preserve newlines in new content', () => {
|
|
const existingContent = '<claude-mem-context>\nOld content\n</claude-mem-context>';
|
|
const newContent = 'Line 1\nLine 2\nLine 3';
|
|
|
|
const result = replaceTaggedContent(existingContent, newContent);
|
|
|
|
expect(result).toBe('<claude-mem-context>\nLine 1\nLine 2\nLine 3\n</claude-mem-context>');
|
|
});
|
|
});
|
|
|
|
describe('formatTimelineForClaudeMd', () => {
|
|
it('should return "No recent activity" for empty input', () => {
|
|
const result = formatTimelineForClaudeMd('');
|
|
|
|
expect(result).toContain('# Recent Activity');
|
|
expect(result).toContain('*No recent activity*');
|
|
});
|
|
|
|
it('should return "No recent activity" when no table rows exist', () => {
|
|
const input = 'Just some plain text without table rows';
|
|
|
|
const result = formatTimelineForClaudeMd(input);
|
|
|
|
expect(result).toContain('*No recent activity*');
|
|
});
|
|
|
|
it('should parse single observation row correctly', () => {
|
|
const input = '| #123 | 4:30 PM | 🔵 | User logged in | ~100 |';
|
|
|
|
const result = formatTimelineForClaudeMd(input);
|
|
|
|
expect(result).toContain('#123');
|
|
expect(result).toContain('4:30 PM');
|
|
expect(result).toContain('🔵');
|
|
expect(result).toContain('User logged in');
|
|
expect(result).toContain('~100');
|
|
});
|
|
|
|
it('should parse ditto mark for repeated time correctly', () => {
|
|
const input = `| #123 | 4:30 PM | 🔵 | First action | ~100 |
|
|
| #124 | ″ | 🔵 | Second action | ~150 |`;
|
|
|
|
const result = formatTimelineForClaudeMd(input);
|
|
|
|
expect(result).toContain('#123');
|
|
expect(result).toContain('#124');
|
|
// First occurrence should show time
|
|
expect(result).toContain('4:30 PM');
|
|
// Second occurrence should show ditto mark
|
|
expect(result).toContain('"');
|
|
});
|
|
|
|
it('should parse session ID format (#S123) correctly', () => {
|
|
const input = '| #S123 | 4:30 PM | 🟣 | Session started | ~200 |';
|
|
|
|
const result = formatTimelineForClaudeMd(input);
|
|
|
|
expect(result).toContain('#S123');
|
|
expect(result).toContain('4:30 PM');
|
|
expect(result).toContain('🟣');
|
|
expect(result).toContain('Session started');
|
|
});
|
|
});
|
|
|
|
describe('writeClaudeMdToFolder', () => {
|
|
it('should create CLAUDE.md in new folder', () => {
|
|
const folderPath = join(tempDir, 'new-folder');
|
|
const content = '# Recent Activity\n\nTest content';
|
|
|
|
writeClaudeMdToFolder(folderPath, content);
|
|
|
|
const claudeMdPath = join(folderPath, 'CLAUDE.md');
|
|
expect(existsSync(claudeMdPath)).toBe(true);
|
|
|
|
const fileContent = readFileSync(claudeMdPath, 'utf-8');
|
|
expect(fileContent).toContain('<claude-mem-context>');
|
|
expect(fileContent).toContain('Test content');
|
|
expect(fileContent).toContain('</claude-mem-context>');
|
|
});
|
|
|
|
it('should preserve user content outside tags', () => {
|
|
const folderPath = join(tempDir, 'preserve-test');
|
|
mkdirSync(folderPath, { recursive: true });
|
|
|
|
const claudeMdPath = join(folderPath, 'CLAUDE.md');
|
|
const userContent = 'User-written docs\n<claude-mem-context>\nOld content\n</claude-mem-context>\nMore user docs';
|
|
writeFileSync(claudeMdPath, userContent);
|
|
|
|
const newContent = 'New generated content';
|
|
writeClaudeMdToFolder(folderPath, newContent);
|
|
|
|
const fileContent = readFileSync(claudeMdPath, 'utf-8');
|
|
expect(fileContent).toContain('User-written docs');
|
|
expect(fileContent).toContain('New generated content');
|
|
expect(fileContent).toContain('More user docs');
|
|
expect(fileContent).not.toContain('Old content');
|
|
});
|
|
|
|
it('should create nested directories', () => {
|
|
const folderPath = join(tempDir, 'deep', 'nested', 'folder');
|
|
const content = 'Nested content';
|
|
|
|
writeClaudeMdToFolder(folderPath, content);
|
|
|
|
const claudeMdPath = join(folderPath, 'CLAUDE.md');
|
|
expect(existsSync(claudeMdPath)).toBe(true);
|
|
expect(existsSync(join(tempDir, 'deep'))).toBe(true);
|
|
expect(existsSync(join(tempDir, 'deep', 'nested'))).toBe(true);
|
|
});
|
|
|
|
it('should not leave .tmp file after write (atomic write)', () => {
|
|
const folderPath = join(tempDir, 'atomic-test');
|
|
const content = 'Atomic write test';
|
|
|
|
writeClaudeMdToFolder(folderPath, content);
|
|
|
|
const claudeMdPath = join(folderPath, 'CLAUDE.md');
|
|
const tempFilePath = `${claudeMdPath}.tmp`;
|
|
|
|
expect(existsSync(claudeMdPath)).toBe(true);
|
|
expect(existsSync(tempFilePath)).toBe(false);
|
|
});
|
|
});
|
|
|
|
describe('updateFolderClaudeMdFiles', () => {
|
|
it('should skip when filePaths is empty', async () => {
|
|
const fetchMock = mock(() => Promise.resolve({ ok: true } as Response));
|
|
global.fetch = fetchMock;
|
|
|
|
await updateFolderClaudeMdFiles([], 'test-project', 37777);
|
|
|
|
expect(fetchMock).not.toHaveBeenCalled();
|
|
});
|
|
|
|
it('should fetch timeline and write CLAUDE.md', async () => {
|
|
const folderPath = join(tempDir, 'api-test');
|
|
const filePath = join(folderPath, 'test.ts');
|
|
|
|
const apiResponse = {
|
|
content: [{
|
|
text: '| #123 | 4:30 PM | 🔵 | Test observation | ~100 |'
|
|
}]
|
|
};
|
|
|
|
global.fetch = mock(() => Promise.resolve({
|
|
ok: true,
|
|
json: () => Promise.resolve(apiResponse)
|
|
} as Response));
|
|
|
|
await updateFolderClaudeMdFiles([filePath], 'test-project', 37777);
|
|
|
|
const claudeMdPath = join(folderPath, 'CLAUDE.md');
|
|
expect(existsSync(claudeMdPath)).toBe(true);
|
|
|
|
const content = readFileSync(claudeMdPath, 'utf-8');
|
|
expect(content).toContain('Recent Activity');
|
|
expect(content).toContain('#123');
|
|
expect(content).toContain('Test observation');
|
|
});
|
|
|
|
it('should deduplicate folders from multiple files', async () => {
|
|
const folderPath = join(tempDir, 'dedup-test');
|
|
const file1 = join(folderPath, 'file1.ts');
|
|
const file2 = join(folderPath, 'file2.ts');
|
|
|
|
const apiResponse = {
|
|
content: [{
|
|
text: '| #123 | 4:30 PM | 🔵 | Test | ~100 |'
|
|
}]
|
|
};
|
|
|
|
const fetchMock = mock(() => Promise.resolve({
|
|
ok: true,
|
|
json: () => Promise.resolve(apiResponse)
|
|
} as Response));
|
|
global.fetch = fetchMock;
|
|
|
|
await updateFolderClaudeMdFiles([file1, file2], 'test-project', 37777);
|
|
|
|
// Should only fetch once for the shared folder
|
|
expect(fetchMock).toHaveBeenCalledTimes(1);
|
|
});
|
|
|
|
it('should handle API errors gracefully (404 response)', async () => {
|
|
const folderPath = join(tempDir, 'error-test');
|
|
const filePath = join(folderPath, 'test.ts');
|
|
|
|
global.fetch = mock(() => Promise.resolve({
|
|
ok: false,
|
|
status: 404
|
|
} as Response));
|
|
|
|
// Should not throw
|
|
await expect(updateFolderClaudeMdFiles([filePath], 'test-project', 37777)).resolves.toBeUndefined();
|
|
|
|
// CLAUDE.md should not be created
|
|
const claudeMdPath = join(folderPath, 'CLAUDE.md');
|
|
expect(existsSync(claudeMdPath)).toBe(false);
|
|
});
|
|
|
|
it('should handle network errors gracefully (fetch throws)', async () => {
|
|
const folderPath = join(tempDir, 'network-error-test');
|
|
const filePath = join(folderPath, 'test.ts');
|
|
|
|
global.fetch = mock(() => Promise.reject(new Error('Network error')));
|
|
|
|
// Should not throw
|
|
await expect(updateFolderClaudeMdFiles([filePath], 'test-project', 37777)).resolves.toBeUndefined();
|
|
|
|
// CLAUDE.md should not be created
|
|
const claudeMdPath = join(folderPath, 'CLAUDE.md');
|
|
expect(existsSync(claudeMdPath)).toBe(false);
|
|
});
|
|
|
|
it('should resolve relative paths using projectRoot', async () => {
|
|
const apiResponse = {
|
|
content: [{
|
|
text: '| #123 | 4:30 PM | 🔵 | Test observation | ~100 |'
|
|
}]
|
|
};
|
|
|
|
const fetchMock = mock(() => Promise.resolve({
|
|
ok: true,
|
|
json: () => Promise.resolve(apiResponse)
|
|
} as Response));
|
|
global.fetch = fetchMock;
|
|
|
|
await updateFolderClaudeMdFiles(
|
|
['src/utils/file.ts'], // relative path
|
|
'test-project',
|
|
37777,
|
|
'/home/user/my-project' // projectRoot
|
|
);
|
|
|
|
// Should call API with absolute path /home/user/my-project/src/utils
|
|
expect(fetchMock).toHaveBeenCalledTimes(1);
|
|
const callUrl = (fetchMock.mock.calls[0] as unknown[])[0] as string;
|
|
expect(callUrl).toContain(encodeURIComponent('/home/user/my-project/src/utils'));
|
|
});
|
|
|
|
it('should accept absolute paths within projectRoot and use them directly', async () => {
|
|
const folderPath = join(tempDir, 'absolute-path-test');
|
|
const filePath = join(folderPath, 'file.ts');
|
|
|
|
const apiResponse = {
|
|
content: [{
|
|
text: '| #123 | 4:30 PM | 🔵 | Test observation | ~100 |'
|
|
}]
|
|
};
|
|
|
|
const fetchMock = mock(() => Promise.resolve({
|
|
ok: true,
|
|
json: () => Promise.resolve(apiResponse)
|
|
} as Response));
|
|
global.fetch = fetchMock;
|
|
|
|
await updateFolderClaudeMdFiles(
|
|
[filePath], // absolute path within tempDir
|
|
'test-project',
|
|
37777,
|
|
tempDir // projectRoot matches the absolute path's root
|
|
);
|
|
|
|
// Should call API with the original absolute path's folder
|
|
expect(fetchMock).toHaveBeenCalledTimes(1);
|
|
const callUrl = (fetchMock.mock.calls[0] as unknown[])[0] as string;
|
|
expect(callUrl).toContain(encodeURIComponent(folderPath));
|
|
});
|
|
|
|
it('should work without projectRoot for backward compatibility', async () => {
|
|
const folderPath = join(tempDir, 'backward-compat-test');
|
|
const filePath = join(folderPath, 'file.ts');
|
|
|
|
const apiResponse = {
|
|
content: [{
|
|
text: '| #123 | 4:30 PM | 🔵 | Test observation | ~100 |'
|
|
}]
|
|
};
|
|
|
|
const fetchMock = mock(() => Promise.resolve({
|
|
ok: true,
|
|
json: () => Promise.resolve(apiResponse)
|
|
} as Response));
|
|
global.fetch = fetchMock;
|
|
|
|
await updateFolderClaudeMdFiles(
|
|
[filePath], // absolute path
|
|
'test-project',
|
|
37777
|
|
// No projectRoot - backward compatibility
|
|
);
|
|
|
|
// Should still make API call with the folder path
|
|
expect(fetchMock).toHaveBeenCalledTimes(1);
|
|
const callUrl = (fetchMock.mock.calls[0] as unknown[])[0] as string;
|
|
expect(callUrl).toContain(encodeURIComponent(folderPath));
|
|
});
|
|
|
|
it('should handle projectRoot with trailing slash correctly', async () => {
|
|
const apiResponse = {
|
|
content: [{
|
|
text: '| #123 | 4:30 PM | 🔵 | Test observation | ~100 |'
|
|
}]
|
|
};
|
|
|
|
const fetchMock = mock(() => Promise.resolve({
|
|
ok: true,
|
|
json: () => Promise.resolve(apiResponse)
|
|
} as Response));
|
|
global.fetch = fetchMock;
|
|
|
|
// projectRoot WITH trailing slash
|
|
await updateFolderClaudeMdFiles(
|
|
['src/utils/file.ts'],
|
|
'test-project',
|
|
37777,
|
|
'/home/user/my-project/' // trailing slash
|
|
);
|
|
|
|
// Should call API with normalized path (no double slashes)
|
|
expect(fetchMock).toHaveBeenCalledTimes(1);
|
|
const callUrl = (fetchMock.mock.calls[0] as unknown[])[0] as string;
|
|
// path.join normalizes the path, so /home/user/my-project/ + src/utils becomes /home/user/my-project/src/utils
|
|
expect(callUrl).toContain(encodeURIComponent('/home/user/my-project/src/utils'));
|
|
// Should NOT contain double slashes (except in http://)
|
|
expect(callUrl.replace('http://', '')).not.toContain('//');
|
|
});
|
|
|
|
it('should write CLAUDE.md to resolved projectRoot path', async () => {
|
|
const subfolderPath = join(tempDir, 'project-root-write-test', 'src', 'utils');
|
|
|
|
const apiResponse = {
|
|
content: [{
|
|
text: '| #456 | 5:00 PM | 🔵 | Written to correct path | ~200 |'
|
|
}]
|
|
};
|
|
|
|
global.fetch = mock(() => Promise.resolve({
|
|
ok: true,
|
|
json: () => Promise.resolve(apiResponse)
|
|
} as Response));
|
|
|
|
// Use tempDir as projectRoot with relative path src/utils/file.ts
|
|
await updateFolderClaudeMdFiles(
|
|
['src/utils/file.ts'],
|
|
'test-project',
|
|
37777,
|
|
join(tempDir, 'project-root-write-test')
|
|
);
|
|
|
|
// Verify CLAUDE.md was written at the resolved absolute path
|
|
const claudeMdPath = join(subfolderPath, 'CLAUDE.md');
|
|
expect(existsSync(claudeMdPath)).toBe(true);
|
|
|
|
const content = readFileSync(claudeMdPath, 'utf-8');
|
|
expect(content).toContain('Written to correct path');
|
|
expect(content).toContain('#456');
|
|
});
|
|
|
|
it('should deduplicate relative paths from same folder with projectRoot', async () => {
|
|
const apiResponse = {
|
|
content: [{
|
|
text: '| #123 | 4:30 PM | 🔵 | Test | ~100 |'
|
|
}]
|
|
};
|
|
|
|
const fetchMock = mock(() => Promise.resolve({
|
|
ok: true,
|
|
json: () => Promise.resolve(apiResponse)
|
|
} as Response));
|
|
global.fetch = fetchMock;
|
|
|
|
// Multiple files in same folder (relative paths)
|
|
await updateFolderClaudeMdFiles(
|
|
['src/utils/file1.ts', 'src/utils/file2.ts', 'src/utils/file3.ts'],
|
|
'test-project',
|
|
37777,
|
|
'/home/user/project'
|
|
);
|
|
|
|
// Should only fetch once for the shared folder
|
|
expect(fetchMock).toHaveBeenCalledTimes(1);
|
|
const callUrl = (fetchMock.mock.calls[0] as unknown[])[0] as string;
|
|
expect(callUrl).toContain(encodeURIComponent('/home/user/project/src/utils'));
|
|
});
|
|
|
|
it('should handle empty string paths gracefully with projectRoot', async () => {
|
|
const fetchMock = mock(() => Promise.resolve({ ok: true } as Response));
|
|
global.fetch = fetchMock;
|
|
|
|
await updateFolderClaudeMdFiles(
|
|
['', 'src/file.ts', ''], // includes empty strings
|
|
'test-project',
|
|
37777,
|
|
'/home/user/project'
|
|
);
|
|
|
|
// Should skip empty strings and only process valid path
|
|
expect(fetchMock).toHaveBeenCalledTimes(1);
|
|
const callUrl = (fetchMock.mock.calls[0] as unknown[])[0] as string;
|
|
expect(callUrl).toContain(encodeURIComponent('/home/user/project/src'));
|
|
});
|
|
});
|
|
|
|
describe('path validation in updateFolderClaudeMdFiles', () => {
|
|
it('should reject tilde paths', async () => {
|
|
const fetchMock = mock(() => Promise.resolve({ ok: true } as Response));
|
|
global.fetch = fetchMock;
|
|
|
|
await updateFolderClaudeMdFiles(
|
|
['~/.claude-mem/logs/worker.log'],
|
|
'test-project',
|
|
37777,
|
|
tempDir
|
|
);
|
|
|
|
expect(fetchMock).not.toHaveBeenCalled();
|
|
});
|
|
|
|
it('should reject URLs', async () => {
|
|
const fetchMock = mock(() => Promise.resolve({ ok: true } as Response));
|
|
global.fetch = fetchMock;
|
|
|
|
await updateFolderClaudeMdFiles(
|
|
['https://example.com/file.ts'],
|
|
'test-project',
|
|
37777,
|
|
tempDir
|
|
);
|
|
|
|
expect(fetchMock).not.toHaveBeenCalled();
|
|
});
|
|
|
|
it('should reject paths with spaces', async () => {
|
|
const fetchMock = mock(() => Promise.resolve({ ok: true } as Response));
|
|
global.fetch = fetchMock;
|
|
|
|
await updateFolderClaudeMdFiles(
|
|
['PR #610 on thedotmack/CLAUDE.md'],
|
|
'test-project',
|
|
37777,
|
|
tempDir
|
|
);
|
|
|
|
expect(fetchMock).not.toHaveBeenCalled();
|
|
});
|
|
|
|
it('should reject paths with hash symbols', async () => {
|
|
const fetchMock = mock(() => Promise.resolve({ ok: true } as Response));
|
|
global.fetch = fetchMock;
|
|
|
|
await updateFolderClaudeMdFiles(
|
|
['issue#123/file.ts'],
|
|
'test-project',
|
|
37777,
|
|
tempDir
|
|
);
|
|
|
|
expect(fetchMock).not.toHaveBeenCalled();
|
|
});
|
|
|
|
it('should reject path traversal outside project', async () => {
|
|
const fetchMock = mock(() => Promise.resolve({ ok: true } as Response));
|
|
global.fetch = fetchMock;
|
|
|
|
await updateFolderClaudeMdFiles(
|
|
['../../../etc/passwd'],
|
|
'test-project',
|
|
37777,
|
|
tempDir
|
|
);
|
|
|
|
expect(fetchMock).not.toHaveBeenCalled();
|
|
});
|
|
|
|
it('should reject absolute paths outside project root', async () => {
|
|
const fetchMock = mock(() => Promise.resolve({ ok: true } as Response));
|
|
global.fetch = fetchMock;
|
|
|
|
await updateFolderClaudeMdFiles(
|
|
['/etc/passwd'],
|
|
'test-project',
|
|
37777,
|
|
tempDir
|
|
);
|
|
|
|
expect(fetchMock).not.toHaveBeenCalled();
|
|
});
|
|
|
|
it('should accept absolute paths within project root', async () => {
|
|
const apiResponse = {
|
|
content: [{ text: '| #123 | 4:30 PM | 🔵 | Test | ~100 |' }]
|
|
};
|
|
const fetchMock = mock(() => Promise.resolve({
|
|
ok: true,
|
|
json: () => Promise.resolve(apiResponse)
|
|
} as Response));
|
|
global.fetch = fetchMock;
|
|
|
|
// Create an absolute path within the temp directory
|
|
const absolutePathInProject = path.join(tempDir, 'src', 'utils', 'file.ts');
|
|
|
|
await updateFolderClaudeMdFiles(
|
|
[absolutePathInProject],
|
|
'test-project',
|
|
37777,
|
|
tempDir
|
|
);
|
|
|
|
expect(fetchMock).toHaveBeenCalledTimes(1);
|
|
});
|
|
|
|
it('should accept absolute paths when no projectRoot is provided', async () => {
|
|
const apiResponse = {
|
|
content: [{ text: '| #123 | 4:30 PM | 🔵 | Test | ~100 |' }]
|
|
};
|
|
const fetchMock = mock(() => Promise.resolve({
|
|
ok: true,
|
|
json: () => Promise.resolve(apiResponse)
|
|
} as Response));
|
|
global.fetch = fetchMock;
|
|
|
|
await updateFolderClaudeMdFiles(
|
|
['/home/user/valid/file.ts'],
|
|
'test-project',
|
|
37777
|
|
// No projectRoot provided
|
|
);
|
|
|
|
expect(fetchMock).toHaveBeenCalledTimes(1);
|
|
});
|
|
|
|
it('should accept valid relative paths', async () => {
|
|
const apiResponse = {
|
|
content: [{ text: '| #123 | 4:30 PM | 🔵 | Test | ~100 |' }]
|
|
};
|
|
const fetchMock = mock(() => Promise.resolve({
|
|
ok: true,
|
|
json: () => Promise.resolve(apiResponse)
|
|
} as Response));
|
|
global.fetch = fetchMock;
|
|
|
|
await updateFolderClaudeMdFiles(
|
|
['src/utils/logger.ts'],
|
|
'test-project',
|
|
37777,
|
|
tempDir
|
|
);
|
|
|
|
expect(fetchMock).toHaveBeenCalledTimes(1);
|
|
});
|
|
});
|