c6f932988a
* MAESTRO: fix ChromaDB core issues — Python pinning, Windows paths, disable toggle, metadata sanitization, transport errors - Add --python version pinning to uvx args in both local and remote mode (fixes #1196, #1206, #1208) - Convert backslash paths to forward slashes for --data-dir on Windows (fixes #1199) - Add CLAUDE_MEM_CHROMA_ENABLED setting for SQLite-only fallback mode (fixes #707) - Sanitize metadata in addDocuments() to filter null/undefined/empty values (fixes #1183, #1188) - Wrap callTool() in try/catch for transport errors with auto-reconnect (fixes #1162) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * MAESTRO: fix data integrity — content-hash deduplication, project name collision, empty project guard, stuck isProcessing - Add SHA-256 content-hash deduplication to observations INSERT (store.ts, transactions.ts, SessionStore.ts) - Add content_hash column via migration 22 with backfill and index - Fix project name collision: getCurrentProjectName() now returns parent/basename - Guard against empty project string with cwd-derived fallback - Fix stuck isProcessing: hasAnyPendingWork() resets processing messages older than 5 minutes - Add 12 new tests covering all four fixes Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * MAESTRO: fix hook lifecycle — stderr suppression, output isolation, conversation pollution prevention - Suppress process.stderr.write in hookCommand() to prevent Claude Code showing diagnostic output as error UI (#1181). Restores stderr in finally block for worker-continues case. - Convert console.error() to logger.warn()/error() in hook-command.ts and handlers/index.ts so all diagnostics route to log file instead of stderr. - Verified all 7 handlers return suppressOutput: true (prevents conversation pollution #598, #784). - Verified session-complete is a recognized event type (fixes #984). - Verified unknown event types return no-op handler with exit 0 (graceful degradation). - Added 10 new tests in tests/hook-lifecycle.test.ts covering event dispatch, adapter defaults, stderr suppression, and standard response constants. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * MAESTRO: fix worker lifecycle — restart loop coordination, stale transport retry, ENOENT shutdown race - Add PID file mtime guard to prevent concurrent restart storms (#1145): isPidFileRecent() + touchPidFile() coordinate across sessions - Add transparent retry in ChromaMcpManager.callTool() on transport error — reconnects and retries once instead of failing (#1131) - Wrap getInstalledPluginVersion() with ENOENT/EBUSY handling (#1042) - Verified ChromaMcpManager.stop() already called on all shutdown paths Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * MAESTRO: fix Windows platform support — uvx.cmd spawn, PowerShell $_ elimination, windowsHide, FTS5 fallback - Route uvx spawn through cmd.exe /c on Windows since MCP SDK lacks shell:true (#1190, #1192, #1199) - Replace all PowerShell Where-Object {$_} pipelines with WQL -Filter server-side filtering (#1024, #1062) - Add windowsHide: true to all exec/spawn calls missing it to prevent console popups (#1048) - Add FTS5 runtime probe with graceful fallback when unavailable on Windows (#791) - Guard FTS5 table creation in migrations, SessionSearch, and SessionStore with try/catch Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * MAESTRO: fix skills/ distribution — build-time verification and regression tests (#1187) Add post-build verification in build-hooks.js that fails if critical distribution files (skills, hooks, plugin manifest) are missing. Add 10 regression tests covering skill file presence, YAML frontmatter, hooks.json integrity, and package.json files field. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * MAESTRO: fix MigrationRunner schema initialization (#979) — version conflict between parallel migration systems Root cause: old DatabaseManager migrations 1-7 shared schema_versions table with MigrationRunner's 4-22, causing version number collisions (5=drop tables vs add column, 6=FTS5 vs prompt tracking, 7=discovery_tokens vs remove UNIQUE). initializeSchema() was gated behind maxApplied===0, so core tables were never created when old versions were present. Fixes: - initializeSchema() always creates core tables via CREATE TABLE IF NOT EXISTS - Migrations 5-7 check actual DB state (columns/constraints) not just version tracking - Crash-safe temp table rebuilds (DROP IF EXISTS _new before CREATE) - Added missing migration 21 (ON UPDATE CASCADE) to MigrationRunner - Added ON UPDATE CASCADE to FK definitions in initializeSchema() - All changes applied to both runner.ts and SessionStore.ts Tests: 13 new tests in migration-runner.test.ts covering fresh DB, idempotency, version conflicts, crash recovery, FK constraints, and data integrity. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * MAESTRO: fix 21 test failures — stale mocks, outdated assertions, missing OpenClaw guards Server tests (12): Added missing workerPath and getAiStatus to ServerOptions mocks after interface expansion. ChromaSync tests (3): Updated to verify transport cleanup in ChromaMcpManager after architecture refactor. OpenClaw (2): Added memory_ tool skipping and response truncation to prevent recursive loops and oversized payloads. MarkdownFormatter (2): Updated assertions to match current output. SettingsDefaultsManager (1): Used correct default key for getBool test. Logger standards (1): Excluded CLI transcript command from background service check. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * MAESTRO: fix Codex CLI compatibility (#744) — session_id fallbacks, unknown platform tolerance, undefined guard Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * MAESTRO: fix Cursor IDE integration (#838, #1049) — adapter field fallbacks, tolerant session-init validation Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * MAESTRO: fix /api/logs OOM (#1203) — tail-read replaces full-file readFileSync Replace readFileSync (loads entire file into memory) with readLastLines() that reads only from the end of the file in expanding chunks (64KB → 10MB cap). Prevents OOM on large log files while preserving the same API response shape. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * MAESTRO: fix Settings CORS error (#1029) — explicit methods and allowedHeaders in CORS config Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * MAESTRO: add session custom_title for agent attribution (#1213) — migration 23, endpoint + store support Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * MAESTRO: prevent CLAUDE.md/AGENTS.md writes inside .git/ directories (#1165) Add .git path guard to all 4 write sites to prevent ref corruption when paths resolve inside .git internals. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * MAESTRO: fix plugin disabled state not respected (#781) — early exit check in all hook entry points Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * MAESTRO: fix UserPromptSubmit context re-injection on every turn (#1079) — contextInjected session flag Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * MAESTRO: fix stale AbortController queue stall (#1099) — lastGeneratorActivity tracking + 30s timeout Three-layer fix: 1. Added lastGeneratorActivity timestamp to ActiveSession, updated by processAgentResponse (all agents), getMessageIterator (queue yields), and startGeneratorWithProvider (generator launch) 2. Added stale generator detection in ensureGeneratorRunning — if no activity for >30s, aborts stale controller, resets state, restarts 3. Added AbortSignal.timeout(30000) in deleteSession to prevent indefinite hang when awaiting a stuck generator promise Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
129 lines
4.7 KiB
TypeScript
129 lines
4.7 KiB
TypeScript
/**
|
|
* Tests for readLastLines() — tail-read function for /api/logs endpoint (#1203)
|
|
*
|
|
* Verifies that log files are read from the end without loading the entire
|
|
* file into memory, preventing OOM on large log files.
|
|
*/
|
|
|
|
import { describe, it, expect, beforeEach, afterEach } from 'bun:test';
|
|
import { writeFileSync, mkdirSync, rmSync, existsSync } from 'fs';
|
|
import { join } from 'path';
|
|
import { tmpdir } from 'os';
|
|
import { readLastLines } from '../../src/services/worker/http/routes/LogsRoutes.js';
|
|
|
|
describe('readLastLines (#1203 OOM fix)', () => {
|
|
const testDir = join(tmpdir(), `claude-mem-logs-test-${Date.now()}`);
|
|
const testFile = join(testDir, 'test.log');
|
|
|
|
beforeEach(() => {
|
|
mkdirSync(testDir, { recursive: true });
|
|
});
|
|
|
|
afterEach(() => {
|
|
if (existsSync(testDir)) {
|
|
rmSync(testDir, { recursive: true, force: true });
|
|
}
|
|
});
|
|
|
|
it('should return empty string for empty file', () => {
|
|
writeFileSync(testFile, '', 'utf-8');
|
|
const result = readLastLines(testFile, 10);
|
|
expect(result.lines).toBe('');
|
|
expect(result.totalEstimate).toBe(0);
|
|
});
|
|
|
|
it('should return all lines when file has fewer lines than requested', () => {
|
|
writeFileSync(testFile, 'line1\nline2\nline3\n', 'utf-8');
|
|
const result = readLastLines(testFile, 10);
|
|
expect(result.lines).toBe('line1\nline2\nline3');
|
|
expect(result.totalEstimate).toBe(3);
|
|
});
|
|
|
|
it('should return exactly the last N lines', () => {
|
|
const lines = Array.from({ length: 20 }, (_, i) => `line${i + 1}`);
|
|
writeFileSync(testFile, lines.join('\n') + '\n', 'utf-8');
|
|
|
|
const result = readLastLines(testFile, 5);
|
|
expect(result.lines).toBe('line16\nline17\nline18\nline19\nline20');
|
|
});
|
|
|
|
it('should return single line when requested', () => {
|
|
writeFileSync(testFile, 'first\nsecond\nthird\n', 'utf-8');
|
|
const result = readLastLines(testFile, 1);
|
|
expect(result.lines).toBe('third');
|
|
});
|
|
|
|
it('should handle file without trailing newline', () => {
|
|
writeFileSync(testFile, 'line1\nline2\nline3', 'utf-8');
|
|
const result = readLastLines(testFile, 2);
|
|
expect(result.lines).toBe('line2\nline3');
|
|
});
|
|
|
|
it('should handle single line file', () => {
|
|
writeFileSync(testFile, 'only line\n', 'utf-8');
|
|
const result = readLastLines(testFile, 5);
|
|
expect(result.lines).toBe('only line');
|
|
expect(result.totalEstimate).toBe(1);
|
|
});
|
|
|
|
it('should handle file with exactly requested number of lines', () => {
|
|
writeFileSync(testFile, 'a\nb\nc\n', 'utf-8');
|
|
const result = readLastLines(testFile, 3);
|
|
expect(result.lines).toBe('a\nb\nc');
|
|
});
|
|
|
|
it('should work with lines larger than initial chunk size', () => {
|
|
// Create a file where lines are long enough to exceed the 64KB initial chunk
|
|
const longLine = 'X'.repeat(10000);
|
|
const lines = Array.from({ length: 20 }, (_, i) => `${i}:${longLine}`);
|
|
writeFileSync(testFile, lines.join('\n') + '\n', 'utf-8');
|
|
|
|
const result = readLastLines(testFile, 3);
|
|
const resultLines = result.lines.split('\n');
|
|
expect(resultLines.length).toBe(3);
|
|
expect(resultLines[0]).toStartWith('17:');
|
|
expect(resultLines[1]).toStartWith('18:');
|
|
expect(resultLines[2]).toStartWith('19:');
|
|
});
|
|
|
|
it('should provide accurate totalEstimate when entire file is read', () => {
|
|
const lines = Array.from({ length: 5 }, (_, i) => `line${i}`);
|
|
writeFileSync(testFile, lines.join('\n') + '\n', 'utf-8');
|
|
|
|
const result = readLastLines(testFile, 100);
|
|
// When file fits in one chunk, totalEstimate should be exact
|
|
expect(result.totalEstimate).toBe(5);
|
|
});
|
|
|
|
it('should handle requesting zero lines', () => {
|
|
writeFileSync(testFile, 'line1\nline2\n', 'utf-8');
|
|
const result = readLastLines(testFile, 0);
|
|
expect(result.lines).toBe('');
|
|
});
|
|
|
|
it('should handle file with only newlines', () => {
|
|
writeFileSync(testFile, '\n\n\n', 'utf-8');
|
|
const result = readLastLines(testFile, 2);
|
|
const resultLines = result.lines.split('\n');
|
|
// The last two "lines" before trailing newline are empty strings
|
|
expect(resultLines.length).toBe(2);
|
|
});
|
|
|
|
it('should not load entire large file for small tail request', () => {
|
|
// This test verifies the core fix: a file with many lines should
|
|
// not be fully loaded when only a few lines are requested.
|
|
// We create a file larger than the initial 64KB chunk.
|
|
const line = 'A'.repeat(100) + '\n'; // ~101 bytes per line
|
|
const lineCount = 1000; // ~101KB total
|
|
writeFileSync(testFile, line.repeat(lineCount), 'utf-8');
|
|
|
|
const result = readLastLines(testFile, 5);
|
|
const resultLines = result.lines.split('\n');
|
|
expect(resultLines.length).toBe(5);
|
|
// Each returned line should be our repeated 'A' pattern
|
|
for (const l of resultLines) {
|
|
expect(l).toBe('A'.repeat(100));
|
|
}
|
|
});
|
|
});
|