9 Commits

Author SHA1 Message Date
pftom 0b61be5d96 Merge remote-tracking branch 'origin/main' into cursor/289994c1 2026-04-28 22:31:29 +08:00
pftom 5a63d09f2f Enhance README and add star promotion assets
- Added a "Star us" section in both English and Chinese README files to encourage users to star the project on GitHub.
- Included a new image asset for the star promotion.
- Introduced a new HTML file for a dedicated star promotion page.
- Updated .gitignore to exclude new cursor-related files.
2026-04-28 20:32:39 +08:00
pftom 19b5272f38 Merge branch 'main' into feat/optimize-naming 2026-04-28 16:23:44 +08:00
pftom 1337907df3 Merge branch 'main' of github.com:nexu-io/open-design 2026-04-28 16:20:14 +08:00
pftom 490bbe29c9 Merge branch 'feat/optimize-naming' of github.com:nexu-io/open-design into feat/optimize-naming 2026-04-28 16:16:51 +08:00
pftom 0eef347336 Update README and documentation for deck framework directives
- Clarified DECK_FRAMEWORK_DIRECTIVE description in both English and Chinese README files to specify conditions for deck kind without a skill seed.
- Added detailed workflow instructions in deck-framework.ts to emphasize the importance of copying the framework before adding content.
- Enhanced discovery.ts to reinforce the framework-first approach for deck projects.
- Updated system.ts to ensure proper handling of deck projects with and without bound skills, preventing re-authorship of scaling and navigation logic.
2026-04-28 16:11:46 +08:00
pftom 243e611eeb Update README and documentation for deck framework directives
- Clarified DECK_FRAMEWORK_DIRECTIVE description in both English and Chinese README files to specify conditions for deck kind without a skill seed.
- Added detailed workflow instructions in deck-framework.ts to emphasize the importance of copying the framework before adding content.
- Enhanced discovery.ts to reinforce the framework-first approach for deck projects.
- Updated system.ts to ensure proper handling of deck projects with and without bound skills, preventing re-authorship of scaling and navigation logic.
2026-04-28 16:07:52 +08:00
pftom 985238403f Add contributing guidelines in English and Chinese
- Introduced CONTRIBUTING.md and CONTRIBUTING.zh-CN.md to provide clear instructions for contributors.
- Outlined contribution types, local setup instructions, and merging criteria for skills and design systems.
- Enhanced README files to reference the new contributing guidelines.
2026-04-28 16:02:17 +08:00
pftom af3f96379a Refactor project name from "Open Claude Design" to "Open Design"
- Updated project name in package.json, package-lock.json, and README files.
- Changed CLI commands and references from "ocd" to "od".
- Adjusted file structure references in documentation and code to reflect new naming conventions.
- Enhanced .gitignore to include new runtime data files.
- Updated metadata in LICENSE file to match new project name.
2026-04-28 14:48:45 +08:00
2 changed files with 3 additions and 25 deletions
-10
View File
@@ -125,13 +125,3 @@ export async function detectAgents() {
export function getAgentDef(id) { export function getAgentDef(id) {
return AGENT_DEFS.find((a) => a.id === id) || null; return AGENT_DEFS.find((a) => a.id === id) || null;
} }
// Resolve the absolute path of an agent's binary on the current PATH.
// Used by the chat handler so spawn() gets the same executable that
// detection reported as available — fixes Windows ENOENT when the bare
// bin name isn't on the child process's PATH (issue #10).
export function resolveAgentBin(id) {
const def = getAgentDef(id);
if (!def?.bin) return null;
return resolveOnPath(def.bin);
}
+3 -15
View File
@@ -6,7 +6,7 @@ import { fileURLToPath } from 'node:url';
import path from 'node:path'; import path from 'node:path';
import fs from 'node:fs'; import fs from 'node:fs';
import os from 'node:os'; import os from 'node:os';
import { detectAgents, getAgentDef, resolveAgentBin } from './agents.js'; import { detectAgents, getAgentDef } from './agents.js';
import { listSkills } from './skills.js'; import { listSkills } from './skills.js';
import { listDesignSystems, readDesignSystem } from './design-systems.js'; import { listDesignSystems, readDesignSystem } from './design-systems.js';
import { createClaudeStreamHandler } from './claude-stream.js'; import { createClaudeStreamHandler } from './claude-stream.js';
@@ -792,20 +792,9 @@ export async function startServer({ port = 7456 } = {}) {
res.write(`data: ${JSON.stringify(data)}\n\n`); res.write(`data: ${JSON.stringify(data)}\n\n`);
}; };
// Resolve the agent's bin to its absolute path. Detection (`/api/agents`)
// already locates the executable via PATH, but spawning the bare name here
// fails on Windows (ENOENT) when the child process's PATH doesn't contain
// the user's npm-global / shim directory — see issue #10.
const resolvedBin = resolveAgentBin(agentId) || def.bin;
// npm shims on Windows are .cmd/.bat files; Node ≥21 refuses to spawn
// those without `shell: true` (CVE-2024-27980). When `shell: true` is set
// on Windows, Node escapes args automatically for the cmd.exe shell.
const useShell =
process.platform === 'win32' && /\.(cmd|bat)$/i.test(resolvedBin);
send('start', { send('start', {
agentId, agentId,
bin: resolvedBin, bin: def.bin,
streamFormat: def.streamFormat ?? 'plain', streamFormat: def.streamFormat ?? 'plain',
projectId: typeof projectId === 'string' ? projectId : null, projectId: typeof projectId === 'string' ? projectId : null,
cwd, cwd,
@@ -813,11 +802,10 @@ export async function startServer({ port = 7456 } = {}) {
let child; let child;
try { try {
child = spawn(resolvedBin, args, { child = spawn(def.bin, args, {
env: { ...process.env }, env: { ...process.env },
stdio: ['ignore', 'pipe', 'pipe'], stdio: ['ignore', 'pipe', 'pipe'],
cwd: cwd || undefined, cwd: cwd || undefined,
shell: useShell,
}); });
} catch (err) { } catch (err) {
send('error', { message: `spawn failed: ${err.message}` }); send('error', { message: `spawn failed: ${err.message}` });